- 28 May, 2013 40 commits
-
-
nkostylev@chromium.org authored
kLoginScreen kLoginScreenSize kAshBootAnimationFunction2 kAshBootAnimationFunction3 kAshDisableBootAnimation2 + related flags See also https://gerrit.chromium.org/gerrit/#/c/56735/ BUG=244224 TEST=compiles, existing browser_tests and autotests work NOTRY=true Review URL: https://chromiumcodereview.appspot.com/16105005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202646 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
ConstrainedWindow used to have clearColor as backgroundColor - which means all underlying views had to assume that the background color was chrome_style::GetBackgroundColor instead of just querying the window. BUG=none Review URL: https://chromiumcodereview.appspot.com/15729008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202645 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
This function is helpful for converting WebStrings to string16s. See https://codereview.chromium.org/15866003/ for more context about why we need this function defined in base rather than in Blink. R=darin Review URL: https://chromiumcodereview.appspot.com/15720004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202644 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
Before: *RESULT third_party\WebKit\PerformanceTests\Parser\html-parser: third_party\WebK it\PerformanceTests\Parser\html-parser= [3177.99999996,3454.00000003,3165.999999 97,3162.99999994,3190.00000006] ms After: *RESULT html-parser: html-parser= [3217.99999999,3337.99999999,3174.0,3397.0,320 1.0] ms BUG=None TEST=python tools/perf/run_measurement --browser=release blink_perf third_party\WebKit\PerformanceTests\ NOTRY=True Review URL: https://chromiumcodereview.appspot.com/15891010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202643 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
BUG=157274 Review URL: https://chromiumcodereview.appspot.com/15645004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202642 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
> Use totmaps if available on chromeos > > We currently use statm on linux. This provides less than great results. > We take total resident memory and subtract "shared pages" from it instead of > using a count of pages that only this process has mapped. > > On chromeos we've added totmaps which sums up the fields from the process' > smaps. > > BUG=125150 > TEST=Examine memory reports from about:memory and task manager, and compare > them to the sums of the results in the smaps. > > R=thestig@chromium.org, willchan@chromium.org > > Review URL: https://codereview.chromium.org/15779007 TBR=davemoore@chromium.org Review URL: https://codereview.chromium.org/16116003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202640 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
We currently use statm on linux. This provides less than great results. We take total resident memory and subtract "shared pages" from it instead of using a count of pages that only this process has mapped. On chromeos we've added totmaps which sums up the fields from the process' smaps. BUG=125150 TEST=Examine memory reports from about:memory and task manager, and compare them to the sums of the results in the smaps. R=thestig@chromium.org, willchan@chromium.org Review URL: https://codereview.chromium.org/15779007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202639 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202638 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
BUG=None TEST=None NOTRY=True Review URL: https://chromiumcodereview.appspot.com/16069008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202637 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/16042005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202636 0039d316-1c4b-4281-b951-d872f2087c98
-
miguelg@chromium.org authored
Simplify the month picker even more by making it locale agnostic for everything except the month names BUG=135948 Review URL: https://chromiumcodereview.appspot.com/16023004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202635 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151260:151267&mode=html TBR= BUG= Review URL: https://chromiumcodereview.appspot.com/15949003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202634 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
This reverts commit 4d9d3bc7. BUG=234278 TBR=caitkp Review URL: https://codereview.chromium.org/15659013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202633 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
I wasn't able to repro locally, but based on the failure, this looks like it would do the trick. BUG=244459 TEST=tools/telemetry/run_tests testClickWithSelectorWaitForNavigation --repeat-count=5 NOTRY=True Review URL: https://chromiumcodereview.appspot.com/15929007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202629 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Notification titles and button text is drawn in kRegularTextColor, notifcation message text is drawn in kDimTextColor. Move kDimTextColor to message_center_style so that it can be shared. BUG=240877 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/16075002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202628 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=243937 Review URL: https://chromiumcodereview.appspot.com/16073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202627 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
BUG=235756 R=jeremy@chromium.org TBR=avi Review URL: https://chromiumcodereview.appspot.com/16050002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202626 0039d316-1c4b-4281-b951-d872f2087c98
-
csorba@chromium.org authored
BUG=237495 Review URL: https://chromiumcodereview.appspot.com/16102004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202624 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
This makes Chrome resend the current projecting state to the power manager if the power manager is restarted. BUG=none Review URL: https://chromiumcodereview.appspot.com/15969004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202623 0039d316-1c4b-4281-b951-d872f2087c98
-
rjkroege@chromium.org authored
BUG=none R=backer@chromium.org Review URL: https://codereview.chromium.org/16133006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202622 0039d316-1c4b-4281-b951-d872f2087c98
-
jwd@chromium.org authored
BUG=228976 Review URL: https://chromiumcodereview.appspot.com/14759008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202621 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremy@chromium.org authored
Motivation: Data collection exposed in this CL is needed by upcoming startup tests we're writing using Telemtry. Expose a new window.statsCollectionController object to JS and move existing histogram reading code into it since that seemed misplaced in DOMAutomationController. Add a new --enable-stats-collection-bindings to activate said object. Example usage in telemtry: with browser.Create() as b: b.tabs[0].Navigate("http://www.google.com") b.tabs[0].WaitForDocumentReadyStateToBeComplete() print b.tabs[0].EvaluateJavaScript('statsCollectionController.tabLoadTiming()') BUG=None Review URL: https://chromiumcodereview.appspot.com/12389073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202620 0039d316-1c4b-4281-b951-d872f2087c98
-
ahutter@chromium.org authored
BUG= Review URL: https://chromiumcodereview.appspot.com/15401005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202618 0039d316-1c4b-4281-b951-d872f2087c98
-
vabr@chromium.org authored
UserManager is needed during MergeSessionThrottle::ShouldShowMergeSessionPage, which appears sometimes to be triggered during ChromeBrowserMainPartsLinux::PostMainMessageLoopRun. I observed this during the test TrayAccessibilityTest.ShowMenu, as described in https://crbug.com/243364#c12. However, at most occasions this was masked by ShouldShowMergeSessionPage being actually triggered earlier. This is restoring the order of destroying UserManager and calling ChromeBrowserMainPartsLinux::PostMainMessageLoopRun to the state before the CL https://chromiumcodereview.appspot.com/15702004/. BUG=243364 Review URL: https://chromiumcodereview.appspot.com/15769004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202617 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
See https://groups.google.com/a/chromium.org/d/msg/chromium-packagers/X1Q6P60JZHM/uol7IsRv0-oJ for more info. BUG=none R=maruel@chromium.org Review URL: https://codereview.chromium.org/16121002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202616 0039d316-1c4b-4281-b951-d872f2087c98
-
caitkp@google.com authored
TBR=dharcourt@chromium.org BUG=169648 Review URL: https://codereview.chromium.org/16165003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202614 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
This method was added at r201847 to indicate a notification can be clickable or not (by changing mouse cursor, for now). BUG=241266 TEST=none R=atwilson@chromium.org Review URL: https://chromiumcodereview.appspot.com/16023005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202613 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
Change alerts system to not request page info from DevTools each command. Also don't fetch main frame ID each time, since NavigationTracker doesn't really need it. BUG=none R=chrisgao@chromium.org Review URL: https://codereview.chromium.org/15393005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202610 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
This is just some code cleanup and should have no behavior changes. BUG=239073 For webui/chromeos, browser/geolocation: TBR=nkostylev@chromium.org,joth@chromium.org Review URL: https://chromiumcodereview.appspot.com/14729017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202609 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
BUG=244465 TEST=None NOTRY=True Review URL: https://chromiumcodereview.appspot.com/16073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202608 0039d316-1c4b-4281-b951-d872f2087c98
-
nona@chromium.org authored
With this change, the responsibility of clearing |pending_input_method_| is moved to ChangeInputMethodInternal. BUG=243149 TEST=Manually checked on link device. Review URL: https://chromiumcodereview.appspot.com/15954008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202607 0039d316-1c4b-4281-b951-d872f2087c98
-
huangs@chromium.org authored
With Chrome / App Launcher unification, the App Launcher can be installed at system-level. Old DCHECK's to enforce otherwise are creating bogus failures, and should be removed. This bug is triggered by https://chromiumcodereview.appspot.com/14711006/ , which adds "shadow" App Launcher Clients/ClientState keys to support 7DA tracking for App Launcher. Unfortunately, these keys are read, and are interpreted as the presence of App Launcher (thus triggering DCHECK). A separate issue is that installation_validator complains about missing information in the "shadow" registry key. This is less urgent, and hence not part of this CL. BUG=243432 Review URL: https://chromiumcodereview.appspot.com/15915003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202605 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
To get the IDB backend off the (deprecated) WebKit thread, remove intermediate proxying, and let us take advantage of base utilities, we're moving the code from Blink to Chromium. This patch is basically a glorified copy/paste of the Blink IDB backend code, with Chromium coding style applied, WTF dependencies replaced with STL and base/, redundant classes removed, etc. It introduces some new temporary proxy classes (content/browser/webidb*_impl.*) to allow us build both the old and new backends. The new backend is currently disabled by default. It can be enabled using a new (and temporary) command line switch: --new-indexeddb Once we've done some further cleanup and are confident that the new backend is stable, and the bots have moved from DumpRenderTree to content_shell, we'll switch to the new backend by default. Once that has survived through a dev channel release, we'll delete the Blink code and eliminate unnecessary proxy classes. BUG=234278 R=alecflett@chromium.org, dgrogan@chromium.org, piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202215 Review URL: https://codereview.chromium.org/15564008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202604 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
It was unreviewed, should not have been TBR'd. Also broke the docserver so reverting rather than figuring out some kind of follow up. TBR=hongbo.min@intel.com BUG=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/15891007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202603 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
Required to avoid duplicating code for upcoming Ash browser_tests on Windows. Also avoids calling into OpenWithDialogController if the test is already default browser. BUG=179830 Review URL: https://chromiumcodereview.appspot.com/15755016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202599 0039d316-1c4b-4281-b951-d872f2087c98
-
ddorwin@chromium.org authored
The problem was at encrypted_media_browsertest.cc line 167, which is a call to RegisterPepperCdm(), but the right fix is to use ASCII for the constants. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/15658009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202598 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
The Mac policy provider loads policies for the browser. This change makes it additionally load policies for the extensions described in the PolicyDomainDescriptor for extensions. BUG=108992 Review URL: https://chromiumcodereview.appspot.com/15038007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202597 0039d316-1c4b-4281-b951-d872f2087c98
-
josephg@gmail.com authored
Patch from Joseph Gentle <josephg@gmail.com> R=jeremya@chromium.org BUG=243995 Review URL: https://chromiumcodereview.appspot.com/15953004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202593 0039d316-1c4b-4281-b951-d872f2087c98
-
nona@chromium.org authored
OnConnected/OnDisconnected observer callback is not meaning anything on chromeos=1 build, so it calles automatically at the begging of input method initialization. However it is too early for CandidateWindowController to do initialization in OnConnected, so do initialization immediately if it is available. BUG=244322 TEST=Manually checked on ubuntu Review URL: https://chromiumcodereview.appspot.com/15974003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202592 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
This splits NotificationDelegate into two interfaces: * message_center::NotificationDelegate, and * ::NotificationDelegate. message_center::NotificationDelegate handles click events, whereas ::NotificationDelegate has a RenderViewHost that can be used to download images. This will support adding message_center::Notification objects directly, including all the binary bits of their image notifications. BUG=174164 Review URL: https://chromiumcodereview.appspot.com/15582004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202591 0039d316-1c4b-4281-b951-d872f2087c98
-