- 21 Sep, 2019 24 commits
-
-
inglorion authored
crrev.com/c/1785680 caused us to lower how many linker invocations we run concurrently when doing ThinLTO builds for Windows. This causes the ToTWinOfficial and ToTWinThinLTO64 bots to time out. This change configures those bots to instruct the linker to use more internal parallelism, which should shorten build times (as tested locally). Bug: 1002306 Change-Id: I9f59dd09ab2c7e98c462ba28667bef10f3f3e8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817186Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#698704}
-
Erik Chen authored
The previous version of the test lived in render_widget_unittest.cc and did not have the full context [e.g. RenderViewImpl, etc.]. This caused the test to fail for upcoming improvements to emulation. The updated version of the test now checks production logic and event sequences, rather than test-only paths. By doing so, this CL removes a lot of boiler-plate mocks from RenderWidgetUnittest. Change-Id: I3e102f997d9e42bdd7db55af79a72219bccc83b9 Bug: 1006052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816733 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#698703}
-
Xianzhu Wang authored
The applicable scope of a exotic blend mode is defined by the containing effect node, so non-composited exotic blend mode can be handled by PaintChunkToCcLayers just fine, if the scope contains only one other layer and no other reason prevent the blend layer from being merged into that layer. This avoids excessive composited layers of CAP than pre-CAP for blend mode. Composited blend mode not working still needs to be fixed. Some of the remaining failures of the bug may be because of that. Bug: 979369 Change-Id: I52a478bcebd9ba9fc59b9de0aaa1a2f25ee33642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814859 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#698702}
-
Lambros Lambrou authored
This replaces the unsigned launchd script with a signed script inside the ME2ME host bundle. This is needed so that we can make changes to the script without having the user re-authorize the host in System Preferences -> Security & Privacy. This also helps with Catalina signing/notarization, because it is expected that Apple's notarization service and/or Gatekeeper will reject an unsigned script. Changes: * org.chromium.chromoting.me2me.sh removed from the installer package. * New script added to the host bundle (with very minor changes needed for it to work). New script is without ".sh" extension, making it language-agnostic (in future, we could convert to a binary). * New script is signed by do_signing.sh - this is required in order to sign the overall host bundle. * Launchd agent plist updated to point to the new script. * Upgrade will preserve the old script and plist, so that users don't have to re-authorize. New installs will use the new script. This is achieved by backing up the old script+plist in preflight and restoring them in postflight. * Updated ME2ME native-messaging host setup to point to the new script. * Permission prompt updated with new name (instead of the ugly string org.chromium.chromoting.me2me.sh). * Uninstaller removes the old script if it exists. Bug: 996989 Change-Id: Id3d7a0a9f666178b6871458b96f0af8177beb301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815977Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#698701}
-
Jan Krcal authored
This CL shows a border around toolbar buttons that have non-empty labels (with a nice fade-in / fade-out while animating the label). This is only enabled when the avatar animation feature is enabled. Bug: 967317 Change-Id: I06668d3548f83d9e646d5f52eb995fb93875a55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771405 Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#698700}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/942d69fa9d5f..bd67d0035a80 git log 942d69fa9d5f..bd67d0035a80 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@bd67d0035a80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Ib5c28815c653d81ea7620e5070987ce1eb2afa25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698699}
-
Ella Ge authored
\o/ Doc: https://docs.google.com/document/d/1KrlQ0m5Ty9RKE1IorjEXDldYFJvUV_Ww10lnjh-TRN0/ Bug: 1000682 Change-Id: Ia77af76fd530be740d7d7c64706f47a48c248387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786591 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#698698}
-
Steven Bennetts authored
This adds CrosNetworkConfig.ForgetNetwork and uses it in the Internet Settings WebUI. Bug: 1001598 Change-Id: Ic9952b9024b0f8bb7ce42955f8f7d00afdc7ac55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808497 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Dana Fried authored
This prevents us from having to put our layout interpolation code in LayoutManagerBase where it really doesn't belong. Bug: 898632 Change-Id: I837b14ff05eee9f5ea9b2659955d787bde23958e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815665Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#698696}
-
Taylor Bergquist authored
Bug: 1000184 Change-Id: I913d52e05dde3daa18543bf3c684344973a0c341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798174 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#698695}
-
Sunny Sachanandani authored
Web runtime features are not the best fit for low latency canvas swap chain because it's a performance optimization and not a new web feature being exposed to developers. Blink code can use finch feature flags so use that directly instead in preparation for a dev/canary field trial. Bug: 939660 Change-Id: I3fc86cffaf0093beb9d262114dfa9b74b362c196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807595Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#698694}
-
Peter Kasting authored
Such directives violate the style guide. Instead pull in just the actual vector commands, via individual using declarations, via a macro. Bug: 82078 Change-Id: I0f3208916285d6e2788932302714e394f1d92d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810618 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#698693}
-
John Lee authored
- Remove border around active tab when being dragged - Prevent thumbnail image from capturing drag events - Fix error when a dragOver event happens before a dragStart event and the dragged item has not been set - Remove a TODO since UX has decided not to support dragging across pinned states Bug: 989131 Change-Id: I79b7acc0778b55c9f867be1843ab2df122f242e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815695Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#698692}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/11dc16350cd4..857bb7ff07a3 git log 11dc16350cd4..857bb7ff07a3 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 ianelliott@google.com Vulkan: Enable most dEQP-GLES31.functional.state_query* tests to run 2019-09-20 geofflang@chromium.org GL: Treat unknown AHardwareBuffer formats as RGBA8. 2019-09-20 jmadill@chromium.org Refactor built-in symbol table. Created with: gclient setdep -r src/third_party/angle@857bb7ff07a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:998535 Change-Id: I929d76902bf6605c17e5b65d1b3fcdbb741e5146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817278Reviewed-by:
-
Yuly Novikov authored
It is identical to Win10 FYI x64 Release (NVIDIA) now. TBR=kbr Bug: 982336 Change-Id: I4a6e5d5c5b67043b1d3d4a7a286ee0b3cab9fc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815710Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#698690}
-
Kurt Horimoto authored
Previously, PreloadController cancelled the prerender whenever the JavaScriptDialogPresenter was fetched by its WebState. This was too aggressive, as the dialog presenter is requested in order to cancel presented dialogs before navigations. This CL updates PreloadController to instead return a custom no-op subclass that cancels the prerender only when the dialog is actually requested. This CL also updates PreloadController to use modern Objective-C. Bug: 995641 Change-Id: I5946e6ab4d8403d4f9fb556ff05beb6b84f5874e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815943Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#698689}
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/08a6c955af00..e3f2f7bd0ddd $ git log 08a6c955a..e3f2f7bd0 --date=short --no-merges --format='%ad %ae %s' 2019-09-19 fayang relnote: On server side, do not process the first initial QUIC packet received from a client if the UDP datagram is < 1200 bytes. Instead, send a connection close with PROTOCOL_VIOLATION if the version is supported. Protected by quic_reloadable_flag_quic_donot_process_small_initial_packets. 2019-09-19 nharper Don't create NullEncrypter/Decrypter in QuicFramer 2019-09-19 ianswett Remove obsolete comments from QuicDispatcher. 2019-09-18 ianswett Shorten names of UberQuicStreamIdManager methods. 2019-09-18 dschinazi Fix QUIC core test display Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I8ac7823ea7dd5d8165c597da64e7b8cf526e80b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815886 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#698688}
-
Taylor Bergquist authored
Tab drag sessions need mouse capture to function; losing capture therefore ends the drag. There are, evidently, some cases where SetCapture() can cause the drag session to lose capture, thereby ending the drag as it's beginning. Bug: 964322 Change-Id: I6bcd53f04aefb7461e6c28abf1085df1a012545a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817211 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
Steven Bennetts authored
This eliminates everything in cr_onc_types.js except for CrOncStrings and moves that to cr_onc_strings.js. This also includes some additional minor cleanup to reduce the use of networkingPrivate and its types. Bug: 1001598 Change-Id: I8e848657a3190354ae6baa85f91da0922b59d665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808316 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/38b295de3851..0c4d75931a0f git log 38b295de3851..0c4d75931a0f --date=short --no-merges --format='%ad %ae %s' 2019-09-20 bsheedy@google.com Disable BufferSetSubData.ManySetSubData on Metal Created with: gclient setdep -r src/third_party/dawn@0c4d75931a0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ib200b33393a0cfa2f6c9baedd57179205bf3c8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815596Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2ef66b69cea5..1f89f58faeb8 git log 2ef66b69cea5..1f89f58faeb8 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 jmadill@chromium.org Do not call Scheduler destructor in libVulkan. Created with: gclient setdep -r src/third_party/swiftshader@1f89f58faeb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141380274 Change-Id: Ic55c236e22edc71668ddccd5cab3a2f5e3f5078e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817277Reviewed-by:
-
Rayan Kanso authored
- Make the ContentCategory optional. - Rename getDescriptions to getAll. Bug: 973844 Change-Id: I05817729e508b916fbc2e3ef84e0da839dc718d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793163Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#698683}
-
Ben Joyce authored
Bug: 896755 Change-Id: If714651fa1a4fa0fadf78f106f22d25f6eb9d13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789428Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#698682}
-
Malay Keshav authored
The device scale factor set for the 320 and 220 DPI are off by a fraction and hence do not match the entries in the display zoom table. This patch fixes it. Bug: b/141325696 Change-Id: Ib4c5effb66bee7e1e360cfdf724d8100a10cd702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815353Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#698681}
-
- 20 Sep, 2019 16 commits
-
-
Anastasia Helfinstein authored
Performing the standard action "showContextMenu" on an automation node currently does nothing. This change removes it as an option so as not to slow down navigation without adding value. Bug: None Change-Id: Ia677d8236840580fc153b5e6799055b87ea66504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814639 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#698680}
-
Henrique Ferreiro authored
Convert the implementation and all users of the content::mojom::BrowserTarget interface. Bug: 955171 Change-Id: I08eaa10a37dca519bb7952cc88985fbd468186a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800665Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#698679}
-
Erik Chen authored
This CL has no intended behavior change. It updates RenderViewImpl::Send and RenderViewImpl::PrintPage. Previously, Send() had a RenderWidget::is_closing(). This is unnecessary since destruction of RenderViewImpl is now synchronous, see Destroy(). Bug: 912193 Change-Id: I828d58a458956ba2569f94d72b7f86d653519e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815499Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aa1b7640..39f2488b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7b79a350aaf8330e2d5abc981ad551e254a67589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817080Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698677}
-
Michael Crouse authored
Change-Id: I8b484bd4d68c72adc5ef453f2a8e0969aeb5eea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815577 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#698676}
-
Nick Diego Yamane authored
So far, KeyEvent's DomKey extraction used to happen lazily at GetDomKey()/GetCharacter() calls. Such approach assumes native_event() is available and holds the underlying XEvent instance so it is able to extract event info straight out of it. Document [1] details the effort to eliminate native event usage outside platform code so that it is possible to migrate Aura/X11's PlatformEvent away from XEvent* to ui::Event instead (part of broader X11 migration to Ozone). This issue addressed in this CL is one those remaining cases listed in doc [1]. CL modifies it to extract DomKey value at KeyEvent construction as it is done in most Ozone backends (e.g: ozone/evdev). Additionally this modifies X11EventSourceDefault, currently used by Ozone/X11, to do the same. [1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc Bug: 987939 Change-Id: I9dddad2359b1c345fcb98dabce4506c677269b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813417 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#698675}
-
Toni Barzic authored
In tablet mode, if onscreen keyboard is shown and then hidden while app list is being dragged, the app list window boudns get misplaced. The reason is that when the keyboard is hidden, the app list bounds are restored to the bounds set before the keyboard was shown - which might not be the intended bounds if the app list view chnaged its position in the mean time. Similar issue that ocured when switching to tablet mode while onscreen keyboard was shown with the app list in the search state. This issue was fixed by clearing wm::kVirtualKeyboardRestoreBoundsKey window property on tablet mode change. This CL extends that approach by clearing the property when the on screen keyboard gets hidden, and then calling SetState to ensure the app list view is updated to match the current state. Also, avoids clearing app list widget transform when the keyboard is hidden unless necessary (i.e. when UI was translated up to ensure the folder header input is visible with the keyboard on screen), as that might mess with the app list position during drag in tablet mode (which is implemented using layer transform). BUG=1004390 TEST= 1. Enable a11y keyboard, show applist, and start typing in the search box - the virtual keyboard should get shown. Switch to tablet mode, and hide the keyboard - the search box widget (and search results view) should stay put. 2. Switch to tablet mode, and start dragging the app list down. In the middle of the drag tap the search box (this should activate app list search, and cause virtual keyboard to pop up). Drag the app list up (and/or end drag), and hide virtual keyboard - the app list UI should not jump down. Change-Id: I7217bd60c5bede7b54485fd56aa8716ab65a508f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815907Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#698674}
-
Daniel Libby authored
crrev.com/c/1774911 changed how the first scroll update is detected. That information is consumed in order to determine whether or not a scroll update event should get queued and dispatched on the next begin frame, or if it should be dispatched immediately. The refactoring had a logic bug because it was trying to detect GSB within the block of has_ongoing_compositor_scroll_or_pinch_ and thus the flag was never reset. This wasn't caught by the unittest for this behavior since the flag was initialized to false in the constructor. I'm adding another scroll begin update sequence to the unittest so that we have coverage on the state transition. Bug: 1002045 Change-Id: I781d782de794ccb0639d972325a4579e1c61abe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816360 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
-
Ryan Hamilton authored
Change-Id: I152b0cc50fab5a8ec20e730238558a62a163eb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815938Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#698672}
-
Evan Stade authored
Bug: none Change-Id: If5638142eff88e547ba37fe9288faf9be7cdc286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814869 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Erik Chen authored
Previously, RenderFrameProxy always relied on existence of a RenderWidget. This CL updates RenderFrameProxy to not have a RenderWidget if the proxy is for the main frame, or a subframe of a remote main frame. Change-Id: Ia24cd85276df77d835e723563fd25de9c4c8be5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809514 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698670}
-
Sophie Chang authored
This is in preparation to support fetching hints for users with the "Make searches and browsing better" setting No functional changes - my plan is to share the site engagement logic and evaluate different blacklist prefs for the different consent models Bug: 1005279 Change-Id: I1844a5e0e7d983ef90318c76a859bc8a65ffb9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816957Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#698669}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6f647b543901..11b57f8d09f5 git log 6f647b543901..11b57f8d09f5 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 seanabraham@chromium.org Revert "cros_mark_as_stable: Add auto_merge for server-side rebase." Created with: gclient setdep -r src/third_party/chromite@11b57f8d09f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic6addcb366352fadcf55f4db80d600e3b2be2f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815595Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/410cf3af9982..d4d1ba4971aa git log 410cf3af9982..d4d1ba4971aa --date=short --no-merges --format='%ad %ae %s' 2019-09-20 ehmaldonado@chromium.org git-cl: Use buildbucket v2 to schedule try jobs. Created with: gclient setdep -r src/third_party/depot_tools@d4d1ba4971aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:976104 Change-Id: I31da36727b1d0e0ac4f56996b86f1ddd82c7085a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815833Reviewed-by:
-
Miguel Casas authored
This CL migrates MailboxVideoFrameConverter from using Textures to using SharedImages. No external functionality changes are expected. Couple of things need to be added: - ScopedSharedImage: an internal class to scope a SharedImage lifetime. SharedImages are kept in |shared_images_|, indexed by a unique id. - Added GetGpuChannelCB that can be derived from the GetStubCB and that is needed for SharedImage creation and destruction. They are generated on Create(), so this interface doesn't change. - This CL uses a WeakPtr to the GpuChannel, accessing its SharedImageStub and the gpu::Scheduler that way. Most of the work goes in: - InitializeOnGpuTaskRunner() and then - the sequence ConvertFrameOnGPUThread() (calls either GenerateSharedImageOnGPUThread() or UpdateSharedImageOnGPUThread()) then jumps back to WrapMailboxAndVideoFrameAndOutput(). Test: crosvideo.appspot.com resolution-changing videos (vp9, h264, vp8) of course with the new VD decoder, on kohaku and scarlet/dru. Bug: 998279 Change-Id: Ic9b5b2270d1b488562bc2725bba89dc2a0350012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772642 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#698666}
-
Matt Menke authored
The class has a per-server cache that could be used for fingerprinting. As it's defined outside of net/, rather than make QuicCryptoClientConfig NetworkIsolationKey-aware, this CL has QuicStreamFactory create one QuicCryptoClientConfig per NetworkIsolationKey, as needed. Once there are no live QuicSessions/QuicStreamFactory::[.*]Jobs using a particular QuicCryptoClientConfig, the QuicCryptoClientConfig is added to an MRU cache of recently used configs, and reused/evicted as needed. This CL also passes in a NetworkIsolationKey to the HttpServerProperties::*QuicServerInfo calls, to finish hooking up NetworkIsolationKeys to HttpServerProperties. It's needed in this CL because the only integration tests for QuicCryptoClientConfig rely on those methods. Bug: 1003423, 969890 Change-Id: Id1823012104b84677f6684205bb58fa0227825b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809601Reviewed-by:
-
