GitLab

R=eae@chromium.org,dgrogan@chromium.org

Review-Url: https://codereview.chromium.org/2161733003
Cr-Commit-Position: refs/heads/master@{#406098}

This patch converts the usage of CanonicalCookie's constructor in
GaiaCookieManagerService::ForceOnCookieChangedProcessing() to use
CanonicalCookie::Create() method.

We are doing this because the Create() method validates the parameters
and we thus we can test the return value to see if it has passed or not.
Whereas we can not do this when using the constructor.

BUG=57061
TEST=components_unittests
R=mmenke@chromium.org,rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2113863002
Cr-Commit-Position: refs/heads/master@{#406097}

The shader translators are basically stateless, but they get recreated (a costly
operation) for every new decoder.
Just keeping a reference to them is enough to keep them in the shader translator
cache, so introduce a getter for them in the decoder, and keep a reference to
them in the fuzzer code.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2152733003
Cr-Commit-Position: refs/heads/master@{#406096}

The test has 10 squares filled with a color gradient. 10 different filter
effects are applied to each square. The filter effects are applied with a
keyframe animation to force the non-display list path.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2156793002
Cr-Commit-Position: refs/heads/master@{#406095}

BUG=598073

Review-Url: https://codereview.chromium.org/2153673002
Cr-Commit-Position: refs/heads/master@{#406094}

https://chromium.googlesource.com/skia.git/+log/6451a0cea600..034f243c6de4

$ git log 6451a0cea..034f243c6 --date=short --no-merges --format='%ad %ae %s'
2016-07-18 caryclark disable test that fails to compute bounds on nexus 5
2016-07-18 caryclark disable new test since it fails on skia_fast
2016-07-18 mtklein Tweak a couple things I found confusing in ColorSpaceXform unit tests.
2016-07-18 fmalita Remove SkDOM::build(const char doc[], size_t len)
2016-07-18 brianosman Introduce GrColorSpaceXform, for gamut conversion on textures
2016-07-18 borenet Convert SK Images to new assets format
2016-07-18 msarett Fix rewinding bug in SkJpegCodec
2016-07-18 bsalomon Initialize fGammaCorrect in DF Path Renderer unit test
2016-07-18 caryclark pathops coincidence and security rewrite

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2158153002
Cr-Commit-Position: refs/heads/master@{#406093}

Review-Url: https://codereview.chromium.org/2152023003
Cr-Commit-Position: refs/heads/master@{#406092}

The pin input right now is too tall, and a unwanted blue outline shows up around it.

BUG=627937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2150383002
Cr-Commit-Position: refs/heads/master@{#406091}

BUG=628878
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2156883003
Cr-Commit-Position: refs/heads/master@{#406090}

Experimenting with a different text did not yield any positive results.

BUG=589128

Review-Url: https://codereview.chromium.org/2158103002
Cr-Commit-Position: refs/heads/master@{#406089}

Review-Url: https://codereview.chromium.org/2148143002
Cr-Commit-Position: refs/heads/master@{#406088}

Also, reposition scroll functionality from the popover helper to the
ColorSwatchPopoverIcon/BezierPopoverIcon. This will allow us to move
the popover helper so it can be re-used in Sources.

BUG=none
R=lushnikov

Review-Url: https://codereview.chromium.org/2155263002
Cr-Commit-Position: refs/heads/master@{#406087}

Tot has ARGB hardcoded, whereas certain platforms (e.g.
Android) usually have ABGR. Make that decision runtime.

Also, code in ToT uses SkBitmap, which is discouraged,
this CL changes it to using SkSurface and SkPixmap
instead.

BUG=628466

Review-Url: https://codereview.chromium.org/2153093003
Cr-Commit-Position: refs/heads/master@{#406086}

Reland of In rebaseline, include build number information with "test_prefix_list" dicts. (patchset #1 id:1 of https://codereview.chromium.org/2151253004/ )

Reason for revert:
Making a reland CL to investigate and try to reproduce the unit test failures (e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/20653/steps/webkit_python_tests/logs/stdio)

Original issue's description:
> Revert of In rebaseline, include build number information with "test_prefix_list" dicts. (patchset #4 id:60001 of https://codereview.chromium.org/2144873004/ )
>
> Reason for revert:
> Seems to be causing failures in webkit_python_tests on multiple bots (e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/20653).
>
> Original issue's description:
> > In rebaseline, include build number information with "test_prefix_list" dicts.
> >
> > When rebaselining, the main argument passed to the rebaseline method is a "test_prefix_list", which is currently a dict mapping test prefixes to builder names to baseline file suffixes.
> >
> > If we want to change _suffixes_for_actual_failures to fetch actual failures for try jobs, then that method needs to know the build number as well.
> >
> > This CL would replace the builder in all "test_prefix_list" dicts with a Build object, which includes builder name and build number, but build number is optional.
> >
> > Planned follow-up: changing build_data() to use a method to fetch and cache results for particular builds, and change _suffixes_for_actual_failures fetch results for particular builds using that method as well. This would make the "skip_checking_actual_results" workaround unnecessary. I could also include that change in this CL.
> >
> > Committed: https://crrev.com/e5830ddcf7cc0fc87decede44a0a0baa4d5e8c61
> > Cr-Commit-Position: refs/heads/master@{#405783}
>
> TBR=dpranke@chromium.org,wkorman@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/110c6f3a6dfa490acca83b2daa49615ee821ac8a
> Cr-Commit-Position: refs/heads/master@{#405804}

TBR=dpranke@chromium.org,wkorman@chromium.org,wjmaclean@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2153973002
Cr-Commit-Position: refs/heads/master@{#406085}

This attribute is used with copyable TrivialStruct which should be passed by
value. It is not transitive. std::vector<TrivialStruct> will be passed by const
ref, for example.

It is added because people think it is useful to make base::Time* pass by value
to be more consistent with our style requirements.

BUG=624136

Review-Url: https://codereview.chromium.org/2146153002
Cr-Commit-Position: refs/heads/master@{#406084}

Remove old callback-based ListenForRouteMessages API and replace it
with StartListeningForRouteMessages and OnRouteMessagesReceived. The
rationale is return value based API doesn't work well for event pages;
when the event page is suspended, the callback supplied by the old API
is lost and cannot be restored when the extension wakes up. Switching
to the listener model unblocks the work to reduce the nessesity of
keeping the event page alive and should result in considerably
simpler logic on the extension side.

To maintain backwards compatibility with older extensions, a smaller
adapter logic is introduced in media_router_bindings.js.

Add missing WakeReason for StartListeningForRouteMessages.

Also added OWNERs for the mojom file to comply with presubmit.

BUG=625007

Review-Url: https://codereview.chromium.org/2111303003
Cr-Commit-Position: refs/heads/master@{#406083}

The flaky suppression didn't work.

BUG=628697
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2159983002
Cr-Commit-Position: refs/heads/master@{#406082}

BUG=627928

Review-Url: https://codereview.chromium.org/2142423003
Cr-Commit-Position: refs/heads/master@{#406081}

Revert of Disable some GLAndSoftwareCompositing content browser tests under MSAN. (patchset #2 id:20001 of https://codereview.chromium.org/1405873002/ )

Reason for revert:
This has been fixed.

Original issue's description:
> Disable some GLAndSoftwareCompositing content browser tests under MSAN.
>
> These tests give errors when run under MSAN. There is likely a real
> problem introduced recently (see bug for details).
>
> TBR=avi@chromium.org
> BUG=542896
>
> Committed: https://crrev.com/47cd72d660d736695b0a2f2a2dedc8d189a6bbfe
> Cr-Commit-Position: refs/heads/master@{#354224}

TBR=avi@chromium.org,benwells@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=542896

Review-Url: https://codereview.chromium.org/2159933002
Cr-Commit-Position: refs/heads/master@{#406080}

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2147933004
Cr-Commit-Position: refs/heads/master@{#406079}

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2148383005
Cr-Commit-Position: refs/heads/master@{#406078}

The DisplayItemList holds data received from WebContentLayerImpl. It
processes that data and holds the results as internal data used by cc.
Separate the data received from WebContentLayerImpl from the internal
data.

BUG=625290
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2149743003
Cr-Commit-Position: refs/heads/master@{#406077}

Currently, most feature validation happens in Parse(). Add a Validate()
function that can be called after Parse() so that if a feature is
generated, validation can still be performed (independent of whether or
not the feature is created from a JSON value).  In the future, these
validations should be performed as part of the compile process, but this
is a starting point.

Also update tests that parsed features and used JSONFeatureProvider only
to test this validation. This way, once we move away from
JSON-based features and JSONFeatureProvider, these tests are still
active.

BUG=280286

Review-Url: https://codereview.chromium.org/2150193002
Cr-Commit-Position: refs/heads/master@{#406076}

BUG=627938
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2157533002
Cr-Commit-Position: refs/heads/master@{#406075}

Revert of [GN] Add JSON project writer (patchset #11 id:200001 of https://codereview.chromium.org/2064533002/ )

Reason for revert:
Broke Win8 GYP (dbg) builder:
[822/12249] LINK_EMBED gn.exe
FAILED: gn.exe gn.exe.pdb
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True gn.exe "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:gn.exe @gn.exe.rsp" 1 mt.exe rc.exe "obj\tools\gn\gn.gn.exe.intermediate.manifest" obj\tools\gn\gn.gn.exe.generated.manifest ..\..\build\win\compatibility.manifest
gn_lib.lib(gn_lib.command_desc.obj) : error LNK2019: unresolved external symbol "public: static class std::unique_ptr<class base::DictionaryValue,struct std::default_delete<class base::DictionaryValue> > __cdecl DescBuilder::DescriptionForTarget(class Target const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,bool,bool,bool)" (?DescriptionForTarget@DescBuilder@@SA?AV?$unique_ptr@VDictionaryValue@base@@U?$default_delete@VDictionaryValue@base@@@std@@@std@@PBVTarget@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@3@_N22@Z) referenced in function "bool __cdecl commands::`anonymous namespace'::PrintTarget(class Target const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,bool,bool,bool,bool)" (?PrintTarget@?A0x51180473@commands@@YA_NPBVTarget@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@_N222@Z)

gn_lib.lib(gn_lib.command_desc.obj) : error LNK2019: unresolved external symbol "public: static class std::unique_ptr<class base::DictionaryValue,struct std::default_delete<class base::DictionaryValue> > __cdecl DescBuilder::DescriptionForConfig(class Config const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?DescriptionForConfig@DescBuilder@@SA?AV?$unique_ptr@VDictionaryValue@base@@U?$default_delete@VDictionaryValue@base@@@std@@@std@@PBVConfig@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@3@@Z) referenced in function "bool __cdecl commands::`anonymous namespace'::PrintConfig(class Config const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,bool)" (?PrintConfig@?A0x51180473@commands@@YA_NPBVConfig@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@_N@Z)

gn_lib.lib(gn_lib.command_gen.obj) : error LNK2019: unresolved external symbol "public: static bool __cdecl JSONProjectWriter::RunAndWriteFiles(class BuildSettings const *,class Builder const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,bool,class Err *)" (?RunAndWriteFiles@JSONProjectWriter@@SA_NPBVBuildSettings@@PBVBuilder@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@222_NPAVErr@@@Z) referenced in function "bool __cdecl commands::`anonymous namespace'::RunIdeWriter(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class BuildSettings const *,class Builder *,class Err *)" (?RunIdeWriter@?A0x1eff038c@commands@@YA_NABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PBVBuildSettings@@PAVBuilder@@PAVErr@@@Z)

gn.exe : fatal error LNK1120: 3 unresolved externals

Traceback (most recent call last):

  File "gyp-win-tool", line 323, in <module>

    sys.exit(main(sys.argv[1:]))

  File "gyp-win-tool", line 29, in main

    exit_code = executor.Dispatch(args)

  File "gyp-win-tool", line 71, in Dispatch

    return getattr(self, method)(*args[1:])

  File "gyp-win-tool", line 179, in ExecLinkWithManifests

    subprocess.check_call(ldcmd + add_to_ld)

  File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 540, in check_call

    raise CalledProcessError(retcode, cmd)

subprocess.CalledProcessError: Command 'E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:gn.exe @gn.exe.rsp gn.exe.manifest.res' returned non-zero exit status 1120

Original issue's description:
> [GN] Add JSON project writer
>
> Output is a JSON file containing information about targets. The generator
> can also optionally invoke a python script on generated file.
>
> Example:
> gn gen --ide=json ./out-json --json-ide-script=//scripts/custom-ide-generator.py \
>     --ison-ide-script-args="additional script arguments"
>
> Also implements --format=json for gn desc as described in https://bugs.chromium.org/p/chromium/issues/detail?id=620132
>
> BUG=
>
> Committed: https://crrev.com/d2edeb9a743ad5a2046e655997277d3bb630db03
> Cr-Commit-Position: refs/heads/master@{#406064}

TBR=brettw@chromium.org,matej.knopp@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2160533004
Cr-Commit-Position: refs/heads/master@{#406074}

Include normal user-reported bug template and version number in link
to file bug in MD Settings appeal banner.

Result looks like crbug.com/628951.

BUG=none
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2155063003
Cr-Commit-Position: refs/heads/master@{#406073}

Revert of gn: Remove unnecessary v8 defaults (patchset #7 id:120001 of https://codereview.chromium.org/2058033002/ )

Reason for revert:
Seems to have broken Google Chrome Mac builder:
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:514:7: Replacing nonempty list.
      remove_configs = [ "//build/config/mac:strip_all" ]
      ^-------------
This overwrites a previously-defined nonempty list (length 2).
See //v8/gni/v8.gni:55:3: for previous definition
  remove_configs += [ "//build/config/compiler:default_optimization" ]
  ^------------------------------------------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
  remove_configs = []
before reassigning.
See //BUILD.gn:202:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1

Original issue's description:
> gn: Remove unnecessary v8 defaults
>
> Remove chromium defaults for v8_optimized_debug and
> v8_use_external_startup_data.
>
> This is not needed after v8 provides these defaults:
> https://codereview.chromium.org/2025803003/
> https://codereview.chromium.org/2024833002/
>
> It also interferes if somebody tries to override the gn args
> with a different value.
>
> BUG=chromium:616034
> TBR=alokp@chromium.org, brettw@chromium.org
>
> Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
> Cr-Commit-Position: refs/heads/master@{#406067}

TBR=jochen@chromium.org,dpranke@chromium.org,vogelheim@chromium.org,alokp@chromium.org,brettw@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:616034

Review-Url: https://codereview.chromium.org/2160663003
Cr-Commit-Position: refs/heads/master@{#406072}

BUG=627306

Review-Url: https://codereview.chromium.org/2153153003
Cr-Commit-Position: refs/heads/master@{#406071}

Smaller font and light grey background.

BUG=626442
TEST=manual

Review-Url: https://codereview.chromium.org/2152243002
Cr-Commit-Position: refs/heads/master@{#406070}

Also fix a bug where the drop shadow offset did not account for scale in this
matrix (e.g. due to high DPI).

BUG=600821
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2114303002
Cr-Commit-Position: refs/heads/master@{#406069}

TBR=dalecurtis@chromium.org
BUG=629147

Review-Url: https://codereview.chromium.org/2159953002
Cr-Commit-Position: refs/heads/master@{#406068}

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Review-Url: https://codereview.chromium.org/2058033002
Cr-Commit-Position: refs/heads/master@{#406067}

This is a follow up to the fix in r405892. Also cleanup some nits.

BUG=628086

Review-Url: https://codereview.chromium.org/2153763005
Cr-Commit-Position: refs/heads/master@{#406066}

Then size is scaled in both axes, so the declared parameter name is confusing.
This changes it to "scale", which matches the parameter name in the definition.

Review-Url: https://codereview.chromium.org/2159723003
Cr-Commit-Position: refs/heads/master@{#406065}

Output is a JSON file containing information about targets. The generator
can also optionally invoke a python script on generated file.

Example:
gn gen --ide=json ./out-json --json-ide-script=//scripts/custom-ide-generator.py \
    --ison-ide-script-args="additional script arguments"

Also implements --format=json for gn desc as described in https://bugs.chromium.org/p/chromium/issues/detail?id=620132

BUG=

Review-Url: https://codereview.chromium.org/2064533002
Cr-Commit-Position: refs/heads/master@{#406064}

So that it can be removed in a followup CL.

This CL also fixes saving/restoring incognito cookie stores
on Android, which was not being done correctly.

BUG=620770,627256

Review-Url: https://codereview.chromium.org/2103863003
Cr-Commit-Position: refs/heads/master@{#406063}

* Add the ability to bold parts of a label.

* Add the ability to show a tertiary label in the PaymentOption, which
  will later be used for phone number display.

* The phone number is passed in to the PaymentOption using the new constructor
  via the AutofillAddress class.

See crbug.com/626833 for screenshots.

BUG=603635,626833

Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f
Review-Url: https://codereview.chromium.org/2135573004
Cr-Original-Commit-Position: refs/heads/master@{#405900}
Cr-Commit-Position: refs/heads/master@{#406062}

Revert of [DevTools] Always report encodedDataLength in Network.ResponseReceived. (patchset #1 id:1 of https://codereview.chromium.org/2101073002/ )

Reason for revert:
Decided to try another approach, see discussion in issue 622018

Original issue's description:
> [DevTools] Always report encodedDataLength in Network.ResponseReceived.
>
> Currently, we only send encodedDataLength for redirects. However, we already know how much we read when sending ResponseReceived. This will improve reporting for failed requests, as they don't get loadingFinished with full encodedDataLength.
>
> BUG=622018
>
> Committed: https://crrev.com/00f8f6c17d27799700974e599d6003b7f376071c
> Cr-Commit-Position: refs/heads/master@{#402543}

TBR=allada@chromium.org,mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=622018

Review-Url: https://codereview.chromium.org/2158073002
Cr-Commit-Position: refs/heads/master@{#406061}

TBR=thestig@chromium.org
BUG=484351,484852

Review-Url: https://codereview.chromium.org/2156123003
Cr-Commit-Position: refs/heads/master@{#406060}

git grep'd for "more then", "less then", "greater then".
(Interestingly, no hits for "fewer then".)

BUG=none
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2157963002
Cr-Commit-Position: refs/heads/master@{#406059}