- 04 Dec, 2019 40 commits
-
-
Juan Antonio Navarro Perez authored
Bug: 1029008 Change-Id: I38d1642451bd0aeb85c25cc1de87737008c38ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940150 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#721419}
-
Eric Seckler authored
Since benchmarks are still flakily failing on linux-perf due to overrunning the buffer. We may be able to reduce this further again once we remove LegacyEvent completely. Bug: 1029510 Change-Id: Ie91d85842fae1f82632c1e72c87e5dc1508ff714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948743 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721418}
-
Andreas Haas authored
With this CL I remove a use of DOMArrayBufferView::deprecatedByteLengthAsUnsigned and replace it by using DOMArrayBufferView::byteLengthAsSizeT. To avoid potential problems with overflows I do an overflow check in NavigatorBeacon::sendBeacon and throw a RangeError if necessary. Additionally I added checks to the BeaconDOMArrayBufferView implementation where the byteLengthAsSizeT is actually used. R=yhirano@chromium.org Bug: chromium:1008840 Change-Id: Ifa94e08e47384232e9d112244ffc29e0e870b2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948884Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#721417}
-
Andreas Haas authored
I removed the declaration of two functions where I deleted the definition recently. Drive-by: I also changed the implementation of ByteLengthAsUnsigned to use a checked_cast now. I was not aware of checked_cast back when I did the change originally. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I8863115c06b44d1c04e8bb71df93709a25012e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947740Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#721416}
-
Andreas Haas authored
The implementation can already deal with size_t anyways. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Id0c0b9997cd2a27dd40d240e234cb89d314a651e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948888Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4b6a26740234..f3aa582f01c2 git log 4b6a26740234..f3aa582f01c2 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 yangguo@chromium.org Remove invalid isolate entries in BUILD.gn 2019-12-04 anubmat@microsoft.com DevTools: Add profileType context in the aria-description of Memory tool sidebar tree elements 2019-12-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. 2019-12-03 zoeclifford@chromium.org Update Googlebot User-Agent 2019-12-03 mjackson@microsoft.com Allow user to tab to the inspect link on the remote devices panel. 2019-12-03 yangguo@chromium.org Move test and localization scripts 2019-12-03 janscheffler@chromium.org Show Network request with SameSite issues Created with: gclient setdep -r src/third_party/devtools-frontend/src@f3aa582f01c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030258,chromium:963183,chromium:984733 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iab0c9089c5bc957ea3de62b99766e5429ff87dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950041Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721414}
-
Hugo Holgersson authored
See Issue 803086 for motivation and context of this effort. Bug: 803086, 1000578 Change-Id: Ib36de3f671204ce0d9b4d05e68966e735ba5544e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949784Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Cr-Commit-Position: refs/heads/master@{#721413}
-
Mark Cogan authored
Update the RecentTabsCooordinator to use the preferred initializer. Most of the change volume comes from adopting the preferred dispatcher/ handler style and usage. This is especially painful in the unittest, since the dispatcher in the test browser needs to conform to several protocols to pass the runtime checks used by HandlerForProtocol(). This probably means that the large command protocols, especially those that conform to several other protocols, need to be made more specific. Bug: 1029346 Change-Id: I69baf57ce162799b5af4ec6fdfe19e7bdc787d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944468Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#721412}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/249cb200173f..b939b4a7247d git log 249cb200173f..b939b4a7247d --date=short --first-parent --format='%ad %ae %s' 2019-12-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src a4af7676feb0..e58c080d4f02 (1 commits) Created with: gclient setdep -r src/third_party/angle@b939b4a7247d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I43b14eb77064c953a4b4a1aed5060120447e3dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949541Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3ed4586044f2..e82a428605f6 git log 3ed4586044f2..e82a428605f6 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 dneto@google.com WebGPU: Array size at most max signed int + 1 (#3077) 2019-12-03 9856269+sarahM0@users.noreply.github.com Permit the debug instructions in WebGPU SPIR-V - remove from the optimizer (#3083) 2019-12-03 dneto@google.com graphics robust access: use signed clamp (#3073) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e82a428605f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I8354cc6437209c19cc8b1e8a7d956d656cbca0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950029Reviewed-by:
-
Richard Knoll authored
Instead of using the WebContents from the tab that initiated showing a SharingDialog, always use the one from the currently shown tab. This makes sure that we show the origin if the initiating one does not match the one in the active tab. Bug: 1029414 Change-Id: Idf79aeff17db3c5cf3137af19727bdaf79989bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948838 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721409}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/162322e97930..30972d73df3e Created with: gclient setdep -r src-internal@30972d73df3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iffcd017fac9212c9dc8ce223927aab8e0f812ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950034Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721408}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a097c941d4f8..b64ff931eb98 git log a097c941d4f8..b64ff931eb98 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 skyostil@google.com TrackEvent: Add tip about constexpr event names Created with: gclient setdep -r src/third_party/perfetto@b64ff931eb98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:132678367 Tbr: perfetto-bugs@google.com Change-Id: I28eecd9921eac4afdc88be08b7fc6911aabcdad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950035Reviewed-by:
-
Maksim Sisov authored
Posthandling events does not work properly in this case as we are not able to track if the event that has been sent to sink is handled or not. That is, SendEventToSink results in copying the entire event which means that the original event is not going to have its handling status changed. That means that we are not able to track if the event is handled or not unless a dispatcher or a target are destroyed (remember that SendEventToSink returns EventDispatchDetails, but does not say anything about handling results). That resulted in the WindowEventFilterLinux always post-processing events and opening context menus twice (the first one was closed immediately after it was shown and the second one was shown instead). TEST: manually tested. Bug: 1028046 Change-Id: I2bedda57c7ca8a05171428da26b889eac04cf36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947733Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#721406}
-
Mario Sanchez Prada authored
This CL migrates the mojo client in the renderer side of the contextual_search component to the new BrowserInterfaceBroker, and adapts the code in the browser process to register the binder from PopulateChromeFrameBinders(), instead of doing it inside of ContextualSearchObserver. Last, this CL also extracts the ContextualSearchObserver class out of contextual_search_manager.cc, so that the receiver can be bound now via the BinderMap owned by the BrowserInterfaceBroker. Bug: 936482,1006361 Change-Id: I95c8046650883c872750dd7408a38e7433ed9df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906667Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Mike West authored
We shipped this restriction in M77 ([1]). We can safely remove the underlying feature flags and histogram. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1646784 Bug: 1030135 Change-Id: I52ce3c152862c0ae74742444faacef741db60abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947734 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#721404}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I32f3daabe58344ff6e6ed22b7876b839a93a1839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950030Reviewed-by:
-
Andy Paicu authored
Bug: 986737 Change-Id: I80eabeb588d807453241df3dacdd1a764c66d7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942087Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721402}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for FaceDetectionProvider and FaceDetection from FaceDetectionImplWinTest using Remote. Bug: 955171 Change-Id: Ic420d06ccb96986ee5991f5b43e50cc3209bea14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939587Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#721401}
-
Gabriel Charette authored
This is the fix to the issue highlighted at https://chromium-review.googlesource.com/c/chromium/src/+/1938067 Anti-starvation on the UI/IO threads is highly problematic per unexpected reorder of base::TaskPriority. BrowserTaskExecutors already disables this. TaskEnvironment needs to do the same. R=alexclarke@chromium.org Bug: 1013535 Change-Id: Ief82ff8a80813455e60bb6ed53fdb23228f68f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948093 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#721400}
-
Thanh Nguyen authored
This CL refactors the test so that we don't need to use the macros Bug: 1028853 Change-Id: Id5372cdc6564921bbb6c850d135257e39838729c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949834Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#721399}
-
Meredith Lane authored
The spec is unclear on whether or not this is actually a bug with aria-owns. It was discovered during implementation of Element Reflection that nodes were unable to be aria-owned by other nodes, if they had previously been aria-owned. This change allows for nodes to be reparented, providing the previous relationship has been removed. BUG=981423 R=dmazzoni, aleventhal, chrishall Change-Id: Ie6757868c6165df28b5217e5bb41a4bd00eb0478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942593 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#721398}
-
Makoto Shimazu authored
TBR=rogerta@chromium.org No-Try: true Bug: 1030602 Change-Id: I67ffa1585a51e32b865b3ba9e28b5c25ff14e060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950047Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721397}
-
Kouhei Ueno authored
We replaced the flaky RFH.deleted() check with WaitUntilDeleted(). > Revert "BFCache: Add a browser_test for WebMIDI" > > This reverts commit efd7d333. > > Reason for revert: > BackForwardCacheBrowserTest.WebMidiNotCached is consistently failing since this landed on at least one bot: > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8840 > Tracking as part of Bug: 1022876 > > Original change's description: > > BFCache: Add a browser_test for WebMIDI > > > > Bug: 981740 > > Change-Id: I40605b9b6b343a3e0b4a12fe3b0e5e0b6f992390 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903182 > > Commit-Queue: Kouhei Ueno <kouhei@chromium.org> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > > Reviewed-by: Fergal Daly <fergal@chromium.org> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#713734} Bug: 981740, 1022876 Change-Id: I531ea5ee417f810df3c8fe699d9b8cebe0be14e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949814Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#721396}
-
Fergal Daly authored
These tests depend on the page not going into the cache. Bug: 1029248 Change-Id: Ie13a0cdd4f01bcb1c3bde3004708dd78ccdfe8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943708 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#721395}
-
Gyuyoung Kim authored
There is a case that SharedRemote needs to support a disconnect callback in order to convert ThreadSafeInterface to SharedRemote. So, this CL adds set_disconnect_handler to SharedRemote with a test case. Additionally, this CL makes the constructor and Create() factory functions private in SharedRemoteBase class. Because SharedRemoteBase needs to have RemoteWrapper as a member variable to call set_disconnect_handler(). TEST: RemoteTest.SharedRemoteDisconnectCallback Bug: 955171 Change-Id: I5131c9947491094fbb0c00bbb733fd3dcbbf1b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947517 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#721394}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d61f8670f996..dc7697bc61e9 git log d61f8670f996..dc7697bc61e9 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src bd8110e5..d02b0cb4 (540 commits) Created with: gclient setdep -r src/third_party/skia@dc7697bc61e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: Idf00878c879dfe165943cb07425aeb14438c6291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949422Reviewed-by:
-
Dominic Battre authored
This CL introduces some debug output about the key and funnel metrics of autofill to chrome://autofill-internals in order to check whether reporting is correct for all kinds of corner cases. Bug: 928595 Change-Id: Ia40b969f0f439532bb88c695989fe4b056951d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947729Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#721392}
-
Christopher Cameron authored
The lifetime of a GL program compile and link can be seen in GrGLProgramBuilder::PrecompileProgram. The sequence is - glCreateProgram creates a program object - GrGLCompileAndAttachShader creates and compiles the vertex, fragment, and geometry shaders - Link status is queried using glGetProgramiv with GL_LINK_STATUS Create the histogram Gpu.GL.ProgramBuildTime for this entire time. While this may not capture all of program building, the fact that it goes through GL_LINK_STATUS ensures that we at least know the source has been parsed. Obsolete histograms that we won't be using. In particular - Using a test shader to disable Metal won't be acceptable, since that will break WebGPU unpredicatably. - Doing several retry attempts isn't going to move the needle on stability, so don't even try. The purpose of all of this is to give us some data comparing OpenGL and Metal, in the hopes that we won't continue to be told that we're holding it wrong. Bug: 974219 Change-Id: Ibed594aeea286344446244d86f7331597d5619ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948265 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#721391}
-
Armando Miraglia authored
Since AEC2 has been fully replaced by AEC3, these metrics are now obsolete and should not be looked at any longer. Bug: None Change-Id: I72987600e9e17180c2435054c34ea86aa715b4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932368Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85bb5de39728..162322e97930 Created with: gclient setdep -r src-internal@162322e97930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I210915a97fc17846cc447cf53316e064d1590703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949421Reviewed-by:
-
Kent Tamura authored
Add timestamp tests for blob-backing files and filesystem files. This CL makes File::LastModifiedTime public because many tests access it. This CL has no behavior changes. Bug: 1027959 Change-Id: I86ff3788f44edf830b1372bc3b17c3a951a77803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948666 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#721388}
-
Megan Jablonski authored
Add the checkbox to the new Translate UI's tab view and the source language view. Bug: 976352 Change-Id: Ic0e2630b4161dc57f053b625c65cea262476bfc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940496 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#721387}
-
Ken Rockot authored
This reverts commit 8b3c757e. Reason for revert: All dependent reverts relanded, there was nothing broken about this CL specifically. Original change's description: > Revert "Delete bind_interface_helpers.h" > > This reverts commit a47f7784. > > Reason for revert: breaks graphics on some Chrome OS devices. > > Original change's description: > > Delete bind_interface_helpers.h > > > > This header provides a bunch of helper functions for Content processes > > modeled as Service Manager services. Since those are no longer a thing, > > this no longer needs to be a thing. > > > > Bug: 977637 > > Change-Id: Ia1ae177b4a9665b727618b12a35be905d5605ce9 > > Tbr: jam@chromium.org > > Tbr: erikchen@chromium.org > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929396 > > Commit-Queue: Ken Rockot <rockot@google.com> > > Reviewed-by: Ken Rockot <rockot@google.com> > > Cr-Commit-Position: refs/heads/master@{#718367} > > Bug: 1028852 > Bug: 977637 > Tbr: rockot@google.com > Tbr: jam@chromium.org > Tbr: erikchen@chromium.org > Change-Id: Ie621804e4a6c03c26bf64130bab49f6a9380dea6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948401 > Reviewed-by: Shuhei Takahashi <nya@chromium.org> > Commit-Queue: Shuhei Takahashi <nya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720918} TBR=jam@chromium.org,rockot@google.com,erikchen@chromium.org,nya@chromium.org Change-Id: I738e84cc2af953c2a03da5c3cf791226ccff7c51 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028852, 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949780Reviewed-by:
-
Keishi Hattori authored
ScriptValue was modified to use WorldSafeV8Reference through r701030, r698399, r694681 but we suspect it may have caused a memory leak. This change ScriptValue back to use SharedPersistent. To maintain the same level of security, the world check from WorldSafeV8Reference has been transplanted into SharedPersistent. Bug: 1029738 Change-Id: I21ed2929c3e90530a958be0503f153646f85ec7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948671 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Glen Robertson authored
Change-Id: I82111e2602c8d0b6488c1aca2440edafca9cfddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949832 Commit-Queue: Glen Robertson <glenrob@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Ken Rockot authored
This reverts commit bfca6c80. Reason for revert: Reverting the revert which was only done make reverting an earlier CL possible. Earlier CL has been fixed and relanded. Original change's description: > Revert "Move Utility processes off Service Manager" > > This reverts commit 0a311ff4. > > Reason for revert: breaks graphics on some Chrome OS devices. > > Original change's description: > > Move Utility processes off Service Manager > > > > This migrates Utility processes to direct ChildProcess API usage instead > > of bootstrapping IPC through the Service Manager. > > > > As this is the last remaining use of Service Manager IPC to bootstrap > > Content child processes, this also rips out a bunch of infrastructure > > that existed only to support that. > > > > Bug: 977637 > > Change-Id: I08e542f1d9f294bc1c387ea5845e8ba0d5a7d2b8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919719 > > Commit-Queue: Ken Rockot <rockot@google.com> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718352} > > NOPRESUBMIT=true > > Bug: 1028852 > Bug: 977637 > Tbr: rockot@google.com > Tbr: avi@chromium.org > Tbr: rsesek@chromium.org > Change-Id: I9b2e8ca44f5b6accc2d3718cab3cb547d979c230 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948402 > Commit-Queue: Shuhei Takahashi <nya@chromium.org> > Reviewed-by: Shuhei Takahashi <nya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720938} TBR=avi@chromium.org,rockot@google.com,nya@chromium.org,rsesek@chromium.org NOPRESUBMIT=true Change-Id: I79ea423c97880366125abfb659dae223d0185023 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028852, 977637 Tbr: rsesek@chromium.org Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949304 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Darin Fisher authored
This is an attempt to avoid a renderer hang that may be explained by trying to get an interface via BrowserInterfaceBroker (BIB) and then make synchronous calls on that interface. This is an experimental change. It is unfortunate to introduce render_frame_id parameters here, and my intent is to come back and remove them once I understand how to do so without the observed hang. The experiment with this CL is to confirm that the observed hang goes away. If it does, then it confirms that there is some interaction with BIB that is causing the issue. If it does not, then we know BIB is off the hook, and we can look elsewhere. Bug: 1023519 Change-Id: I696b63f057605b3cd5fe7f0c8182b044f2a60578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949036Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721382}
-
Ella Ge authored
The crash in GetInterpolatedEventForPredictedEvent is due to the initial value of 'idx' is set to -1, but it's an unsigned type. This CL makes it initialize to 0. Bug: 1030386 Change-Id: I44796c1813374f4c192ee3c125c5f957fbe57061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948048Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#721381}
-
Makoto Shimazu authored
It's flaky on win-asan bots. TBR=dtapuska@chromium.org No-Try: true Bug: 1030589 Change-Id: I317d93e60daf8be5d5813307da487f7b58efedc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949836Reviewed-by:
-
