GitLab

This reduced the local runtime of virtual/layout_ng_flex_box from 2m22s
down to 0m18s. I had previously been jumping through hoops locally to
not run the virtual suite at all.

Change-Id: Idf4ba1c6cf6d7fc43d5873b873c7eb8be313e474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999185
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731765}

Increase the lifetime because this is still useful.

Bug: 1037439
Change-Id: I3a76d173a2500de61c4edb542d364e37536e6fb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998297
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731764}

Since WrapCallbackWithDefaultInvokeIfNotRun() should be used sparingly,
replace it with code to handle a disconnect in arc::PrintSessionImpl.
Now, arc::PrintSessionImpl manages pending callbacks, and handles PDF
Flattener disconnects.

Bug: 997243
Change-Id: I8a0be44998ce1eec93f166f1776e0595d15e714b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995941
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731763}

This reverts commit 8fb47ccd.

Reason for revert:
Fixed: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1995823
Rolled: crrev.com/c/1998818

Original change's description:
> Revert "Enable init_stack_vars for non-official Debug Windows builds"
>
> This reverts commit d140b7a4.
>
> Reason for revert: Broke crashpad_tests reliably
> https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/12597
>
> Original change's description:
> > Enable init_stack_vars for non-official Debug Windows builds
> >
> > Debug build is fixed with: crrev.com/c/1973353
> >
> > Bug: 977230, 1030261
> > Change-Id: Idcb24d092247f6bc7438c74b6405b4b93539507d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970852
> > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
> > Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
> > Reviewed-by: Hans Wennborg <hans@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#728840}
>
> TBR=hans@chromium.org,vitalybuka@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 977230, 1030261
> Change-Id: Iad7d92e12299365b4a45a5237c3bc5e371e33dbe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993964
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#730123}

TBR=vasilii@chromium.org,hans@chromium.org,vitalybuka@chromium.org

Change-Id: Icccde6c0629968511d14368f00586f5cf40226e6
Bug: 977230, 1030261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995988
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731762}

Also, just reuse the OWNERS file for libxml in libxslt.

Change-Id: I3cc3f0bc0a207090f86b72a8060565091d7f684a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001109Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731761}

Bug: none
Change-Id: I1718ddc7ea6577ee6d30b95dd31fbc58167a9e2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000277Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731760}

This commit rolls the hunspell_dictionaries dependency's commit into
this repo, which deletes the older versions of the en and fa
dictionaries as the second part of
https://chromium-review.googlesource.com/1994089.

Roll src/third_party/hunspell_dictionaries/ b22df2b32..e96f230bf (1 commit)

https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries.git/+log/b22df2b32d70..e96f230bf759

$ git log b22df2b32..e96f230bf --date=short --no-merges --format='%ad %ae %s'
2020-01-14 varuncvarada Remove old en and fa dictionaries

Created with:
  roll-dep src/third_party/hunspell_dictionaries

Bug: 1041438
Change-Id: Iec7c115c559383efb8d7d1444878f539e0c4fc98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001527Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731759}

This is a refactoring to be able to register the SharedPrefs keys
declared in ShareHelper in ChromePreferenceKeys. Only the keys used for
the main SharedPrefs file need to be registered.

Bug: 1022108
Change-Id: Ia69e0a8c02f374662cdbed70010ad50bafe76b05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992501
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731758}

Bug: None
Change-Id: Ie1878fc725026ddb1dca29655556c0064764c3a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001357Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731757}

Change-Id: Ib6f5317f71aa2b899e3f5560d161733d3b8336c0
Bug: 1037334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000763
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731756}

This is a reland of f3a7d44e

No new images for a few days, should no longer fail when re-enabled.

Original change's description:
> Reland "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation"
>
> This reverts commit b4099b2c.
>
> Reason for revert: new image has been triaged in Skia Gold.
>
> Original change's description:
> > Revert "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation"
> >
> > This reverts commit 7076daa4.
> >
> > Reason for revert: The test started failing again after this CL was landed. More details on crbug.com/1040202
> >
> > Original change's description:
> > > Remove Pixel_CSSFilterEffects_NoOverlays failure expectation
> > >
> > > Test was producing a minor image diff, has been triaged.
> > >
> > > Bug: 1040202
> > > Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564
> > > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > > Commit-Queue: Brandon Jones <bajones@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#729597}
> >
> > TBR=kbr@chromium.org,bajones@chromium.org
> >
> > Change-Id: Id637b25550ce9f423e448d0b332c0dbbf34b9eb9
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1040202
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992367
> > Reviewed-by: sebsg <sebsg@chromium.org>
> > Commit-Queue: sebsg <sebsg@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#729736}
>
> TBR=kbr@chromium.org,bajones@chromium.org,sebsg@chromium.org
>
> Change-Id: Ief8494871a1a32571d7526ac313f7cbbc0d78d69
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1040202
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993113
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#729838}

TBR=kbr@chromium.org

Bug: 1040202
Change-Id: I1045d7601496b271faf1ca41dd7a7707889ec733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001225Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731755}

Changes: only call a PartitionAlloc method when PartitionAlloc is
         enabled.


Original change's description:
> Revert "[windows] Release the Win32 address space reservation on OOM."
>
> This reverts commit db01ddb8.
>
> Reason for revert: Breaks linking on all cronet bots.
>
> ```
> ld.lld: error: undefined symbol: base::ReleaseReservation()
> >>> referenced by memory_linux.cc:48 (../../base/process/memory_linux.cc:48)
> >>>               base/memory_linux.o:(base::(anonymous namespace)::ReleaseReservationOrTerminate()) in archive obj/base/libbase.a
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
> ```
>
> Bug: 1041737, 1028086, 1023804
>
> Original change's description:
> > [windows] Release the Win32 address space reservation on OOM.
> >
> > On Windows 32 bit, Chrome reserves a significant chunk of address space
> > when a renderer starts, to make large contiguous allocations easier to
> > fulfill. Once a memory allocation fails, the reservation is released,
> > then the allocation retried. This only works if *all* the allocators are
> > aware that this mechanism exists. Unfortunately, malloc() in particular
> > is not aware of this, meaning that if a large malloc() allocation bumps
> > into this issue first, then the renderer crashes.
> >
> > As this seems to be the case, from looking at crash reports (see linked
> > bugs for instance), malloc() should be made aware of this.
> >
> > On Windows, allocations use the allocator shim, and call the "new
> > handler", which should return a non-0 value when it is able to free some
> > memory. Currently, this new handler always crashes the process. We
> > update it to drop the reservation if it exists, and crash otherwise.
> >
> > This should hopefully solve some crashes we are seeing, especially some
> > related to video decoding, frequently allocating buffers of ~1MB, which
> > is large enough to trigger the issue, as seen in crash reports.
> >
> > This is not a complete fix, since it does not address all allocators in
> > a process, e.g. allocations by DLLs loaded by the process will not pass
> > through the new-handler hook. We do not (yet) see these as a significant
> > cause of crashes in practice though.
> >
> > Note that this CL also adds the reservation dropping behavior to Linux
> > builds as well. There is no address space reservation in actual Chrome
> > builds on Linux, but adding this allows to exercise the tests on Linux
> > builders as well, which is preferable.
> >
> > Bug: 1028086, 1023804
> > Change-Id: I12ad4aa0c7bf518c3cf1df93c966e8631a69c280
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989747
> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > Reviewed-by: Benoit L <lizeb@chromium.org>
> > Reviewed-by: Wez <wez@chromium.org>
> > Commit-Queue: Benoit L <lizeb@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#730994}
>
> TBR=wez@chromium.org,brucedawson@chromium.org,lizeb@chromium.org
>
> Change-Id: I45bc4e480105548384291f97fc50df01c5e6ecc3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1028086, 1023804
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999245
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#731042}

TBR=wez@chromium.org,nyquist@chromium.org,brucedawson@chromium.org,lizeb@chromium.org

Change-Id: Ie7cc4a04d816f5f8fc7de2cdc4ce0d003bbe7dfe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1041737, 1028086, 1023804
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999888Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731754}

Some blink_perf.layout tests e.g. floats_10_1000.html stress code where
-ftrivial-auto-var-init inserts unnecessary padding initialization.

Issue this patch is trying to solve:
HEAD + trivial-auto-var-init(crrev.com/c/1711704) vs HEAD: 9.8% slower
https://pinpoint-dot-chromeperf.appspot.com/job/119c3039a20000

Same with the fix:
this + trivia-auto-var-init(crrev.com/c/1711704) vs HEAD: 2% faster
https://pinpoint-dot-chromeperf.appspot.com/job/1707ab99a20000

Patch has small effect on perf without trivial-auto-var-init
this vs HEAD: x86-64 1.5% slower, Arm 1.5% faster. Both are probably noise.
x86-64: https://pinpoint-dot-chromeperf.appspot.com/job/149354c3a20000
Arm: https://pinpoint-dot-chromeperf.appspot.com/job/14f307c7a20000
Win10: https://pinpoint-dot-chromeperf.appspot.com/job/10c69ba9a20000

Bug: 977230
Change-Id: Ifd34565e12312d8e840dbb5771aa9dbf1c3907e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997164Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731753}

This is adding tests for:
 - isSessionSupported (immersive-ar on AR & VR devices).
 - requestSession (immersive-ar on AR & VR devices).
 - environmentBlendMode allowed values in AR & VR.

Bug: 949296
Change-Id: Idee7a1d03a0f9bc961e65a225e8fcc851c2eaa14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001196Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731752}

https://chromium.googlesource.com/catapult.git/+log/c8083d168105..7431e17d79d0

git log c8083d168105..7431e17d79d0 --date=short --first-parent --format='%ad %ae %s'
2020-01-14 hypan@google.com Use --no-streaming option when installing app on certain devices
2020-01-14 jbudorick@chromium.org devil: dump host_forwarder_log on failure to kill host forwarder.

Created with:
  gclient setdep -r src/third_party/catapult@7431e17d79d0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1004322,chromium:1038789
Tbr: wenbinzhang@google.com
Change-Id: Iac937a0c6c4ed8a23abcbf7133b56217916df299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001523Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731751}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/85f423a4..df902743

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I42f00357eae1746280d800c89982611598c887eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001617Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731750}

Nvram-based boot lockbox was first introduce in M74. Through TPM 2.0,
nvram is initialized (think: empty set). Device initialized before M74
has uninitialized value (think: nil) from boot lockbox's perspective.

When the nvram is uninitialized, the QueryAdbSideload D-Bus call returns
with error NEED_POWERWASH, since powerwash is the only way to initialize
the value.

NEED_POWERWASH can only be returned on old devices, and on old devices
adb sideloading is not available. Thus, it is safe to assume that when
NEED_POWERWASH is returned, the device does not have sideloaded apps.

      2) flash to update to M80  # see warning message at login screen
      3) apply this fix  # warning message is gone

Test: 1) flash the device to M73, powerwash to initialize TPM state, login
Bug: 1038672
Change-Id: Iae7af4905d1b6824cba0c25b9cd4c69277c3d893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001721
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731749}

Just give it 10 more milestones. This is still a useful metric for
our team.

Bug: 1036930
Change-Id: I9f2b15940a82222c0c6b416deacd8b5554007f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997642
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731748}

Bug: 1037808
Change-Id: Ide0179f5eb417bc7645d686aa523bd54fd10715c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001719
Auto-Submit: Francois Marier <francois@brave.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731747}

Bug: b/129956026
Merge-With: eureka-internal/349523
Test: CQ
Change-Id: Iec5f242094c7eef34a7632cc4207ec8b3fb0af51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986959
Commit-Queue: Junbo Ke <juke@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731746}

Chrome currently supports Android KitKat, but as of this CL, a UI will be
presented to users running on Android KitKat. Whether this message is shown
or not is possible override from a server side configuration.

This is in preparation of an upcoming deprecation of Android KitKat support.

Bug: 1041930
Change-Id: I6eef0697887215cc58a1d4e5067ba19ee383c76a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001241
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731745}

Param names are updated in the field trial test.

Bug: 1017120
Change-Id: I6f3fee3faaac5f9061c097858c5b02b05c3e8fb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989066
Auto-Submit: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731744}

Done with:

$ git ls-files 'ui/webui/*.js' | xargs perl -p -i -e 's/ ([!=])=(?!=)/ \1==/g'

Bug: 720034
Change-Id: Ib012e225c21f3d68176078a7b5410207e1778e0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001259
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731743}

These classes implement the behavior shared amongst all infobar modal
implementations.  The coordinator packages a modal view configured by
subclasses into a UINavigationController and presents it modally.  The
mediator conforms to InfobarModalDelegate and handles those callbacks.

Bug: 1030357
Change-Id: I2c20f8c545daa5038bcccca3c10d7a24a8b3d2b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995687
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731742}

Bug: 1023482
Change-Id: I182fb9a4534441fecde63fb03949f8441656de4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001555
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731741}

Bug: None
Test: CQ
Change-Id: I3ed71c53de6108fbf096202e0d2d8b06f27fa0fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994842Reviewed-by: David Munro <davidmunro@google.com>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Auto-Submit: David Munro <davidmunro@google.com>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#731740}

In order to enable the OpenXR flag by default we must fix tests that
assume OpenXR is disabled otherwise they will fail.

Change-Id: If9d117e3ea4ef2e2ddd7d9f1bb3aedc601c0b27e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999450Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Lachlan Ford <laford@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#731739}

This implements the same logic in pre-CAP compositor that prevents
squashing of two layers that are too far away to avoid big squashed
layer with sparse contents.

Change-Id: Iea9f761ed6bcff19a45d57489bc3929d4bca71a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990343
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731738}

Have commented the new code out as the file does not exist in the
current app that is pulled in from g3. Can uncomment line after the
next CIPD update that includes the new file.

Bug: b/147331285
Change-Id: Ib323a03c8c6f0404f97957185936320a7a5ed6fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999887Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Cr-Commit-Position: refs/heads/master@{#731737}

Change-Id: Ia9237329cedb733e657912fc44a15688ae3bafd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806075Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731736}

ContentSettings.MixedScript has already expired, and the metrics are no
longer used (or emitted) after the mixed content shield removal. This
CL removes uses from code and marks the histogram obsolete.

Bug: 988686
Change-Id: I203a447b53aff09f7ac10895e35e4355e5ddf61e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987294Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731735}

- override new 4x4 virtual
- override scale/translate virtuals

In the new *brave* world, SkCanvas will call didTranslate() and didScale() in
response to the corresponding public calls. On the impl side, SkCanvas
no longer has a default impl for either, so they must be overridden.

Having to update multiple unittests might point to a slight problem with layering
and testing. It appears (to me) that most of the sites I had to update were
incidental, not core, to the test. The caller is baking in assumptions about how
Skia handles some high-level api calls (and what virtuals it may call). If we
could find a different way to still test the chrome/blink code in question, it
will be easier going forward.

bug: skia:9768

Change-Id: I8aa62feb354392105229ea45686b8208ba0e1450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998247
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731734}

This CL updates the TabStripUIHandler to send events ot the WebUI for
when a tab's group state is changed. This CL also sets up the first
unit test for the handler.

This CL does not add the front-end changes, or the events for changes
to a tab group's visuals or indexes.

Bug: 1027373
Change-Id: I7c72dbbd189a308c8565c9ecd29e76007fe60c93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999225
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731733}

BUG=1041822
TBR=harringtond@chromium.org

Change-Id: Id22776f84bc687fbe164fd197496314b5941c94d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001583Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731732}

This CL changes PWA manifest update check throttling to reset on browser
restart. This is to make it easier to diagnose any issues with PWA
updating detected on live profiles by ensuring that manifest update
checks will be performed after a browser restart.

This CL adds a DesktopPWAsLocalUpdatingThrottlePersistence flag that
can quickly revert us back to the previous behaviour should we need.

Bug: 926083
Change-Id: Id9a0f9146af710922dd11cc42c114bf6dff31a3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999902Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731731}

This change implements the methods in BluetoothChooserContext and
creates a unit test for the class.

Design Doc:
https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/edit?usp=sharing

Bug: 589228
Change-Id: I1c564177063f9459081c45ddb4c0bb757fabd667
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978819
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731730}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d85dc3874aaa..a0840e9a2f6a

git log d85dc3874aaa..a0840e9a2f6a --date=short --first-parent --format='%ad %ae %s'
2020-01-14 hongchan@chromium.org Migrate webaudio/ to ESM internally

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@a0840e9a2f6a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759,chromium:1040646
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7a57268e4ee9d4ab4fd54fde8fe5b2f2fdc4c949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001522Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731729}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e62267bbb42..69949ed05dcf


Created with:
  gclient setdep -r src-internal@69949ed05dcf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1022108,chromium:1028270,chromium:684817
Tbr: jbudorick@google.com
Change-Id: Ia7acfb14e57e52374e5c4d0f1e3cebaee1eb612c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001519Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#731728}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/88d715c..4f3976e

TBR=kbr@chromium.org

Bug: 1000354
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64
Change-Id: Icf1f39b04a3b90b8a652238b6110f1b87221f0d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998295Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#731727}

This adds code (behind a flag) to allow WebXr sessions to determine the
needed permissions and prompt the user for them on both Desktop and
Android.

In order to properly link to the PermissionManager and related classes,
VRServiceImpl and the classes that call into it needed to be moved into
the chrome/browser Build target.  Given that this target depends on
vr_common (where these other classes are), vr_common couldn't depend on
it, or else it would introduce a circular dependency. Therefore, these
files were moved into chrome/browser's target, which seemed to be common
for other classes that relied on PermissionManager.

vr_headset.png's generated from source SVG in crbug.com/912203 (which is
the source of the currently checked-in vr_headset.icon)

Note that strings are currently placeholders.

Showing the permission status in the page info bubble and site settings
will be done in future changes.

Bug: 1033592
Change-Id: I5be7f8b6e62c00fcb11ddeb6c2410720ec9c1bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992508
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731726}