- 21 Jun, 2018 40 commits
-
-
Gauthier Ambard authored
The dispatcher wasn't set for the primary toolbar used by the NTP, leading to bugs where the commands weren't sent to the rest of the application. Bug: 851930 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I17b2e015a307e993e548c4dfcbca599472503d58 Reviewed-on: https://chromium-review.googlesource.com/1110123 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569279}
-
James Wallace-Lee authored
TalkBack should just speak the cell data for cells in table. TBR=avi@chromium.org Bug: 669622 Change-Id: Iecb736acdbe36d106672b97425bb72988eef1efa Reviewed-on: https://chromium-review.googlesource.com/1108920 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#569278}
-
Devlin Cronin authored
We're getting ready to roll extension bindings out to beta, so add a fieldtrial testing config entry for the experiment to have it run by default on the bots. Bug: 763564 Change-Id: Ibdf83e16cbc10e4c62e2304cf14cd7c24377bc31 Reviewed-on: https://chromium-review.googlesource.com/1108192Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569277}
-
Rune Lillesveen authored
Be explicit about when we try to access pseudo style caches instead of uncached. We will remove cached access for computing style for PseudoElement and only use caching for pseudo element style where we don't generate any elements (like ::selection) and for getComputedStyle queries on elements which do not generate pseudo elements. E.g. getComputedStyle(elm, "::before") when elm has no matching ::before rules. Bug: 836126 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2e4436ea78b31bc72f05ada66b2955369ee93f4a Reviewed-on: https://chromium-review.googlesource.com/1109825Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#569276}
-
Mounir Lamouri authored
Bug: 848537 Change-Id: I07e7195991ea350a9b5d17b48682a541ff2ef7a4 Reviewed-on: https://chromium-review.googlesource.com/1081871 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#569275}
-
Samuel Huang authored
This CL moves Zucchini-gen invocation code from zucchini_commands.cc (in target zucchini) to zucchini_integration.cc (in target zucchini_io) to clean up layering in Zucchini API, i.e.: - zucchini_lib: Operates on buffers only. - zucchini_io: Adds files interface, uses memory-mapped I/O. - zucchini: Stand-alone executable that parses command-line arguments. Other changes: - Rename zucchini_lib functions (zuchcini.h), to dedup names and emphasize that these functions operate on buffers: - GenerateEnsemble() -> GenerateBuffer(), - GenerateEnsembleWithImposedMatches() -> GenerateBufferImposed(), - GenerateRaw() -> GenerateBufferRaw(), - Apply() -> ApplyBuffer(). These renames only affect Zucchini and various tests. - Variable renames and parameter reordering in zucchini_integration.cc. - Remove '-dd' param in help text of Zucchini-detect (was never ported from Trunk, and has been recently deleted there as well). - Replace all base::File&& with base::File. - Miscellaneous cleanup for header include. - Update README.md. Change-Id: I835b80d4d3d7b291fa822a7a89dab225bf9171e9 Reviewed-on: https://chromium-review.googlesource.com/1105625Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#569274}
-
Marc Treib authored
This adds a State enum to StartupController and exposes it via GetState(). It's not strictly required right now, but a) it'll help with sanitizing ProfileSyncService's state, b) it makes the tests a bit nicer, now they can use the enum instead of relying on debug strings, and c) it lets us move GetEngineInitializationStateString from StartupController to ProfileSyncService, where it's slightly less out of place (bonus: extra DCHECKs for consistent state). Other semi-related test cleanups: don't call SetFirstSetupComplete from FakeStartBackend (no idea why that call was there), and don't check for the kSyncDisableDeferredStartup cmdline flag (if you run the tests with a custom flag, it's your own fault if they fail). Bug: 839834 Change-Id: I16f83be8ee828024329cbce899be4723241323db Reviewed-on: https://chromium-review.googlesource.com/1109939 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569273}
-
Peter Beverloo authored
This utility class contained the (custom) interaction of notification permission storage with the HostContentSettingsMap. Instead, fall back to using the HCSM directly where there's no diverging behaviour, and add a NotificationPermissionContext::UpdatePermission() method for the rest. Change-Id: I729d460a5773c691d611285ecfbf7cc97618f304 Reviewed-on: https://chromium-review.googlesource.com/1093091 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#569272}
-
Maks Orlovich authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. Note that this only covers the code immediately here; the underlying google_apis/gaia code is unchanged. Bug: 844963 Change-Id: I9ba41c0c7cbb3a996db49d437b421d65f7e9c8ee Reviewed-on: https://chromium-review.googlesource.com/1087412 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#569271}
-
Ian Vollick authored
This should take precedent over other environments, even incognito. Bug: 853818 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I001b11ade38415e884d889c4c13c617707cfd8a7 Reviewed-on: https://chromium-review.googlesource.com/1104978Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569270}
-
Mikel Astiz authored
We refactor and extend the tests to: 1. Add support for USS types (which requires migrating the tests from reading the directory directly). 2. Capture more complex sequences, combining multiple transitions. 3. Add disabled tests that are under investigation, due to flakiness reported on iOS integration tests the exercise analogous transitions. Bug: 854446 Change-Id: Ic6aa9294086a8511255a084af08112f3455f078b Reviewed-on: https://chromium-review.googlesource.com/1110118Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#569269}
-
Matthew Jones authored
This patch renames the questionably named "FadingBackgroundView" to something that makes sense, "ScrimView". All associated interfaces have also been updated. Change-Id: Ib95226264c9f23f3aaa1a0053cf81e44722eb910 Reviewed-on: https://chromium-review.googlesource.com/1005623 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#569268}
-
Oscar Johansson authored
When building using Jumbo namespace aliases with the same name may end up in the same unit, causing a conflict at compilation. This commit removes "using windows" and "using tabs" and instead call the namespace by its full name. This is done to increase the robustness of the code. std::unique_ptr<T>() are removed because of presubmit check errors. Bug: 850484 Change-Id: I91f44728d4b54dd15213bac602176ca8736bb3cd Reviewed-on: https://chromium-review.googlesource.com/1107633Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#569267}
-
Danil Chapovalov authored
So that webrtc/api:optional target can be removed. webrtc version of Optional is gone in favor of absl::optional Chromium already updated not to use rtc::Optional and use absl::optional only when is needed to be set in webrtc structures. Bug: webrtc:9078 Change-Id: I282197cb800e46ece9486bb6b6068d1680a40d2b Reviewed-on: https://chromium-review.googlesource.com/1109830Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#569266}
-
Arthur Sonzogni authored
The GURL class upgrades the port from 80 to 443 when asked to replace the URL's scheme from 'http' to 'https'. Doing it manually was pointless. Bug: none. Change-Id: I12aaa7f0a243134a3810ed871e73b7473acfad5a Reviewed-on: https://chromium-review.googlesource.com/1107931Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#569265}
-
Rune Lillesveen authored
We create an unobservable inline box for display:contents pseudo elements storing the original style on the element. Split this code out into a separate method as we will need it for constructing pseudo elements as part of style recalc later. Bug: 836126 Change-Id: I8610ea5cd92ebbefd0428f84ca2ff4e48169b232 Reviewed-on: https://chromium-review.googlesource.com/1109827Reviewed-by:
-
Dave Tapuska authored
Add additional API to determine if we should revalidate if we are allowing a stale response. Add a test to cover the different intervals of what should be returned by the API. BUG=348877 Change-Id: I69be1c768e4896362406bb80a3dde307edae27d2 Reviewed-on: https://chromium-review.googlesource.com/1102352Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#569263}
-
Jungshik Shin authored
This roll has just one change to fix the timezone detection on Japanese/Korean and other non-English Windows. https://chromium-review.googlesource.com/1094322 In addition, switch to ICU to convert UTC to local time in blink. This is to deal with a cryptic failure of external/wpt/html/dom/doc*/resource*/document-lastModified-01.html parens. Bug: 849724 Test: Set the timezone to Tokyo on Japanese Windows Test: In JS console, 'new Date()' outputs 'Japan Standard Time' in Test: Layout test external/wpt/html/dom/doc*/resource*/document-lastModified-01.html Change-Id: I3037252ff9044a114ae831de2b151df7c652603c Reviewed-on: https://chromium-review.googlesource.com/1100739Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569262}
-
Olivier Robin authored
BUG=852964 Change-Id: Ic47e00858062874ad30eaeeb4bae54d93ae1087d Reviewed-on: https://chromium-review.googlesource.com/1108215 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569261}
-
Deepanjan Roy authored
Allows specifying cache temperature with --cache-temperature. Values are as defined in telemetry/page/cache_temperature.py. For example: --cache-temperature=warm. Also, changes the default cache temperature for loading_ct to COLD. Change-Id: Ib0210bf2a72d28902bfe653cc01646aae4ccbcff Reviewed-on: https://chromium-review.googlesource.com/1106643 Commit-Queue: Deepanjan Roy <dproy@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#569260}
-
Danyao Wang authored
WKBasedNavigationManager needs to create a web view to restore session. The current order causes an CHECK in CRWWebController that prevents the creation of new web view when |_webUsageEnabled| is false. This fixes failure in NavigationTestCase and crashes observed in the wild. Bug: 852847 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia6a7800ca6ec985a2080d0e0acc3a743c8c62c5f Reviewed-on: https://chromium-review.googlesource.com/1108575Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#569259}
-
Martin Šrámek authored
Bug: 854538 Change-Id: I1e33574edf070dc93cf897faab75a0e53df39dd8 TBR: mkwst@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1109959Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Mustaq Ahmed authored
Bug: 805015 Change-Id: I9b9c8ee0071707220ec9ad1f7966816b055cf655 Reviewed-on: https://chromium-review.googlesource.com/1108438Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#569257}
-
Stuart Langley authored
Rename to --disable-team-drives for disabling. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1103986. sashab@ is on vacation so I am landing her changes in this CL, with fixes for failing unit tests. Bug: 849772 Change-Id: I37260458a60f69d2e95d87afbf87213456131c29 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1108241Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#569256}
-
Kai Ninomiya authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1098558 but with the bug fixed. TBR=piman@chromium.org, geofflang@chromium.org Bug: 828135 Change-Id: I8c2b899e911277f9ad0d86363a54d187aad64843 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1105564Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#569255}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b67614b..653887dd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3ef6bab11c902b33ea07e7d7a68c367136a6f28d Reviewed-on: https://chromium-review.googlesource.com/1109741Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569254}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5b8dd4d75ec3..8b23dba0e50f git log 5b8dd4d75ec3..8b23dba0e50f --date=short --no-merges --format='%ad %ae %s' 2018-06-21 philipel@webrtc.org Add RTPVideoHeader const accessor. 2018-06-21 danilchap@webrtc.org Replace rtc::Optional with absl::optional 2018-06-21 ouj@fb.com Create a peer connection factory builder 2018-06-21 phensman@webrtc.org Add OnLogMessage(msg, sev, tag) to logsinks 2018-06-21 saza@webrtc.org Remove nonlinear beamformer API from APM 2018-06-21 philipel@webrtc.org Add RTPVideoHeader accessor. 2018-06-21 buildbot@webrtc.org Roll chromium_revision e1ef7d4b..b47e7752 (568794:569173) Created with: gclient setdep -r src/third_party/webrtc@8b23dba0e50f The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:None,chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I971128efa0de663e8c5c768eb373e7672768a096 Reviewed-on: https://chromium-review.googlesource.com/1109860Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569253}
-
Quan Nguyen authored
This reverts commit 8db5d9a3. Reason for revert: This CL was identified as introducing flakiness to LoginCursorTest.CursorHidden (in interactive_ui_tests) Original change's description: > Enable powerwash shortcut in views-based login screen. > > Bug: 837501 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: Ia55c5e302d70c1a65409fd7268ae135e0ee7c5ca > Reviewed-on: https://chromium-review.googlesource.com/1102904 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569043} TBR=xiyuan@chromium.org,dcheng@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org Change-Id: I2cf2fcc2d8a0f8c491b16e4bca4387e07cabb69c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837501 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1109617 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569252}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I3b0380e69b94665b8687757939c11c8427c52015 Reviewed-on: https://chromium-review.googlesource.com/1110137Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569251}
-
Rune Lillesveen authored
Bug: 836126 Change-Id: Ifd1705c3d72af1c9250f97279a03f439ee08d478 Reviewed-on: https://chromium-review.googlesource.com/1109824 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Philip Jägenstedt authored
This is because add_cleanup will begin accepting thenable return values, and returning any other value will cause a harness error: https://github.com/web-platform-tests/wpt/pull/8748#issuecomment-398954260 Change-Id: I700233ef706328c09e67c6d262f206b8f0d06da7 Reviewed-on: https://chromium-review.googlesource.com/1109513 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#569249}
-
Philip Jägenstedt authored
Roll in the most recent version of: testharness.js, testdriver.js, idlharness.js and webidl2.js Change-Id: I90d19fcca8d4cd5ef616534da61937f185913085 Reviewed-on: https://chromium-review.googlesource.com/1109514 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
chrome://dinoEdward Jung authored
Bug happens on the rare occasion that bdayFlashTimer == 0, the dino keeps on flashing and bday mode never gets set. Bug: 846473 Change-Id: Iddbe3f9fdba49c540930aac1721cb76a2b137af6 Reviewed-on: https://chromium-review.googlesource.com/1109501Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#569247}
-
Peter Beverloo authored
This removes all permission-related code from the Web Notifications implementation beyond the NotificationPermissionContext. The //content-level code has been amended to use the PermissionManager directly now that all permission checks happen on the UI thread. Web Notifications inherit the "notifications" extension permission. This was implemented in the PlatformNotificationServiceImpl, which meant that not all ways of checking for granted permission (notably the Permission API, as well as internal checks) reached the same conclusion. This led to bugs. In order to unify all of that, these checks are now also done by the NotificationPermissionContext. The key difference there from the previous implementation is that we no longer check whether the extension is indeed running in a particular process. That's OK because the Mojo service, BlinkNotificationServiceImpl, decisively knows which origin it's owned by. (Which could be the extension Id that this code is dealing with.) Various new tests have been added to cover this behaviour, including a NotificationPermissionContextApiTest suite that verifies that our Web exposed behaviour is consistent among the various APIs that are able to request and/or use notification permission status. Bug: 845514 Change-Id: I4b8b306858a69ed93b6b1ab553985f4c90b7b2d1 Reviewed-on: https://chromium-review.googlesource.com/1085568 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Marc Treib authored
This reorders and renames some members, extracts logic into helpers, removes an unnecessary ForTest method, etc. No functional changes. While we're here, also switch from ThreadTaskRunnerHandle to SequencedTaskRunnerHandle - nothing here requires thread affinity. Bug: 846238, 854978 Change-Id: Iaeaf7664ec78a23acbc0dfaf84122dea9ca4ef38 Reviewed-on: https://chromium-review.googlesource.com/1109897Reviewed-by:
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/393d20a8e911..e0b24e08909e Created with: gclient setdep -r src-internal@e0b24e08909e The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide530129c2e76ad999d991b5af5b3febf27dadda Reviewed-on: https://chromium-review.googlesource.com/1109862Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569244}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cd70aa422ce6..3237f75953c1 git log cd70aa422ce6..3237f75953c1 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 lucferron@chromium.org Vulkan: Fix issue when a sampler2D was not used in FS or VS Created with: gclient setdep -r src/third_party/angle@3237f75953c1 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ibaf3dc15aea352302bfd07c8ee88bdb487848c5f Reviewed-on: https://chromium-review.googlesource.com/1109857Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569243}
-
Justin Cohen authored
It seems with Xcode 10 items behind the keyboard are appearing as visible. This is likely an EG bug. Bug: 854847 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I905d4e7809afe6d5d35e240b8e6c815f70cd41df Reviewed-on: https://chromium-review.googlesource.com/1109307Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569242}
-
Ned Nguyen authored
This CL improve the sharding algorithm by adjusting the policy of picking a story at the boundary a benchmark shard. Before this, we will keep adding story to a benchmark shard until the total time assigned is greater than expected total time (assuming assignment is perfect). This CL changes it to keep adding story until the absolute value of the difference between total time assigned and expeted total time is minimal. The effectiveness of this change can be shown by looking at the predict stats ("extra_info" field) in the 3 shards: linux_perf_shard_map, mac_1012_low_end_26_shard_map, mac_1013_high_end_26_shard_map. Change-Id: I3ace373fb1393658cc21aca1a61a66d865a8c059 NOTRY=true # tests covered by PRESUBMIT Change-Id: I3ace373fb1393658cc21aca1a61a66d865a8c059 Reviewed-on: https://chromium-review.googlesource.com/1108374 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#569241}
-
jonross authored
Locally the SitePerProcessBrowserTests were working with surface sync on Android. This updates the filter to only block SitePerProcessHitTests instead. Also updates the Viz filter to remove the Mac only failures. TBR=fsamuel@chromium.org TEST=surface_sync_content_browsertests, viz_content_browsertests Bug: 849746 Change-Id: Id6fca3c0ff2ad31a2ee0051b2b889fb80d0c51e3 Reviewed-on: https://chromium-review.googlesource.com/1110038Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#569240}
-
