- 06 Jun, 2018 40 commits
-
-
Dominik Röttsches authored
Change-Id: I402ab2491cc71d76169c2336d0a514fba18375c4 Reviewed-on: https://chromium-review.googlesource.com/1089111Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#565098}
-
Xi Cheng authored
Change-Id: Ie3d2ebaf98ca26de363dd961f64d5461b909ec14 Reviewed-on: https://chromium-review.googlesource.com/1089803Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#565097}
-
Findit authored
This reverts commit 413675e9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 564933 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQxMzY3NWU5YjY2N2UwN2FlODRhMTE1MjY4YWJlZGZkYjc0MzA3NDAM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7480 Sample Failed Step: browser_tests Original change's description: > Run PrioritizedTaskRunner tasks with the same priority in posting order > > What: > If two tasks have the same priority, they should run in posting order. > > A second thing this CL does is fix a race in the unittests. I meant to block > the task runner before queueing up requests but failed to. Fixed here. > > Why: > This can prevent hypothetical task starvation. It's also necessary for the > SimpleCachePrioritization control group to ensure that we maintain old > behavior. > > Bug: 850085 > Change-Id: I1f259296604bf04ea33ecbee9ad3180f064c4266 > Reviewed-on: https://chromium-review.googlesource.com/1088759 > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564933} Change-Id: Id4930090c0026aefa9d92bb8871e809a3fcfa124 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850085 Reviewed-on: https://chromium-review.googlesource.com/1089892 Cr-Commit-Position: refs/heads/master@{#565096}
-
Nigel Tao authored
This brings the (still hand-written) externs/file_manager_private.js file closer to what tools/json_schema_compiler/compiler.py generates. Test: "ninja ui/file_manager:closure_compile" runs without error Bug: 613096 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3dfdddd9a6b9c0d67d143f89a5f9348eaecb4ae Reviewed-on: https://chromium-review.googlesource.com/1088345Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565095}
-
Charlie Ma authored
Bug: 845328 Change-Id: Ia55620022af7303904c3da0987f1514822d8c973 Reviewed-on: https://chromium-review.googlesource.com/1089865Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Charlie Ma <charliema@chromium.org> Cr-Commit-Position: refs/heads/master@{#565094}
-
Lei Zhang authored
Change-Id: Id296f888fc40eb2758c6fc9827024e2871082b37 Reviewed-on: https://chromium-review.googlesource.com/1087398Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#565093}
-
Erik Jensen authored
On Linux, the user-session binary, after forking the host deamon, keeps running in the foreground to relay log messages and return the ultimate success/failure of starting the host to the caller. However, if the host takes more than 120 seconds to signal it is online, the foreground process will time out and quit, leaving the background process running. With this commit, the foreground process will optimistically return success to the calling process in this case, rather than failure as it did previously. This allows the setup flow to be completed even when replication delays or other issues cause the host to take a long time to start, as an error return code during initial setup would cause the host to be automatically unregistered from the directory. Change-Id: Ie8d157cf2bc433a59857b65b495cc79aeea63ffc Reviewed-on: https://chromium-review.googlesource.com/1086386Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#565092}
-
Ryan Hansberry authored
SecureChannelClient's full implementation will follow in a subsequent CL; we are creating the interface and test fake now to unblock other engineers' work. Bug: 824568, 752273 Change-Id: Ic7bc054d6a59d1f1b65e7831c4be9c6f77045ad0 Reviewed-on: https://chromium-review.googlesource.com/1083948 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#565091}
-
Aleks Totic authored
Bug: 467127 Change-Id: I4176cb0e4216ced9434c5c84832df6d6a5cd37d3 Reviewed-on: https://chromium-review.googlesource.com/1089205Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#565090}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1b40071..93a962f git log 1b40071..93a962f --date=short --no-merges --format='%ad %ae %s' 2018-06-06 benjhayden@chromium.org Add logging to measure alerts query latency. Created with: gclient setdep -r src/third_party/catapult@93a962f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2c5ea98c547a15ad394c0a3fbeb3d28cc66210de Reviewed-on: https://chromium-review.googlesource.com/1089693Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565089}
-
Ken Rockot authored
There's no reason for Mojo to provide this API. Bug: 844763 Change-Id: I32e9e92f82e55564273961f3f59dd15677125e81 Reviewed-on: https://chromium-review.googlesource.com/1086035Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#565088}
-
Ethan Kuefner authored
Disabling a couple of stories due to bot health bugs. These are in benchmarks blink_perf.svg, and rendering.desktop/mobile. NOTRY=true TBR=nednguyen@google.com Bug: 850293, 850295 Change-Id: I9d201fd8997d94e53aa16f55c48ed136566b9570 Reviewed-on: https://chromium-review.googlesource.com/1090007 Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Reviewed-by:
Ethan Kuefner <eakuefner@chromium.org> Cr-Commit-Position: refs/heads/master@{#565087}
-
Xi Cheng authored
Change-Id: Ic5a1a6e51a2387e3215e2aac5192e318ab31c525 Reviewed-on: https://chromium-review.googlesource.com/1087789Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#565086}
-
edchin authored
This CL enables the badged reading list by default. Bug: 848358 Change-Id: I23e371c2de66f39c6e2b856c802451129911140f Reviewed-on: https://chromium-review.googlesource.com/1088191Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565085}
-
David Grogan authored
Old code only supported auto and fixed flex bases. This makes 3 more tests pass. Also added a ton of comments. From spot checking, it seems many non-crash failures are due to not setting the flex container's height correctly, e.g. external/wpt/css/css-flexbox/align-content-001.htm css3/flexbox/relpos-with-percentage-top.html Bug: 845235 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I06a3d8f4b8923c8acb1d6fb07826da66d55826a5 Reviewed-on: https://chromium-review.googlesource.com/1088229 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#565084}
-
John Z Wu authored
will combine signin and sync for //ios/web_view. //ios/web_view only needs to signin because it needs to sync autofill data. As such, we will combine them to simplify the API. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9ecefad6523ae0207ec5c33516fd90bc536633b1 Reviewed-on: https://chromium-review.googlesource.com/1089352Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565083}
-
Varun Khaneja authored
No change to README.chromium required since it already contains: - Replace exceptions with terminating the current process. Guarded with the macro UNRAR_NO_EXCEPTIONS. R=wfh Bug: 750327,847635,767906 Change-Id: Ie5efe8b637f87647ea2972c115a2ac2464ef793d Reviewed-on: https://chromium-review.googlesource.com/1081434Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#565082}
-
Ryan Hansberry authored
This class is no longer used and can be deleted. BeaconSeeds are no longer fetched on demand; they are always present in a RemoteDevice object. R=jhawkins@chromium.org Bug: 824568, 752273 Change-Id: I6047f5ed9da2abd01c93e26c752e46e9562ff2a1 Reviewed-on: https://chromium-review.googlesource.com/1087875 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#565081}
-
Oystein Eftevaag authored
This will act as a fallback while derived types are converted to their own optimized proto messages. Dependent on https://android-review.googlesource.com/c/platform/external/perfetto/+/699955 being rolled into third_party/perfetto first. Bug: 839063 Change-Id: I00fc5a639a770d06fbf08c60fb43d12871aa69c7 Reviewed-on: https://chromium-review.googlesource.com/1087643Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#565080}
-
David Trainor authored
This is the initial implementation of a prefetch view item for the new download home UI. This change includes the following: - Builds out the ViewHolder that can handle thumbnails (automatically processes it and pushes it to the view). - Builds out the ViewHolder that can handle a 3-dot menu (automatically handles the callback information). - Adds the initial XML for the prefetched item. BUG=849584 Change-Id: I965df4b6bdffc73f084f2f18c15588488b4beb0f Reviewed-on: https://chromium-review.googlesource.com/1087319 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565079}
-
Xianzhu Wang authored
GeometryMapper::SourceToDestinationProjection(parent, child) returns identity if child transform is not invertible, so it's not reliable to use it to check if parent and child are in the same transform space. Now avoid the function, while still handle most common cases to combine clips through identity transforms. Bug: 849382 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I747e857d3828a5fb6eea0f69ed8746843912baf4 Reviewed-on: https://chromium-review.googlesource.com/1086492Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565078}
-
Quinten Yearsley authored
The results for these files are likely changed by recent ShiftShader changes. This CL involves rebaselining and adding a flaky timeout for expectation for virtual/gpu/fast/canvas/canvas-composite-video.html associated with crbug.com/726075. Bug: 736177 Change-Id: Id18ca42ad63ebe27869eec599f22d441b43bad34 Reviewed-on: https://chromium-review.googlesource.com/1085750 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565077}
-
Ingvar Stepanyan authored
Now that new clipboard API is available in stable Chrome, it can be used to enable copy actions by default even in hosted mode. Change-Id: Ifacb15f7db990c03df21f97560a6e81e9b7746f0 Reviewed-on: https://chromium-review.googlesource.com/1068946Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565076}
-
Yuichiro Hanada authored
Bug: 829383, 834027 Test: IME works on ARC++ apps and notifications from ARC++ apps. Change-Id: I98d7cb43845c668ad0afb273c623b49abf08f595 Reviewed-on: https://chromium-review.googlesource.com/1051433Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#565075}
-
Tommy Martino authored
This new flag is meant to enable all upcoming ui features, so it should force the new dropdown on even if the dropdown-specific flag is off. Change-Id: Ia3aa38285bf4a60fa72250ac35d8cc9e20ae98a7 Reviewed-on: https://chromium-review.googlesource.com/1089791 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#565074}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1a3e67e..874afdd git log 1a3e67e..874afdd --date=short --no-merges --format='%ad %ae %s' 2018-06-06 jclinton@chromium.org cbuildbot_launch: Blow away everything if cleaning up locks fails Created with: gclient setdep -r src/third_party/chromite@874afdd The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850236 TBR=chrome-os-gardeners@chromium.org Change-Id: Id5e16d8dc9ad7f322e079286221bae29d82463aa Reviewed-on: https://chromium-review.googlesource.com/1089694Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565073}
-
Max Moroz authored
https://chromium.googlesource.com/webm/libwebm.git/+log/af81f26025b7..01c1d1d76f13 $ git log af81f2602..01c1d1d76 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 mmoroz Move definition of IMkvReader::~IMkvReader() to mkvparser.h. 2018-05-14 johannkoenig replace vp10 with av1 2018-04-24 johannkoenig remove unused PesHeader 2018-04-24 johannkoenig add codereview.settings Created with: roll-dep src/third_party/libwebm/source Bug: 849812,764514 Change-Id: I87e412794820fd1d8a7a320faca2b4220b7bf23b Reviewed-on: https://chromium-review.googlesource.com/1089571Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#565072}
-
edchin authored
This CL hooks up the URLLoader for remote tabs in tab grid. When the user taps on a remote tab, the tab will be loaded and the tab will be displayed. Bug: 804588 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7a6dbe200d8e806b14012d3986bbd61789cf810b Reviewed-on: https://chromium-review.googlesource.com/1088188Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565071}
-
Xiaocheng Hu authored
Current LayoutNG hit test code computes wrong |accumulated_offset| when falling back to legacy. It tries to maintain an additional offset for legacy, but fails to do so. This patch computes the fallback offset directly from NG offset, which fixes legacy fallback, and also removes the legacy offset maintenance code. Bug: 811502 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I06b2df66dc2a36efaf32077ea26a3abb4a26eb49 Reviewed-on: https://chromium-review.googlesource.com/1089800Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#565070}
-
Sahel Sharify authored
We already skip recording scroll metrics when the GSU events are ignored since ignored events don't cause GPU swap. This cl terminates the latency info from ignored GSU events and adds a unittest to verify the termination. It also has a browsertest to verify no scroll latency gets recorded when GSU events are ignored. ScrollLatencyBrowserTest.ScrollLatencyNotRecordedIfGSUIgnored Bug: 773740 Test: RenderWidgetHostLatencyTrackerTest.LatencyTerminatedOnAckIfGSUIgnored, Change-Id: Idaa4c3d739a79a8e44e4c3db82a74877428d404c Reviewed-on: https://chromium-review.googlesource.com/1080035 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565069}
-
Dominik Röttsches authored
The device scale factor that is configured in the browser process, for example through Gtk environment settings, or through the command line flag --force-scale-factor is not always identical with the one in the renderer process. The renderer process DSF can be configures als through TestingInternals and other configuration mechanisms. So these two can go out of sync and do not have the same semantics. As a solution, pass the DSF from Blink via IPC to identify the intended rasterization settings for a system font. Rebaselines are needed for those tests where the DSF settings in browser and renderer went out of sync. Overall, this CL is preparation for moving the Sandbox IPC functions to Mojo instead of the current filedescriptor communication approach. Also, addressing an older TODO about not passing size and is_bold, is_italic in one variable. Bug: 845468 Change-Id: I6fbe5c906f31f2e8872296404ffa269fbeb652f0 Reviewed-on: https://chromium-review.googlesource.com/1071512 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#565068}
-
Ian Vollick authored
With this change, we should revert to the behavior prior to crrev.com/c/1087170, however the reported dirtiness will still only be true if the transform is actually updated. Bug:850210 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I6a038953e0b658d9ea0b9a64a599faf5073cde9b Reviewed-on: https://chromium-review.googlesource.com/1089854Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#565067}
-
Khushal authored
The image animation system selects the frame index for the animation during tile raster. As a result updating the frame of the image is missed for Webview resourceless draw mode which does not use these tiles and later rasterizes the display list in SoftwareRenderer. Plumb through the animation state on the PictureDrawQuad and use it to select the frame index for image at raster. R=boliu@chromium.org, danakj@chromium.org Bug: 849565 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I20f48a664ae816da29e7d55012b7da4dec488ede Reviewed-on: https://chromium-review.googlesource.com/1087321Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#565066}
-
Jao-ke Chin-Lee authored
BUG=731417 Change-Id: Ic2e8071ce052e2d8ef5b6f0c508f6f62da7624fc Reviewed-on: https://chromium-review.googlesource.com/1089913Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#565065}
-
David Bertoni authored
Change-Id: Ia662afb410051f747178486ac3c29e3ed1548725 Reviewed-on: https://chromium-review.googlesource.com/1089832Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#565064}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/93deff4..82ff2ae git log 93deff4..82ff2ae --date=short --no-merges --format='%ad %ae %s' 2018-06-06 thomasanderson@chromium.org Remove manual references to exe_and_shlib_deps Created with: gclient setdep -r src/native_client@82ff2ae The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:845700 TBR=mseaborn@chromium.org Change-Id: Iea87daa701390fc3f17f4fbbd2b88aad16dce4f2 Reviewed-on: https://chromium-review.googlesource.com/1089550Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565063}
-
David Bokan authored
This CL does some cleanups around size-related methods in VisualViewport. Changes here include: - Making VisibleRect methods allow including or excluding the scrollbar sizes. The default is now to exclude, matching the intuition of what the visible rect is as well as the convention set in ScrollableArea. - VisibleWidth, VisibleHeight are no longer overriden and use the correct convention regarding scrollbars. - Use VisibleRect in other methods rather than duplicating code - Added, clarified, and corrected comments in visual viewport - Updated tests (and converted to more modern style) to not use internals visual viewport methods where a web-visible API exists. - Explicitly use PageZoomFactor for zoom adjustment, rather than the misleadingly named AdjustScroll helper. Change-Id: I4df38bbff78224cccf47f0ee86a573c8fe033c5d Reviewed-on: https://chromium-review.googlesource.com/1082928Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565062}
-
Adrienne Walker authored
Currently, out of process rasterization (oop-r) is controlled by a single command line flag (--enable-oop-rasterization) and default off. Many places in the code check this. This patch centralizes the enabling logic into gpu_util.cc and GpuFeatureList as the definitive source for whether oop-r is enabled. First, command line entries are forwarded via GpuPreferences to the gpu process. Then, GpuInfo decides whether or not oop-r can be supported. Then the gpu preferenes (enable and disable), blacklist, and finch entry (default off now) are used to set the GpuFeatureInfo status value. This status value is passed to gles2::FeatureInfo to enable/disable chromium_raster_transport in the raster decoder if needed for oop raster. The command line flags no longer need to be piped to the renderer or the gpu process. The renderer also uses the GpuFeatureInfo to figure out whether to use oop-r. If it says it is supported, then it should be used. Bug: 847684 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifecda890216e573745ae1c823294b9bbc1962cab Reviewed-on: https://chromium-review.googlesource.com/1083115 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#565061}
-
Sky Malice authored
Change-Id: I35da57c3825753bf348b8388c087249bdc928834 Reviewed-on: https://chromium-review.googlesource.com/1089639Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#565060}
-
Matt Wolenetz authored
This change makes the web-visible SourceBuffer.mode attribute compliantly set initially to 'sequence' and forced to remain 'sequence' for byte streams which have their 'Generate Timestamps Flag' set in the MSE Byte Stream Format Registry [1]. Prior to this change, for affected byte streams (audio/mpeg and audio/aac), we would generate timestamps, but allow the SourceBuffer.mode to vary among 'segments' and 'sequence'. We also would not initialize the mode correctly to 'sequence' for those streams. This should not be a breaking change, since generated timestamps mimic 'sequence' mode logic already, unless there is a pre-existing bug causing discontinuities in those generated timestamps. But it does compliantly set and restrict the SourceBuffer.mode attribute. This change is useful also as a prerequisite for the 'changeType' work, which will also need to conditionally set and constrain SourceBuffer.mode based on the new MIME type's byte stream format. [1] https://www.w3.org/TR/mse-byte-stream-format-registry/ BUG=607372 TEST=Related wpt layout FAIL expectations removed and tests pass locally with proprietary codecs. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib5ac4e0430c75bd4c6fa00e76073dc83a9b987dc Reviewed-on: https://chromium-review.googlesource.com/1086356 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#565059}
-