- 28 Aug, 2020 40 commits
-
-
minch authored
Add the logic for syncable dark/light switcher. Enable/Disable the dark mode through the feature pod in system tray will update the preference for this user on other devices too. Login screen will be done in a follow up cl. Bug: 1106012 Change-Id: Idbbc3f5652effdc7590713fc5687e031e3d97dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373134 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#802737}
-
Andrey Kosyakov authored
Bug: 1114636 Change-Id: Iba3865206d7e80b363ec69180ac05e20b56aade2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380855Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#802736}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15826356..8aa817bf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0c608fddcbd705ec88f42fdf01ffb6b75ea93c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382230Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802735}
-
Leonid Baraz authored
Since EncrypedRecord represents not only data but also sequencing information, rely on it everywhere, including the unittests. Extend test to verify sequencing too. Bug: b:153364303 Bug: 1078512 Change-Id: I04dfe6bb9c1bbaac92f34363b26e149011dc9502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380498 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#802734}
-
Prashant Nevase authored
Replace WTF::HashSet by std::map. Bug: 1091095 Change-Id: Ieb445f6ef98486668b6241f800895af9607c963f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214731Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#802733}
-
Jeffrey Cohen authored
The upload screenshot tool now optionally captures screenshots for translated strings in the downstream clank directory. This allows engineers who are adding strings to features located in the clank directory to integrate with the existing translation tooling. Bug: 1122780 Change-Id: I348caf20c09cf22a0924d154ef4bdcc7902e70af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380328Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802732}
-
Emily Stark authored
Make it more obvious that the policy is experimental and subject to change. Change-Id: I8a78625f9c35a2927a0e441870397c2f3fdd95fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378754Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#802731}
-
Adam Ettenberger authored
This is a reland of 8f92c37d Revert CL : https://chromium-review.googlesource.com/c/chromium/src/+/2346996 Reason for revert: causing build failure: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/15547? Original change's description: > Fix Role::kButton name invalidation when descendant text is modified > > This CL addresses a bug where Role::kButton, and possibly other roles > that derive their name from descendant contents, were not firing > Text Changed when a descendant Node.TEXT_NODE modifies its text |data|. > > ax_object_cache_impl.cc : > - When firing a text changed event, also fire a text changed event for > the first ancestor that derives its name from descendant contents. > This ensures the nodes are invalidated, send appropriate text changed > events, and the changes are serialized to the browser process AXTree. > > browser_accessibility_manager_win.cc : > - FireUiaTextContainerEvent made it possible to fire text events more > than once for a given text provider so it has been removed. > - Instead, populate a set |text_changed_events_| which contains the > text providers via |GetUiaTextPatternProvider| and fire the UIA text > events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents > - |text_selection_changed_events_| could also potentially end up with > the same double-event problem, so it uses GetUiaTextPatternProvider > now as well. > - Removing usage of std::unordered_set based on the guidance in > base/containers/README.md. In general these sets shouldn't grow large > enough to benefit from being unordered. > > AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced. > Bug: 1105262 > Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564 > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796464} Bug: 1105262 Change-Id: Idfafd2e7f886d4d27b735d143ceaa0f33607f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346933 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#802730}
-
Jeroen Dhollander authored
This is the main controller for the bloom feature. The current implementation is incomplete, but it performs the first steps of the Bloom interaction: * Fetch the access token * Request a screenshot from the user (currently stubbed) * Start the Assistant interaction which should open the Assistant UI (currently stubbed). Bug: b/165356952 Tests: chromeos_components_unittests --gtest_filter="BloomController*.*" Change-Id: If2860c46c8c03d72290d04ae24e0a78585fd63ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364812 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802729}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/33a6332a9232..d7c4e9418e36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3990cc28824a82bf9edba6ae52b8939d34d669a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382291Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802728}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d7c4e9418e36..b1e3f57ef7c0 2020-08-28 lalitm@google.com Merge "perfetto: fix documentation for unix socket and simplify ipv6 handling" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7297b812021d241e0b1672b5fe9b03e73d4de4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380648Reviewed-by:
-
Tibor Goldschwendt authored
This is more consistent with the GN targets of other WebUIs. + Move module_wrapper.* to modules/. This is a reland of e2431d75. Downstream has been fixed to work with this CL. Original change's info: > Change-Id: I23be97df455e8cb0a9ed35b15b184902b3fa1a9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376529 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802008} TBR=dpapad@chromium.org Change-Id: I6db4ed44fc6bb6fc9e85a9a5e671238b23df009a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382212Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#802726}
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: I5253597f59fad15243fc62e0001765d48f693b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377736 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#802725}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/43c78abe0440..fc1eb95f39a3 2020-08-28 mtklein@google.com second-guess AVX-512 opts 2020-08-28 mtklein@google.com add missing include 2020-08-28 bsalomon@google.com Remove use of texture swizzle in GL backend. 2020-08-28 mtklein@google.com add suggested `override` 2020-08-28 brianosman@google.com Don't run glesnarrow on Mali400 bots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I8e4ee4229a0f30557ebc1fa62ab8fac605806d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380647Reviewed-by:
-
Christopher Cameron authored
Create a blink::Picture::ScopedSharedImage structure, which will keep a SharedImage alive as long as it is alive. This will be used to pass a SharedImage from the hardware decoder across to the VTVideoDecodeAccelerator. The PictureBufferManager is where the decision about use of SharedImage will be made. It will be sent to the VTVideoDecodeAccelerator by specifying an empty PictureBuffer. Bug: 1108909 Change-Id: Iabb71b1b69dd922dc44aca3821f243fcdd22c6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377419 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#802723}
-
Karandeep Bhatia authored
PopulateItem is used when parsing arrays. We should never be parsing arrays of optional types (which are represented as std::unique_ptr). Remove these overloads. BUG=None Change-Id: Ia29ef89bd555cbfad10b92e9963e4fda431495a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380322 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
rbpotter authored
These tests run the basic_test.js tests after loading the service worker. As a result, now that basic_test.js has been adapted to run with the flag enabled in https://chromium-review.googlesource.com/c/chromium/src/+/2376871, these tests pass with both flag states and just need to be parameterized so that they are run on the bots with both. Bug: 1120279 Change-Id: I25628e049946745432277701d555009ecae8fe37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381061Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#802721}
-
Mugdha Lakhani authored
WebLayer embedders may have a setting to let their users override the system dark mode setting. This propagates the embedder's dark mode setting to all WebLayer UI instead of following the system default. UI after the change: https://drive.google.com/file/d/1L1UdoX1JKAeHR9UhclTp5zQIxuPrsGwk/view?usp=sharing https://drive.google.com/file/d/19QuLXj0xgBDtXuzoMRcmCQJFzfHzK-4j/view?usp=sharing Bug: 1103716 Change-Id: Iddf3d95a47c56a95d813ddb29280e6b527b2045e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356007Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#802720}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ffb12276aa7d..336f984f8cbc 2020-08-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Ib4fa9490cbe620352db23d8e35b66415be0b9eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381633Reviewed-by:
-
Xinghui Lu authored
Bug: 1122697 Change-Id: I828b21a122241bcbf76954d47bf6d789ea31dc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380419Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802718}
-
Toni Barzic authored
Implements HoldingSpaceThumbnailLoader - a helper class that uses image loader extension to generate thumbnail bitmaps for file system file paths. The class establishes a native connection with the image loader extension, and sends it a message with the requested image parameter. The message format should match the image loader request. Upon response from the image loader, the HoldingSpaceThumbnailLoader closes the connection to the extension, converts the data received from the extension into a bitmap, and returns the bitmap to the caller. On image loader side, implements onConnectNative listener to handle image requests. BUG=1113772 Change-Id: Icff6ead726b3be8945ab58b7ff177259707ebc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362973 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#802717}
-
ckitagawa authored
This CL stops a preview from being shown if the page is already loaded. This can happen if the utility process is very slow to initialize. Change-Id: I7a0d3ff140c9efc47551c63b483351593ac4e25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381952Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#802716}
-
Jesse McKenna authored
Adds a note about component builds to the chrome_pwa_launcher.exe README. PWA file handling does not currently work with a component-build launcher, because it depends on DLLs in the out directory. This makes that limitation more clear. Bug: 1123018 Change-Id: I9c5de4fcdc58f0cae1244b96bd152d9cdf12d300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382052Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#802715}
-
Maksim Sisov authored
Some internal methods use wl_proxy_get_version and wl_proxy_marshal_constructor_versioned that were defined in libwayland 1.10. However, we fail to resolve to map with these symbols when Chromium is run against older versions and that results in failures. Thus, fix that by checking if these exist by redeclaring them with weak function attribute. Bug: 1123005 Change-Id: I4407e0a6917f951b0ccfe3f9ffd366bc64dc9838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379917Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#802714}
-
danakj authored
This moves the renderer reset functionality over to TestRunner, since it is global to the renderer process, including resetting the TestRunner. And moves test configuration over to WebViewTestProxy since that is set on each frame tree fragment (ie each RenderView) in the main window. It can't be entirely process-wide as a process may hold frame tree fragments from multiple windows. R=avi@chromium.org Bug: 866140 Change-Id: If5ede5ad25797ad191dd282dfef9e7d6a5ace4bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380090Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#802713}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ec3650f56ca2..2014e7b9290e 2020-08-28 capn@google.com Work around std::is_trivially_copyable issue with MSVC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ifb00116262ca1578118b3d6507bebc4183927698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381594Reviewed-by:
-
Xiaohan Wang authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/a1f3db690c65..d96f468ef020 $ git log a1f3db690..d96f468ef --date=short --no-merges --format='%ad %ae %s' 2020-08-26 xhwang Updated ffmpeg for M87 2020-08-27 lance.lmwang Revert "avfilter/yadif: simplify the code for better readability" 2020-08-24 andreas.rheinhardt avfilter/af_headphone: Fix leak of channel layouts list on error 2020-08-24 andreas.rheinhardt avfilter/af_headphone: Fix segfault upon allocation failure 2020-08-25 andreas.rheinhardt avfilter/vf_signature: Avoid cast from function pointer to void* (...) 2020-08-09 jamrial avcodec: move ff_alloc_a53_sei() to atsc_53 2020-08-09 jamrial avcodec/hevc_sei: use ff_parse_a53_cc() to parse A53 Closed Captions 2020-08-07 jamrial avcodec/h264_sei: use ff_parse_a53_cc() to parse A53 Closed Captions 2020-08-07 jamrial avcodec/libdav1d: add support for A53 Closed Captions 2020-08-07 jamrial avcodec: split off A53 Closed Caption parsing code into its own file Created with: roll-dep src/third_party/ffmpeg Bug: 1105124 Change-Id: I0bdd9c9a3b2ea4e029e25636efa0fc3f2dddc75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381152 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#802711}
-
Aaron Colwell authored
This change fixes a bunch of DumpWithoutCrashing reports related to devtools not completely cleaning up it WebContents which results in the devtools RenderProcessHostImpl not being cleaned up before its BrowserContext is destroyed. This was leaving open an opportunity for UAF bugs to potentially be exploited. This change simply introduces a ScopedKeepalive to keep the browser main loop running long enough for devtools to properly shutdown before the BrowserContext gets destroyed. Bug: 1113159 Change-Id: Ie2ef74638c860f884fa5c377867a7c7bb00fa534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378900 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#802710}
-
dpapad authored
Specifically removing offensive term from IDS_SETTINGS_LANGUAGES_SPELL_CHECK_MANAGE description. Bug: None Change-Id: I55014100f12c074e5412e0f310db47fe6c734276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377583 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#802709}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4a7e12496b5..6ec121d8c3d5 2020-08-28 tvanderlippe@chromium.org Fix URL flickering in image preview pane 2020-08-28 tvanderlippe@chromium.org Remove is_legacy_javascript_entrypoint 2020-08-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-28 tvanderlippe@chromium.org Fix focus ring for TBT link 2020-08-28 wolfi@chromium.org Fix pie chart backgound color on dark theme 2020-08-28 tvanderlippe@chromium.org Typecheck persistence/IsolatedFileSystem.js with TypeScript 2020-08-28 tvanderlippe@chromium.org Typecheck persistence/FileSystemWorkspaceBinding.js with TypeScript 2020-08-28 szuend@chromium.org Fix blur handler of BreakPointEditDialog 2020-08-28 tvanderlippe@chromium.org Typecheck persistence/EditFileSystemView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1066415,chromium:1081452 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I390512c15e7c9f396f64e28631e0c5234ca6842f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381449Reviewed-by:
-
Fritz Koenig authored
Modifiers are associated with buffers. They need to be passed along to V4L2 decoders so they can take advantage of the modifier. BUG=b:149525848 TEST=decode with modifiers on trogdor TEST=PlatformVideoFramePoolTest.ModifierIsPassed Change-Id: I2708918d6fce43f75579908ab9f3292f03aa0095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343043 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
-
Daniel Classon authored
Fix: The failing test fails only when is_debug is true, so the test was grepped out to only run when is_debug is false. Filed a bug here: https://crbug.com/1122752 Reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/2377629 Reason for revert: Caused OSSettingsPersonalizationPageV3Test.All to fail in linux-chromeos-dbg. See, e.g.: ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20179 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2375730 Adds deep links to the Personalization Page, including the change picture and ambient mode subpages. Also fixes a bug where the ambient mode page tests were not run. Bug: 1084154 Change-Id: I71e020a4897f53639ea0c9d2b74426088fb8bdee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380141 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802706}
-
Garrett Beaty authored
Bug: 1109276 Change-Id: Ie87ad95334d15beb1de8a34c344c4fe9930ce634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382194Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#802705}
-
Daniel Classon authored
Fix a bug where the "Set up Crostini" search result did not connect to the eponymous setting, so the setting was inaccessible for deep linking. Bug: 1084154 Change-Id: I0b5452425eb19203c61c8b45ba4d2d96afc16264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380749Reviewed-by:
-
Fredrik Söderqvist authored
In SVGAnimateMotionElement, the check performed expands to: if (mode == 'by && additive != "sum" && mode != 'by') which will never be true. Also make the function re-use the parsing from CalculateFromAndToValues() and then apply the 'by' delta. In SVGAnimateElement, the GetAnimationMode() == kByAnimation && !IsAdditive() check amounts to checking if the type supports addition - just like for the from-by case - so the two checks can be merged and simplified (since this function is only called when mode is either by/from-by). The new form also makes more sense in that it only considers the animated type and not the (implicit) effect function. Bug: 1017723 Change-Id: Idb0be24379e5fce60109559dfd2428d4c26bb086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379901Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#802703}
-
Meilin Wang authored
Previously we leave the weather settings as their default values on the server side, which causes an unpredictable behavior on whether server will return weather info to us in the response. This CL fixed this issue by setting these values explicitly to notify server that we are always expecting weather info to be included in the response. Related CL: https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/3215310 Bug: b/158630188 Test: manually Change-Id: I0e38e9fa46d22e36a6e5f6e2f42f84818acea433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363914 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
This CL implements VisibilityStateEntry behind a flag. Only browsertests are added at the moment. Some WPTs will be added in a followup but full WPT support is not possible until we receive more support from the harness, see https://github.com/web-platform-tests/wpt/issues/25233. Explainer: https://docs.google.com/document/d/1l5kHiJRkdQwEN-CYI5_mUNODhQVB5rCyjN4jHDdXDHA/edit Intent to Prototype: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/visibility%7Csort:date/blink-dev/0rW4Q_NtL20/h1C2C0rLAAAJ Bug: 1103451 Change-Id: I72d98cf0884d1f820ddffec9da2007e4d253bc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375733Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#802701}
-
Sergei Glazunov authored
This is a reland of 4d9450df Original change's description: > [PartitionAlloc] Use reciprocal multiplication to speed up GetSlotOffset > > Currently, the "get offset of a pointer within its allocated slot" > functionality, which is used extensively by several MiraclePtr > implementations, performs an expensive modulo operation. This commit > replaces it with a cheaper sequence of multiplications and bit shifts. > > Bug: 1092288 > Change-Id: I866689a79fff704b5f83fc07d8f28b3386ef644d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335443 > Commit-Queue: Sergei Glazunov <glazunov@google.com> > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802194} Bug: 1092288 Change-Id: Iec17efe8f9837f55c2f40dcf80033e6efd9580dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380277 Commit-Queue: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#802700}
-
Peng Huang authored
This reverts commit a37811d1. Reason for revert: https://chromium-swarm.appspot.com/task?id=4e4ecbbb4657b710#ScreenshotSync_GPURasterWithDivs,ScreenshotSync_SWRasterWithDivs Original change's description: > SkiaOutputDevice: use buffer format passed to Reshape > > Bug: 1108406 > Change-Id: Iaca79e3b6c1d66e421711c46f75a1cb614b7f961 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378745 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802450} TBR=penghuang@chromium.org,vasilyt@chromium.org Change-Id: Idd1c5aaca95ede1e052e72fd19e8b590ed21c79a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382056Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802699}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008280800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/e6UISBIfdcTS7sATnTUvRDyO7rV3PGA8ubhN8f-RejgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ia4acb51c95e6f983b75fdd66d0525ab1aabd1fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380304Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802698}
-
