GitLab

bartfab ran into this as a result of an unrelated patch he was testing. The logic in ScreenLocker should match that in LoginUtils, and not send this notification out if the password is blank.

BUG=chromium-os:31600
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10544043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141252 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131832
TEST=


Review URL: https://chromiumcodereview.appspot.com/10545092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141250 0039d316-1c4b-4281-b951-d872f2087c98

Prerender.

BUG=131026
TEST=no change


Review URL: https://chromiumcodereview.appspot.com/10540078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141249 0039d316-1c4b-4281-b951-d872f2087c98

Clear out the notifier in the PrefService destructor, to make it easier to diagnose
cases where a PrefChangeRegistrar outlives the PrefService.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10547002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141248 0039d316-1c4b-4281-b951-d872f2087c98

Switch back to the old method of launching the login flow while keeping some of the benefits of the new method.

BUG=chromium-os:31470
TEST=functional/chromeos_login.py

Change-Id: I31555baedabb76f049b568479d7db42eebf105cc


Review URL: https://chromiumcodereview.appspot.com/10533038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141247 0039d316-1c4b-4281-b951-d872f2087c98

This makes us configure renderers appropriately based on
--enable-text-subpixel-positioning.  It also updates
SandboxIPCProcess to pass the flag through so the results
returned by its calls to WebFontInfo::renderStyleForStrike()
will reflect the setting.

BUG=125066
TEST=manual: both regular and web fonts within the renderer use subpixel positioning when --enable-text-subpixel-positioning is set


Review URL: https://chromiumcodereview.appspot.com/10540038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141246 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128140
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10454093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141245 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130751
TEST=Adhoc; converted sample test case to JSON, and stub still works


Review URL: https://chromiumcodereview.appspot.com/10527004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141244 0039d316-1c4b-4281-b951-d872f2087c98

Move type completeness check into functino.
 anonymous namespaces within the same namespace are treated as the same namespace. This is to avoid  duplicated definitions.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10533063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141243 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141242 0039d316-1c4b-4281-b951-d872f2087c98

And add better handling of corner case failures.

TBR=davemoore@chromium.org (for chrome/browser/chromeos/cros/onc_network_parser.cc)
BUG=131630
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10541036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141241 0039d316-1c4b-4281-b951-d872f2087c98

BUG= none
TEST= native_client_sdk/src/sdktry-git.sh

Review URL: https://chromiumcodereview.appspot.com/10534056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141240 0039d316-1c4b-4281-b951-d872f2087c98

Make Chromoting Host report crashes to Breakpad (Windows only). The user must enable crash dumps collection by setting the "usagestats" value in the ClientState or ClientStateMedium key.

BUG=130678
TEST=remoting_unittests.BreakpadWinDeathTest


Review URL: https://chromiumcodereview.appspot.com/10495003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141239 0039d316-1c4b-4281-b951-d872f2087c98

This permits, along with the 'with' statement, to have automatic fix up of the
logs upon tracing session termination.

Standardize on "logname" variable instead of "filename".

Still move more code around a bit.

NOTRY=true
R=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10537059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127771
TEST=power status showing on settings row if the battery presents.

Review URL: https://chromiumcodereview.appspot.com/10540041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141237 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10540057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141236 0039d316-1c4b-4281-b951-d872f2087c98

Downloads.

BUG=131026
TEST=no change


Review URL: https://chromiumcodereview.appspot.com/10545064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141235 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131326


Review URL: https://chromiumcodereview.appspot.com/10536034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141234 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=131658
TEST=build

Review URL: https://chromiumcodereview.appspot.com/10538053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141233 0039d316-1c4b-4281-b951-d872f2087c98

This will permit in the end to be able to do multiple traces concurrently.
Still not using 'tracename' parameter.

NOTRY=true
R=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10543058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141232 0039d316-1c4b-4281-b951-d872f2087c98

Also, splitting extension_tab_modules_constants namespace into
extensions::tab_modules_constants.


BUG=101244
TEST=N/A, only moving code, no change in functionality
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10544023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141231 0039d316-1c4b-4281-b951-d872f2087c98

Clarify the use of --register-chrome-browser-suffix which triggers |unique_suffix| in ShellUtil::RegisterChromeBrowser()

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10535061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10412058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141229 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141228 0039d316-1c4b-4281-b951-d872f2087c98

Also fix layout test controller bindings after my last change

BUG=none
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10545087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141227 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131483
TEST=All tests pass.


Review URL: https://chromiumcodereview.appspot.com/10537076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141226 0039d316-1c4b-4281-b951-d872f2087c98

TBR=saintlou@chromium.org
BUG=131500
TEST=
Go to wallpaper picker page, verify if the "Custom..." button changed to
"Browse...".

Review URL: https://chromiumcodereview.appspot.com/10538058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141225 0039d316-1c4b-4281-b951-d872f2087c98

Fall back to use default wallpaper index when the logged in user didn't have index saved in LocalState.


BUG=130685
TEST=
1. Install R20 build
2. Add few new users
3. Verify that all new added users have default wallpaper set(Do not change wallpaper)
4. Autoupdate to R21 build
5. Check the existing users desktop wallpaper

Expected: default wallpaper should show up instead of a black wallpaper.

Review URL: https://chromiumcodereview.appspot.com/10527006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141224 0039d316-1c4b-4281-b951-d872f2087c98

Move chromeos::GDataFileSystem::GetCacheDirectoryPath and GetCacheFilePath implementation to GDataCache

This is a part of an effort to move cache related code from GDataFileSystem to GDataCache.
GDataFileSystem::GetCacheDirectoryPath and GetCacheFilePath are still provided to serve a number of existing users, this is a temporary solution.
cache_paths() and kMountedArchiveFileExtension are exposed as a temporary solution.
Tests for these methods are not moved from GDataFileSystemTest in this change, they will be removed and reimplemented once we finish moving other methods and get ready to do more comprehensive test in GDataCacheTest.

BUG=131756
TEST=unit_tests --gtest_filter="GData*"

Review URL: https://chromiumcodereview.appspot.com/10545084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141223 0039d316-1c4b-4281-b951-d872f2087c98

Add flag which shows visually places where hidpi resources are supported however a hidpi resource cannot be shown because of missing assets

Bug=131631
Test=manual

Review URL: https://chromiumcodereview.appspot.com/10494013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141222 0039d316-1c4b-4281-b951-d872f2087c98

Autofill.

BUG=131026
TEST=no change


Review URL: https://chromiumcodereview.appspot.com/10546054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=RemoteFileSystem.RemoteMountPoint


Review URL: https://chromiumcodereview.appspot.com/10536065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141220 0039d316-1c4b-4281-b951-d872f2087c98

Content Settings.

BUG=131026
TEST=no change


Review URL: https://chromiumcodereview.appspot.com/10544056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141219 0039d316-1c4b-4281-b951-d872f2087c98

TBR=acolwell@chromium.org
BUG=122913
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10536072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129768
TEST=Verify app list bubble is at correct position with an auto-hide launcher bar.

Review URL: https://chromiumcodereview.appspot.com/10537061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141217 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10542063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127791.
TEST=Manually.


Review URL: https://chromiumcodereview.appspot.com/10532009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141215 0039d316-1c4b-4281-b951-d872f2087c98

Fix conversion between NSImage to ImageSkia for when this is the case.

Also changed unittest constants to be kWidth1x, kHeight1x etc

Test=ImageMacTest.NSImageWithResizedNSImageRepToImageSkia
Bug=None

Review URL: https://chromiumcodereview.appspot.com/10545069

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10535079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141214 0039d316-1c4b-4281-b951-d872f2087c98

Forcing string16 to 0 leads to iterator compatiblity check crash in MSVS2010 Debug builds.

This bug was diagnosed by tom.cassiotis@gmail.com

BUG=131589
TEST=Start MSVS2010 Debug build of chrome.exe

Review URL: https://chromiumcodereview.appspot.com/10545065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141213 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131744
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10538052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141212 0039d316-1c4b-4281-b951-d872f2087c98