- 24 Apr, 2019 40 commits
-
-
Allen Bauer authored
Updated usages to a visible changed callback. Bug: 938501 Change-Id: I01fe4f9f21f3f5b40fedb05edde0331afce97604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505848 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#653559}
-
Michael Ludwig authored
Skia uses two sources for its bounds during a saveLayer call: the current clip and a user-provided bounds hint. SkiaRenderer calculates the final filtered bounds for the combination of the RPDQ's visible_rect and the backdrop_filter_bounds of the quad, and it used to provide those bounds as both a clip and the hint. It turns out that Skia will automatically adjust any provided hint bounds to account for how the filters transform the data, so the bounds were being doubly-affected by the filter transforms, leading to extra clipping in the case of css3/filters/effect-reference-composite-hw.html where the image filter included a translation. Since we precalculate the correct bounds and use it as the clip, Skia already has enough information to use a smaller offscreen buffer for the filtering, and there's no real need to provide a separate hint with the SaveLayerRec. Bug: chromium:955612 Change-Id: Ice1680fca8c58fd9147e02b106ceefdfb1ead36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579659Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#653558}
-
Michael van Ouwerkerk authored
Bug: 924118, 956031 Change-Id: I7876e83dff4bf0cf2a68dd3926760f295c3126de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578549 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#653557}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e5598c5d7828..505f9c976576 git log e5598c5d7828..505f9c976576 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 eseckler@google.com Merge "startup writer: Don't hold lock while grabbing new trace packet." 2019-04-24 hjd@google.com Merge "trigger_perfetto: Add trigger_perfetto binary" Created with: gclient setdep -r src/third_party/perfetto@505f9c976576 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie606ba62f1c954b3fef7366095072e2531490a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581999Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653556}
-
Olivier Robin authored
1fc9cc0d0e1dfafb8d29dba8d01f09587d870026 [Breakpad iOS] Add a callback on report upload completion. 8c70c504b241f918e41f28a3102f5ca03475082b Make breakpad_unittests work with Chrome's test runner instead of gtest's ebab5970b027c8c41eccf67a83883b4bfb736505 Use correct c++ standard library in Xcode project. Bug: 954175,949098 Change-Id: Ifdc99129956e08dda9feaf8cc7e51fc90ac8184b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581343 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#653555}
-
Lowell Manners authored
Rather than calling IdentityManager::Shutdown explicitly, perform the Shutdown logic as part of ~IdentityManager(), so we don't need to remember to call it. This means that IdentityManager's dependencies will be shutdown later than they were before this CL, but this shouldn't matter (tm) since the dependencies are wholly owned by IdentityManager. Bug: 945385 Change-Id: I061e78f90f9754716a8f537116dd55d2c769589b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578613 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#653554}
-
Alex Clarke authored
It's dangerous to post a task with a RenderProcessHost pointer because the RenderProcessHost can go away before the task is run. Bug: 863341 Change-Id: I9a5e3ae068dd42ea5a68d6e4afcf77d7486eeac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581580 Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#653553}
-
Javier Ernesto Flores Robles authored
Improves the style of the actions to be like the UX mocks. Bug: 951358, 951300 Change-Id: I535fd2ba711321d782d1ff0c5bb41781523aef88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578745 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#653552}
-
Julie Jeongeun Kim authored
This CL replaces the type of SVGDashArray with base::RefCountedData<WTF::Vector<Length>> from RefVector<Length> to avoid using RefVector. Bug: 955618 Change-Id: I00fe7db4e700657f5f64c9811678d361e8a4d6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580694Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#653551}
-
Javier Ernesto Flores Robles authored
Adds a button that changes its background to gray when highlighted. This is to be used in the buttons of the new AlertViewController. Bug: 951358, 951300 Change-Id: Ib76fb1eef38f911de096781050b101997f091b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578743Reviewed-by:
-
Huanzhong Huang authored
-Add another initializer to ClearBrowsingDataCollectionViewController, so to allow dependency injection in tests. -Make corrections on ClearBrowsingDataManager, to avoid a strong reference cycle. -Change tests to utilise more appropriate methods. Bug: 935350 Change-Id: I2d4a1b3a740a75785499f3487ee94b842949ce0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579719Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#653549}
-
Lutz Justen authored
Adds stubs of a couple of policies that will be used to control the Kerberos functionality for cloud managed Chrome OS devices. The KerberosEnabled policy is used to guard the feature. No existing functionality should change if it is disabled (or not defined). BUG=chromium:952233 Change-Id: I4af3980ad3a94c9a5bfc92bdf8c0a61a8c185726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565981 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#653548}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d83850b5221..923ad6b5efb0 Created with: gclient setdep -r src-internal@923ad6b5efb0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: Ic7e9f6ba1ee378b9c087baca43b2e8ee8af4cf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581819Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653547}
-
Camille Lamy authored
This CL ensures that we can simulate browser-initiated POST navigations in NavigationSimulator as well as set a post id. Bug: 728571 Change-Id: I9f5bf213a06feedf76a9b8102736bdafc08d504e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578571 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#653546}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I44533cf5abed290b1519b224dfe33d2d2166f81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582000Reviewed-by:
-
Henrique Ferreiro authored
This CL removes `inline` specifiers from constructors in core/svg classes to prepare for porting third_party/blink/renderer/build/scripts/templates/element_factory.cc.tmpl to MakeGarbageCollected. Bug: 939691 Change-Id: If16a792f9ac03e56eafd59a96067f616f53ac069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577418Reviewed-by:
-
Rayan Kanso authored
This CL incorporates some of the changes discussed in the latest UX meeting: - Reorder the columns and toolbar buttons - Display the metadata in a manner to a similar to the Network panel - Add instructions for the inital landing page and other UI states Bug: 942174 Change-Id: I7bd451377b241ec70d49c6d0b443522b43e5bcfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578554 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653543}
-
Raphael Kubo da Costa authored
When toggling CONTENT_SETTINGS_TYPE_SENSORS from allow to block (or vice-versa) in chrome://settings/content/sensors while a tab was open and trying to access sensors, the icon/tooltip used to get out of sync with the bubble title/message. The icon/tooltip previously indicated whether sensor access was ever allowed in that tab, whereas the bubble title/message indicated whether sensor access was ever blocked. This happened because TabSpecificContentSettings' OnContentAllowed() and OnContentBlocked() methods did not reset each other's values, so we could easily end up in a situation where both |allowed| and |blocked| were true, so we could not distinguish a setting that changed from allow to block from a setting that changed from block to allow, furthermore, the state with both flags set was interpreted differently by the icon/tooltip and the bubble title/message. After this change, the state with both allow/block flags set is now well-defined to mean "we allowed previously, but the last decision was to block". Furthermore, this state is now interpreted consistently by both the icon/tooltip and the bubble title/message in the same way, i.e. we indicate blocked access. Bug: 955408 Change-Id: I6837129364af2d75d431b9424e6b6fc0c37b3473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579082 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#653542}
-
Gauthier Ambard authored
This CL adds everyone as owner of the ui_feature_flags. Bug: 944008 Change-Id: I56046288747a490ffca71abde15ecd501db2b3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581200Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/54c8fd37..99694fa3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id98ad87edf32963e8e359b07f99a94242a6abb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580644Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653540}
-
chrome://webrtc-internalsIgor Kobylin authored
R=hbos@chromium.org Bug: 677338 Change-Id: I283100259931e22fefb14e41ac54510a68a3fd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581622Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Igor Kobylin <ikobylin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#653539}
-
Marc Treib authored
This method is only supposed to be used for internal/debugging purposes (like chrome://sync-internals), and after https://crrev.com/c/1065741 that's actually the case! Bug: 953272 Change-Id: I5baf03d4d9e7ccef25c59dd3b0f57ecc37ad265d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581342 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#653538}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d670490b817e..5d83850b5221 Created with: gclient setdep -r src-internal@5d83850b5221 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: I8ec08fe5030043c7b8cf322646d93da62fb2ad34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581323Reviewed-by:
-
Yi Su authored
Change the desired favicon size in points from 24 to 32 for search settings, since favicons for prepopulated search engines will be fetched from google favicon server which only supports 16,32,64,96,180. Favicon size will be multiplied by screen scale(1, 2, 3), so changing the size to 32 will meet the size expectation(32, 64, 96) of favicon server. Otherwise the server will return an icon with default size(16x16), which looks blur. Bug: 953246 Change-Id: Ief3ac90941b428987b55dfb298291036484147d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581202Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d63e3ca06b1e..e5598c5d7828 git log d63e3ca06b1e..e5598c5d7828 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 treehugger-gerrit@google.com Merge "processor: Replace utid column with ref+type in slices table." Created with: gclient setdep -r src/third_party/perfetto@e5598c5d7828 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I389fd1fb01e0d15d9c8e950decfeff51cfd85341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581322Reviewed-by:
-
Stepan Khapugin authored
Displays favicons when they are available in the left view. Bug: 945324 Change-Id: I4d4423bfb4c56d5d1b959bf670dc0ba9e70c509e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573739 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#653534}
-
David Roger authored
TBR=rockot Bug: 955916 Change-Id: I804c986913fad58d75a5f2c3ab8a9b6c1a786e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581579Reviewed-by:
-
Thomas Tangl authored
Bug: 954919 Change-Id: I0939944da11c5ff3406c2753d11d0f895497a76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578568Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#653532}
-
Michael Lippautz authored
Change-Id: I44f7b77fc6ae86cbc3ad54b12e2229e5e6db1aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581339 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a0c4ebc0..54c8fd37 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id3d6ef8c003b9ebb8b473b63b21ce26ebc0f6abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581459Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5825d5fae793..d670490b817e Created with: gclient setdep -r src-internal@d670490b817e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: I78fc475e8e4a851dad617912709192b763697b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581320Reviewed-by:
-
A Olsen authored
Stateless utility functions, except of course that they affect the state of the existing NotificationDisplayService. These are not yet called. Still TODO - add some state that decides when to call these functions. Looks like this: https://storage.googleapis.com/chromium-translation-screenshots/54f9f5c62799b5a050152f23982b4eb275ee1e4c Bug: 930109 Change-Id: I529f7283745b95c38735835b1ca74484e4452338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572408 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653528}
-
Carlos Caballero authored
This is not really needed, as tracing will keep track of the tid in a dedicated field. Also it makes it harder for test ifrastructure to find a given thread (prefix match instead vs exact match). Some current infrastructure uses exact match and thus threads created with SimpleThread might not get accounted for correctly (e.g. see bug) If it turns out that that client code really needs this we could add support for a placeholder %tid in the name. Bug: 954579 Change-Id: Ibd595463d8421891616000c1d518f5bbcf95e046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578539Reviewed-by:
-
tzik authored
v8::Context may refer C++ object embedded by Blink, and it was left stale on Worker and Worklet shutdown. This CL ensures them to be cleared at the end of the shutdown process. Bug: 804661 Change-Id: Ib66d1bf6bc88370310d65b04210ca763474ff8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578518 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
After reviewing the progress so far with UX, 14 seems to be a better radius. Bug: 951300 Change-Id: I66c541c4e5b1ed55fb091665623c47e3591f7959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578612 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Recent patch has added new entries to the PasswordSyncState enum in password_manager_metrics_util.h and didn't update the corresponding enum in histograms/enums.xml. https://chromium-review.googlesource.com/c/chromium/src/+/1552822 This CL updates histograms/enums.xml to match password_manager_metrics_util.h Bug: 949493 Change-Id: Ia432689604385b8e9d482ad4a8dea4e69b3d9569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581341Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#653524}
-
David Roger authored
The test is timing out. TBR=ricea Bug: 955883 Change-Id: Ia780e55b9f3629e91037a1d3795d832925e0fbfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581340Reviewed-by:
-
Yutaka Hirano authored
auth-base-https-other-https.html has already been listed as slow, and we don't have a reason to believe auth-other-https.html runs faster. Bug: 955883, 874695, 948056 Change-Id: Id0f044ea2ca94f25cc107f15291d24e813422b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580995 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#653522}
-
Darwin Huang authored
of mojom::ClipboardBuffer::kStandard. While it could be useful to allow this argument to have other values, perhaps to use for ClipboardBuffer::kSelection in X11, this is currently not used and always has the same value, so let's remove the unnecessary checks and passing around of this buffer value. SystemClipboard: :Read{Image,PlainText}() have an argument, mojom: :ClipboardBuffer buffer, which always has the same value Change-Id: Ide1d9ecb5b8f2869b14232dc2acbfe4c681419e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576184 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#653521}
-
David Jean authored
Added attributed strings handling to action sheet coordinator. Bug: 953625, 953624 Change-Id: Ic70b68fb8e124c12696a971fafe9d6db47dce65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569938Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#653520}
-
