- 29 May, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48a6bcf4f11e..15a98af79295 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: olka@google.com Change-Id: I305b3bc08b517ff5b7c1f3e4fe0f0ee5ae26717a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220821Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773126}
-
James Cook authored
The sync consent screen is skipped for non-branded (e.g. developer) builds. We need to do this check after the check for non-GAIA and public accounts, otherwise we try to enable sync for account types that don't have an IdentityManager primary account. This fixes DCHECK failures on account_id in Active Directory and device local account tests. This CL also adds an explicit sync consent screen test for Active Directory accounts, because it took me a while to figure out why unrelated AD tests were failing in sync consent code. Bug: 1060289 Change-Id: Ief0b78ae6869349993b4427226af625591d827f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211181 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773125}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iecbfab03f5bf9594c65b6fbf55194d8660f8abf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773124}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a869b729..259d8f40 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I016bcf5e56fbc3d4be728995ae4729fd81d4c8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218395Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773123}
-
Etienne Bergeron authored
This CL replace the fixed size vector used to store the text style by a std::array which is by default fixed size. The goal is to statically ensures the size of the vector. R=pkasting@chromium.org Bug: 1025561 Change-Id: I773897545adb34680cf62ece1594f03617d2e262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220074 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#773122}
-
Mark Brand authored
Adds mojo/tools/fuzzers/mojom.gni which has a template rule that wraps most of the build-file mechanics necessary to build fuzzer targets using MojoLPM, and adds pipe date size limits to the MojoLPM data pipe implementations to prevent fuzzers from OOMing so easily. In order to make the mojolpm_fuzzer_target work, it needs to fix handling for testonly in a couple of places: - adding testonly propagation to protoc_convert. - adding testonly to seed_corpus copy rule. Bug: 1076336 Change-Id: Ib6b2efbe533151e28c3ef26593ac0dc322725770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172079 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773121}
-
sandromaggi authored
The Autofill Assistant now handles back button clicks by removing its UI and stopping. Bug: b/152954282 Change-Id: I9c86d45c58b036147c5d729801faae2484068fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207177 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#773120}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590724612-5db2101d2a61d33e1335d92c89441aeea9c7ea20.profdata to chrome-win64-master-1590739125-6c79d7b2f103e2693202dab38de41a1a724cbc3e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I37d54dbd5d59650d17ead1c5fb3737674a0db8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222310Reviewed-by:
-
Patrick To authored
When initializing the GPUInfo of each GPU on the computer, also include the LUID. A LUID is needed to uniquely identify a GPU adapter. The vendor ID and device ID is not sufficient because device IDs are unique only relative to the vendor ID, not to each other. If a computer has two of the same exact GPU, they will have the same vendor ID and device ID, but different LUIDs. This change is one part of a series of changes to add multi-GPU support for VR. This code was originally reviewed as part of a larger CL here: https://chromium-review.googlesource.com/c/chromium/src/+/2096778 However, that change is being split into smaller pieces to facilitate code review and landing. The other parts of the split will be put up within a few days. Bug: 792657 Change-Id: I4821e2d1317caf335add61b16a9adc7e0d08a41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216166Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773118}
-
Mikel Astiz authored
Most sync integration tests don't need to wait until history loads. It slows down the tests, and in fact runs into timeouts on some platforms. Instead, let's rely on tests themselves being robust enough to handle history initialization, and if that's not the case they should explicitly wait until history loads. Change-Id: Iaf06c3055c21eed0b4502559450bdbf5726bb88e Bug: 1086829,1049597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218022 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#773117}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/45b9192ad981..980e0c16b911 2020-05-29 handellm@webrtc.org VideoSendStreamTest: remove lock recursions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9aba055ed50745135c933537607f829aa3652940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222314Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/33004b09f180..b41baa411329 2020-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from afe55126be2d to 3c5bad0911e3 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I48c0993d557827ade40b5ea0310372169d86ad00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222306Reviewed-by:
-
Joel Hockey authored
This reverts commit 6fce9dc3. Reason for revert: Relanding with fix Original change's description: > Revert "Refactor crostini use CrostiniId rather than vm_name, container_name" > > This reverts commit 3984e14d. > > Reason for revert: CrostiniManagerRestartTest.RestartMultipleThenUninstall crashing on https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg > > first failure https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/18909 > > crash log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878996586056266096/+/steps/unit_tests/0/logs/Deterministic_failure:_CrostiniManagerRestartTest.RestartMultipleThenUninstall__status_CRASH_/0 > > Original change's description: > > Refactor crostini use CrostiniId rather than vm_name, container_name > > > > Refactor only change. > > > > Change places where vm_name and container_name are being used in a > > function to use ContainerId, and particularly ContainerId::GetDefault. > > > > TBR=haraken@chromium.org > > > > Bug: 846190 > > Change-Id: Iaa545c750aa979cceff74c87e89ef4bd21867f4f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220106 > > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > > Commit-Queue: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Julian Watson <juwa@google.com> > > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#773035} > > TBR=haraken@chromium.org,joelhockey@chromium.org,juwa@google.com > > Change-Id: I8bc3d9e68df869fc19c04381d4d013fe6ef4f7b3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 846190 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218313 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773085} TBR=haraken@chromium.org,olka@chromium.org,joelhockey@chromium.org,juwa@google.com Bug: 846190 Change-Id: I4597e0d01cd8c9f9b2d5bb94591b1c1c2f404741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222084Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773114}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 169c3365. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I903f871cbf5eb9bdb03897830e98c93678db523a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218813Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773113}
-
Maksim Ivanov authored
Fix the policy_fuzzer to use the new accessor interface of the PolicyMap::Entry class. Bug: 1083984 Change-Id: I0dae1ac3ecc39ca4cab89ffc937dd4081e077580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218316 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#773112}
-
Victor Hugo Vianna Silva authored
This CL uses the previously introduced frontendId field to deduplicate entries across stores in chrome://settings/passwords. Bug: 1049141 Change-Id: I295a92a0525db80cae6e57551a0cf0bab34fdbbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219503Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#773111}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fcef4e406f7d..7b165971aa48 2020-05-29 janscheffler@chromium.org Reenable test for layers panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1053901,chromium:1076763 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0552f988b9ddd76ba3750211f23ea3346d623e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222312Reviewed-by:
-
Olga Sharonova authored
This reverts commit 4b053da1. Reason for revert: breaks the build https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878975239685380208/+/steps/compile/0/stdout Original change's description: > [Fuchsia] Add WebGL MSAA to the allowed list for WebEngine > > Now webgl-antialiasing-mode and webgl-msaa-sample-count can be > specified in WebEngine config. This will allow to control MSAA support > when using WebGL. > > Bug: 766360 > Change-Id: If325bedefb31c1c960868563bcf223ba0bc88999 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220865 > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773101} TBR=reveman@chromium.org,wez@chromium.org,sergeyu@chromium.org Change-Id: Ifb1e0fa7717e14424dce62a93b81602adca09435 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218317Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#773109}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a075151a2121..5666031c614c 2020-05-29 hjd@google.com Merge "trace_processor: Fix layout track" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I224be11f1c1b8150341fcdf77f8c4dfb9a3567fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222311Reviewed-by:
-
Tomasz Moniuszko authored
With the feature disabled, MediaHistoryKeyedServiceFactory instance is not created in ChromeBrowserMainExtraPartsProfiles:: EnsureBrowserContextKeyedServiceFactoriesBuilt() and thus dependency graph is incomplete. Creating MediaHistoryKeyedService on clearing browsing data can lead to crashes on keyed services shutdown for profile. Bug: 1064755 Change-Id: I883b98db96fcd7ce6f0445b296342d529cb038af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218121 Auto-Submit: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#773107}
-
Andrew Walbran authored
Often not all the buttons and axes between 0 and buttons_length / axes_length are actually used. This change adds some fields to keep track of which ones are used. This is necessary in some cases to determine which mapping is appropriate. Also fixes a bug where special buttons might not be counted towards the buttons_length on Windows. BUG=1073130 Change-Id: I9f69b7bc9f68e124b5682588af22a135ed8964a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216510Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Andrew Walbran <qwandor@google.com> Cr-Commit-Position: refs/heads/master@{#773106}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590724612-c1421d9824c914ff15feb610fd2b028bed82b9e1.profdata to chrome-mac-master-1590739125-30ac6fa847343d316264eb803765e7acf0a7e6c1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3b54b3601d93e69ee50e5b370c75654abdc54640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222309Reviewed-by:
-
Kenichi Ishibashi authored
This CL adds the following mojo wrappers ServiceWorkerStorage operations: * StoreUncommittedResourceId() * DoomUncommittedResources() Bug: 1055677 Change-Id: I09e8086aa4ebed3930ed41137d578126af266c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220129 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773104}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d95366028fd0..48a6bcf4f11e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:996088 Tbr: olka@google.com Change-Id: I80a37bd094435985ce9871079d84af023c8e9c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222302Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14aed087..a869b729 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9ac1a40260e7cccdd9b39fb04277f35997d2a602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218394Reviewed-by:
-
Sergey Ulanov authored
Now webgl-antialiasing-mode and webgl-msaa-sample-count can be specified in WebEngine config. This will allow to control MSAA support when using WebGL. Bug: 766360 Change-Id: If325bedefb31c1c960868563bcf223ba0bc88999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220865 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#773101}
-
Matthias Körber authored
Change-Id: I3147cce49be27f644aec762e48f1c1793d73f4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220008Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#773100}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/93a9381c76d8..399b81d2743f 2020-05-29 rharrison@chromium.org Add standalone tint gclient config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ife9ea05c6ff94eace191fc9fa5ece35cbf47fabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222303Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c24dc8f24368..fcef4e406f7d 2020-05-29 bmeurer@chromium.org [sources] Make editor location mapping more robust. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1056632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34eb7e59ff0c855995a8c6d2f910052a0fb6b71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222305Reviewed-by:
-
Christopher Cameron authored
Add methods to create a SharedImageRepresentationOverlay for IOSurfaces. This is based on the GLImage, so common-ize the GLImage lifetime across all (now 3) callers. Bug: 894929 Change-Id: Iac2e629a9e2d05089ee72889e42255b75a6fe51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222220Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#773097}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I59742d38cf9e8f1bed6745b5195e20451d23c29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222304Reviewed-by:
-
Victor Hugo Vianna Silva authored
With the addition of new fields to the PasswordUiEntry type over time, this helper function (used to create mock data for tests) was modified to set default values to these fields, since they were not relevant for most tests. Once deduplication happens in passwords_section though, only duplicates will be allowed to share the value of frontendId, which is problematic. In order to avoid having several optional parameters in an fixed order, this CL changes the signature to receive them in a key/value manner. When no frontendId is passed, it assumes the value of the id. This allows tests that do not care about duplicate entries to simply set the id value. Besides that, the CL also touches existing tests that did not set id values (which was inconsistent with the production code anyway). This will allow adding the deduplication functionality in crrev.com/c/2219503 without touching these tests, but rather focusing on adding tests for the new behavior. Bug: 1049141 Change-Id: If773b2684eda844dc025fea6255288215cd66bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218055 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773095}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/295a4177aebc..e4f8e19e72e9 2020-05-29 cwallez@chromium.org Remove the defaulting for bytesPerRow = 0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ieadc653a6d85b527692dfa7337fdc4c90779245a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222301Reviewed-by:
-
Fredrik Söderqvist authored
Since SVGTransformListTearOff::consolidate() is the business logic of this method, we can implement the specific logic there rather than in SVGTransformList. With that also drop the IsEmpty() check from it return the resulting AffineTransform instead of using an out- variable. SVGTransformList: :Concatenate() - leaving that to the callers - and have Change-Id: I25c80f7ae222f48fafecccd876a2cd79d57004e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218021Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#773093}
-
Richard Knoll authored
This hooks up the NearbyProcessManager to the NearbySharingServiceImpl that will manage which profile is enabled for Nearby via some user action and UI. Bug: 1084576 Change-Id: I1290044115e247a03cc95a6cbcb3587e2bc69f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218114Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773092}
-
Yoshifumi Inoue authored
Utilize selection_test() in editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html This patch changes "modify-by-lineboundary-in-inline-editable-contexts.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Iec04294c7960073945badcbfff1afa43beffdac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220412 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773091}
-
Henrique Ferreiro authored
Replace the validity of a blink::WebDragData object with the usage of base::Optional. This CL removes WebDragData::valid_, and Initialize(), IsNull() and Reset() methods. Bug: 1039255 Change-Id: Ieca195ab87bbf28f574959e0f5418941a8b80d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216074Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#773090}
-
chrome://safe-browsingJun Kokatsu authored
This change removes innerHTML usage in chrome://safe-browsing so that it'll be compatible with Trusted Types. Bug: 41905 Change-Id: I06ba1bf4d1bfd7cdf2b0769678fdb5daf02390c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212627 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#773089}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dd9feece3750..52014ab2d7f2 2020-05-29 dberris@chromium.org experiment: Explore E-Divisive with Jupyter 2020-05-29 dberris@chromium.org auto-triage: Tidy up issue filing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1086639 Tbr: rmhasan@google.com Change-Id: Ic21f593854553ecfdc548060a6f567ce2a0bfe5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222135Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb9831d2211c..c24dc8f24368 2020-05-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3a6d3f50ce77f25fc7bb535f1091dbccba827205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222132Reviewed-by:
-
