- 13 Jun, 2018 40 commits
-
-
Antoine Labour authored
This avoids allocating arbitrary large buffers, which could fail or cause unnecessary fragmentation. Bug: 844854 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib7f0f14628fdb26c7efad08c26aba77d4b20095c Reviewed-on: https://chromium-review.googlesource.com/1096296Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566981}
-
Koji Ishii authored
This patch allows base/containers/adapters.h, that contains base::Reversed(), in platform. Also includes the use in ShapeResult, which often requires to iterate in reversed order for RTL. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iebe6b99da81d554562ddbeac4e4421f51333fcfe Reviewed-on: https://chromium-review.googlesource.com/1094849Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#566980}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5f032995b3d7..4c48b107c6d1 git log 5f032995b3d7..4c48b107c6d1 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 npm@chromium.org Add FPDFText_LoadStandardFont to public API 2018-06-13 npm@chromium.org Remove CFX_FixedBufGrow from fx_apple_platform.cpp 2018-06-13 tsepez@chromium.org Guard some non-windows only code in cfx_font with ifdefs. 2018-06-13 tsepez@chromium.org Tidy FFLCommon() 2018-06-13 hnakashima@chromium.org Refactor GetOrCreateDefaultGraphics out of ProcessDefaultGraphics. Created with: gclient setdep -r src/third_party/pdfium@4c48b107c6d1 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idf9656ee72b19b26012dbb0d0aeea9a1daebcbfc Reviewed-on: https://chromium-review.googlesource.com/1099457Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566979}
-
Aldo Culquicondor authored
Instead of caching the DIP scale at creation, query the scale from the view. Bug: 851634 Change-Id: Iaacec8f649fcb0da6aa01ec0859b29f8cf1281b3 Reviewed-on: https://chromium-review.googlesource.com/1099045Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#566978}
-
Reid Kleckner authored
The chromium.win Windows 10 testers use 'Windows-10-15063' as the swarming os dimension, not 'Windows-10', as I did for the ASan bots. It seems that sbox_integration_tests fails on newer versions of Windows 10, and some other tests might as well. For now, make sure these bots match the main waterfall. For every test that this fixes, I'll file a follow-up bug about that test not passing on recent versions of Windows. TBR=thakis@chromium.org BUG=844398 Change-Id: I959f2d19459c722e54da9dd09b5fc169e3b171fd Reviewed-on: https://chromium-review.googlesource.com/1099567Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#566977}
-
Majid Valipour authored
Smooth scrolling makes find-in-page to be artificially slow in large test results. find-in-page is very useful when trying to narrow down to a specific test result in a large set. The smooth scroll is a non-critical UX which impedes more important functionality. Change-Id: Iec027eb4abe2ba7ec72b12b8eaabec85f0eeded0 Reviewed-on: https://chromium-review.googlesource.com/1099264Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#566976}
-
Kyle Horimoto authored
This CL adds an empty body for all three observer functions. Upcoming CLs only need to make use of some of the functions, so requiring that observers implement all three functions is cumbersome. Bug: 824568, 752273 Change-Id: I0e9d363afce71aa847ea8619a5e40b18f4a293b6 Reviewed-on: https://chromium-review.googlesource.com/1099678Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#566975}
-
Allen Vicencio authored
Adds SmbShareFinder which is a high-level class responsible for finding available shares in a network. Functions are all NOTREACHED and will be implemented in a future CL. Bug: 757625 Change-Id: I88ba748df0dafa0a0a2a46d3500b4e057d59163b Reviewed-on: https://chromium-review.googlesource.com/1089850 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#566974}
-
Robert Liao authored
BUG=848979 Change-Id: I13beb6efc1dbc86541b639661f2550b519982eca Reviewed-on: https://chromium-review.googlesource.com/1099047Reviewed-by:
-
Victor Costan authored
Change-Id: If9bd995760570480c0ab0c13de09e6e84d07a8fa Reviewed-on: https://chromium-review.googlesource.com/1098687Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#566972}
-
kylechar authored
When UseSurfaceLayerForVideo and VizDisplayCompositors are both enabled with software compositing, VideoFrameSubmitter doesn't detect and recover from GPU process crashes. Add a connection error handler on the mojom::CompositorFrameSinkPtr to handle this case. Bug: 730660 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie364610bc61de3cdb3a18ce62f23e0fa217219df Reviewed-on: https://chromium-review.googlesource.com/1099475 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566971}
-
spqchan authored
Currently when BrowserTouchBarNotificationBridge is destroyed, it will try to update the touch bar buttons, which might have been destroyed. This CL fixes the issue by having it just remove the observer. Bug: 852222 Change-Id: I8eae99985ea21c5b9f6ea5a3ffdf3998b80394e9 Reviewed-on: https://chromium-review.googlesource.com/1099483Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566970}
-
Dmitry Gozman authored
The event is only used by default click handlers and form submission. This patch replaces event with NavigationPolicy calculated on the call sites and (unfortunately) WebEventTriggeringInfo. Replaced one unit test with layout test which exercises real click instead of simulating it. Next patch will encapsulate all navigation policy logic in navigation_policy.cc and fix a bug with form submissions ignoring event modifiers (see issue). TBR=haraken@chromium.org Bug: 849055 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic64b0eec02d69e58d0dbe283abd7ee157f46f747 Reviewed-on: https://chromium-review.googlesource.com/1084323 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566969}
-
Reid Kleckner authored
This reverts commit 1e874ff9. Reason for revert: This appears to be causing many UKM related tests to fail in official builds: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/86186 Original change's description: > Create fallback config for UKM sampling. > > Some clients do not have the sampling configuration for UKM records > and the large number of entries can cause significant bias when weighted > against those clients that are sampling. Setting a large default > sampling value will at least bias the other way. > > Bug: 766909 > Change-Id: Ib6d656bd2ce4d82efb35281d09dc7b94128fadb2 > Reviewed-on: https://chromium-review.googlesource.com/1095596 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566831} TBR=rkaplow@chromium.org,asvitkine@chromium.org,bcwhite@chromium.org Change-Id: I85b86053a3a41add9a5c93e31006b885b3b2f3d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766909 Reviewed-on: https://chromium-review.googlesource.com/1099617Reviewed-by:
-
Mohamed Heikal authored
Layout inflation takes about 200-300ms on lower end devices. It is currently done during oncreate way early during startup for WebApkActivity (a splashscreen is showing so inflating the UI eagerly is not important. This CL refactors startup to allow for layout inflation in the background for activities subclassing ChromeActvitiy. Bug: 819760 Change-Id: I538baa1abf19c6f53080b1a4552a8920a0ffcf56 Reviewed-on: https://chromium-review.googlesource.com/1072607 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566967}
-
James Wallace-Lee authored
This add the utility class ApiHelperForN. It moves references to ServiceWorkerControllerAdapter and TokenBindingManagerAdapter, which were added in N, into the separate class. On pre-N devices, this reduces log spam caused by a NoClassDefFoundError. It also improves startup time. org.chromium.android_webview.test.AwServiceWorkerClientTest#. Bug: 791099, 838702 Test: adb logcat | grep 'Failed resolution of' Test: run_webview_instrumentation_test_apk -f Change-Id: I519075e03bee8c04a3f03a3ff3d316e1473dcc31 Reviewed-on: https://chromium-review.googlesource.com/1098225Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#566966}
-
Eugene But authored
Bug: 852276 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4313bff438d9c8a0d05bf995bb0025040c9fe5d9 Reviewed-on: https://chromium-review.googlesource.com/1099175 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#566965}
-
Peter Collingbourne authored
This allows compilers targeting the MS ABI to select the correct inheritance model for the member function pointer types PrefixFunc and InfixFunc using the complete type of Parser. It will allow us to enable the new Clang flag -fcomplete-member-pointers globally. Bug: 847724 Change-Id: I5b3488ce0b64b3ac4884bc499cd355e1651d12b3 Reviewed-on: https://chromium-review.googlesource.com/1098515 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#566964}
-
Justin Cohen authored
Asset catalogs fail for jpg imagesets with the iOS 12 SDK running with iOS 11. See rdar://41088480 Bug: 852431 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibec667c21ec0abec5e0e1da2b1e7b81b2aabdb0b Reviewed-on: https://chromium-review.googlesource.com/1099144 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#566963}
-
Koji Ishii authored
This patch fixes the static position of an out-of-flow objects to honor the 'text-align' property, when they have inline-type 'display' property, and their siblings are block-level. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7c83f241984d079f9d3729e3bfbdb8bd428946a4 Reviewed-on: https://chromium-review.googlesource.com/1098750 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#566962}
-
Kush Sinha authored
Bug: 820046 Test: chromeos_unittests --gtest_filter="*AccountManager*" Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: I017bb9e9f9ed789d77235336be8fa465fd4289b8 Reviewed-on: https://chromium-review.googlesource.com/1087455Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#566961}
-
Allen Vicencio authored
Moves TranslateErrorToMountResult functions to smb_errors and adds unit tests Bug: 757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I93c415a5855d05d75cabe312c3f6cce398120d0c Reviewed-on: https://chromium-review.googlesource.com/1087546 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#566960}
-
jonross authored
Previously two tests were disabled on Viz due to flakiness. Since then it was determined that these tests were flaking even without Viz and have been disabled on the according platforms. This removes them from the Viz testing filter. TBR=kylechar@chromium.org TEST=MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated MainThreadEventQueueBrowserTest.MouseMove Bug: 760181 Change-Id: Ie686d7925cb0413542a68cf72bda68295500ca56 Reviewed-on: https://chromium-review.googlesource.com/1099716Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#566959}
-
Sadrul Habib Chowdhury authored
Use a GLFence fallback (when available) if GPUTimer is not supported for reporting presentation time. BUG=851504 TBR=dcastagna@ for trivial mechanical change in media/gpu/ Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib7cb1361974e8f4e0cfa019ebb2fc2f620ac353a Reviewed-on: https://chromium-review.googlesource.com/1098528 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566958}
-
Daniel Bratell authored
In jumbo all files are merged into a single (or many) larger translation unit and then a couple of kButtonPadding variables end up in same anonymous namespace so that they clash. This patch gives those constants unique names, matching their individual use. Bug: 773275 Change-Id: I9d8be1076552b7ffaa095bb4d50d3fa3d5845274 Reviewed-on: https://chromium-review.googlesource.com/1078816Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#566957}
-
Daniel Bratell authored
In jumbo all files are merged into a single (or many) larger translation units and then a couple of kBorderThickness variables end up in same anonymous namespace so that they clash. This patch gives those constants unique names, matching their individual use. Bug: 773275 Change-Id: I1d81153af042c27927902b648fd7271a13f47c92 Reviewed-on: https://chromium-review.googlesource.com/1079168Reviewed-by:
-
Tom Sepez authored
https://chromium-review.googlesource.com/1060025 moved the creation of the PDFium engine from OutOfProcessInstance::OutOfProcessInstance() to OutOfProcessInstance::Init(), so it is possible that multiple calls to Init() might produce more than one engine. The crash in 852273 looks like a page might have somehow outlived an engine, so prevent duplicate engine creation. We rollback the configurable javascript option, since a single engine would have to support all environments. Having fixed the crash, we can re-consider this implementation. Bug: 852273 Change-Id: I00fa208fbc54dc376385fb1c2009d56944d804cb Reviewed-on: https://chromium-review.googlesource.com/1099359 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#566955}
-
Ben Wagner authored
This is a temporary build flag to hold out a Skia change which will affect very tiny text with FreeType. This will change the layout tree in two layout tests on Linux and will cause them to better match the other platforms. This flag will hold out the Skia change until these can be rebaselined. Bug: skia:8042 Change-Id: Iecb305343924dfc9f945352e94b81361a131bb22 Reviewed-on: https://chromium-review.googlesource.com/1099423Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566954}
-
Maks Orlovich authored
(Those would generally fail cleanly in release code on CRC checking) Bug: 851912 Change-Id: I9c4301893c917b6a51f3d9532080ae7098829b12 Reviewed-on: https://chromium-review.googlesource.com/1099275Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#566953}
-
Jeffrey Kardatzke authored
This finishes the refactoring on the Chrome side of things so that it communicates with cicerone instead of concierge for all communication that goes to the container. Once this is merged and Chrome OS is uprev'd to use the version of Chrome with this CL we can remove all of the corresponding calls from concierge. Bug: 842845 Test: Verified all related container functionality Change-Id: Ia44796333b2e12e243a899477d5ca2581374166a Reviewed-on: https://chromium-review.googlesource.com/1097939 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#566952}
-
Justin Cohen authored
Followup to http://crrev.com/c/1098627, correct the iOS category field. Change-Id: Ia0b0213825b6ee7bb241c9f67dab4e389001e3ea Reviewed-on: https://chromium-review.googlesource.com/1099433Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#566951}
-
Robert Ogden authored
Bug: 852120 Change-Id: I11844f1785fa3f6bd6e19ed28ea8dfe25f3dd11f Reviewed-on: https://chromium-review.googlesource.com/1099042 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#566950}
-
Kevin McNee authored
Since all gesture pinch event handling is done on the compositor thread, sending gesture pinch events via EventSender has no effect. Bug: 787924 Change-Id: Iac8cb5b387eede1bdf7d172d71ac746fd2cd70fb Reviewed-on: https://chromium-review.googlesource.com/1087403Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#566949}
-
Ben Pastene authored
And enable base_unittests on the CQ. Bug: 840967 Change-Id: I485b9d785ef02fe9918e0f2c310e3b63ffab1b4a Reviewed-on: https://chromium-review.googlesource.com/1098314Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#566948}
-
Xida Chen authored
It seems that TouchActionFilter::scrolling_touch_action_ could have no value in various cases: 1. Start a fling with a touchpad and then do fling boosting with a touch screen. 2. We could have TapDown targeting an iframe and GestureScrollBegin targeting the main frame. This CL does the temporary fix to ensure that the scrolling_touch_action_ always have value. A proper fix with tests will come later. This CL also fixes the case when we try to access the allowed_touch_action_ which could have no value. TBR=creis@chromium.org Bug: 850979 Change-Id: I8dc52a396970d20a7037fa64dc239a25def4fac1 Reviewed-on: https://chromium-review.googlesource.com/1099193Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#566947}
-
Frank Kastenholz authored
A number of IETF framer tests were disabled to cope with the incomplete merging of IETF Framing to chromium. Those issues have been resolved and the tests can now be reenabled. N/A is tests only. This was manually merged to Chromium Merge internal change: 200386798 R=rch@chromium.org Bug: 109878472 Change-Id: I908510175c02a30d7d76b2931e8e61b863dbfe0c Reviewed-on: https://chromium-review.googlesource.com/1099137Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org> Cr-Commit-Position: refs/heads/master@{#566946}
-
Matthew Jones authored
This reverts commit a6b5210c. Reason for revert: Breaks all tablets Original change's description: > Remove not-tablet check in DeviceFormFactor > > This patch removes an early return from > DeviceFormFactor#detectScreenWidthBucket that will allow tablets to > return their screen width "bucket". This should prevent tablets from > trying to load phone resources in certain cases. > > Bug: 850096 > Change-Id: Ie25c66d7dcc5278300f628cdd58e7e7c8f1052da > Reviewed-on: https://chromium-review.googlesource.com/1095642 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566246} TBR=tedchoc@chromium.org,agrieve@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 850096 Change-Id: Ia214bd8fc00e0c20bc79bb74f1d092348527bb1f Reviewed-on: https://chromium-review.googlesource.com/1099395Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#566945}
-
Quan Nguyen authored
This reverts commit 83ce891c. TBR=jdufault@chromium.org Bug: 839593 Change-Id: I7dc8393ddc3101d7c47f4e770d4007a0a6c16f96 Reviewed-on: https://chromium-review.googlesource.com/1099268Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#566944}
-
Fabio Tirelo authored
This addresses the following feedback provided during UI review: - Footer item height should be 40 = 36 (suggestion height) + 4 (compensation for corner radius); in the current implementation, this is 44 (36 + 2 * 4). - All footer items should have the same value; in the current implementation, the last one is taller than the others. - Left and right padding should also compensate for the corner radius; it's 8 today, should be 8 + 4. Bug: 851009 Change-Id: I0dad1c8bbbe97dce9341900d25af44df9efbde11 Reviewed-on: https://chromium-review.googlesource.com/1091158Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#566943}
-
Sadrul Habib Chowdhury authored
Reland of crrev.com/566724. Original commit message: The presentation-time from gpu gives a more correct view of what the user experiences, rather than the swap-time in the renderer process. So switch to using the presentation-time to measure the various paint-time metrics. The various paint-time metrics in telemetry tests (loading benchmark) will go up after this change, but it is expected, and it is not a regression. Results on various platforms with this change: Win 7: https://pinpoint-dot-chromeperf.appspot.com/job/14d09714240000 Win 10: https://pinpoint-dot-chromeperf.appspot.com/job/149921e4240000 Mac low-end: https://pinpoint-dot-chromeperf.appspot.com/job/12eeeba5240000 Android one: https://pinpoint-dot-chromeperf.appspot.com/job/16ab13e9240000 Android N5x: https://pinpoint-dot-chromeperf.appspot.com/job/12d45da5240000 BUG=811961 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7742fa669ab583dbfda8be2259c553385b7fef10 Reviewed-on: https://chromium-review.googlesource.com/1099187Reviewed-by:
-
