GitLab

Those fields are never accessed after initialization (except for
destruction). Remove the fields also track preferences that are
unused on iOS (they are related to managed accounts which is not
supported on iOS).

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I13f86b143d34fd0ba07d4372ff0e37133e0e2213
Reviewed-on: https://chromium-review.googlesource.com/1097334
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567211}

This reverts commit 6bc98f91.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 566961 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZiYzk4ZjkxODRkYjQzZmFlYWE5N2YwODZhMTFlYmEyNGZkMWMxZjkM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27907

Sample Failed Step: unit_tests

Original change's description:
> Add server token revocation in AccountManager
> 
> Bug: 820046
> Test: chromeos_unittests --gtest_filter="*AccountManager*"
> Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*"
> Change-Id: I017bb9e9f9ed789d77235336be8fa465fd4289b8
> Reviewed-on: https://chromium-review.googlesource.com/1087455
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Lutz Justen <ljusten@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: Kush Sinha <sinhak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566961}

Change-Id: Ie71a2d159ed50aa3196bf43b488877747b1f88b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820046
Reviewed-on: https://chromium-review.googlesource.com/1100515
Cr-Commit-Position: refs/heads/master@{#567210}

The guard was present in the .h, but not in the .cc. This CL adds the
misssing guard in the .cc.

Change-Id: I8716cbad52dd2f578cf730b41118ebbb554fc480
Reviewed-on: https://chromium-review.googlesource.com/1100470Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567209}

This reverts commit 94c42a4f.

Reason for revert: To unblock https://chromium-review.googlesource.com/c/chromium/src/+/1100515

Original change's description:
> Code Cleanup: Dedup usages of AccountManager's URL Context
> 
> |InlineLoginHandlerChromeOS| and |ChromeOSOAuth2TokenServiceDelegate|
> use the system URL context because they 'know' that AccountManager is
> going to use the same. This is a leaky abstraction.
> 
> Add a method in AccountManager that returns its URL Request Context.
> This request context happens to be the system URL context for now.
> 
> Bug: 820046
> Change-Id: I668769167893c995f73df63acc575eb410c0f986
> Reviewed-on: https://chromium-review.googlesource.com/1088617
> Commit-Queue: Kush Sinha <sinhak@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Lutz Justen <ljusten@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566998}

TBR=xiyuan@chromium.org,ljusten@chromium.org,sinhak@chromium.org

Change-Id: I57c56e1cde479c6544f93c42061cfc6eec08254e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820046
Reviewed-on: https://chromium-review.googlesource.com/1100775Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567208}

Bug: chromium:847679
Change-Id: I36061d52a69fb89ce3d4a224904be39c82c40d59
Reviewed-on: https://chromium-review.googlesource.com/1098746
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567207}

This CL also marks WebThreadScheduler::DefaultTaskRunner main-thread
only.

Change-Id: Ia2b8d962c78a4cf426c1ecc1010d728b58c45e4a
Reviewed-on: https://chromium-review.googlesource.com/1100603Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567206}

Bug: 852202, 669772, 806658
Change-Id: Ife9c41fbe08c1f414bb5459cba29d98d7e1fb892
Reviewed-on: https://chromium-review.googlesource.com/1098650
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567205}

The Blink rename changed the WebSocket handshake files from WebSocketHandshake*
to web_socket_handshake*. Since WebSocket is one word, these should properly be
websocket_handshake*. Fix them.

BUG=834596

Change-Id: I2009a679c948ea460713890ed548e42d797b290c
Reviewed-on: https://chromium-review.googlesource.com/1098743Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567204}

Add plumbing that allows to skip the "manual password entry"
logic when the smart card SAML sign-in is used. Without this,
the user would be asked to type their password at the end of
their HTTPS-client-certificate-based SAML sign-in.

For this, the gaia sign-in screen JS code will ask the C++ handler
whether the user is expected to have a password. In this CL, the
handler is just a stub. It will be replaced later with an actual
smart card sign-in logic, once it's implemented.

No changes in behavior are expected from this CL alone.

BUG=chromium:826417
TEST=none (existing tests)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I44012f02fade8823556bcf1200a122b0791d8292
Reviewed-on: https://chromium-review.googlesource.com/1097406Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567203}

LoginPromptBrowserTest.CancelLoginInterstitialOnRedirect fails
occasionally on Mac 10.12. Disabling it.

Bug: 852703
Change-Id: I3ac9fac42fdb1da52a21ccf27049889693136e20
Reviewed-on: https://chromium-review.googlesource.com/1100467Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567202}

BrowserTest.ReattachDevToolsWindow occasionally fails on Mac 10.11.

Bug: 852697
Change-Id: Ibd94a9b94d7963825c42dbe50fb8c72097409da0
TBR: ellyjones@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1100465Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567201}

Bug: 798408
Change-Id: I6983b0468743607e8dd2a8722885a4861aaba8b2
Reviewed-on: https://chromium-review.googlesource.com/1096772Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567200}

Fix1: If either AllowOnlyPolicyNetworksToConnect or
AllowOnlyPolicyNetworksToAutoconnect is enabled, this CL will
additionally remove the network configurations
(AllowOnlyPolicyNetworksToConnect) or disable auto-connect (for
AllowOnlyPolicyNetworksToAutoconnect) for the unmanaged networks to
prevent Shill from re-connecting when searching for a best service to
connect.

Fix2: Fixed missing disconnect, when AllowOnlyPolicyNetworksToConnect
gets enabled. This disconnect was incorrectly prevented by the
|applied_autoconnect_policy_| boolean before, which ensures that the
disconnect on AllowOnlyPolicyNetworksToAutoconnect only happens once.

Bug: 850550
Change-Id: I869ed49d58adb82707e8856e896c5a141f6f6625
Reviewed-on: https://chromium-review.googlesource.com/1091051Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567199}

To make writing unit-tests easy, this CL separates mojo interfaces
from ArcInputMethodManager.
This CL does the following:
- Rename ArcInputMethodManagerBridge to ArcInputMethodManagerService.
- Introduce new ArcInputMethodManagerBridge interface for injection
  point.

Bug: 845079
Test: unit tests
Change-Id: I2e16b0bb9eba2c6bf9717813dff1640bd1f54b1d
Reviewed-on: https://chromium-review.googlesource.com/1098738
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567198}

Apart from making it more human neck friendly, those which were in
vertical-lr would expose bug 850504 (once support for anonymous NG table
cells is enabled), which really isn't an interesting thing to test in
these tests. To be consistent, rewrite all tests to use horizontal-tb,
not just those that previously used vertical-lr.

viewport-y-vertical-XX-rtl additionally need a fixed horizontal offset
for the absolutely positioned box in the ref. Not sure what went wrong,
but both NG and legacy decided to act up in identical ways.

Bug: 850504
Change-Id: I888db0680c5d543c9ac19a1ae8ab9ca791d8b259
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/1099384Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567197}

This CL connects the TabLayout int the keyboard accessory with the
ViewPager in the accessory sheet.
This means the visibility of keyboard and tabs can be controlled by the
ManualFillingCoordinator and is decoupled from the accessory.

Bug: 828832, 811747
Change-Id: I01f225458d068e75fde19398fc352672779d23c0
Reviewed-on: https://chromium-review.googlesource.com/1091190
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567196}

Fixes regression introduced in CL:1068184

Also added a browsertest to verify behaviour on user kerberos files
changed D-Bus signal

BUG=chromium:845829
TEST=ExistingUserControllerActiveDirectoryTest.UserKerberosFilesChangedSignalTriggersFileUpdate

Change-Id: Ieeb800f85210c094f34c93a71b0e7502ceae3114
Reviewed-on: https://chromium-review.googlesource.com/1089060Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567195}

This CL updates the tab grid selector control assets, and removes the
programatic scaling effect now that the assets are scaled. Tinting is
also now done in code.

Bug: 849645
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I48e9a3e72cad8609ad14a2940733a02140d89005
Reviewed-on: https://chromium-review.googlesource.com/1099070
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567194}

Bug: 845075
Change-Id: Id6667e02fcdd7be54d11e6ccec0074a475948754
Reviewed-on: https://chromium-review.googlesource.com/1100360Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567193}

Per the attached bug, this CL changes the tab grid to not show the changed selection state when leaving the tab grid via a tap on a cell.

Cell selection actually happened twice when a cell was tapped; once directly from the collection view, and a second time after the selection had round-tripped through the mediator. This CL cleans that up, and has the collection view decline all selection events, allowing them only to happen as a result of consumer calls.

This CL adds a |showSelectionState| property to the grid view controller; when set to NO, the grid view controller will not update the selection state of the cells when the -selectWithItemID: consumer call is received. The ID of the selected item is maintained, however.

This Cl also doesn't show the selection ring on the proxy cells animated for the transition.

Bug: 849642

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibf8d2c91dc80c42dea55c7e457efe7232d234267
Reviewed-on: https://chromium-review.googlesource.com/1096763Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567192}

This CL enables the spec fetching if you enable the ExperimentalUi. If you have
to manually enable the feature, this probably means that you did not get a
proper finch config, so a good default is set that exercises the new code.

Bug: 846694
Change-Id: I072e7c3b1977bd654949e2244873a48fb5a551ee
Reviewed-on: https://chromium-review.googlesource.com/1100458Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567191}

The identity_test_utils.h methods that deal with refresh tokens promise
that they block until the relevant operation is complete (as do their
wrapper IdentityTestEnvironment methods). However, they don't actually
do that. And that's really the most important part.

This CL makes reality match the contracts. As part of this change,
OneShotIdentityManagerObserver needs to be extended to have the
information of which event it's waiting on, as a single signin can
generate both a token updated and a primary account set event, and
the one that's received first might not be the one that the client of
the observer is actually intending to wait on.

Note: The current production impl doesn't actually require this
blocking as it is synchronous. However, it is a goal to change those
interactions back to being asynchronous, which this blocking in the
test code future-proofs for.

Bug: 798699
Change-Id: Ib8b098b65411ef22a8a3ceed4a4f58dfcad1e931
Reviewed-on: https://chromium-review.googlesource.com/1098966
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567190}

https://skia.googlesource.com/skia.git/+log/28252da5cf0a..7d4d6b816c28


git log 28252da5cf0a..7d4d6b816c28 --date=short --no-merges --format='%ad %ae %s'
2018-06-14 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files


Created with:
  gclient setdep -r src/third_party/skia@7d4d6b816c28

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: If22f28c901c95110abdb4cfcb66fca18adfb4b86
Reviewed-on: https://chromium-review.googlesource.com/1100695Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567189}

Bug: none.
Change-Id: I803b731a6418f02b2326b4e9a8cc9da7a572c92b
Reviewed-on: https://chromium-review.googlesource.com/1100549Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567188}

TBR=dpranke@chromium.org

Bug: 831171
Change-Id: Ida71a6072a3b25910bdda8fa4f15901349c7c8a0
Reviewed-on: https://chromium-review.googlesource.com/1100461Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567187}

This CL changes icon color and sub header text color in
UnifiedSystemTray's detailed views.

Screenshot: http://screen/224qsUVChRx

TEST=manual
BUG=850396

Change-Id: I48b512bd3d0e0cb4b7b42b3f6b2557fb637239af
Reviewed-on: https://chromium-review.googlesource.com/1098857Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567186}

Shows network error message instead of an unknown error message

BUG=842619
TEST=manual

Change-Id: I5149fbed8282c44e9cf1960d3b4a6f013095f983
Reviewed-on: https://chromium-review.googlesource.com/1098693Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567185}

This CL adds audio detailed view (audio settings) to UnifiedSystemTray.
Audio settings is only accessible when there are multiple audio inputs
or outputs.

TEST=manual
BUG=847770

Change-Id: Ifee6be242c9c89bdb8012f3a6c905fca042aa1c6
Reviewed-on: https://chromium-review.googlesource.com/1098871Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567184}

This CL replaces the duplicated @+id/keyboard_accessory used for the
bottom sheet with @+id/keyboard_accessory_sheet.

Furthermore, it adds some spacing, colors and dimensions that bring the
whole appearance of the keyboard accessory and its bottom sheet closer
to the intended outcome.

Bug: 828832, 811747
Change-Id: I7e949b8e0f3f5825344f672a933e7b3e6bcd685a
Reviewed-on: https://chromium-review.googlesource.com/1090921Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567183}

Origins with only embargoed content settings are currently not included in the
All Sites list. Fix.

Bug: 835712
Change-Id: Ic413db891753e729f618097cca28c554cc02f1fc
Reviewed-on: https://chromium-review.googlesource.com/1090596
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567182}

This patch rebases image expectations for
- paint/markers/inline-spelling-markers-hidpi-composited.html
- paint/markers/inline-spelling-markers-hidpi.html
since they are scaled and only have 1px diff.

Bug: 850448
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ib5e68393d577a7ee493b31406d65dab60efb36ce
Reviewed-on: https://chromium-review.googlesource.com/1100595Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567181}

BUG=b/74845106
TEST=covered by unittests

Change-Id: I1dde9c2ab19d08945f7ad4d9d2038dc1d0ff3e54
Reviewed-on: https://chromium-review.googlesource.com/1093518Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567180}

Instead of redirecting ModuleMap->Modulator->ModuleScriptLoader,
this CL makes ModuleMap::FetchSingleModuleScript() to invoke
ModuleScriptLoader directly, in order to:
- Reduce indirection around Modulator, and
- Remove Modulator::FetchNewSingleModule().

This CL moves ModuleScriptLoaderRegistry from ModulatorImplBase
to ModuleMap, to make it accessible from ModuleMap.
This shouldn't affect lifetime and semantics, because Modulator and
ModuleMap correspond one-to-one.

Previously, unit tests have overridden
Modulator::FetchNewSingleModule() and put fake implementation there.
After this CL, unit tests creates a fake ModuleScriptFetcher.

Bug: 845285
Change-Id: If94d958c57e0e3e18622efd032863b2fbd8cc5c2
Reviewed-on: https://chromium-review.googlesource.com/1079963
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567179}

ServiceWorkerGlobalScope#registration (WebServiceWorkerRegistrationImpl)
can still be alive and handle incoming messages even the thread local
pointer ServiceWorkerContextClient::ThreadSpecificInstance() has already
been reset to nullptr by
ServiceWorkerContextClient::WillDestroyWorkerContext(), thus, we need to
add a guard logic into WebServiceWorkerRegistrationImpl to avoid
accessing nullptr.

BUG=852195

Change-Id: Ia07b88f40d195293db8690216bd46d1a22bd687a
Reviewed-on: https://chromium-review.googlesource.com/1098563Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#567178}

This makes sure Picture-in-Picture context menu does not show at all
(instead of disabled) for video elements with audio track only (e.g.
MediaDocument).
It also shows audio related items such as "Open audio in new tab"
insteaad of "Open video in new tab" for these cases.

Screenshots: https://imgur.com/a/1d1UNrg

Bug: 806249
Change-Id: I6341f476557389521ab2b6f21e53c2bd6a5df34d
Reviewed-on: https://chromium-review.googlesource.com/1096759
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567177}

Before moving //device/geolocation into //services, we have to make sure
all the clients do not depend on //device/geolocation directly.

Now the chrome/browser:browser depends on //device/geolocation, to
remove that dependency, we have to change the geolocation target from
"component" to "source_set". The reason is:

When building libchrome.so, linker tries to find the symbol:
"Java_org_chromium_device_geolocation_LocationProviderAdapter_nativeNew
ErrorAvailable" as there are native functions being declared in
LocationProviderAdapter.java. Without depending on
"//device/geolocation" in chrome/browser:browser, linker will complain
error that symbol cannot be found. Note that there is no *actual*
dependency from //chrome to //device/geolocation, the Java code that is
using the native function will be moved into Device Service as an
internal implementation.

So we change the "component" to "source_set" to let the symbols inside
the //device/geolocation can be propagated up to target which builds the
libchrome.so. At the same time, the geolocation_export.h is removed.

Because the //device/geolocation will be moved into //services/device
and be hidden, sooner or later it will be changed to type of source_set.

BUG=800659

Change-Id: I3e581f9a0e5c492528a85a07e97e93af48ab7eb1
Reviewed-on: https://chromium-review.googlesource.com/1086490
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567176}

This CL enables the user to:
1) See recently closed tabs in the tab grid.
2) Tap and open recently close tabs.

This CL adds a method to UrlLoader protocol that restores a tab to
the WebStateList based on SessionID.

In BVC, the restored tab replaces the current WebState.
In tab grid, the restored tab is added to the end of the WebStateList.

Bug: 851219
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6dc6c22f43d746a9dc73d15b65d6fd5193899a25
Reviewed-on: https://chromium-review.googlesource.com/1094324
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567175}

This is a follow-up CL for the preview review comments:
https://chromium-review.googlesource.com/c/chromium/src/+/1090592/4/third_party/blink/renderer/core/script/fetch_client_settings_object_snapshot.h#23

Bug: 845285
Change-Id: I69192292116ee9a5675aeb94cbb4e7381f01f7f7
Reviewed-on: https://chromium-review.googlesource.com/1098654
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567174}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I95fb0bd3f737c7252bf0aa0d28909a4e9a720f03
Reviewed-on: https://chromium-review.googlesource.com/1100345Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567173}

History coordinator can now be started on top of the tab grid.
This history coordinator was not properly being dismissed
inside main_controller's |-dismissModalDialogsWithCompletion:|.

As part of fixing dismissal, this CL also fixes a bookkeeping flaw
in main_controller. Previously, main_controller conflated the
existence of |self.currentBVC| with the BVC being presented and active.
This CL changes that logic to use |-isTabSwitcherActive| instead.

Bug : 852243

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I93d5efb33a2de8eaed7b0472fa2994c14603d11a
Reviewed-on: https://chromium-review.googlesource.com/1098555
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567172}