- 13 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4c6903a455df..df6b7298bb41 2020-10-13 cclao@google.com Vulkan: Use StoreOp_None_QCOM for read only depth stencil buffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Change-Id: Iee16f2105cf3d71b72a8255bb91d5238f26ecd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816479}
-
Alexander Cooper authored
The Oculus runtime is no longer considered for selecting an appropriate VR Runtime, as our plan is to unify behind OpenXR as the single, supported runtime. This removes the unused Oculus runtime. Fixed: 1121625 Change-Id: I327619423e7a3d6c160a176dffca1354515af4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435722 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#816478}
-
Peter Marshall authored
Feature CL: http://crrev.com/c/2443620 Enable CL: http://crrev.com/c/2454085 Bug: 1127827 Change-Id: Ic7ad3ce77c222163794dd3173d046fa3fe6a8a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454721 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#816477}
-
Ilya Sherman authored
The top-level histograms.xml file is deprecated. This change * Ensures that `set noparent` applies for all CLs that update histograms. * Cleans up cruft from the //tools/metrics/histograms/OWNERS file. * Leaves cthomp@ as a general metrics reviewer. * Removes all other general metrics reviewers (see below). Note that I have only included cthomp@ as a non-Metrics-team reviewer in this new file. If you were previously listed as a metrics reviewer and wish to continue to be a metrics reviewer, feel free to send a CL re-adding yourself -- typically to one or several relevant subdirectories' OWNERS files, but it's also fine to add yourself as an owner for the entire histograms_xml directory if you prefer. If you were not previously trained as a metrics reviewer but would like to take on stewardship for some metrics reviews, please reach out to the Metrics team. We'll be more than happy to get you onboarded! R=sweilun Fixed: 1133371a Change-Id: I2d3207e74114eead80dc753c5e9f4aa81785ec99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462166 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816476}
-
Fredrik Söderqvist authored
Use StyleDifference::BlendModeChanged() to check for changes. The initial isolation notification will be handled by the AddChild() on the container. Switch the call to IsBlendingAllowed() to a more targeted call (or no call at all). drop that from LayoutSVGModelObject. LayoutObject: :SetStyle() already marks paint properties for updating, so Change-Id: I2d43d6b314509db0881003809375aaf0d8f3a292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463829Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#816475}
-
Peter Marshall authored
Frontend CL: http://crrev.com/c/2456592 Enable CL: http://crrev.com/c/2462084 Bug: 1136848 Change-Id: I8e76d0c7d0708c5467046b6a7c0bae713abf4bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461340Reviewed-by:
-
Joey Arhar authored
This patch rolls libxml from e4fb36841800038c289997432ca547c9bfef9db1 to 0b3c64d9f2f3e9ce1a98d8f19ee7a763c87e27d5 add-missing-ifdef-in-xml-reader.patch was merged upstream. add-fuzz-target.patch was added in order to prevent autoreconf failure on mac. config.h was generated in a different spot than the script looks for on my windows machine, so I changed the path for it. Bug: 934413 Change-Id: I8ddbdd9b36210942730b6b3b78051cff0c17d125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444429 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Exclude chrome/chrome_cleaner/ from the rewrite as it does not ship with the Chrome binary. Bug: 1080832 Change-Id: I0a1975e2e157155d9808bc9e2715e360e2057ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467041Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
There's no need to differentiate between blocking and non-blocking types in the sync codebase anymore (more details in the linked bug), so: - NonBlockingTypeCommitContribution is renamed to CommitContributionImpl - NonBlockingTypeDebugInfoEmitter is merged with its base class Bug: 1103583 Change-Id: I8b97b0117474d92df964ba8b322090155a8743d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466100Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#816471}
-
Yuki Shiino authored
Implements the same features of V8DOMConfiguration as a new class IDLMemberInstaller with refactoring and clean-up. V8DOMConfiguration remains unchanged in order to make the old bindings generator workable as much as possible. IDLMemberInstaller gets rid of old and unnecessary burden, and the APK size will be reduced by 30 KBytes. IDL constants of origin trial features are removed because 1) It's not used in production, it's used only in testing. 2) IDL constants themselves are (a sort of) obsolete. Overall, it's unlikely that we'll need IDL constants of origin trial features. Bug: 839389 Change-Id: I7bd876c779542c4889edbec6d9f6d4150e0bfec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448570 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#816470}
-
Bartek Nowierski authored
Continuation of crrev.com/c/2455947 and crrev.com/c/2463043. The remaining GetAllocatedSize() was still ambiguous, returning two different things only one of which could be considered "allocated size". Furthermore, naming of function params and local variables wasn't always clear. This is an attempt to make the terminology consistent: - requested_size - what the app requested - extras - PA-internal data surrounding the allocated data, like tag/ref-count (for CheckedPtr) or cookies (debug only) - raw_size - requested_size + extras - usable_size (>=requested_size) - in case of over-allocation, this is what's available for the app (no risk of overriding extras, etc.) - utilized_slot_size - contiguous region of the slot that accommodates all of the above (requested allocation, additional usable space and extras); equal to raw_size if it's possible to save it in meta-data (for large allocations only), slot_size otherwise Change-Id: Ia2a771af6d29261b049b0dc98fede6395dc7a35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462909 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Josiah K authored
Plumb through active-descendant focus-following for full-screen magnifier in Chrome OS. Bug: 1131153 Change-Id: I8bc79096768449a231221cd8f354f80c966033a9 AX-Relnotes: Adds Magnifier support for active-descendant focus-following Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440763 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816468}
-
Yuki Shiino authored
Enables the new bindings of IDL callback functions and IDL callback interfaces. No behavioral change, but reduces the APK size by 7 KBytes. Bug: 839389 Change-Id: I8281c922ac310a277954bf35864fc85c7bb9932b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370682 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Updates a few chrome/browser/ui/views/profiles/* classes for compatibility with ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ie11779eebf17c6a8dc93eb5ad88279112faa9836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461315 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816466}
-
rajendrant authored
This is a reland of 0716d3fb The failing test ran fine 100+ times in linux. Could not repro the Mac failures, but I am removing the failing expect check. Original change's description: > LiteVideo: Stop throttling on playback seek events > > This plumbs the playback seek event from renderer to browser and uses it > to stop litevideo throttling. The seek updates to browser are throttled > for performance reasons. > > Subsequent CL will change this to stop throttling only after k seek > events (finchable), and record this in UKM. > > Bug: 1134672 > Change-Id: Idd88819e8ae50ffbc215197a437bf87d6fa9a36a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453801 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815787} TBR=mcrouse@chromium.org,dalecurtis@chromium.org,kinuko@chromium.org Bug: 1134672 Change-Id: Ic75af0f84e35515ae6fde3c2c44b9da782751d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467014Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#816465}
-
Han Leon authored
Ensure PowerMonitorTest:: data members all be accessed only on the UI thread. Bug: 1127374, 1126315 Change-Id: I9c41bb7c4cd451f84732b128f80e14db40d6bcaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465190Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#816464}
-
Colin Blundell authored
WebLayer does not use //components/history and does not want to take a dep on the (large) component, as every dep that WebLayer adds has an impact on WebView. SubresourceFilterContentSettingsManager, however, currently depends on //components/history for its optional observance of the user's deletion of URLs from history. This CL prepares for abstraction of that dependency by having SubresourceFilterContentSettingsManager::OnURLsDeleted() operate on new public APIs of ContentSettingsManager for deleting site metadata. A followup CL will then do the following: - Add the ability for SubresourceFilterProfileContext to store opaque embedder data (via a simple SubresourceFilterProfileContext::EmbedderData interface) - Move the history observance to a new SubresourceFilterHistoryObserver class that is an EmbedderData and takes in a SubresourceFilterContentSettingsManager instance to call into - Have SubresourceFilterProfileContextFactory create SubresourceFilterHistoryObserver to be stored by SubresourceFilterProfileContext instances In this way, WebLayer will be able to use SubresourceFilterProfileContext, AdsInterventionManager, and SubresourceFilterContentSettingsManager without taking on the //components/history dep. Bug: 1116095 Change-Id: Icf20e19722ce4b728645b157d513194cbfefec6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464264Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#816463}
-
Milica Selakovic authored
Autofill assistant is using text selectors that are based on innerText. If translation is presented, it breaks these selectors. So while assistant is running we are disabling translation and enabling it back when assistant finishes run. Bug: 1133783 Change-Id: Ia975a6081625a54183a1bf5ae4b1fcb470b54202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453289Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816462}
-
Kent Tamura authored
This fixes a crash in the following test with LayoutNGTextArea flag: - virtual/layout_ng_block_frag/fast/multicol/textarea-with-placeholder-as-multicol-crash.html This CL has no behavior changes. Regardless of LayoutNGTextArea flag, 'column-count' property doesn't affect <textarea> behavior. Bug: 1040826 Change-Id: Ia66834f8beb8bd0b5df843f5302df2d0ad57d2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467045 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816461}
-
Kelvin Jiang authored
This returns the number of static rules an extension can enable before exceeding the static rule limit. Bug: 983299 No-Presubmit: True Change-Id: Ic20376cde4e8e3dd04286d4b6a8ffbfeccd004e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455247 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#816460}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a69414b1a37a..f6bb6691b933 2020-10-13 alexrudenko@chromium.org Enable TypeScript for AXBreadcrumbsPane.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If7ded872c13679382179780afa06c0148cb5f3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463858Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 187247ee. With Chromium commits locally applied on WPT: cfa13307 "Revert "Enable "Immersive-AR" session for OpenXR runtime"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Id4495ca46f555efa2528e7c5d07eb85bc094e1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467280Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816458}
-
Joel Hockey authored
Use 'Parallels Desktop' rather than 'Windows' to be consistent with the 'Share with Parallels Desktop' string we use. Bug: b/169903064 Change-Id: Ia41628537c64c633eec2aeddbe08c343151f72ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467298 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816457}
-
Hayato Ito authored
A crash occurs when loading an empty resource in a bundle because PipeDataSource::Read accesses data_[offset] even when data_.size() is zero. We should memcpy only when |len| > 0 to avoid out-of-range access. Bug: 1082020 Change-Id: I4c04ef38029c30ef57908ddaf8c4868e66531c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463095Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#816456}
-
hai007 authored
third_party/nearby uprev @e9dd5d32f0f7a81b50ba8a5f327edf2ac738f956. Bug: b/156632928 Change-Id: I12d012353a84419c4e67c6ed2987d8bc819c9fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466166 Commit-Queue: Hai Shang <hais@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#816455}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f58db3c94da3..387fd62a1280 2020-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4a368eae to c4100566 (954 revisions) 2020-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0f55e3e5d266 to df6b7298bb41 (5 revisions) 2020-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 793a07e36636 to d1bca09f4ab3 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Test: Test: Test: Asphalt 8 MECTest: Test: https://chromium-swarm.appspot.com/task?id=4f2b87c4f8234910 Change-Id: Ica00d2dfa068fb12c89ba930a5a7142479dbc935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464690Reviewed-by:
-
Joey Arhar authored
Before this change, color-suggestion-picker.html failed to open the color picker. Change-Id: I4301e50f6c5030760dd112092f49fc55410f420d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466513Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#816453}
-
Payton Bradsky authored
The fuchsia.media.Audio FIDL service has been migrated to audio_core.cmx. This change reflects the migration, removing the injected Audio service and moving it to be a system-service, which allows Audio to be accessed through the AudioCore system-service instance. Bug: fuchsia:57744 Test: media_unittests Change-Id: I4f68123f72f3db46677d02b194156e5d9f0c211f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453928Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Payton Bradsky <pbradsky@google.com> Cr-Commit-Position: refs/heads/master@{#816452}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/51af1b428f5f..d1bca09f4ab3 2020-10-12 kainino@chromium.org Change rowsPerImage units from texels to blocks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I2378c6321b235645e579ff7933c598a54d534190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467070Reviewed-by:
-
mlcui authored
Change-Id: Iaadb846eae348b95ce5f71be17f97761af220821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404283 Commit-Queue: Michael Cui <mlcui@google.com> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
-
Maggie Cai authored
This reverts commit acfed35e. Reason for revert: This CL is likely breaks the Deterministic Linux build and cause a tree closure (https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/29271) It fails compare_build_artifacts and the difference is in: nacl_test_data/nonsfi/irt_exception_test_pnacl_newlib_x32_nonsfi.nexe nacl_test_data/nonsfi/irt_manifest_file_pnacl_newlib_x32_nonsfi.nexe ppapi_nacl_tests_pnacl_newlib_x64.nexe test_data/ppapi/tests/extensions/packaged_app/nonsfi/ppapi_tests_extensions_packaged_app_pnacl_newlib_x32_nonsfi.nexe Original change's description: > [Flash] Remove PPP_Flash_BrowserOperations API > > This also removes plugin data and settings persistence, which isn't > needed if the Flash plugin doesn't exist (it used to persist its own > data on command from the browser.) > > Adds a TODO to figure out how we will remove plugin data now that > Flash is deprecated. > > Bug: chromium:1064652,chromium:1135773,chromium:1135779 > Change-Id: I2eb1e30856071190cba29cea98cdd86a37722f95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450057 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Anthony LaForge <laforge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816370} TBR=sky@chromium.org,bbudge@chromium.org,laforge@chromium.org,tsepez@chromium.org Change-Id: I494da0a1897c7a75dd3f79d52f210e21a66ed5fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1064652 Bug: chromium:1135773 Bug: chromium:1135779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467168Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#816449}
-
Kunihiko Sakamoto authored
This fixes an issue that content:// URLs behaves differently from file:// URLs in tests. Bug: 1136315 Change-Id: Idf5311ea36c07a739ef6025023675e5a8000cdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462898Reviewed-by:
-
Bettina Dea authored
Max EP promo impressions should be defined in the server-side experiment and not hard-coded. SigninPromo max impressions will also be defined in the same experiment as it is introduced only when the Enhanced Protection promo has started its experiment. Bug: 1136612 Change-Id: I5ecf4f60ed01af7dcf493a9c2ab24674df05553c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461994 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#816447}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602503558-c2e745b5a37c8ee5f138ede7ee7fff767428f64a.profdata to chrome-win64-master-1602536311-64e797cbe41fbbe11cccf8259e756a8b7f11c663.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5cf3eb578efc880cb646eea79b36823e20c655b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466858Reviewed-by:
-
Peter Boström authored
Removes explicit SetShowCloseButton calls. Leaves an ability to more explicitly override the close-x (OverrideShowCloseButton) to avoid changing existing dialogs as they are converted. Making all existing dialogs respect dialog modality and removing this override is something I'll try to negotiate separately, but this can at least be correct by default. Bug: 1106422 Change-Id: Ib8424e5c45fadee58aa07e5a2d26bd117054ebbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465805 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#816445}
-
Jérémie Boulic authored
Manual tests: - Enable files-zip-mount flag - Mount a archive containing many files, ensure that the visual signal is displayed, and removed once the archive is mounted - Mount an invalid archive, ensure that an error message is displayed - Mount an encrypted archive, ensure that no visual signal is displayed during password prompt, and that no error message is seen when cancelling it - Mount a large encrypted archive, provide wrong password multiple times, ensure that the "Opening" message is displayed once the right password is provided Bug: chromium:912236 Test: manual tests above, crrev.com/c/2467162 Change-Id: Ifc01d9b43b8e746e6676b2f7bd623fe173f59c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423448Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#816444}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/720508005564..f58db3c94da3 2020-10-13 csmartdalton@google.com Various optimizations to stroke tessellation shaders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I4e4fc35d3eaa2a80791a8a58c8809d484f91bf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467067Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d21d9e8681bc..5fa8ec27e929 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mxcai@google.com Change-Id: I4a435ef9a631a4f33ee63dd42d48c9488232d2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467236Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816442}
-
Kent Tamura authored
This CL ports LayoutTextControlMultiLine::LayoutSpecialExcludedChild() to LayoutNG. - A placeholder box doesn't affect its parent's MinMaxSizes. - NGBlockLayoutAlgorithm checks if a child is a placeholder, layout it, and place it at (0, 0) of the content box. - shadow_element_utils.* and NGLayoutInputNode have helper functions to check if a node is a placeholder. This CL fixes seven web tests with LayoutNGTextArea flag. Bug: 1040826 Change-Id: Iefa3c2306b62c1e98a509cd3227e1ee0efde17c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462894 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9103d0e4fc9b..a69414b1a37a 2020-10-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3ca1390d93de44ac01bdda582129ed5d4b24ebf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467007Reviewed-by:
-
