- 08 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8bd58eb928c3..5472a5a44c1c git log 8bd58eb928c3..5472a5a44c1c --date=short --no-merges --format='%ad %ae %s' 2019-08-08 rmhasan@google.com [Telemetry] Implement GetBrokenExpectations in typ_expectations.StoryExpectations Created with: gclient setdep -r src/third_party/catapult@5472a5a44c1c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:973936 Change-Id: I4a2c1edce7622d8e607dc92f192173a86c453c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685350}
-
Morten Stenshorne authored
I didn't check why one test started to pass (it's not a very interesting test for overflow). Bug: 829028 Change-Id: I2c2d5fe3ea8c6a87f00df47f81d4158936d8a1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742162Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#685349}
-
Leo Zhang authored
Chrome crash report ../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc: **CRASHING**:seccomp-bpf failure in syscall 0098 Bug: 991435 Change-Id: I249a80192cc874eee1769233f2c10fb4e1267dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741329Reviewed-by:Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#685348}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a110bf60c043..1b4c7e9f3844 git log a110bf60c043..1b4c7e9f3844 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 cbiesinger@chromium.org Make gclient_utils work with Python 3 Created with: gclient setdep -r src/third_party/depot_tools@1b4c7e9f3844 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I003198b4b72870a29b85cc385ff96af229f450d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744769Reviewed-by:
-
Elly Fong-Jones authored
This change is a fixed version of <https://chromium-review.googlesource.com/c/1334147>. This change: 1) Has MenuController consider command to be an accelerator key, along with control and alt, for the purpose of not searching for mnemonics; 2) Has MenuController stop handling a key press, and cancel the menu, when the key press looks like it is a window-level accelerator instead. Testing: 1) Open the app menu 2) With the app menu still open, hit cmd-T 3) The app menu should dismiss 4) A new tab should appear Bug: 885138 Change-Id: Ib9c9e1517ae9ad3f9ec55eadb9bdfe61762df4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742520 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#685346}
-
Aaron Krajeski authored
It's possible that it has been disposed but its ID still exists. This can lead to UAP bugs. Bug: 978793 Change-Id: Idb4639cb78110878a28ab3c50807174343a66033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744642Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#685345}
-
Jared Saul authored
Was set to ENABLED_BY_DEFAULT, so should be a no-op. Change-Id: I78aa42ca8a7d00face3d2e702c4c7beae550a6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742441Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#685344}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b1c529c6e47..0756495a26fb git log 0b1c529c6e47..0756495a26fb --date=short --no-merges --format='%ad %ae %s' 2019-08-08 treehugger-gerrit@google.com Merge "perfetto-ui: Add truncate end option" 2019-08-08 treehugger-gerrit@google.com Merge "perfetto-ui: Update example trace" 2019-08-08 treehugger-gerrit@google.com Merge "trace_to_text: Truncate traces from start or end" 2019-08-08 eseckler@google.com Merge "Trace processor: Export Chrome metadata to JSON" 2019-08-08 skyostil@google.com Merge "client api: Always compile watchdog_posix.cc" Created with: gclient setdep -r src/third_party/perfetto@0756495a26fb The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I2cf01c56638bded45841dc21176d488b4b6ecfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743022Reviewed-by:
-
Max Moroz authored
The header (testing/libfuzzer/libfuzzer_exports.h) should be included in fuzz targets they define optional libFuzzer symbols, as otherwise those symbols may be stripped by the linker on Mac and fuzz target may work incorrectly, see https://crbug.com/687076 for more information. Bug: 991345 Change-Id: I459774f2bc8de708d67c0af455031146592c4799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738756 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#685342}
-
Sophie Chang authored
Without this, it chokes if multiple optimization types have filters Bug: 969558 Change-Id: Ib8e9fa546847a865f91b758e6f4980b1e4eedad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743103Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#685341}
-
Robbie Gibson authored
One major change is making all the leftImages template images. I looked through all the places I could find that set a left image and they all looked like they are currently blue, so making them a template image should work. Bug: 991185 Change-Id: Ie84b2a945bab07b4eebef889371a94d653eedecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742235 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#685340}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f51ce3d98c68..8b062b2de99f Created with: gclient setdep -r src-internal@8b062b2de99f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Ia431d41a01fbe1a86e4f85b983330dffda393bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743023Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685339}
-
Yuly Novikov authored
conformance/reading/read-pixels-test.html on Win Vulkan passthrough TBR=kbr Bug: angleproject:3788 Change-Id: I606f82780bf93cf904bebdf6a864d28f941817b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744581Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#685338}
-
Gabriel Charette authored
MOCK_TIME now works across all managed Threads (main thread and ThreadPool) and also drives TimeTicks::Now(). There once was a desire to perhaps make that the default mode for tests using ScopedTaskEnvironment but I've been hesitant to go there because it might be surprising at times. In light of recent discussions where other defaults (multi-threadedness) have been surprising, I think keeping minimally modifying defaults is better for TimeSource. This completes crbug.com/905412 R=dcheng@chromium.org Bug: 905412 Change-Id: I8ad7669c1abee0c95acc9f06bc4bea5454bd8c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742616Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Add descriptions for all tools implemented in src/tools/perf/cli_tools. Bug: 991270 Change-Id: I2781439821f18090cdd95bb82b6291d93e5cf9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743633 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#685336}
-
Ahmed Mehfooz authored
Adding workaround for keeping the notification timestamp visible. Invalidating the layout of the parent view of the timestamp any time it's visibility is changed. Bug: 991150 Change-Id: If8c750bfc8f34310a8e93ff2ea30e180e19a9e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739976Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#685335}
-
Fernando Serboncini authored
This adds a flag to disable: - window.OffscreenCanvas - Context2DCreation.desynchronize. - HTMLCanvasElement.transferControlToOffscreen This is a reland to add WebView layout test expectations. TBR=alexmos,chrishtr,wfh,boliu Bug: 940953 Change-Id: I1973c94ced693f0e91785c5197c0d9173e467af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743098Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#685334}
-
Chris Mumford authored
TBR=pwnall@chromium.org Bug: None Change-Id: Ie9ef58efb532a0f2392959fa3f3b3cd35118f910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744523Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#685333}
-
dpapad authored
test_util.waitForRender -> test_util.waitBeforeNextRender PolymerTest.afterNextRender -> PolymerTest.waitAfterNextRender This is a preparatory step for exposing these helpers from the auto-generated test_util.m.js, necessary for testing Polymer3 elements. Bug: 965770 Change-Id: I6fbee615a19311c534023490222298b4582e3d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744580Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#685332}
-
Emircan Uysaler authored
This CL adds enforce-vulkan-protected-memory switch that forces us to use protected memory for vulkan compositing in fuchsia. Based on this flag, we make sure that all the allocations and vulkan calls are marked as protected according to the spec. This is a part of the bigger effort to enable protected memory usage for video playback, see bug for details. Adding these changes behind this flag allows us to test chrome in different environments while there are ongoing changes re protected memory in skia, scenic and HW decode. Bug: 982922 Change-Id: If69345ee757d6571c4934cab477a3e19c6dd888b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695931 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#685331}
-
Christopher Cameron authored
Add a cache of the result of calls to NewLibraryWithRetry. This will store all resulting MTLLibraries indefinitely, and will grow without bound. The goal is to minimize the number of calls hitting the MTLCompilerService, which is prone to hangs. Should this significantly help the situation, a more robust cache will be added either to MTLDeviceProxy or to Skia. This does not cache MTLRenderPipelineState results (a follow-on patch may, if that seems helpful in diagnosing the crases). Bug: 974219, 988964 Change-Id: I94e360eb8996b0624eae03fe6f0a85a3aee71fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738807Reviewed-by:
-
Nicolas Arciniega authored
Setting this policy should affect the state of the network service as it is getting created. This test verifies that the policy does indeed modify the state of the network service. It does not experimentally verify the number of connections per proxy. That sort of test is covered in /services code. Bug: 981598 Change-Id: Icf376f922d7d8907fb22abfad62ffd7daf33c6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738342 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#685329}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4c833efb60a1..b8ec98fe171b git log 4c833efb60a1..b8ec98fe171b --date=short --no-merges --format='%ad %ae %s' 2019-08-08 courtneygo@google.com Fix build issue with tracing enabled 2019-08-08 ianelliott@google.com Vulkan: Fix crash with glBeginTransformFeedback 2019-08-08 clemendeng@google.com BasicMangledName class 2019-08-08 iannucci@chromium.org Roll ./build/ 54ea0e7fd..680f9ea3d (665 commits) Created with: gclient setdep -r src/third_party/angle@b8ec98fe171b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:973721 Change-Id: I90943e9ef4b08a0c8fb3c350c6d6bc77c85c8254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743024Reviewed-by:
-
Tibor Goldschwendt authored
This test dummy module will be used by a smoke test execute various bundle / DFM system test scenarios (see go/dfm-testing for more details). The test type needs to be a smoke test as we will be testing scenarios that depend on packaging, i.e. we need an actual bundle with separate DFM APKs. That is something a unit or integration test doesn't provide. This CL adds one sample test scenario. We will add more later. Bug: 989651 Change-Id: I3f78025a7f0b48904eaa24c1080a817dadd7811a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726394Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#685327}
-
Danan S authored
Also, hide Parental controls from regular settings if SplitSettings is enabled. Bug: 977615 Change-Id: I13aa6f32aec8768e94bc2bf4730fb62209633c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740306 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#685326}
-
Marina Ciocea authored
On Windows, the default native widget type is DesktopNativeWidgetAura, while on Linux it's NativeWidgetAura. This leads to different behavior on Windows for contents border widget: clicks don't go through the widget, z-ordering is incorrect (the border widget is always on top), and the widget does not follow the browser window when dragged around. Use a NativeWidgetAura on Windows as well to fix these issues. Bug: 991896, 991954, 991921 Change-Id: Id9ea6101ae24dbf0cad6bfb162bed634aba22bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742140 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#685325}
-
ssid authored
Startup experiments use the next session's behavior to upload. It is simpler if we made proto output the default behavior. Change-Id: I0b00dce1a4f07f16dc7283084886f2d75c949764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725119 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#685324}
-
Greg Kerr authored
This adds a preliminary system call filter, which passes basic web browsing on 10.15, and an experimental flag to control it. The experiment won't be rolled out until the V2 GPU sandbox is complete. Bug: 988148 Change-Id: I4529b31bd88df8f2e786b1765226560e53cdd472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721240 Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Kush Sinha authored
Chrome OS Account Manager is launching (via Finch) in M76 but it needs some time (until next branch point = M78) to be enabled by default in ToT and a subsequent cleanup. Change-Id: If32390e3792e8a6b74cf9c4406b2067bf90a462a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744548Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#685322}
-
Raymond Toy authored
https://wpt.fyi/results/webaudio/the-audio-api/the-convolvernode-interface?label=master&label=experimental doesn't show any test failures so let's try removing the entry from TestExpectations. Local runs on a macbook show no timeouts either. Bug: 989036 Change-Id: I7ca70277f7ca9578931686967a7199e3e4e5148c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743076Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#685321}
-
Daniel McArdle authored
The canonicalization of file URLs effectively lowercases IPv6 addresses. This confuses GetCookieDomainWithString; when it determines the host is an IP address, it checks whether the specified domain is an exact match to the URL's host. This exact string match works fine for IPv4 addresses, because lowercasing them has no effect. Suppose the URL is "file://[A::]" and the domain is "[A::]". Because the URL's host was canonicalized as "[a::]", the exact match will fail. The reason the linked Clusterfuzz bug only reproduced on Windows is that it relies on Windows-specific behavior that turns URLs that resemble UNC paths (prefixed with two backslashes) into file URLs. Bug: 986675 Change-Id: I66b81dcd499a36132bdf39e42479425e427f0c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726989Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685320}
-
Kristi Park authored
Account for RTL arrow key directions when moving between shortcut options in RTL mode. Bug: 953822 Change-Id: I883cfa2056e5bfad897426420b363a62265adb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742888 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#685319}
-
Xi Han authored
In this CL, we record more information, field trails to the Persistent histogram data in the reduced mode. Bug: 965482 Change-Id: I5a5221d2e4c9eeeaeb8f5ace8275921a9aa08b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742367Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#685318}
-
Christian Biesinger authored
universal_newlines=True makes communicate() return a string instead of bytes. This is necessary to match the type of the return value of readlines() in clobber_if_necessary so that we don't think the lines are different when they are actually the same. R=thakis@chromium.org Bug: 941669 Change-Id: Ideb56385cdf5c3036e6858922fa3a7275e3b1be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744689 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#685317}
-
Ryan Sturm authored
This experiment shows good results on Android as well as Desktop platforms, so far. Based on those results, we'll move to Beta for more data. Bug: 962693 Change-Id: Id37d846101a2573494b1e340156628ed188dc758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740650 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#685316}
-
Joe DeBlasio authored
This CL adds an infobar for Android for safety tips. This infobar is only included in Android builds. The CL also updates strings with the latest draft strings. This version does NOT use the lightbulb icon, nor does it bold the safety tip title text. Those will come in a subsequent CL. Bug: 982930 Change-Id: I112a77f5f68ed9bcd7be9044c35af4a6a7c0a863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739674Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#685315}
-
Kent Tamura authored
The element is unnecessary. We can implement ripple effect in author's stylesheets. The test switch-appearance-customization.html has a sample implementation of ripple effect. Bug: 972476 Change-Id: Iaffe849d34f34614635906522c56ad42cd30e7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743434 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#685314}
-
Etienne Pierre-doray authored
Subsequent CL uncovered a few issues JobTaskSource that weren't exposed previously. This CL fixes those issues and add proper coverage: - ThreadPoolImpl::PostJobTaskSource was never called and had logic flaws. - A job taskSource that becomes empty while in queue could sit there forever without waking up any workers. This is fixed by forcing at least 1 worker to wakeup as long as there are things in the queue. - GetRemainingConcurrency could underflow if max concurrency drops below num workers. Bug: 839091 Change-Id: Id634eec15c925654b6ebba19b5f7e87c7fa8dd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742210 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#685313}
-
Chris Lu authored
Bug: 976673 Change-Id: I8644c0151fca6d589c9f7cd0d6b8c4203e62484d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744518Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#685312}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/171da61e7635..ecc1e12f780d git log 171da61e7635..ecc1e12f780d --date=short --no-merges --format='%ad %ae %s' 2019-08-08 shchen@chromium.org Revert "branch_archive_stages: Update firmware blob pathname" Created with: gclient setdep -r src/third_party/chromite@ecc1e12f780d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Icd4ecdcdb9381bbf49ea5fe29f21ba42e2ccfc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744646Reviewed-by:
-
