- 17 Jul, 2019 40 commits
-
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/d57d3f905ac4..58ac6508f78f $ git log d57d3f905..58ac6508f --date=short --no-merges --format='%ad %ae %s' 2019-07-17 bnc Use testing::Eq() for QuicStringPiece. 2019-07-17 bnc Revert SipHash change. 2019-07-17 bnc Refactor QpackEncoder to do two-pass encoding. 2019-07-17 bnc Factor out QpackInstructionEncoder::Values. 2019-07-17 bnc Consume unknown frames in QuicReceiveControlStream. 2019-07-17 wub gfe-relnote: In QuicSpdyClientBase, automatically convert HTTP request header names to lower case. Protected by default true, non-feature flag --quic_client_convert_http_header_name_to_lowercase. 2019-07-16 renjietang Remove stream counting for pending streams. 2019-07-16 quiche-dev Don't split sent messages on MemSlice boundaries. 2019-07-16 bnc Automated g4 rollback of changelist 258400699. 2019-07-16 fayang gfe-relnote: In QUIC, replace constant kMaxTrackedPackets with a flag. No functional change expected. Not protected. 2019-07-16 renjietang Merge GetOrCreateDynamicStream() into GetOrCreateStream(). 2019-07-16 fayang Internal QUICHE change 2019-07-16 fayang gfe-relnote: In QUIC, when RTO fires and there is no packet to be RTOed, let connection send data. Protected by gfe2_reloadable_flag_quic_fix_rto_retransmission. 2019-07-16 nharper Fix logging in QuicFlowController 2019-07-16 dschinazi QuicConnectionId::Hash adoption of SipHash 2019-07-16 fkastenholz Use VarInt encoding for IETF QUIC Reset Stream error code 2019-07-16 bnc Make HttpDecoder::ParsePriorityFrame() more robust. 2019-07-16 fkastenholz Update IETF QUIC Stop Sending to use varint for error code 2019-07-16 renjietang Remove the previous headers_stream_ and Change unowned_headers_stream_ to header_stream_. 2019-07-16 quiche-dev gfe-relnote: Add support for sending MAX_PUSH_ID, defaulting to zero and close connection if we receive a push ID higher than the max. Protected by the existing disabled and blocked quic_enable_version_99 reloadable flag. 2019-07-16 fkastenholz IETF CONNECTION CLOSE code is varint encoded 2019-07-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_check_connected_before_flush. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I11ca5f3cc299d5c1527181df6b152feee28ad8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706576 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#678320}
-
Alan Cutter authored
This CL makes WebAppUiService the same as all the other WebApp*Managers on WebAppProviderBase. It is no longer a KeyedService and gets connected through to all the other WebAppProvider components via SetSubsystems() like everything else. There should be no behavioural changes in this CL. Bug: 973324 Change-Id: I6f55d0f148026ab96ccac1a87c8f6397820406fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702344 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#678319}
-
Philip Rogers authored
core.minidump_unittest.BrowserMinidumpTest.testMultipleCrashMinidumps is failing on the linux-trusty-rel bot: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/938 core.minidump_unittest.BrowserMinidumpTest.testSymbolizeMinidump is failing on the linux-trusty-rel bot: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/934 https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/928 https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/922 https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/915 These failures may be related to the recent re-enabling of these tests in https://crrev.com/675899. TBR=bsheedy@chromium.org Bug: 634156 Change-Id: Id846e321393cf7511f9b03cbb9184c2b4a8d124d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706948Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678318}
-
Sergio Villar Senin authored
It was only used by UMA, but they were removed long time ago in https://codereview.chromium.org/1113353003 Bug: 919383 Change-Id: I00e8cfc7457afaed4e3a8e0ffe60dc5ab4b1ff45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706434 Commit-Queue: Sergio Villar <svillar@igalia.com> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#678317}
-
Ian Wells authored
On Android Q+, publish offline pages to the downloads collection rather than DownloadManager. Bug: 966236 Change-Id: Ibef10c8b35fb62dd0e088580ed1cd3f9a2614723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641664 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#678316}
-
Raphael Kubo da Costa authored
Now that PlatformSensorProvider is no longer a singleton, remove all base/singleton.h includes and clean up PlatformSensorProviderWinrt, which still had some singleton code in addition to the unnecessary include. Bug: 947564 Change-Id: Id14c0f0bb4bda7dea453259f7c80afcf95ddf5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706438 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678315}
-
Matt Jones authored
This patch removes the need to hold on to a TabModelSelector in the BottomSheet. Its primary uses were acquiring the current tab (solved with the ActivityTabProvider) and creating a new tab (which is no longer something the sheet supports). This patch also removes a few unused private constants. Change-Id: Ibee1a05e91d3e5dee67c2f5e35feda3f9a0a34c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703004Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#678314}
-
Jenna Himawan authored
Bug: 974633 Change-Id: I47261f41e7f14cdea39a3f22009f1373f6a1c15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706810Reviewed-by:
-
Chris Lu authored
Now that BadgeMediator is the only delegate for InfobarBadgeTabHelper, LegacyInfobarBadgeTabHelperDeleagte is no longer needed. Bug: 980800 Change-Id: Iff436e0970d4a0a058fc9120256d77c8d50ff4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693161 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#678312}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=droger@chromium.org Change-Id: I227b0f5030bb20a2dea53cef0b927f206e012dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649373 Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#678311}
-
David Pursell authored
Switches logging_unittest over to the new channel-based exception APIs as the port APIs will be removed soon. No functionality change. Change-Id: I87f72bb70b80cc2c7c11a07287384b754eb0dc00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696995 Commit-Queue: David Pursell <dpursell@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678310}
-
Polina Bondarenko authored
Start DeviceWilcoDtcConfigurationExternalDataHandler only if WilcoDtc feature is enabled on the device to avoid crashes if not supported. Remove WilcoDtcSupportdManager non-null checks since if the handler is created, the manager is not nullptr. Bug: 984486 Test: browser_tests Test: configure kDeviceWilcoDtcConfigurationPolicy, verify Chrome OS doesn't crash on startup if WilcoDtc feature is enabled ordisabled. Change-Id: Ic6458b096d3514e7426ee1cf5e3232c2256a2610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702376Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#678309}
-
Tomasz Śniatowski authored
All usages now call MoveToSequence, so the old function can be removed. Bug: 978036 Change-Id: Ia7cdc7e44ab2c2c0c67fe42236712db3a5d654a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702270Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/master@{#678308}
-
Alex Chau authored
- Callback will be delayed until ack is received, or time has expired - message_id is not exposed to caller anymore Bug: 984568 Change-Id: I16e3fcc13dcfcc01be94ce49f3a5dfe5f53d7633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706517Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#678307}
-
Robert Ogden authored
Bug: 977603 Change-Id: I3073cb92b91649aae42a2d90a5f7b1f15fe179e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693909Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#678306}
-
Martin Robinson authored
Bug: 903804 Change-Id: Iece660e8aecb1321d75a7f9209b8b50ac28aadb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664136 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#678305}
-
Manu Cornet authored
This field really isn't necessary. Bug: 973443 Change-Id: I6b83e2443efa9d984b879a248fe605563c3cc2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706354Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#678304}
-
Sergio Villar Senin authored
First things first, SpeculationsPumpSession was storing a base::Time at creation time to compute an elpased time later on. Using base::TimeTicks is probably better here since we are not interested in dates but in timestamps. Since the only purpose of that timestamp is to compute an elapsed time, using a base::ElapsedTimer seems the perfect fit. Bug: 979137 Change-Id: Ifbfec4dc9562d79cd0db7d1b158d4acb16c2f1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705918Reviewed-by:
-
Gauthier Ambard authored
When the trait collection is changing, the constraints of the NTP header view should be updated. Bug: 978586 Change-Id: If4effb75f23072a71235607dce32f4fa95a68188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706692Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#678302}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45086ca6db84..97816debc9ba Created with: gclient setdep -r src-internal@97816debc9ba The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: I32d06960a5ca99804bb34979f9abe952cb80f679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706769Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678301}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9584bbf0. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" 1e9c7b68 "[Client hints] Enable ACHL persistence in content shell, refactor tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ecobos@igalia.com: external/wpt/css/css-display hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I8081d21bd35d7217b604ac8fceee6147319dc81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706352Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678300}
-
Mitsuru Oshima authored
This is no longer necessary. Bug: 984347 Test: updated the test. no functional change. Change-Id: Ia1ae37b6ed9a84af49ce5e6ab3025f0d9cb13ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704314Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#678299}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e574f1e409aa..64329094c2a8 git log e574f1e409aa..64329094c2a8 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 egdaniel@google.com Move renderable flag and valid samplecounts in GrGLCaps to FormatInfo. 2019-07-17 egdaniel@google.com Add comment regarding gl BGRA format and renderability. Created with: gclient setdep -r src/third_party/skia@64329094c2a8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nifong@google.com Change-Id: Ic312d577387fb3122d51dad56258378e7c1b5061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678298}
-
Raphael Kubo da Costa authored
This commit makes the technical changes required to make the wake lock code in Blink aware of workers (i.e. use ExecutionContexts instead of Documents, exposing the WakeLock interface to dedicated workers and making WakeLockController support both Documents and DedicatedWorkerGlobalScopes). From a user perspective, though, this is still not very useful, as dedicated workers cannot acquire screen locks, and right now we always deny all requests for system locks. Bug: 967667 Change-Id: I6a775b1aac2b600006cb6f2ce0595514548bff17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702378Reviewed-by:
-
David Bokan authored
This crash happens because the hit test returns a null node. In that case it's safe to just return without doing anything. Not sure how to set this case up in a test though. Bug: 982360 Change-Id: I20d32e2704543ee816ac17c31a51957b30366309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706355 Commit-Queue: David Bokan <bokan@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#678296}
-
Sylvain Defresne authored
Change ProfileDownloaderDelegate to expose two new methods to access the IdentityManager and the URLLoaderFactory thus allowing to inject just the needed dependencies instead of requiring a Profile. Convert ProfileDownloaderTest to use IdentityTestEnvironment and TestURLLoaderFactory from IdentityTestEnvironmentProfileAdaptor, thus allowing to remove the need for creating a TestingProfile. Convert other implementation of ProfileDownloaderDelegate to fetch the IdentityManager and URLLoaderFactory internally from their Profile instance. Bug: 984487 Change-Id: Id0a43967acb5c9bbc82e18de39093724acb7401a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704255 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#678295}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icca82bfb2f2d03f4c4e0a5d8b842a903fb41f863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706768Reviewed-by:
-
Nektarios Paisios authored
This patch fixes screen reader announcements when moving by character or by line in editable fields, either through a hard line break <br>, or through a blank line (<br><br>). A tree position is returned by the AX selection API when either the anchor offset or the focus offset refers to a child index and not to a character offset. We were not handling tree positions on Mac at all, whilst on Windows IA2 and Linux ATK we were not handling them if any of the caret or selection APIs were called on the anchor or the focus of the selection and not on one of their ancestors, e.g., calling IAccessibleText::get_caretOffset on a content editable that contains an img element as a direct child, and the caret being placed before the image. Tree positions were correctly handled on Windows IA2 and Linux ATK if the selection endpoints were inside a descendant of the current object, or in a completely different part of the tree. Bug: 951777 R=aleventhal@chromium.org Change-Id: Iac3c673c4c15668367f379d979d3f2457c9fefb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699017Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#678293}
-
Robbie Gibson authored
Bug: 976681 Change-Id: I664faa59f53464cadb0ab73910936e49e7ad756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706850Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#678292}
-
Dave Tapuska authored
The histogram is expired now and the implementation can be removed. BUG=975271 Change-Id: I264d8cf74d951c368ff4ca41a024aa315273279b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703924Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#678291}
-
Chris Lu authored
Bug: 981925, 976901 Change-Id: Ie4be37f33212753b6b44b5cfb370c646597ea5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702285Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#678290}
-
Michael van Ouwerkerk authored
Bug: 976311 Change-Id: I2da915f5aca77d8d882f503dd22d2a8cffc15078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703409 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#678289}
-
Wei-Cheng Xiao authored
Histograms: Cryptohome.ChecksumStatus Cryptohome.TimeToMountGuestAsync Bug: 972785 Change-Id: Ic3d800cdf30b7fc95e17d329b8fd006917a752ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704757 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
On <div><b>x y<b></div>, we do following steps: 1. "x y".splitText(1) -> " " "x y" 2. " ".splitText(0) -> "" " " "x y" Before this patch, we have following layout tree: LayoutInline {<pseudo:first-letter>} at (0,0) size 8x19 LayoutTextFragment (anonymous) at (0,0) size 8x19 text run at (0,0) width 8: "x" LayoutText {#text} at (8,0) size 4x19 text run at (8,0) width 4: " " <======= This is for " " before "x y" LayoutTextFragment {#text} at (12,0) size 8x19 text run at (12,0) width 8: "y" This is invalid because " " should be collapsed and placed before <pseudo:: first-letter>. After this patch, |Element::UpdateFirstLetterPseudoElement()| detects this case then rebuild first-letter part of layout tree. Bug: 984389 Change-Id: I7eaa613045da44e09caa80435a04ad9615f4c40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706030 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#678287}
-
Javier Ernesto Flores Robles authored
Updates the tab strips backgrounds with the new vertical ones. Deletes unused ones @1x. Updates constants specific to each assets: tab overlap and cap inset. Bug: 976817 Change-Id: Ida3b95548ac33c0740c2375eb2153f5bafc569e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706436Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#678286}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/134aeeec27e1..f43cc6905fc2 git log 134aeeec27e1..f43cc6905fc2 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 33130413..b5dcfdfc (678125:678230) Created with: gclient setdep -r src/third_party/webrtc@f43cc6905fc2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I00e8733888880aeecfcccd57ed5bf48eacb9fab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706610Reviewed-by:
-
Alex Ilin authored
The following tests are being disabled: - VrBrowserCompositorViewHolderTest#testResizeWithCompositorViewHolderDetached - VrBrowserTransitionTest#test2dtoVrShellNfcUnsupported - VrBrowserTransitionTest#test2dtoVrShellto2dUnsupported - WebXrVrDeviceTest#testGvrlessMagicWindowCapabilities__ChromeTabbedActivity - WebXrVrDeviceTest#testGvrlessMagicWindowCapabilities__CustomTabActivity - WebXrVrDeviceTest#testGvrlessMagicWindowCapabilities__WebappActivity TBR: bsheedy@chromium.org Bug: 984943 Change-Id: If391b8cd7f66d7f3ca81e2081f21e0e2096c724d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706437Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#678284}
-
henrika authored
These are monitored as part of experiments from time to time. Bug: 984192 Change-Id: Ib7fba49f58906d5b9c18b5d4bccef8fd5174cadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706513Reviewed-by:
-
Ben Kelly authored
Bug: 984125 Change-Id: I0c3c88a410a3697040dd1b508ee3b78fb75ec08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702523 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#678282}
-
Lan Wei authored
In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. Here we are changing some touch input tests with touch action in pointerevents/extension. Bug: 606367 Change-Id: Icd5b11236bf3ec575cb93b7cb7403cea1f983034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704690Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#678281}
-
