GitLab

To support this, shortcut creation on Linux for extensions has been modified so that the filename encodes the extension ID and the profile. Also, when creating shortcuts any existing shortcuts are removed first.

Web page shortcuts are not affected.

BUG=130456
TEST=Test uninstalling apps removes their shortcuts; test uninstalling
apps is not broken in any way; test shortcuts for web apps
are not broken in any way.


Review URL: https://chromiumcodereview.appspot.com/10698114

TBR=benwells@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10735048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146066 0039d316-1c4b-4281-b951-d872f2087c98

To support this, shortcut creation on Linux for extensions has been modified so that the filename encodes the extension ID and the profile. Also, when creating shortcuts any existing shortcuts are removed first.

Web page shortcuts are not affected.

BUG=130456
TEST=Test uninstalling apps removes their shortcuts; test uninstalling
apps is not broken in any way; test shortcuts for web apps
are not broken in any way.


Review URL: https://chromiumcodereview.appspot.com/10698114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146065 0039d316-1c4b-4281-b951-d872f2087c98

Instead of DCHECKing (and then later crashing) if the state machine thinks it should be uploading old logs, but there aren't any, just advance the state and return.

This should prevent crashing in edge cases where something else has gone wrong and the state is out of sync.

Also change StageNextLogForUpload to CHECK instead of DCHECK that there is a next log before doing a swap(), since swap()ing in garbage pointers leads to hard-to-understand crashes later.

BUG=135285
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10692059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146064 0039d316-1c4b-4281-b951-d872f2087c98

[NTP4] Fix pane switcher images while we figure out the difference between <structure type="chrome_html">s and <include type="BINDATA">s.  This is partial revert of r145332.

R=tbreisacher@chromium.org
BUG=136389
TEST=Pane switchers have arrows again.


Review URL: https://chromiumcodereview.appspot.com/10689155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146063 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10763011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134821
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10704062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146061 0039d316-1c4b-4281-b951-d872f2087c98

TBR=
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10754002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146060 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10690126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146059 0039d316-1c4b-4281-b951-d872f2087c98

The leakage ocurrred on failure.

BUG=136597
TEST=tools/valgrind/valgrind.sh  --leak-check=full  out/Release/unit_tests --gtest_filter=GDataDBTest.*

Review URL: https://chromiumcodereview.appspot.com/10735040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146058 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10689131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146057 0039d316-1c4b-4281-b951-d872f2087c98

This just reflects --enable-drive-v2-api flag for use by drive API code.
Not used by anyone so far.

This code depends on https://chromiumcodereview.appspot.com/10753024/

BUG=chromium:127728
TEST=compile

Review URL: https://chromiumcodereview.appspot.com/10692149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146056 0039d316-1c4b-4281-b951-d872f2087c98

This is a part of effort to remove CrosLibrary and its belongings.

BUG=126719
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10701075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135388
TEST=run chrome on Server 2003 SP2 x86.
TBR=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10701125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146054 0039d316-1c4b-4281-b951-d872f2087c98

TBR=satorux@chromium.org
BUG=chromium-os:32464
TEST=

Review URL: https://chromiumcodereview.appspot.com/10736023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=ran chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/10704118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE


Review URL: https://chromiumcodereview.appspot.com/10413036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146051 0039d316-1c4b-4281-b951-d872f2087c98

Original codereview at http://codereview.chromium.org/10766016/

[Sync] Add location parameter to SyncChange in Sync API.

SyncChanges now require the location they were created as a parameter. This
is then used in the case that the change violates and invariant. We display
the location and type of erroneous change in about:sync, in addition to
disabling the offending datatype.

TBR=stevet@chromium.org, rlarocque@chromium.org
BUG=135108
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/10690128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146050 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10698143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146048 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10692150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146047 0039d316-1c4b-4281-b951-d872f2087c98

gdata: Move GDataFileSystem::AddUploadedFile() call out of uploader and into GDataDownloadObserver class.

The async GDataFileSystem::AddUploadedFile() call causes the file to be moved to the gdata cache. This must be invoked after DownloadObserver receives the COMPLETE status notification.

BUG=136435
TEST=unit_tests, lumpy

Review URL: https://chromiumcodereview.appspot.com/10759007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136474
TEST=./build/android/run_tests.py -s out/Release/base_unittests_apk/base_unittests-debug.apk -e 1


Review URL: https://chromiumcodereview.appspot.com/10692132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146045 0039d316-1c4b-4281-b951-d872f2087c98

It's possible client returns buffer after cached_dibs_ are freed.
Also fix a copy&paste error.

BUG=133096
TEST=the pages in bug 133096 do not crash.
Review URL: https://chromiumcodereview.appspot.com/10748018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146044 0039d316-1c4b-4281-b951-d872f2087c98

Contributed by fengx.dai@intel.com

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10695095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146043 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10703130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146042 0039d316-1c4b-4281-b951-d872f2087c98

The MessagePumpLibeventTest.StopWatcher and MessagePumpLibeventTest.DeleteWatcher
use fd 0, which is not permitted in apk test while calling 'epoll_ctl', and cause
failure on Android. Fix this by using fd created from pipe.

Also remove them from Android disabled case list.

BUG=None
TEST=base_unittests


Review URL: https://chromiumcodereview.appspot.com/10698112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146041 0039d316-1c4b-4281-b951-d872f2087c98

Favicon updates are per-url, and originate from a different thread. It's possible
by the time we receive an update notification we've already deleted that bookmark,
and should handle that situation gracefully.

BUG=121587
TEST=


Review URL: https://chromiumcodereview.appspot.com/10696163

TBR=zea@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10694126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/10545021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146039 0039d316-1c4b-4281-b951-d872f2087c98

Make eventArgumentMassagers asynchronous so custom bindings don't need to override chrome.Event.prototype.dispatch.


BUG=121479


Review URL: https://chromiumcodereview.appspot.com/10704073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146038 0039d316-1c4b-4281-b951-d872f2087c98

It turns out we had two bugs in our non-HTTP code path:
  1) Connection retries used the wrong start callback, which caused the loader to never get created
  2) The start position for non-HTTP resources is kPositionNotSpecified, which caused us to report [-1, file size) instead of [0, file size) for buffered status

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10698139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146035 0039d316-1c4b-4281-b951-d872f2087c98

Complete the TODO for native unittests apk to place used
jars into ${out.dir}/java/libs. Add the conditional check
if there is no jar in that directory.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10701113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146034 0039d316-1c4b-4281-b951-d872f2087c98

Use this flag for the period of migration from Document List API
to Drive v2 API for file browser / filesystem APIs etc.
Code for using this flag will follow separately.

BUG=chromium:127728
TEST=compile

Review URL: https://chromiumcodereview.appspot.com/10753024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146033 0039d316-1c4b-4281-b951-d872f2087c98

Favicon updates are per-url, and originate from a different thread. It's possible
by the time we receive an update notification we've already deleted that bookmark,
and should handle that situation gracefully.

BUG=121587
TEST=


Review URL: https://chromiumcodereview.appspot.com/10696163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146032 0039d316-1c4b-4281-b951-d872f2087c98

Rename it so it can contain code to set other power manager settings,
not just for screen locker.

BUG=chromium-os:32240
TEST=Build successfully.

Change-Id: I412b775c8679386262791e84e0b2575fe182872a
Signed-off-by: Simon Que <sque@chromium.org>

R=stevenjb@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10689101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146031 0039d316-1c4b-4281-b951-d872f2087c98

ShutdownTest.SimpleWindowClose

BUG=136644
TEST=
TBR=ananta

Review URL: https://chromiumcodereview.appspot.com/10703136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146030 0039d316-1c4b-4281-b951-d872f2087c98

On android, ENABLE_THEMES and ENABLE_PROTECTOR_SERVICE are not defined.
This fixes some link errors for unit_tests.

BUG=117407
TEST=

Review URL: https://chromiumcodereview.appspot.com/10704148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146028 0039d316-1c4b-4281-b951-d872f2087c98

Previous fix r144228 does not fix the crash. It seems the crash is more likely
to be caused by user closing the app window in a nested message that runs by
synchronous session restore. Add an WebContentsCloseObserver to monitor the app
contents and skip focusing logic if it is closed.

BUG=134478
TEST=Verify the crash in 134478 no longer happens.


Review URL: https://chromiumcodereview.appspot.com/10700145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10690081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146026 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10692146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146025 0039d316-1c4b-4281-b951-d872f2087c98

If we call DoSeek() without a demuxer we've clearly got issues as we shouldn't be seeking without a demuxer so crashing is preferable.

BUG=none
TEST=none
TBR=acolwell

Review URL: https://chromiumcodereview.appspot.com/10694125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146024 0039d316-1c4b-4281-b951-d872f2087c98