- 19 Jan, 2021 40 commits
-
-
Olivier Li authored
This is the first step needed to enable defining a similar class that will detect different chromium usage scenarios to be recorded alongside power use. Bug: 1153193 Change-Id: I29e59a8cffae7cc5962882f78c8fbbf29073a170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597013 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#844802}
-
Mike Taylor authored
Note: after this CL lands, mozilla0011-test and mozilla0011-expected will still be around. The intent is to port that with the rest of the domain-test.html tests. Here's a mapping from the legacy http-state/general-tests.html to their new location (found in wpt/cookies/), which will have a cookie with some variation of test=N in it. 0001 => Not ported. Already covered. 0002 => test=3 (attributes/expires.html) 0003 => test=4 (attributes/expires.html) 0004 => Not ported. Already covered. 0005 => test=2 (attributes/max-age.html) 0006 => test=3 (attributes/max-age.html) 0007 => test=14 (attributes/invalid.html) 0008 => test=15 (attributes/invalid.html) 0009 => Not ported. Basically the same as test=14 and 15 and otherwise covered. 0010 => Not ported. Already covered. 0011 => test=16 (attributes/invalid.html) 0012 => test=17 (attributes/invalid.html) 0013 => test=12 (name/name.html) 0014 => testA=13 (name/name.html) 0015 => a=test14 (name/name.html) 0016 => z=test15 (name/name.html) 0017 => z=test16 (name/name.html) 0018 => test=18 (attributes/invalid.html) 0019 => test=19 (attributes/invalid.html) 0020 => test=20 (attributes/invalid.html) 0021 => test=16 (name/name.html) 0022 => test=22 (value/value.html) 0023 => test=21 (attributes/invalid.html) 0024 => test=22 (attributes/invalid.html) 0025 => test=23 (attributes/invalid.html) 0026 => test=24 (attributes/invalid.html) 0027 => test=17 (name/name.html) 0028 => test=25 (attributes/invalid.html) Here's the mapping for http-state/mozilla-tests.html: mozilla0001 => test=4 (attributes/max-age.html) mozilla0002 => Not ported. Dupe of test=3 in max-age.html. mozilla0003 => test=5 (attributes/expires.html) mozilla0004 => Not ported. Covered by test=2 in max-age.html. mozilla0005 => test=5 (attributes/max-age.html) mozilla0006 => Not ported. Covered by test=2 in max-age.html (and dupe of mozilla0004?) mozilla0007 => Not ported. Dupe of mozilla0003. mozilla0008 => test=6 (attributes/max-age.html) mozilla0009 => test=7 (attributes/max-age.html) mozilla0010 => test=8 (attributes/max-age.html) mozilla0011 => Not ported yet, will be ported as part of Bug 1159858 mozilla0012 => test=9 (attributes/max-age.html) mozilla0013 => test=10 (attributes/max-age.html) mozilla0014 => Not ported. Covered by test7 in value.html mozilla0015 => test=11a (attributes/name.html) mozilla0016 => test=11b (attributes/name.html) mozilla0017 => test=11c (attributes/name.html) Bug: 1159862 Change-Id: I662c4af50289fef313ddf0c509a30ab6b24c88b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628259Reviewed-by:
Steven Bingler <bingler@chromium.org> Commit-Queue: Mike Taylor <miketaylr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844801}
-
Evan Stade authored
Bug: 1164069 Change-Id: I5061c1c90688daf15ee2c42e233eaee37a9ea77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626196 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844800}
-
ckitagawa authored
This CL re-enables the ContinuousSearchTabHelperTest. To de-flake, the following actions were taken: - Change how URLs were loaded. - Increase time delay for Handler.postDelayed. - Added more helpful debugging information in the event the loadUrl fails. Tested using run-swarmed on Nexus 5X and appears to no longer be flaky. Bug: 1157325 Change-Id: I5023c4ef3e3055ac007ac5dfd36577c42dde050f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626426Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#844799}
-
Zhiyuan Cai authored
Bug: 1163136, 1166702, 1166704 Change-Id: If1ab00206e17596230ff5874a9d98da896dc15ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629694 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844798}
-
Stephen Chenney authored
We do not support context-fill and context-stroke for defining colors in SVG. Bug: 367737 Change-Id: I633fdfda851d0fe359d713bc18a476959c23edb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637394Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#844797}
-
Mark Edward Winter authored
Fixed the typo of obfuscated in the field obfudscated_gaia_id in ChromeSignedInUser R=zmin@chromium.org Bug: 1036237 Change-Id: Ic39fce4d836af6cf3f69fed9a061330127f87b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636004 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844796}
-
Hans Wennborg authored
These flags were removed in crrev.com/824947 but the win thinlto flag was accidentally left behind. Bug: 1127713 Change-Id: Ie7698e4a5819eb2dcd97effcf3715f208f75801f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637577 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844795}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29bd8638adb0..6cdb67fb33ed 2021-01-19 danilchap@webrtc.org Document expected thread safety of the TaskQueue interface 2021-01-19 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-19T04:01:32). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ice33cb7d048d32f7dc0136c4d80f05650ec3fc46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637736Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844794}
-
Philipp Hancke authored
BUG=webrtc:2488 Change-Id: Ie69222d78cebf881a311e3d9590a7367a44bc4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627519 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#844793}
-
Evan Shrubsole authored
Was set to the wrong value in https://chromium-review.googlesource.com/c/chromium/src/+/2621817 Bug: 1156144 Change-Id: I82ddd9432ca6aa10ad9ab01edd0cae2fdc45610c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637578 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by:
-
Wez authored
Several of the AccessibilityBridgeTest suite's tests expect exact numbers of commit calls to the SemanticTree, which will not be met in general due to the asynchronous nature of e.g. page loads. Also rename the TestNavigation to give it a less generic sounding name. Bug: 1168126, 1167266 Change-Id: I51d557face6c31ee3b6649cc5a28f784311d64b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637500 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#844791}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101190600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/8CHDR6OyUJOhDursCeohpsk9HLyo0NS2MhikX4GjSPgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Id52d3245940ff39276a3aef3822fbbb07a993af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637893Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844790}
-
Xida Chen authored
[sheriff] Disable ProactivelySwapBrowsingInstancesSameSiteTest.StorageModificationAfterPagehideHistogram This is flaky on all major platforms. TBR=eirage@chromium.org NOTRY=true Bug: 1156218 Change-Id: Ic8893aad0a1e1b1c55f1ae7c6220d17e7b03b5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637075Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844789}
-
Yuta Hijikata authored
This is in preparation to switching lacros-chrome from target_os="linux" to target_os="chromeos". The change is made so that the behaviour of lacros-chrome is consistent. More detail on http://go/lacros-macros. Bug: chromium:1052397 Change-Id: Icfc3a9418fb83c9d91e0ecdce8cab9db48cc1ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636906 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844788}
-
Dominique Fauteux-Chapleau authored
This fixes the crash observed in crbug.com/1166233 and adds tests for it. See the comments in that bug for more details. This fix also removes the dialog for unauthorized users for pasting after the initial scan that does authentication, so crbug.com/1028133 is affected. Bug: 1166233, 1028133 Change-Id: Id3c992fdeccfa92a9f88e25c13e7a15bcb1afd8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633701Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844787}
-
danakj authored
There are no observers to inform as this happens before RenderFrameCreated, so we can just remove it. R=dcheng@chromium.org Bug: 1158869 Change-Id: Ib42a75e89b6f2391c994062effb54f24d4b7d14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633921Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844786}
-
Sebastien Marchand authored
Bug: 1153193 Change-Id: I09fcbbbe6335dfbc420d551957399a2999e3b97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624768 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#844785}
-
Andrew Grieve authored
Codesearch indexes with is_java_debug=true, so this change will allow looking up method hashes via codesearch. Bug: None Change-Id: I1d8d841073c5ef502d1e1b421a411894776e4cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636297 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#844784}
-
Jonathan Ross authored
With DCHECKs enabled base::HashInts uses a random seed, which is only valid in its process. This means that a given viz::LocalSurfaceId would have different hashes in different process. Which breaks performing Traces with Flow. Additionally while debugging issue 1060058 I noticed it was difficult to know when Viz was blocked on pending surfaces, and when rotations were occurring. This change adds a new trace to viz::Surface to list the Surface being waited on. As well as adding new traces to LayerTreeHost to denote the current viewport rect. Bug: 1154826 Change-Id: I60d9f2f195ae6ca45e9eabd101df971462b34224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633098 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844783}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/95612c220891..9e417d1e36be 2021-01-19 alexrudenko@chromium.org Increase required contrast for color suggestions 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate recorder 2021-01-19 tvanderlippe@chromium.org Migrate trimMiddle to string-utilities 2021-01-19 jacktfranklin@chromium.org Fix type of DataGrid renderer. 2021-01-19 alexrudenko@chromium.org Fix the size of the select in Layout pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549,chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0d323dd190b35774c6417ca7cc81496b462f44bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636926Reviewed-by:
-
Victor Costan authored
The Google C++ style guide recommends explicit constructors, with a few exceptions where implicit conversion is desirable. Implicit conversion between TaskRunner and RefCountedDeleteOnSequence seems surprising. This CL does not introduce any functional changes. Change-Id: I1ccf85fa5a673e7a91dd6090676788d682890412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634866 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#844781}
-
Luke Zielinski authored
Bug: 1168130 Change-Id: I6f7e3a0e5b6b9d5eb758c368d61d5366cbd3d6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637455 Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844780}
-
Xida Chen authored
This reverts commit d660a480. Reason for revert: Test fails: https://ci.chromium.org/ui/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/76721/overview Original change's description: > [profiles] Clean up guest ephemeral profile on startup > > This CL fixes a bug which leads to the guest ephemeral profile not being > cleaned up on startup if it has been left over in the previous session. > > ProfileManager::CleanUpEphemeralProfiles() needs to pass the `true` > parameter in ProfileAttributesStorage::GetAllProfilesAttributes() to get > the full list of registered profiles. > > Bug: 1167883 > Change-Id: I3051a9174e8472eb2af046126be88dbfb44bcb47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635158 > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844749} TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I6fb55866ddcda42c54d60aaa2e823da18b353348 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1167883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637395Reviewed-by:
-
Hidehiko Abe authored
This reverts commit 640009eb. Reason for revert: The original CL looks wrongly identified as a cause of test breakage. Even without this CL, the test is flaky. Original change's description: > Revert "Support multiple receivers for Cros APIs." > > This reverts commit 8aca3b4d. > > Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview > > [ RUN ] WindowOpenApiTest.PopupBlockingExtension > 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. > 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. > 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag > 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. > 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user > 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? > 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. > 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? > 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. > 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry > 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? > 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. > 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found > 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files > 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als > 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. > 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported > 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files > 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico > 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico > ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure > Expected equality of these values: > num_browsers > Which is: 4 > chrome::GetBrowserCount(browser->profile()) > Which is: 2 > Google Test trace: > ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 > Stack trace: > #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() > #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() > #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() > #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() > #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() > #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE > #6 0x563646f2068c base::internal::Invoker<>::RunOnce() > #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv > #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() > #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() > #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() > #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() > #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() > #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() > #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE > #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() > #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv > #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() > #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() > #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() > #20 0x7fb5dc82a804 content::BrowserMain() > #21 0x7fb5de9aae56 content::RunBrowserProcessMain() > #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() > #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() > #24 0x7fb5de9a9106 content::RunContentProcess() > #25 0x7fb5de9a9a3d content::ContentMain() > #26 0x563646f1cb13 content::BrowserTestBase::SetUp() > #27 0x563645acb283 InProcessBrowserTest::SetUp() > #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() > #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() > #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() > > > > Original change's description: > > Support multiple receivers for Cros APIs. > > > > With this CL, most of Cros API starts to support multiple receivers. > > AshChromeService and LacrosChromeService are exceptions. > > > > Bug: 1148448 > > Test: Build and run Lacros on a DUT. > > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > > Reviewed-by: James Cook <jamescook@chromium.org> > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#842869} > > TBR=jamescook@chromium.org,hidehiko@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1148448 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842943} TBR=jamescook@chromium.org,hidehiko@chromium.org,kolos@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1148448 Change-Id: Ic2ec65fa476b9b67a705497aad1cf3f1bffa0da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633482Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844778}
-
Xida Chen authored
TBR=rainhard@chromium.org NOTRY=true Bug: 1070886 Change-Id: I4bf958456b1602620f479802e0838d2f9dbea380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636875Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844777}
-
Hans Wennborg authored
This speeds up builds when using ThinLTO. The resource leak preventing this from being enabled before has been fixed upstream. The only bots doing ThinLTO builds on Windows are ToT bots that use upstream clang. Bug: 871962 Change-Id: Ie7a250a5bab009a95f919631b5f268aafdcdffab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637620 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Hans Wennborg authored
The SDK was updated to 11.1 in crrev.com/844553. This updates the build script to match Bug: 1168134 Change-Id: Ia9054b5b49e7f24bc9135ccd6024e3c8af8cd518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637477 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/035dfc7b..b28c3b8f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibf6a72e6aae8ea915b16c8b1eb3f085fe9a785cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637814Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844774}
-
Xida Chen authored
This test is flaky on a few platforms TBR=rainhard@chromium.org NOTRY=true Bug: 1070886 Change-Id: I5ac13c73ab75be22d34b3f0f5749efa4cb11297b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636874Reviewed-by:
-
Antonio Sartori authored
In the Blink Content Security Policy code, we switch from using the internal blink type blink::CSPDirectiveList to using the mojo type network::mojom::blink::ContentSecurityPolicy for storing a parsed Content Security Policy. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: Idb11f4af00bae348140864584d9c522ad361559b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602125 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#844772}
-
Nohemi Fernandez authored
This patch fixes a crash that occurs when a user goes through the advanced Sync settings sign-in flow with an account that has a Sync encryption password. Starting from this patch Sync error cards are only displayed after the sign-in flow has been completed. Bug: 1125631 Change-Id: I877e59e25265e78a4220fbb66b7a3855757dceb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637575Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#844771}
-
Sebastien Marchand authored
as discussed in https://chromium-review.googlesource.com/c/chromium/src/+/2621678 Bug: 1153193 Change-Id: Ib5068b627c9e91644857892a57213414b9cfd77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627886Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#844770}
-
Rune Lillesveen authored
Mark it as STACK_ALLOCATED. There's a ComputedStyle which is not refcounted which would be dangerous if TextDecorationInfo gets allocated on the heap. Noticed this when reviewing moving ComputedStyle to Oilpan. Change-Id: Ia3ec8ea0bfa542da817110d6c1b9b6c52315ad21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637834Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#844769}
-
Victor Costan authored
Bug: 1163048 Change-Id: I1744df8280e11bc96073415354a0006f49fd6a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628078Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#844768}
-
Xiaocheng Hu authored
A previous patch crrev.com/c/2629991 has a bug that it always enters a code path that should be entered only when CSSAtRuleCounterStyle is enabled. This patch handles the flag properly. Bug: 1167596 Change-Id: I15dcdae0d70a716185e5ab376a0c08bcb5f134dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636378 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844767}
-
Guillaume Jenkins authored
Installs the BrowserSignin policy handler by default. It was previously hidden behind the --install-browser-signin-handler command-line flag while the different parts of the implementation were being finished. The policy now fully works, so the command-line flag is no longer needed. Bug: 1155745 Change-Id: I58dda5bdc143cbfbd21cecbea13d184bc60100ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633352Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#844766}
-
Titouan Rigoudy authored
We test 6 out of the 7 possible URLs: - about:blank - the initial empty doc - about:srcodc - data: - blob: - filesystem: We do not test javascript:, since we cannot load in a sandboxed iframe (even with `sandbox = "allow-scripts"`). Fixed: chromium:1167697 Change-Id: I8c4c634bd7c0cc7d1ed9a6c1148f63fa79f7dfcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637616 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change extends the PasswordManager.BulkCheck.CanceledCredentials and PasswordManager.OsPasswordStatus histograms. R=chromium-metrics-reviews@google.com Fixed: 1160745, 1167775 Change-Id: I2310afe4516b85fdbe9927cd03df267daf7d30ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637696 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Jarryd authored
Bug: 1165235 Change-Id: I71582edc502c7bdee6b8826c5425de3bf2279d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632854 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
