- 22 Oct, 2020 40 commits
-
-
W. James MacLean authored
At present ChildProcessSecurityPolicyImpl::SecurityState stores only a single BrowsingInstanceID (the lowest) even though its associated process may contain multiple BrowsingInstances. This may lead CanAccessDataForOrigin to consider the wrong BrowsingInstance when performing its checks for opt-in isolated origins. This CL converts SecurityState to track an ordered set of all the BrowsingInstanceIDs so that they can all be checked. CanAccessDataForOrigin is modified to return 'true' if *any* BrowsingInstance in the set would allow the access, otherwise it returns 'false', and logs the failure reasons for each of the BrowsingInstances. This CL also includes delayed cleanup of BrowsingInstance state from ChildProcessSecurityPolicy when BrowsingInstances are deleted. This avoids memory leaks but may pose a small risk of renderer kills. We will monitor the CanAccessDataForOrigin crash keys to see if such cases occur in practice. Bug: 1135539 Change-Id: Icb7d25a84601b378c0c495a19266cd013667136a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446370Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#819830}
-
Elizabeth Popova authored
AddressEditor.Purpose.AUTOFILL_ASSISTANT is defined but no longer used. Now autofill assistant uses AddressEditor.Purpose.PAYMENT_REQUEST, see [1]. [1]https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/features/autofill_assistant/java/src/org/chromium/chrome/browser/autofill_assistant/user_data/AssistantCollectUserDataBinder.java;l=672 Change-Id: Idb67ca782c7c9f28d24e3bda722ac31d2f77a736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489994Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#819829}
-
W. James MacLean authored
Bug: 1092510 Change-Id: I0b7d7c4ea94f91767fd2a4e6c7c807bfc73a8fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490226Reviewed-by:
-
Matt Menke authored
LoadTimingBrowserTest.HTTP is flaking for unknown reasons. The only unusual thing it obviously does before it hangs is use the chunked handler in the SpawnedTestServer. We want to reduce usage of that test server, anyways, so this adds an equivalent handler to the EmbeddedTestServer. This CL also removes the legacy chunked handled from the SpawnedTestServer, and migrates the small number of consumers off of the SpawnedTestServer. Bug: 1138769 Change-Id: Ia63be2326349f2019a1052cc04e9a708f9a2f4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481702Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819827}
-
Ioana Pandele authored
Bug: 1141018 Change-Id: I44c9516636f5ab8c3610aa272b725329c2fe911c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489912Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#819826}
-
Ben Mason authored
This reverts commit 54eea645. Reason for revert: Rejected by Play: crbug/1141430 Original change's description: > Reland "Enable isolated splits in canary" > > This is a reland of b9d174e5 > > This time component builds should be actually fixed with > http://crrev.com/c/2490668. > > Original change's description: > > Enable isolated splits in canary > > > > All known issues have been fixed so enabling this in canary to see if > > there are any major problems. > > > > Bug: 1126301 > > Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144 > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819200} > > TBR=agrieve@chromium.org > > Bug: 1126301 > Change-Id: I71afd73c704deb6c7d65a76c6ea8a2b6f0b6fb57 > Cq-Include-Trybots: luci.chromium.try:android-pie-arm64-dbg > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490871 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819681} TBR=agrieve@chromium.org,cduvall@chromium.org Change-Id: I99bddb7d0f1a370ce811f212159b04b98aa7ad49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126301 Cq-Include-Trybots: luci.chromium.try:android-pie-arm64-dbg Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489998Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#819825}
-
Jan Krcal authored
This CL introduces a timeout so that profile creation is not blocked on the lack of extended account info. This is useful when the request gets blocked by a firewall, etc. When this happens, the account email address is used as the name of the new profile instead of the account's given name. Bug: 1126913 Change-Id: I6e251caed78800ee075295f6677c7db3d7d44d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489911 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#819824}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603346243-3f07f08fc669370b6060ed7693324b959ad870ad.profdata to chrome-linux-master-1603367983-f14ef1ec6eb1e2af5431460b8d6073dd67a6ea14.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0e84091ec11695ae6eb78cc9a751e7fcdd68305a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491962Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819823}
-
Camillo Bruni authored
Preparation for landing https://crrev.com/c/2487123 which changes the error location for failing module imports. Bug: v8:6513 Change-Id: I4ad7dc72782b9cb94bd4effbc447627f4944044d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489993Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#819822}
-
David Bienvenu authored
This is an attempt to fix oom crashes in SetRegValueWorkItem::DoImpl when the current registry value for keys it is trying to set are ginormous. When rollback is disabled, DoImpl doesn't need to read the current value, and thus hit OOM. Bug: 1106328 Change-Id: Id70bc05732ce7e1401d5fe706f81e1f9f1283087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488923Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819821}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c5210c268e2..ae7f748fc467 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC beverloo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1115604,chromium:1138425 Tbr: beverloo@google.com Change-Id: Id3c363f03781eedb33a332941a5b6cf505ea0c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491667Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819820}
-
Matt Jones authored
This patch simplifies the SceneOverlay API by providing the LayerTitleCache to the LayoutManager and directly to the features that actually need it. Bug: 1070281 Change-Id: I564c4b8d91f2c5026e97163e4b4532421f08af4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480882Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819819}
-
Tanmoy Mollik authored
Remove unused class SyncOffPreference and the resource xml file that is only used in this class. Bug: 1139896 Change-Id: I0ce6ecf5203f8c682e4f965ffe66e57204dcf5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484450Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#819818}
-
Monica Basta authored
This CL deletes 'signin_icons' and replaces all usage of 'signin:business' with 'cr:domain'. Change-Id: Ifa234f23af00f0d45e2b528ad4b1d37f3568f2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490045Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#819817}
-
Javier Ernesto Flores Robles authored
bug: 1138710 Change-Id: I9c1c787837d6c64e7ef88c66bf9070bb7d073547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477236Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#819816}
-
Reilly Grant authored
These tests were broken by User Activation v2 because they assumed that an activation is inherited by cross-origin child frames. The tests have been updated to use test_driver.click() in the iframe to create their own activation. Bug: 860713 Change-Id: I5b3d6d17d97098eaa1689e77f5fc112002f76795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491683 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#819815}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ded46963acfa..4492cf287a23 2020-10-22 yangguo@chromium.org [ts] Type-check DOMStorageItemsView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79edc4380cb34c8d5325e35e4443ea112a476642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491355Reviewed-by:
-
Palak Agarwal authored
Change-Id: I5b7ee18f7f497d787998bde8408d46987a45a6eb Bug: 1136714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463833 Commit-Queue: Palak Agarwal <agpalak@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#819813}
-
Matt Menke authored
Add NetworkIsolationKey to Network Error Logging policies. This CL modifies the NelPolicy struct representing a NEL policy, by replacing the origin field with a (NetworkIsolationKey, origin) tuple. The policies are stored in the NetworkErrorLoggingService map of policies by this new key, instead of just origin. Bug: 993805 TBR: msramek@chromium.org Change-Id: If5e8d61aec8cf6325e2cf707b12e5b5a79fb67a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485531 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#819812}
-
Tanmoy Mollik authored
The test failed because of 4 pixel mismatches on the corners of the rendered images. To the naked eye they look identical. Enabling the test as it might be golden render issue. This is a reland of 7201dc96 Original change's description: > [Android] Add render test for sync promo in MainSettings > > This cl adds a render test to check that sync promo is shown when the > user has signed in with without sync consent. > > Bug: 1105800 > Change-Id: I24bb2a78f84ebf39586fbe285bc7361ecba30cc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467878 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817018} Bug: 1105800 Change-Id: Iacdd454607f1f755c38f25531dd9a8bc8fd0dd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484431Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Andrew Grieve authored
This reverts commit b47e9c83. Reason for reland: Updated more .pydeps files. Original change's description: > Revert "Android: Use locally-build devil deps only when build_with_chromium=true" > > This reverts commit 49fdeca1. > > Reason for revert: Breaking presubmit due to stale .pydeps file: > android_webview/tools/run_cts.pydeps > > Original change's description: > > Android: Use locally-build devil deps only when build_with_chromium=true > > > > Bug: 1120190 > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819489} > > TBR=agrieve@chromium.org,bpastene@chromium.org > > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1120190 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819668} TBR=agrieve # reland Bug: 1120190 Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819810}
-
Danila Kuzmin authored
Bug: 1134822 Change-Id: I8fdae2162564b787a9d484b58cb687cf6c8d5b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470878Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#819809}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d74754378f09..1c7f0284516a 2020-10-22 lexa.knyazev@gmail.com Vulkan: Fix invalid clamping of ES3 clear stencil values If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I70098b4bf6c9d9f42b4850528332331d99f0a4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491354Reviewed-by:
-
Josh Nohle authored
Before this CL, failed or cancelled send attempts resulted in duplicate share targets in the UI on the next send attempt. The root cause of this behavior was that the share target from the failed/cancelled attempt was overwritten in the endpoint-ID --> outgoing-share-target map during the second share attempt (using the same endpoint ID), and observers were not notified that the previous share target was removed. In this CL, we handle removal of outgoing share targets in a consistent way. The removal process is as follows: - The share target is removed from the |outgoing_share_target_map_|. - File payloads are released. - The share target info is removed from |outgoing_share_target_info_map_|. - Send-discovery observers are notified that a share target was lost. Fixed: 1133824 Change-Id: Ia5faf674ae50e86a1d813d4e2f58d770248c95b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491221Reviewed-by:James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#819807}
-
W. James MacLean authored
These UMA metrics have expired, so this CL removes them. Bug: 988806 Change-Id: Ia59e475097e5b5eb8dd4b6e5b79b4835ce87d987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490246Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#819806}
-
sandromaggi authored
Previously, each step resolved the element anew. Now the element is resolved once and used throughout the action to perform actions on. Bug: b/168107066 Change-Id: I4def429d89251cda5831cd5ca8268cf2bcf0ebab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485211 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#819805}
-
Peter Kasting authored
This includes changing some ButtonPressed overrides to callbacks as well as updating various comments. Bug: 772945 Change-Id: I404e8715ad8aff3078b9e525a77ca921e1941186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490844Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#819804}
-
Jordan Oroshiba authored
Removing the button for clearing cookies to make the cookie line item have a trash can icon and do the delete action. Screenshots: https://crbug.com/1077766#c76 Bug: 1077766 Change-Id: I85f98871a74c18a07624e4a5db4b5634026736be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472923 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#819803}
-
Kazuki Takise authored
Although PIP windows are not supposed to be resized by Chrome, because of vaious off-by-one issues, some bounds move events for PIP windows are currently considered to be BOUNDS_CHANGE_REASON_RESIZE, and Android rejects those events as the window is already in PIP. BUG=b:171361297 TEST=Manually confirmed the bounds of PIP matches between Android and Chrome Change-Id: I62d2909f32143e5369587de2ea8abf5748b82233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488263 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#819802}
-
Ramin Halavati authored
ProfileManager unittests are updated to cover ephemeral Guest profiles, and Guest profile names are updated to be different from regular profile names. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I11b868925e47135e6773b75f0d298f3311f52e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483827Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Wojciech Bielawski authored
Summary: Jinja2 already supports python3, but templates must be aware of environment they're run on. This commit fixes 'str object' has no attribute 'values' error when template is rendered using python3 Bug: 1138872 Change-Id: Iaf2f660369ff4857ee3307825944cf1d2accef3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475118 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#819800}
-
Morten Stenshorne authored
This is a reland of 772dfcc1 See crbug.com/1140604 - Pretty sure this was unrelated to this CL, but now it's been fixed anyway. Original change's description: > Enable "gn check" for //third_party/blink/renderer/core > > Bug: 800764 > Change-Id: I54f490a37baee7f8e98198fa28794aa216f9f33c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469563 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818849} Bug: 800764 Change-Id: I6c451a2c4637471170c64b378c06c09a5aa0814b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491361Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#819799}
-
Rohit Agarwal authored
This CL: 1) Explicitly makes use of getPrimaryOTRProfile for tests relying on primary OTR profile instead of getOffTheRecordProfile. 2) Adds a tests for non primary OTR profile. 3) This CL also simplifies OfflinePageBrideTest by not launching the incognito CCT and just creating the non primary OTR profile. Bug: 1060940 Change-Id: I0adbddbcb0435e55d4f15f79d0823ea920d20f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489988Reviewed-by:
-
Keishi Hattori authored
Temporarily use CHECK in SetFreelistHead to debug a crash. Should be reverted after a Canary release. Bug: 1137799 Change-Id: I9e01a5cdfafb7da2af76997f8c42716394ac4cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491724Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Introduce a new mixing 'ios_cpu_x64_x86' used to configure fat builds with "x86_64" and "i386" architecture instead of using two mixins. This will allow changing how fat builds are configured to use a special value for `target_cpu` instead of using two separate variables. This should be a no-op on the bots since the generated args.gn will be identical after the change. Bug: 1040487 Change-Id: I46ebd383ee13449a3ccb1e1b3eccbc486b2fbe9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489907 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#819796}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603291852-8226e53db1ad923442028152d5859381e4c42533.profdata to chrome-win64-master-1603335567-5b7ae75a80b56b2c3e08e562ca96c9be42987f9c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8584eb98eece32007aab9f354377ca639367a944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490859Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9be16a326a9b..ef6970472eb9 2020-10-22 landrey@webrtc.org Get rid of redundant async in token state update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114055 Tbr: oysteine@google.com Change-Id: Ie8cb2769ff7709c604dc307bcf80ec5593ff2282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491920Reviewed-by:
-
Simon Zünd authored
Various places in Chromium collect and symbolize V8 stack traces. This could be DevTools or heavy ads instrumentation. To get better insights we want to add some trace events around stack trace capturing and symbolization under a new, disabled by default, tracing category. Corresponding V8 CL: https://crrev.com/c/2491028 R=petermarshall@chromium.org Change-Id: I266b0783dcf6266efc512503b7b13044bd8b71c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490044Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#819793}
-
Boris Sazonov authored
Changes AccountPickerBottomSheetCoordinator argument from Context to Activity. This ensures that the view is never inflated using an themeless context. This is a tentative fix for an intermittent issue when AccountPickerBottomSheetView rows don't have a ripple animation. Bug: 1141000 Change-Id: Idc63fdac6dde06e912d57bcf8ef0bc1572ca968d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489904 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819792}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I17cb6028040ca5e89d806acc85863ccf6e9ad9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491512Reviewed-by:
-
