- 27 Jul, 2010 40 commits
-
-
dmazzoni@chromium.org authored
alphabetization. Note that the F1 key is the "Back" key on Chrome OS, and F2 is "Forwards". BUG=none TEST=none Review URL: http://codereview.chromium.org/2878059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53827 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Doing the most simple eliding, which is to truncate and replace with ellipses on a character basis. I put this in the code rather than the .xib because this seems like it should be a hard-wired Omnibox behavior. BUG=50253 TEST=Put in a very long URL and check that it elides as the window gets too small for it to fit. You can easily craft long URLs by adding # and filling with whatever you desire after that. Review URL: http://codereview.chromium.org/3010031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53826 0039d316-1c4b-4281-b951-d872f2087c98
-
agayev@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/3035032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53825 0039d316-1c4b-4281-b951-d872f2087c98
-
sanjeevr@chromium.org authored
Exposed an IsEnabledAt for ButtonMenuItemModel (this is not used yet, will be used in a subsequent checkin). The Mac wrench menu zoom controls honor the global enabled state of the zoom commands. BUG=None. TEST=Open a PDF using the internal PDF viewer on the Mac. The Zoom controls on the Wrench menu should be disabled. Review URL: http://codereview.chromium.org/3026025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53824 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
BUG=20504 TEST=greener valgrind TBR=evan@chromium.org,mark@chromium.org Review URL: http://codereview.chromium.org/3020036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53823 0039d316-1c4b-4281-b951-d872f2087c98
-
dhg@chromium.org authored
BUG=4994 TEST=none Review URL: http://codereview.chromium.org/3043024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53821 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
A field of the ViewHostMsg_Resource_Request structure was uninitialized. Also, includes a fix for an ASSERT_EQ that listed the expected value second instead of first. R=oshima BUG=50002 TEST=none Review URL: http://codereview.chromium.org/3052014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53820 0039d316-1c4b-4281-b951-d872f2087c98
-
ahendrickson@google.com authored
This covers the cases using GSSAPI for Negotiate to authenticate to a proxy, where: - The user does not have a TGT (Ticket Generating Ticket), or - The user is unable to get to the TGS (Ticket Granting Server). The bug was that the authentication system tried to reuse the Negotiate handler even though it was not possible for it to succeed, leading to infinite retries. BUG=33033 Test=None Review URL: http://codereview.chromium.org/3040015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53819 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Basically verifies that our assumptions on how FFmpeg works opening/seeking/parsing files remain intact. BUG=19865 TEST=run ffmpeg_unittests :) Review URL: http://codereview.chromium.org/3058004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53818 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
This fails on all platforms, not just Mac. BUG=48148 Review URL: http://codereview.chromium.org/3036022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53815 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
TEST=try BUG=none Review URL: http://codereview.chromium.org/2856063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53813 0039d316-1c4b-4281-b951-d872f2087c98
-
pathorn@chromium.org authored
BUG=43624 TEST=Able to run 'PYTHONPATH=third_party/tlslite:third_party/pyftpdlib python net/tools/testserver/testserver.py --data-dir=chrome/test/data/' Review URL: http://codereview.chromium.org/3014036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53812 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
update. The strings being removed are all unused and were not added recently. BUG=none TEST=Ideally, this will not cause test failures on Windows. This change is actually the TEST= of a build tool upgrade. Review URL: http://codereview.chromium.org/3064011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53811 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
TEST=try BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53810 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
The DEPTH attribute works fine as long as you're building the base library from the chrome src directory (which the vast majority of people do). If, however, you're trying to build it as a dependency in another project (as I am for the webtest-plugin project), the DEPTH attribute does not work. The relative path builds correctly in both situations. Review URL: http://codereview.chromium.org/2868068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53809 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
- make the code more object-oriented, make the object expose less accessors - make some parts of code look more obvious, use existing helpers - make the public interfaces slightly better (less ctor parameters) - make some names slightly better TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3029025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53808 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
BUG=49091 TEST='Manage' button in DOMUI Basics prefs should bring up an empty sub-page. Review URL: http://codereview.chromium.org/2806081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53807 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
- remove obsolete workaround for us opening two data connections, we no longer do this - add comments explaining the 599 FTP error code BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3057012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53806 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Bumped ANGLE rev in which shader translator API changed. Updated shader translation code to reuse compilers for performance. Review URL: http://codereview.chromium.org/3035028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53805 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@google.com authored
TBR: arv BUG=49328 TEST=no bookmark bar promo on first run to empty profile. or ever. Review URL: http://codereview.chromium.org/3053015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53804 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
BUG=29675 TEST=none TBR=evan@chromium.org,willchan@chromium.org Review URL: http://codereview.chromium.org/2884041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53801 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
BUG=29675 TEST=greener valgrind TBR=evan@chromium.org Review URL: http://codereview.chromium.org/2870072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53800 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
This is a speculative/defensive fix for bug 49274. BUG=49274 TEST=manual (checked that this didn't break normal behavior) Review URL: http://codereview.chromium.org/3054018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53799 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=50307 TEST=none Review URL: http://codereview.chromium.org/3020034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53798 0039d316-1c4b-4281-b951-d872f2087c98
-
nshkrob@chromium.org authored
BUG=none TEST=TopSitesTest Review URL: http://codereview.chromium.org/3039029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53796 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@google.com authored
Turn on SK_USE_FLOATBITS for Skia to force safe float-to-int conversions. This is a temporary change until Skia supports saturating float->int conversions. [Landed on behalf of wjmaclean] TEST= existing layout tests BUG= WebKit 25645 (https://bugs.webkit.org/show_bug.cgi?id=25645) Review URL: http://codereview.chromium.org/3014039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53795 0039d316-1c4b-4281-b951-d872f2087c98
-
http://crbug.com/49862wtc@chromium.org authored
R=vandebo BUG=49862 TEST=none Review URL: http://codereview.chromium.org/3072003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53794 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=compile BUG=44549 Review URL: http://codereview.chromium.org/3064007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53793 0039d316-1c4b-4281-b951-d872f2087c98
-
alyssad@chromium.org authored
Review URL: http://codereview.chromium.org/3026016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53791 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
--host-rules seems like a reasonable enough substitute for these two command line flags, and removing them will simplifies the fairly complicated URL rewrite logic in HttpNetworkTransaction. BUG=None TEST=built and ran net_unittests Review URL: http://codereview.chromium.org/3041019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53790 0039d316-1c4b-4281-b951-d872f2087c98
-
cmasone@google.com authored
Also, increase login timeout. BUG=None TEST=unit tests Review URL: http://codereview.chromium.org/3061019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53789 0039d316-1c4b-4281-b951-d872f2087c98
-
craig.schlenter@chromium.org authored
Patch is 99% the same as spotrh's version (thanks spot!) except for the use of gfx::kNullPluginWindow in this version. BUG=49533 Review URL: http://codereview.chromium.org/3014034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53788 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
We had a leftover call to InPlaceMenuDestroy without creating a menu in the first place. This caused us to delete IE's menu and fail the first check inside ieframe!CDocObjectHost::OnInitMenuPopup. It took a while to figure this out and even longer to figure out why our menu was NULL in this case and not mshtml's. I don't think that there are any bad side effects with this change but I ask the reviewer to check. The visible change is that the Print menu item will become enabled and visible whereas Page Setup will be disabled and Print Preview will (correctly atm) not be visible for GCF documents. BUG=24034, 47074 TEST=See description above and bug report. Review URL: http://codereview.chromium.org/3034033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53786 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
encoding menu on those pages. BUG=48157 TEST=On the NTP, Wrench menu --> Tools --> Encoding is disabled. On normal web pages, it isn't. Review URL: http://codereview.chromium.org/3027023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53785 0039d316-1c4b-4281-b951-d872f2087c98
-
agayev@chromium.org authored
BUG=49683 TEST=None Review URL: http://codereview.chromium.org/3035015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53784 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Add "MainMessageLoopStart()" and related platform methods to handle tasks directly tied to the start of the main message loop. BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/2931007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53783 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
I was previously sloppy with DNSDomainFromDot. Really it should have included a terminating NUL in the result string to represent the root label, but it actually omitted it because it was more convenient to test that way. This CL fixes that. BUG=none TEST=net_unittests http://codereview.chromium.org/3070002/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53782 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/3044022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53781 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
As of r2200 (in Chromium SVN now), the default value is "no". As of r2344 (planned to check-in soon), the default value is "yes" but some false positive reports are not yet eliminated for this mode. BUG=http://code.google.com/p/data-race-test/issues/detail?id=40 Review URL: http://codereview.chromium.org/3041024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53780 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
Review URL: http://codereview.chromium.org/3043020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53779 0039d316-1c4b-4281-b951-d872f2087c98
-