- 05 Dec, 2017 40 commits
-
-
Alexandr Ilin authored
The test is flaky on Lollipop Phone Tester Bug: 774451 Change-Id: Idebf57f1a19b991d2e437b0feaed4dff1dd1c21d TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/809045Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521696}
-
Eric Seckler authored
Bug: none TBR: skyostil@chromium.org Change-Id: Ic7973be016e3f2bb7387ac1481934cc7fc0f138f Reviewed-on: https://chromium-review.googlesource.com/809104Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#521695}
-
Ken Buchanan authored
The element visibility observer posts visibility updates to RemoteFrameView. Based on crash reports, it looks like these can sometimes arrive after the RemoteFrame has been removed from the frame tree, making the FrameClient inaccessible. This CL causes an early return in that case, avoiding a null pointer dereference. Bug: 789460 Change-Id: Ibe82253859a9c0f90917331532dac39ba90fd364 Reviewed-on: https://chromium-review.googlesource.com/806363Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521694}
-
Dianna Hu authored
This CL lands server change 177311740 by clshepherd. BUG=488484 Change-Id: I257a10f801e375453d38c05f9f6c84514782a5a6 Reviewed-on: https://chromium-review.googlesource.com/807145 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521693}
-
Andrew Grieve authored
Change-Id: I46a33d40a6f5ea96b905268a548e1c0c09c01f2c Reviewed-on: https://chromium-review.googlesource.com/809024Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#521692}
-
Vaclav Brozek authored
SavePasswordsPreferences never registers itself as an OnPreferenceChangeListener so its onPreferenceChange method never gets called. This CL removes that dead code. Note that OnPreferenceChangeListener is still used in-line, so the import is not removed. Bug: 788701 Change-Id: I87ae4f6be3e2dc4322fad56551338b0a8355e062 Reviewed-on: https://chromium-review.googlesource.com/808265Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521691}
-
Ned Nguyen authored
Bug: 787500 Change-Id: I2966d90b7d9353c91f72b7bf09e1d5e6d120ebc3 Reviewed-on: https://chromium-review.googlesource.com/808544Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#521690}
-
Dominik Röttsches authored
This includes performance fixes for hb_set. After this lands, we need to inspect the graphs for issue 782220 and 781794 to see if performance regressions return. Previously, these performance regressions were fixed by reverting to the old hb_set implementation, compare https://chromium-review.googlesource.com/c/chromium/src/+/804374. 1.7.2 also includes an additional API that allows setting the CTFont directly, and should help with issue 785522. Bug: 791915 Change-Id: I447c1527d81e01c01253d0c3fa5b8c8b3a5a3683 Tbr: behdad, eae, kojii Reviewed-on: https://chromium-review.googlesource.com/807986 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#521689}
-
Justin Cohen authored
Although the omnibox popup itself honors safe are in the table view, the width of the omnibox pop text can be too wide. Bug: 787164 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If10523863a4ffd404a8c255bbad6b5219aa534e1 Reviewed-on: https://chromium-review.googlesource.com/807784Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521688}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f5d857d3..b88605f7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2da8e2cd62c4e972b305a1215b984266d992f5f9 Reviewed-on: https://chromium-review.googlesource.com/808624Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521687}
-
Henrik Grunell authored
Speculatively re-enable based on comment #5 in the bug. TBR=guidou@chromium.org Bug: 783790 Change-Id: Ie10aa49212a4279a8696dfbc021a577bda0a2dfd Reviewed-on: https://chromium-review.googlesource.com/808845Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521686}
-
Kevin Bailey authored
std::make_unique is preferred over base::MakeUnique, and allows one less include. Bug: Change-Id: Ibf3f6c1b061d4e53331ff976c0966b0773dcf80f Reviewed-on: https://chromium-review.googlesource.com/806414 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521685}
-
Lalit Maganti authored
The iterator should work on the scope of the entire graph as it relies on shared visited set between processes to do its job. Bug: 768373 Change-Id: I2be92608c8d709464a32f8f35a10cd5686fc7af9 Reviewed-on: https://chromium-review.googlesource.com/788870Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Lalit Maganti <lalitm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521684}
-
Jonathan Backer authored
This is part of a larger refactoring. The overall call is to have two Stub implementations in the GPU process: - a RasterInterface client will have a RasterCmdBuffStub on the server side and - a GLES2Interface client will have a GLES2CmdBuffStub on the server side Rationale for having different stubs are that they are coupled to the decoder, context, and scheduling. In the future, the RasterInterface backend will diverge from the GLES2Interface backed in these respects. Step 1: Create CommandBufferStub class. Step 2 (separate CL): Have GLES2CmdBuffStub and RasterCmdBuffStub inherit from CommandBufferStub (see crrev.com/c/796951 for WIP patch). BUG=789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic15f80bed7fc0e7e4637832378e6502a77568c73 Reviewed-on: https://chromium-review.googlesource.com/806719 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#521683}
-
Guido Urdaneta authored
This CL introduces functions to get the ID name of the following special devices in AudioManager. - Default audio input device - Communications audio input device - Communications audio output device There was already a similar function for the default audio output device. In enumeration results, the label of special device entries now have appended the label of the corresponding real device. This CL also adds implementation of the new functionality for Mac, and reverts the effects of http://crrev.com/520087, which implemented similar but more limited functionality. Bug: 780492 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iee5afc2fc231913baddaf6ef3fedd4535b3d9841 Reviewed-on: https://chromium-review.googlesource.com/803814Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#521682}
-
Greg Thompson authored
BUG=791981 TBR=dmazzoni@chromium.org NOTRY=true Change-Id: I325920f109ae515a43eef3fcd10760e736e4114d Reviewed-on: https://chromium-review.googlesource.com/808705Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521681}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/4ba80741d0fc..e0dc203974cd $ git log 4ba80741d..e0dc20397 --date=short --no-merges --format='%ad %ae %s' 2017-11-24 mythria Remove v8.compile trace event based contribution to eqt metrics Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id44cc34881d8bab3b99557b505875efcddc1c587 Reviewed-on: https://chromium-review.googlesource.com/808424 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521680}
-
Harald Alvestrand authored
Closed objects with no references are garbage collected. Non-closed objects are not garbage collected. NOTE: This uses a very primitive mechanism (static variable) for collecting the count. It should use a more reasonable one, and the accessor should be marked "only visible in testing". Advice on how to best do that appreciated. Bug: 782099 Change-Id: If44f9e6ecaabc8f0dfebe3ee959c5179308f2b0b Reviewed-on: https://chromium-review.googlesource.com/806195Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#521679}
-
Patrik Höglund authored
The test doesn't do anything and hasn't for a while. I don't think it can be salvaged because it's inherently a performance test. It will inevitably be flaky. We do have performance tests that cover frame rates, maybe not in the "two getusermedia" case though. Bug: 789121 Change-Id: I483096ed8ac18f4572245f93d1f2b2ccb2c473f2 Reviewed-on: https://chromium-review.googlesource.com/803348Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#521678}
-
Sarath Singapati authored
HistoryService::GetHistoryCount() takes period endtime instead of Time::Max(). Added unittest for history deletion. Bug: 243833 Change-Id: If804a5b17b1f34d985d4a46a6d77a33fd39c0cdc Reviewed-on: https://chromium-review.googlesource.com/780219Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Sarath Singapati <sarath.singapati@huawei.com> Cr-Commit-Position: refs/heads/master@{#521677}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 45000d23. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6947 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: Ideba72d07879400cffde88c8deca1a4f6bbaa320 Reviewed-on: https://chromium-review.googlesource.com/808065 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521676}
-
Morten Stenshorne authored
Allows for narrower windows without causing scrollbar issues. Blink uses 800px when running layout tests. Bug: 788337 Change-Id: I7abd46699d1d58511ec3489f180f8733d3f7f1c3 Reviewed-on: https://chromium-review.googlesource.com/808306Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521675}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb9e2b3a..f5d857d3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia852333d38cf3fc924d7aaf5f9e1026c3f0477c3 Reviewed-on: https://chromium-review.googlesource.com/808064Reviewed-by:
-
Rune Lillesveen authored
A text node gets its style from its flat tree parent. The problem is that our layout code expects the LayoutObject parent to have the same inherited styles as the text node. That is not the case if a text node has display:contents ancestors and the display:contents parent does not have the same inherited styles as the closest ancestor generating a box. Example: <div> <div style="display:contents;font-size:50px">Text</div> </div> We're solving this by inserting an anonymous inline between the LayoutText and its parent LayoutObject. We do not try to merge inline wrappers for subsequent text nodes, so for: <div style="display:contents:color:pink">A<!-- -->B</div> we create one wrapper for each of A and B, even though one would suffice. We attach and detach these wrappers on-demand, so if, for instance, the inherited computed styles of the display:contents change so that it matches the computed styles of the LayoutObject parent, we detach the wrapper as it's no longer needed. We also currently detach the wrapper when the computed style of the display:contents and hence the computed style of the wrapper changes. We could have optimized this through more checking and SetStyle on the anonymous wrapper. Bug: 717460, 706316, 709808, 713019 Change-Id: Ia53b9fe2c0a6067c4600dab49cdf43f23b95b8fa Tests: see removed lines from TestExpectations. Reviewed-on: https://chromium-review.googlesource.com/806158 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:Robert Hogan <robhogan@gmail.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#521673}
-
Olivier Robin authored
It is possible for the PasswordController to be detached between the call to GetPageURLAndCheckTrustLevel and the JS completion. In that case, passwordManager is reset and there is a nullptr exception. Bug: 791710 Change-Id: Ibec514aefbaf5fb7a8773cd0254f0bf2f785e06e Reviewed-on: https://chromium-review.googlesource.com/808045Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521672}
-
Christian Dullweber authored
Create a UserConsent object and pass it to the UserEventService. UserConsent objects are whitelisted to not require history sync permission as they don't contain history data. They are also whitelisted to be sent for users who have a passphrase. Bug: 781765 Change-Id: I13800d9b3a28d3acf44052011adcaa3d7ca172fa Reviewed-on: https://chromium-review.googlesource.com/785912Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#521671}
-
Henrik Boström authored
Enable two tests: - WebRtcRtpBrowserTest.AddAndRemoveTracksWithoutStream - WebRtcRtpBrowserTest.AddAndRemoveTracksWithIndividualStreams Also remove the AppendSwitch for "RTCRtpSender", a flag which has been removed and enabled by default. TBR=phoglund@chromium.org Bug: 788760 Change-Id: I2942aed11dca4bf70e4540840ff796def64a3f1d Reviewed-on: https://chromium-review.googlesource.com/808384Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#521670}
-
Koji Ishii authored
Revert "Create NGPhysicalFragment for every SPAN element for LayoutNGPaintFragments runtime feature enabled" This reverts commit 813190a7. Reason for revert: It turned out that this change regressed 387 tests when NGPaintFragment is enabled. Local test here: https://chromium-review.googlesource.com/c/chromium/src/+/802840 The assumption was that this change fixes several failures without any additional failures (after bidi was fixed in CL:802673.) Since the assumption didn't stand, revert this once and we'll revisit again when we have more insights on what's happening. Original change's description: > Create NGPhysicalFragment for every SPAN element for LayoutNGPaintFragments runtime feature enabled > > This patch changes |ShouldCreateBoxFragment()| to return |true| for producing > box fragments for plain SPAN when |LayoutNGPaintFragments| runtime feature > enabled, to locate |NGPhysicalFragment| associated to |LayoutInlinline| for > computing bounding box and other kinds rects. > > Without this patch, we need to traverse fragment tree rooted by > |LayoutBlockFlow| containing |LayoutInline|. > > In legacy layout tree, we don't generate |InlineBox| for |LayoutInline| for > performance optimization and called "Culled InlineBox". To compute rects in > legacy layout tree, we traverse layout tree and line boxes in |LayoutInline|. > This code makes |LayoutInline| implementation complicated. Note: There is a > flag disabling "Culled InlineBox" as |AlwaysCreateLineBoxesForLayoutInline|. > > Once LayoutNG is stable enough to have profiling, we investigate whether > generating fragment for every SPAN causes performance regression or not. > > > [1] http://crrev.com/c/763188: ONE [LayoutNG] Utilize DCHECK(CanUseInlineBox()) > in core/layout/ > > Bug: 789390 > Change-Id: Ife87fc9ee487397891ae4515d1bcaea1afcf9c04 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Reviewed-on: https://chromium-review.googlesource.com/790177 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520865} TBR=yosin@chromium.org,kojii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 789390 Change-Id: I7cdbb2ca7ab9b07718a2ce6b7f998f4b38803f3b Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/807426 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
yosin (OOO Dec 11 to Jan 8) <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521669}
-
Thomas Tangl authored
When DICE is enabled and Sync is not turned on, the user menu should display a view that contains an illustration on top, a promo text and a "Turn on Sync" button. This CL adds this feature. Mocks can be found in the bug report. Additional changes: - Extend the user menu width to 288px when DICE is enabled. - Add unit test for a negative |between_child_spacing| in BoxLayout. Bug: 786369 Change-Id: I816ee93c8b8105182c599e42ca10fd7e413fe62b Reviewed-on: https://chromium-review.googlesource.com/793451 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#521668}
-
Vaclav Brozek authored
The resetList method tries to call PreferenceGroup#removeAll on TextMessagePreference (which is not a PreferenceGroup) if an update of the settings happens while the last state had no saved passwords to display. This is a rare situation because people who have no saved passwords are not very often inspecting their passwords settings, but can happen in reality as well (e.g., when somebody inspects the page during early moments of syncing and Chrome sync populates the page as the user views it). This CL introduces a special method to do the job of resetList in the case there are no lists, and adds a test which executed the invalid cast before the fix. Bug: 788701 Change-Id: I64ada510deb78cc7b8f22f085ef2f401e9bb76ba Reviewed-on: https://chromium-review.googlesource.com/806165 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Roman Sorokin authored
EnterpriseEnrollmentTest.TestAttributePromptPageGetsLoaded EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_UIErrors BUG=chromium:746723 Change-Id: If65f47d6193822c692d1a337621e94944153768d Reviewed-on: https://chromium-review.googlesource.com/803315Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521666}
-
Ned Nguyen authored
This allows us to remove credentials_path later on as it's currently handled by Telemetry's page (https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/page/__init__.py?rcl=a12fb2d1ad961877f3fc1ca4b72965394270419d&l=47) Bug: 787500 Change-Id: I74217522183322fd533aaa0e84c029c9f4b9d2b8 Reviewed-on: https://chromium-review.googlesource.com/806802Reviewed-by:
-
Nicolas Dossou-gbete authored
- Introduces @ChromeHome.Enable and @ChromeHome.Disable - @ChromeHome.Enable automatically causes the test test to be skipped when running on a tablet - @ChromeHome now works for unit tests, ensures the cached state is reset between tests. The plain @ChromeHome should eventually be removed in favour of the dedicated annotations, that will happen in a subsequent cleanup patch. Bug: 783160,754778 Change-Id: I60c69c2fb97a08aa1d0bcf533a8378cbbc1a548b Reviewed-on: https://chromium-review.googlesource.com/796672 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521664}
-
mallikarjun82 authored
Bug: 791427 Change-Id: Ic421215d3e77e1d6381512d29e1457fba15135ca Reviewed-on: https://chromium-review.googlesource.com/796250 Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#521663}
-
Vaclav Brozek authored
The connected base::Features are also used on Android, but the about:flags page is set up to only allow changing it on desktop. This CL adds the possibility to control those two base::Features through about:flags on Android as well. Bug: 788701 Change-Id: Ib6ae924ed453c8ceda746746fb10659d718d18e0 Reviewed-on: https://chromium-review.googlesource.com/808105Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521662}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/3337fb647c42..4ba80741d0fc $ git log 3337fb647..4ba80741d --date=short --no-merges --format='%ad %ae %s' 2017-11-30 perezju [Telemetry] Unify forwarders API and remove public PortPairs Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I93e4dc677f150001cb6fbb11003b05152e8a93ad Reviewed-on: https://chromium-review.googlesource.com/808127 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521661}
-
Koji Ishii authored
This patch supports LayoutInline::LinesVisualOverflowBoundingBox() when LayoutNGPaintFragments is enabled. Layer painting use this function to determine dirty regions. This is a split of CL:803875 to measure the fix impacts. Estimated to fix 385 tests in LayoutNGPaintFragments. Bug: 714962 Change-Id: I2822528a56d116037fd507dc2c086cdb27c50b2e Reviewed-on: https://chromium-review.googlesource.com/807972 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Daniel Bratell authored
X11 header files are infamous for creating macros with common names such as None, True, False, Status, Bool, ... To save oursaves the mess that creates, they are now wrapped in a header, ui/gfx/x/x11.h, which puts those symbols in the x11 namespace and removes the global macros. Bug: 782184 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I10a9acecb8e7adacd170d1080a411bc9d1e49f79 Reviewed-on: https://chromium-review.googlesource.com/806275Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#521659}
-
Scott Chen authored
This CL changes the layout and text that is used in sync-confirmation dialog for the DICE profiles. Screenshot of the UI after the changes: https://imgur.com/a/DxMd6 Bug: 782155 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia04733f23a0b249789cd5dc965358a62514553b5 Reviewed-on: https://chromium-review.googlesource.com/768876Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521658}
-
Morten Stenshorne authored
It's obsoleted by multicol-nested-column-rule-001.xht, according to that test. Bug: 788337 Change-Id: I8a4b324c936d25137e0775164b7bee21b1fdaa0a Reviewed-on: https://chromium-review.googlesource.com/807927Reviewed-by:
-
