- 29 Aug, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/58d77ccd..3e737ddc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iebf7d74d8b7cb0197a8bd1dc2a1b320bed44f294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773412Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691585}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4b46042d2a25..9b593a3406f4 git log 4b46042d2a25..9b593a3406f4 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 rmcilroy@chromium.org [Tracing] Add Main-Thread histograms to runtimeStatsTotalMetric. Created with: gclient setdep -r src/third_party/catapult@9b593a3406f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: None Change-Id: Ifc2579544d1e60b758bcdb39de112d3886dc6ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691584}
-
Dominic Farolino authored
This CL centralizes the cross-origin-prefetch-specific logic to PrefetchURLLoaderService, whereas previously it was split between PrefetchURLLoaderService and PrefetchURLLoader. This does not come with any observable change, however simplifies the implementation in a way that will make the preload-header-on-prefetch code cleaner. This CL also eliminates the PrefetchURLLoaderService::CreateLoaderAndStart method that was called from the network::mojom::URLLoaderFactory override, leaving only the URLLoaderFactory override method left. This is much cleaner, as both were not necessary now that the network service has been enabled by default. Bug: 939317 Change-Id: I06b57222ea02a4ac9594eec1f89700a1011655b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775646 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#691583}
-
Mohamed Amir Yosef authored
This reverts commit 55420155. Reason for revert: I have rolled back one suspect change. Enabling the test again to verify it was indeed the culprit. Original change's description: > Disable SingleClientWalletSyncTest.SameUpdatesAreIgnored on ASan/TSan > > The test is disabled due to high flakiness. > > TBR: treib@chromium.org > Bug: 997912 > Change-Id: Ifa5e1cc89354163622a6a6ca593498c6fe3a6028 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771974 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690763} TBR=treib@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 997912 Change-Id: I275345a29e2917d5abe5a402fa03cac0d107703c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774630Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#691582}
-
Fergal Daly authored
The fix is to always observe the entire container of elements so that if it comes onscreen, we sync. Also remove ResizeObversers on the elements as the cases it was defending against (suddenly expanding onto the screen) are covered by observing the container. Bug: 998480 Change-Id: I0c253453e0b2f642d686c7213a11d152c1f8330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774008Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#691581}
-
Rob Buis authored
Implement the interface mixin between HTML/SVG/etc as specified here: https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement Note that the intention is to rename above HTMLOrSVGElement to HTMLOrForeignElement: https://github.com/whatwg/html/issues/4702 This also removes NoncedElement. Matches WebKit and Firefox. Bug: 835571 Change-Id: I98c7fcf4c081bdee1a861138e03155a77ca37161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655789 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#691580}
-
Findit authored
This reverts commit 06a7200b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 691574 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzA2YTcyMDBiMzcwZjM4ZjM5Yzk3YTQ4MTBkMDkzMWFiNTU5NjAxNGUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/51573 Sample Failed Step: compile Original change's description: > Convert WebSocket to new Mojo types > > This CL converts WebSocketPtr, to new Mojo types and > updates OnConnectionEstablished from websocket.mojom. > > Bug: 955171, 978694 > Change-Id: I82416b209e2380241b64ebd3d829dd8bde5247c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773016 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#691574} Change-Id: I2dcce548233f9cd12bd144a5a2ed613ec2fe31cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171, 978694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775676 Cr-Commit-Position: refs/heads/master@{#691579}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c0cbd328. With Chromium commits locally applied on WPT: 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifa04d7cf4c41984fc8939e14e73951b56bcf27d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773411Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691578}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/228900f8b1e0..7db900e2e78d git log 228900f8b1e0..7db900e2e78d --date=short --no-merges --format='%ad %ae %s' 2019-08-29 sprang@webrtc.org Simplify pacer queue Created with: gclient setdep -r src/third_party/webrtc@7db900e2e78d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I4fccd7bde139e2ae4c217c764e91bdfa7d599725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775104Reviewed-by:
-
Andrei Chulkov authored
Those strings are subject to change before branch point and will be later used for experiments. Bug: 983445 Change-Id: Iaadd1e63732bdc8b67e9c9c4a5286b15ad6df272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771615 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#691576}
-
Oskar Sundbom authored
This reverts commit 20d2671d. Reason for revert: Causes build failures on iOS bots, see: https://crbug.com/999096 Original change's description: > [base] Use FuzzedDataProvider included in LLVM package. > > Bug: 991200 > Change-Id: Iee88e3a81057d509e18a2875a3070c5abc17c959 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774303 > Auto-Submit: Max Moroz <mmoroz@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691207} TBR=thestig@chromium.org,mmoroz@chromium.org Change-Id: I044f8863f8fa7e2bb9e70b0f33e73fdd8bfa2a29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 991200, 999096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776043Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691575}
-
Julie Jeongeun Kim authored
This CL converts WebSocketPtr, to new Mojo types and updates OnConnectionEstablished from websocket.mojom. Bug: 955171, 978694 Change-Id: I82416b209e2380241b64ebd3d829dd8bde5247c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773016 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#691574}
-
Javier Ernesto Flores Robles authored
crrev.com/c/1742139 introduced a regression while fixing the jumping icons bug. While this fixes the new bug, the ability to preload the voice search when pressing down the mic button has been removed. This is removed from iPhones for consistency, because UIBarButtonItem supports only one action, and UIButton can't be used in iPads as described in the original CL. The a11y ID was renamed to something unique. Previously there where 2 views with the same ID at the same time. An internal follow up CL contains the regression test. Bug: 996260, 984905 Change-Id: I07ac763a92b0a462cefe1b1a6dd4119357c77ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768323Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#691573}
-
Mohamed Amir Yosef authored
This reverts commit 5f47f6e7. Reason for revert: Reverting some CLs that are suspect for causing flakiness in the tests Original change's description: > [Sync] Support FCM Invalidations in Sync browser tests > > Change-Id: I43de31210a0e52a39f2b0017e08994ccf1207714 > Bug: 985287 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745997 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689571} TBR=treib@chromium.org,mamir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 985287 Change-Id: Idacca73b390e5fe88fa5a658991c5e3f9c611cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774924Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/03e4f459a98e..dd9f43487e19 git log 03e4f459a98e..dd9f43487e19 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 lalitm@google.com Merge "tests: remove .tmp extension and change location of metric files" Created with: gclient setdep -r src/third_party/perfetto@dd9f43487e19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Iade480f4ab76597e878b1449504466ff3aaa43f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775674Reviewed-by:
-
Juan Antonio Navarro Perez authored
The script can be used independently of Telemetry to process a directory with intermediate results. Also add tests for options parsing/processing in both regular and standalone modes. Bug: 981349 Change-Id: Ic27e3ac538d56f45a5352b7bf866fcf725a49918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760306 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#691570}
-
Michael Lippautz authored
Bug: 982754 Change-Id: I68592a4110322c5d53af343f7d7bf45bf027702e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776019 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691569}
-
Sigurd Schneider authored
This CL adds a new tracing message so DevTools can learn which resources are cached. This is important as cached resources have timing numbers corresponding to the original request, and using those in the timeline view causes distortions. Bug: chromium:996743 Change-Id: I1b9fc8fb931488cb8e02ad69f2a3b9ee09b27ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765511 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#691568}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ca0eac314b80..b58435c6f9d5 git log ca0eac314b80..b58435c6f9d5 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 shaobo.yan@intel.com Vertex buffer stride size needs to be a multiple of 4 bytes Created with: gclient setdep -r src/third_party/dawn@b58435c6f9d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I5f1b0ec8cdceec0c733e2617991dc63633069f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775924Reviewed-by:
-
Morten Stenshorne authored
TBR=eae@chromium.org Bug: 997994, 999022 Change-Id: Ie70fd36df5b308146f42d27d09c89ab06555856d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774628Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#691566}
-
Henrique Ferreiro authored
Finish the migration of blink.mojom.DevToolsSession started at https://crrev.com/c/1748906. Bug: 955171, 978694 Change-Id: Icd73c8a5205afcb8cf42e588450588068ad28297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768518Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#691565}
-
Eric Willigers authored
Most clients of AppBrowserController do not need to include hosted_app_browser_controller.h as app_browser_controller.h is sufficient. TBR=sky@chromium.org Bug: 953540 Change-Id: I6b41d3ec5b78b013d013ba36f5c877a86fe836bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775878Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#691564}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68f2584d937d..144ee522bc79 Created with: gclient setdep -r src-internal@144ee522bc79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I11663828171cea29445128bca05d3bd2f2bc2886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775672Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691563}
-
Jiajie Hu authored
This is a change similar to https://crrev.com/666977, but for indirect drawing instead. Bug: 859249 Change-Id: Id77a08cb3c3135094217ffce7e3c61d9985dc309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772677Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Jiajie Hu <jiajie.hu@intel.com> Cr-Commit-Position: refs/heads/master@{#691562}
-
Kentaro Hara authored
The real cause was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1773403/. This CL reenables the tests. Bug: 997984 Change-Id: I1ba114f71953f9d75363bbb560a7a3472ed92984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772871 Auto-Submit: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#691561}
-
Chih-Yu Huang authored
Port the V4L2SVDA input queue to V4L2Queue, in order to reduce the amount of code in this messy class and make it overall more secure. BUG=990687,938156 TEST=run video_encode_accelerator_unittests on kevin Change-Id: I30f5114b0d3c20e0c6bc22f18269dde4c2596797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741773 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#691560}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0fa8a07ef4a9..9d20c5a52d62 git log 0fa8a07ef4a9..9d20c5a52d62 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 vapier@chromium.org cros_test_lib: make cidb monkey patching dynamic Created with: gclient setdep -r src/third_party/chromite@9d20c5a52d62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib5c1a0cec81420272828f42e06bdf25dc21c1b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775673Reviewed-by:
-
Robbie Gibson authored
The bug is that images with rendering mode UIImageRenderingModeAlwaysTemplate do not automatically respond when the mode changes. To fix this, the view controller will alert the mediator whenever its own mode changes. The mediator can then use this value to get the correct icon from the branded image provider, and update the icon back. Once the bug is fixed, none of this code is necessary, as the image should update automatically through UIKit. Bug: 998090 Change-Id: I4e39f4267724366a26b189112b55ccf9b3b222cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774284Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#691558}
-
chrome://settings/clearBrowserDataTsuyoshi Horo authored
Bug: 935267 Change-Id: Ib395a834742ae38523ab26bae49d5f9b3b8c1552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775857Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Andrei Chulkov authored
The descriptions of the getHeight and getWidth methods of the WebContents class state that the return values are in physical pixels, whereas they are actually in dip. Change-Id: I1b18cf0182f025b6b880e70d13c3265d0f825791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768710Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Andrei Chulkov <achulkov@google.com> Cr-Commit-Position: refs/heads/master@{#691556}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/15fc19d0912d..73422a0a5ee1 git log 15fc19d0912d..73422a0a5ee1 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 stevenperron@google.com Check feature mgr in context consistency check (#2818) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@73422a0a5ee1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cwallez@chromium.org Bug: None Change-Id: Ic9714e54f1fcd2745fc4aa12ec84432e3fa81328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775921Reviewed-by:
-
Henrique Ferreiro authored
Convert the users of the blink::mojom::CopylessPaste interface. Bug: 955171, 978694 Change-Id: I20ddda253bce762f6d6dc34bee2e9e5b5b5d0aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768769Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#691554}
-
Darin Fisher authored
This change reverts WebRtcLoggingHandlerHost to being a ref-counted class so its lifetime can be extended via PostTask. This allows the class to finish its work after the tab or window is closed. As part of this change, WebRtcLoggingHandlerHost is renamed to WebRtcLoggingController since it is no longer a legacy IPC "host" class. This new name better reflects its role in being the main class used to control webrtc logging from the browser-side. Bug: 989458 Change-Id: I9cbac4c93278e597e7a782cd79eb34550ded1c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774052 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#691553}
-
Kent Tamura authored
This CL implements B in the explainer [1]. [1] https://github.com/tkent-google/std-switch/blob/master/README.md#form-submission Bug: 972476 Change-Id: I29e0e820753a8f9a35092dab3e85d88f2736ba43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772852 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#691552}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5d27a6961601..80b1ba63edff git log 5d27a6961601..80b1ba63edff --date=short --no-merges --format='%ad %ae %s' 2019-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src f27bd2aa2e3f..796df2d74e05 (4 commits) 2019-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 15fc19d0912d..73422a0a5ee1 (1 commits) Created with: gclient setdep -r src/third_party/angle@80b1ba63edff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: chromium:None,chromium:None Change-Id: I61310a4ea842c4ab4b8874541ba78b55a3aacf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775922Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts BlobURLStoreAssociatedRequest, BlobURLStoreAssociatedPtr, BlobURLStorePtr, and BlobURLStoreAssociatedRequest to new Mojo types. It updates URLStoreForOrigin from blob_registry.mojom and methods and members with new Mojo types. Bug: 955171, 978694 Change-Id: I4206429d8d46cd9321ec871599818153ef9d1fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772790Reviewed-by:
-
Mohamed Amir Yosef authored
This reverts commit 06142604. Reason for revert: Reverting some CLs that are suspect for causing flakiness in the tests Original change's description: > [Sync] Delete FakeServerInvalidationService > > With the recent introduction of FakeServerInvalidationSender which > excerises FCM-based invalidation production code, the > FakeServerInvalidationService isn't needed anymore. > > Change-Id: I18b8eba337c27d9d3f7a5d12dd101ed5aea0c38f > Bug: 985287 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758242 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689579} TBR=treib@chromium.org,mamir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 985287 Change-Id: Id97b595432f575393bada8692217b8274c370658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776018Reviewed-by:
-
Morten Stenshorne authored
This adds support for the fundamentals required by column-span:all. We still don't attempt to position the spanners correctly. We need to margin-collapse between spanners and calculate the inline position first. We also still don't support breaking between spanners, or between column rows and spanners. This may be necessary if we're nested inside another fragmentation context. Spanners are detected during regular column layout, and will bubble up to the column layout algorithm, where they will be laid out as children, before regular column content resumes. The column content will see the spanner as a forced column break. Some tests now start to fail. Two dynamic tests fail because NGPaintFragment doesn't really understand block fragmentation. One starts to crash, because a spanner causes a break inside the containing block of an out-of-flow positioned descendant, which we have never supported anyway. See crbug.com/996655 Bug: 829028 Change-Id: I60229da59f745dd469bbf104f6f46e5f93e1a1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771909 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#691548}
-
Oskar Sundbom authored
This reverts commit 6268a44d. Reason for revert: Test fails on ChromeOS, see: https://crbug.com/999072 Original change's description: > Hide saved printers when empty > > - The header for saved printers will be hidden when the saved printers > list is empty. > - Adds a browsertest to reflect this change. > > Bug: 993819 > Test: browser tests, end to end manual > Change-Id: I4bbae8f389161a7c3252df09d39380c896413fa2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767488 > Commit-Queue: jimmy gong <jimmyxgong@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Bailey Berro <baileyberro@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691391} TBR=khorimoto@chromium.org,zentaro@chromium.org,baileyberro@chromium.org,jimmyxgong@chromium.org Change-Id: Iee2c84d5e9aacd691bb695229a2c26d8ffff1b2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 993819, 999072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776039Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts LockManagerRequest and LockManagerRequestPtr to new Mojo types. It also replaces using BindingSet with ReceiverSet. Bug: 955171, 978694 Change-Id: Icc5f15537f3eb36deb94a3d26a5ccf2a91990898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771364 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#691546}
-
