- 17 Jun, 2020 40 commits
-
-
Julian Pastarmov authored
Now it returns error messages that contain the actual error code of the OS level issue that caused the call to fail. BUG=1095648 TEST=unit_tests:EnterpriseReportingPrivateGetPersistentSecret* Change-Id: I26a8e5110e75d6c694db33e1f161340108b9c816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247884 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779262}
-
Ioana Pandele authored
This reverts commit 7811e701. Reason for revert: This broke the bots again after the internal change landed. TBR=chouinard@chromium.org Change-Id: I7dadfcf3ae19508156369e1877385be7e54f73ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247730Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#779261}
-
Fergal Daly authored
Add - decl in .h file and impl in .cc - hint about needing CONTENT_EXPORT Change-Id: I463315e961c2c80e713f1aee8e1da72b6d86a5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237436 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#779260}
-
Rayan Kanso authored
Change-Id: I23c43c704aaf3484d495560f0f1659bcc7534916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248565 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#779259}
-
Ioana Pandele authored
TBR=smcgruer@chromium.org Bug: 1095969 Change-Id: I7c7e5bec55dc945b56539f09061598f2208e32bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248682Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Icd6683a7cd408a81b08b02060ecb1b76fc196bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249698Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779257}
-
Christian Dullweber authored
Show account-scoped passwords in Clear Browsing Data. Also some cleanup of other counter code. Bug: 1086433 Change-Id: I4f0fcdb26325d21a080b84cbad909a4c6d4c449a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237932 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779256}
-
Lukasz Anforowicz authored
Before this CL, the list of fields to ignore that we've gathered so far in //tools/clang/rewrite_raw_ptr_fields/fields-to-ignore.txt had two sections: 1) fields manually added to the list 2) fields automatically added to the list, during one of previous runs of the rewriter. This CL removes the second section of the file, because: A) that section has been growing stale B) it is easy to accidentally include the stale section during a rewrite. When we are actually going to start the SomeClass -> CheckedPtr<SomeClass> rewrite, *then* it should be okay to once again save the automatically generated fields-to-ignore.txt (preserving knowledge of the fields that were actually excluded at the time of the rewrite). Bug: 1069567 Change-Id: I9d0a9f411709d7c8a2caebc16e64ef1695a9f410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247143 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#779255}
-
Jose Dapena Paz authored
std::unique_ptr requires including <memory>. Bug: 819294 Change-Id: I0da9f4affbdfd7a55f54e0e1f744b8f4483d386b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248678Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#779254}
-
Maksim Ivanov authored
Avoid assert'ing on the "location" header being non-empty, and restore the original handling (before r746703/r745762) that was treating this as not having the "choose what to sync" option enabled. This header happens to be empty in some browser tests, and also it might potentially be empty in real-world usages. Bug: 1033936, 1054394 Change-Id: I65aaa1a71cd86b5cf80be57a9407bcea41c80bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248192Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#779253}
-
Hitoshi Yoshida authored
This CL updates included files so that the .cc file doesn't rely on included files in v8_trusted_type_policy_options.h. Bug: 839389 Change-Id: Ieb26048f908b5d019902d2159fbae490d140c5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249401 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#779252}
-
Mohamed Amir Yosef authored
This is a reland of 3a58dbb7 after initializing |destination_dropdown_| which caused failures like here https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8877299825241158736/+/steps/unit_tests/0/logs/Deterministic_failure:_PasswordSaveUpdateWithAccountStoreViewTest.OnThemesChangedShouldNotCrashForFederatedCredentials__status_CRASH_/0 Original change's description: > [Password] Add the Account Storage Promo to the Save Bubble > > Screenshot: https://screenshot.googleplex.com/NdctJthyEtR > > Bug: 1044038 > Change-Id: I32a70d3ab46302c1fd2311f79b48c8558fee2e7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220048 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778946} TBR=vasilii@chromium.org,twellington@chromium.org,bcwhite@chromium.org, Bug: 1044038 Change-Id: Ib727d1e9d2c8fad4b38708d3a99dcf37e9910440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247887Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#779251}
-
Sylvain Defresne authored
Downstream code has been converted to overload the version of the method taking base::Time parameter. Remove old int64_t version of the method. Bug: none Change-Id: I744fb0c345aeec963c2ca1f8010713a591680271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245909 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#779250}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2b2b0b86339..26c8e338b587 2020-06-17 patrick.brosset@microsoft.com Introduce a few unit tests for the grid overlay logic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I65bf774752f4ed7cd7d680ae9a51c0084efe88ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249629Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I037c5fa71738596b1527d3e01295a9f7d80594f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249628Reviewed-by:
-
Morten Stenshorne authored
If the legend is shorter than the fieldset's block-start border, there'll be no non-zero gap between the block-start inner edge of the fieldset and its first (regular, non-legend) child, and therefore there should be no class C breakpoint there. https://www.w3.org/TR/css-break-3/#possible-breaks Bug: 875235 Change-Id: Ib5fa61e1f9fa268ed5b542e1734634aa102fa1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246584Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#779247}
-
Fergus Dall authored
Currently the crostini app icon handler returns an error when |allow_placeholder_icon| is true. This should instead cause the handler to refraim from returning any value until the real icon has been loaded from the VM. Bug: 1088393 Change-Id: I6dcb874193ccea91fd539c633940673275466835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226106 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#779246}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/130a852f852b..4d5abe756b88 2020-06-17 treehugger-gerrit@google.com Merge "Change Query page name" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I00febcf5b80299776138da867b89813fa326f09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249562Reviewed-by:
-
Morten Stenshorne authored
We used to only update the appeal of breaking inside a box when inserting an in-flow break, either before/inside an in-flow child, or inside the box itself (if its non-auto remaining block-size was too large to fit). What was missing was when the box itself could fit, and it only had parallel flow breaks. Without this fix, if a float broke inside a block, and the block itself didn't need a break for its own sake, we'd consider the break inside to be a last-resort break (so that we'd try our best to break earlier). Bug: 829028 Change-Id: I5cd5f05ea319a75186c7510bf40dd54b104160b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245911Reviewed-by:
-
Julian Pastarmov authored
This change makes the missing file state an error rather than a success with an empty return value. Also change the error string returned to contain an error code about the type of error that occurred. BUG=1094275 TEST=unit_tests:EnterpriseReportinPrivate* Change-Id: I1b79dfd6f6a89dc27a2465bb1e476bb3ff725457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241544 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
-
David Jean authored
The infobars pop-up in every window, letting the user select where they want the new tab. Once a selection or dismissal is done, all other infobars are dismissed. Bug: 1068482 Change-Id: I39dff75a69ec74258e50516ba246938b6e0c9a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232547 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#779242}
-
Yoav Weiss authored
Prefetched non-cacheable resources get a 5 minutes window in which they can be reused from cache. That enables prefetching them without causing double-downloads. However, currently that window also takes `Age` into account, meaning that resources that are cached by intermediaries don't benefit from the same advantage. This CL fixes that, as well as adds browser tests for this behavior. As the behavior is not specified, no WPTs are added. Change-Id: I2fe6e302ac399816cc0059f43e7ff8f47b206db3 Bug: 1086152 Change-Id: I2fe6e302ac399816cc0059f43e7ff8f47b206db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212209 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#779241}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/52a5f074e9bb..a7112d544b2e 2020-06-16 ehsannas@gmail.com Eliminate branches with condition of OpConstantNull (#3438) 2020-06-16 andreperezmaselco.developer@gmail.com spirv-fuzz: Implement vector shuffle fuzzer pass (#3412) 2020-06-16 andreperezmaselco.developer@gmail.com spirv-fuzz: Add replace linear algebra instruction transformation (#3402) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ib61b7166ea285d1453ed44c131afd887b2eea6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249625Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |selection_test()| in "click-left-of-rtl-wrapping-text.html" for ease of maintenance and help to enable EditingNG. Bug: 679977, 707656 Change-Id: I6c1992fca70d585ed1b27d271085dbbcea87b83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249399 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#779239}
-
Nidhi Jaju authored
The service worker codebase currently uses a lot of GURLs for origins. However, url::Origin should be used for origins instead of GURL where possible due to security decisions. Hence HasRegistrationForOrigin() was changed to take url::Origin as a parameter, and the related fields were also modified. Bug: 1095896 Change-Id: I7843427d163bdf8d1bae6541da86885d29060fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249260 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#779238}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/51487e1e3084..340da1459b4d 2020-06-17 syoussefi@chromium.org Vulkan: Disable 1xMSAA on integer formats too If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Icbfadccda9a033ecdef2143d3f8ab381e02da28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249618Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I9230051efb1a06adae24eb8c12c2cd6b2db461dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249624Reviewed-by:
-
Alice Wang authored
This CL refactors PasswordViewingTypeTest with ChromeBrowserTestRule and SettingsActivityTestRule. Bug: 1094298 Change-Id: Ide55a2cb4e04cb583a3d5203b0b807aa626289c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241690 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#779235}
-
Eric Willigers authored
We add a AppSearchProvider unit test that creates a web app, and searches for it. Bug: 1086827 Change-Id: I2d5d985d2ea1d6ac4b961cbcb46be67102308a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249265 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Rob Schonberger authored
This reads from the switch added in: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2239812 in two places and checks for both compatibility and an appropriate radius polynomial. Unit tests updated to test new code path. Tested on Kohaku device. Bug: chromium:1060051 Change-Id: I089cba14f2dd09ad672615dd3ced4fa4eb70d2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241325 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#779233}
-
Alex Chau authored
- Finch config change will be in http://cl/316466264 - Made SharingPreferVapid enabled by default in Android, and UnidoPreferSync field trial disables SharingPreferVapid Bug: 1044607 Change-Id: I51a98f01d50681231464f0589a1d911763f67a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246679Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#779232}
-
Eric Willigers authored
A debugging message was inadvertantly committed. TBR=dominickn@chromium.org Bug: 1086833 Change-Id: I213a07dc739f252ac079a654868e1cbe1affad84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247949Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592351803-853e31be24ca6a2ab7be452c8083d82053228cd8.profdata to chrome-mac-master-1592373607-cbb56276e9eec8291c1dfc389a85c83bce237656.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7814748ca2f3171e83dd93cfbfcf2cc84f04f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249523 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/36c50114f184..c2b2b0b86339 2020-06-17 kimanh@chromium.org Revert "[DevTools] More info for Service Worker Fetch Responses" 2020-06-17 alexrudenko@chromium.org Update font preview size once the font is loaded 2020-06-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-06-16 alexrudenko@chromium.org DevTools: use detailed tooltip setting for a11y info 2020-06-16 petermarshall@chromium.org Settings: Change 'Selected context only' setting to be persistent 2020-06-16 changhaohan@chromium.org Add Grid adorner V1 in Elements Tab 2020-06-16 sigurds@chromium.org Be resilient againt source maps without mappings 2020-06-16 mathias@chromium.org Use the bundled `node` binary for all npm scripts 2020-06-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-06-16 tvanderlippe@chromium.org Reland "Move rollup configuration to front_end/rollup.config.js" 2020-06-16 sigurds@chromium.org [docs] Add section about e2e-test debugging 2020-06-16 bmeurer@chromium.org [third_party] Roll wasmparser 2.2.2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1043081,chromium:1047356,chromium:1055875,chromium:1066595,chromium:1066772,chromium:1071432,chromium:1074325,chromium:1084578,chromium:1092841,chromium:1095581,chromium:1095582 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib0d57c107334a0e7fde16b15c424d831e3683720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249622Reviewed-by:
-
Harald Alvestrand authored
Note to sheriffs: If this needs to be rolled back because of bot failures, please write an update to https://crbug.com/1091163 to see if we can get that bot also reconfigured. This should only affect bots that run web-platform-tests. Bug: chromium:840659, chromium:1091163 Change-Id: Ide6471967f681b5bf9fd507508d996d8db14a5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246159 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#779228}
-
Alice Wang authored
This CL replaces SigninTestUtil with AccountManagerTestRule in IdentityDiscControllerTest. Bug: 1081644 Change-Id: I366f5b6acd958d64f7b008889989b0afc3bedcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246511 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#779227}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome TBR=chrome-os-gardeners@google.com Change-Id: I21990b80b23acd80ec9fc09be4a7ffdc7ee8dcee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248424Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779226}
-
Anders Hartvoll Ruud authored
This CL introduces CSSIdSelectorValue, and accompanying function in css_parsing_utils which can parse such a value. It's not very different from CSSCustomIdentValue, but my experience with re-using "close enough" CSSValues in the past has been less than optimal, hence I think the proper way to do it is to add a full CSSValue subclass. Bug: 1074052 Change-Id: I54727a339b5525af4107d5217c78281182b825ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238070Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#779225}
-
Yoshifumi Inoue authored
[EditingNG] Make SelectionModifier::{Next,Previous}LinePosition() to move editable to editalbe correctly This patch changes |SelectionModifier::{Next,Previous}LinePosition()| to move editable to editalbe correctly. Before this patch, |{Next,Previous}LinePosition()| use |LayoutText:: PositionForPoint()| to locate caret for the last caret x/y-coordinate and expects to return boundary position of text even if x/y-coordinate is outside of text. However, |LayoutText::PositionForPoint()| returns a position of another item because it uses |LayoutBlockFlow::PositionForPoint()|. After this patch, |{Next,Previous}LinePosition()| uses |NGInlineCursor:: PositionForPointInChild()| to return boundary position when x/y-coordinate is outside of found item. Example: <s>static-1</s><e>|editable-1</e><br> <e>editable-2</e><s>static-2</s> => NextLine Before: <e>editable-2</e><s>|static-2</s> After : <e>editable-2|</e><s>static-2</s> PositionWithAffinity LayoutText::PositionForPoint( const PhysicalPoint& point_in_container) { if (... LayoutNG ...) return ContainingNGBlock()->PositionForPoint(point_in_container); ... Locates in InlineTextBox's for |this| |LayoutText| ... } Bug: 707656 Change-Id: I0a13ce543cfab4d91798f31bdd06de36507eb2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249278 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
Benoit Lize authored
PartitionRootBase now has a single sub-class, which is templated as well. Merge it into PartitionRoot. Bug: 787153 Change-Id: I91193ff0d0112537fd4468e6dda91c846bed0928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246694Reviewed-by:
-
