- 09 Mar, 2020 24 commits
-
-
Maggie Cai authored
This test start failing on multiple linux chrome os bots since 8th March. There is no CL on the blame list that looks suspecious. Disable the test and file a bug for the owner to look at it. BUG=1059626 TBR=afakhry@chromium.org Change-Id: I74770b256c9d6448d7cd3f581f44e8170b3828f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094416Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#748091}
-
Luciano Pacheco authored
When the element has the focus is hidden/removed/disabled the browser moves the focus to <body>, in this situation user doesn't have any visual clue where is the focus. To fix this we move the focus from <body> to file list which is the default element when opening Files app. Use "focusin" and "focusout" in the <body> element, because these two events bubble from any body's child element, whereas "focus" event doesn't. In the event handler we use requestIdleCallback() to give a chance for any synchronous code to finish and potentially set the focus somewhere else other than <body>. Test: browser_tests --gtest_filter="*tabindexFocusBody*" Bug: 1059137,957413 Change-Id: I9563294a3b6c541cf6bd2bba03470041bc8af41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089444Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#748090}
-
Chih-Yu Huang authored
Originally USE_CHROMEOS_MEDIA_ACCELERATION is only used in //media/gpu. We plan to use it at other //media code. This CL moves this buildflag from //media/gpu to //media. Bug: b:149797442 Test: run `gn check` and `ninja chrome` on octopus and kevin boards Change-Id: I7b5139d2cbfe6cdd1242ba82b428865a6af41cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089539Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748089}
-
Bence Béky authored
Bug: 1059073 Change-Id: I0ab1d5a5d311c7e5187acf16021e5a86e3325a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090506 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748088}
-
Zain Afzal authored
Previously for every js file we needed in index.html or app.html we would manually add a .grd entry, then an addResourcePath call and then a script tag in the relevant html file. This was tedious and cluttered up our html and cc files. This CL adds single js files which bundle together the scripts we need in index/app.html, adding more js sources now just involves adding a `// include<>` to the relevant bundle file (i.e media_app_(app|index)_scripts.js). Bug: 1059134, 996088 Change-Id: I972f538b8414b381529543b8d4692cf6c5390328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093957Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#748087}
-
Chih-Yu Huang authored
Currently GpuArcVideoDecodeAccelerator bridges the video codec from ARC++ to a VDA instance. We plan to deprecate to VDA implementation at chromium by new VD implementation. So we temporary need an adapter to convert between these two interfaces, until the GpuArcVideoDecodeAccelerator is ported to the new VD interface. This CL implements VdVideoDecodeAccelerator as the adapter. With this class, GpuArcVideoDecodeAccelerator could bridge the video codec to a VD instance via the adapter. Bug: b:136716838 Test: Pass video_decode_accelerator_tests with following CLs on Kevin and eve Change-Id: I17f8607cc422c682eaad7760f5680a425de90095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913228 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#748086}
-
Noel Gordon authored
Use <cr-action-menu> for the drop-down menu items, style to match non- files-ng menus items (or as close as I could get them). Tune the <cr-action-menu> location to be under elider ... button, then tune its horizontal Location for RTL/LTR. <cr-action-menu> is position absolute and its code needs to calculate widths causing style resolves so our use of offsetLeft offsetWidth etc to locate the menu _does not_ add more style resolves overall. Change the breadcrumb HTML structure (simplify and remove unneeded DOM elements, p:before, p), and JS code to integrate <cr-action-menu>, and have it deal with drop-down menu keyboard/mouse/scroll interactions. Note: <cr-action-menu> handles menu item ARIA. Logical follow-up would be ARIA for the elider ... button itself and consider if we should use <cr-button>, deal with the elider button tap-target size ... Bug: 1035691 Change-Id: Ie241cec3911847be90971d13629fbdf47c54e1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094057Reviewed-by:
-
Kazuki Takise authored
Even if a client sends the post-rotation buffer and new orientation at the same time during screen rotation, currently the orientation lock is reset before the frame with the buffer isn't completely processed. This CL moves the reset logic from OnPostWidgetCommit() to DidReceiveCompositorFrameAck(); BUG=b:118493249 TEST=Manually confirmed display rotation didn't cause black flashes for ARC apps. Change-Id: I470bef456345b67cfee396c80157cc97e852b603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089562 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#748084}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7d20b4450182..532be50b761b git log 7d20b4450182..532be50b761b --date=short --first-parent --format='%ad %ae %s' 2020-03-09 jiawei.shao@intel.com Check bindingType with shader stage when creating default pipeline layout Created with: gclient setdep -r src/third_party/dawn@532be50b761b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ifcf57a3015588e50ae5478c38c05a0d3215a5e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093530Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748083}
-
Hitoshi Yoshida authored
This CL does following refactorings; a) Filter usable events in .py at the beginning b) Reduce the number of include files based on a) c) Remove an unnecessary branch Before this CL, make_event_factory.py filtered events to iterate in template system. Beside it, the code also iterated all given events to generate included files. As a result, a generated file included many unnecessary header files. After this CL, the code makes a list of events to work for, and does every iteration over it. Bug: 839389 Change-Id: I095a1c8e7b3a403687129160acca2f8ef880eb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089545Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#748082}
-
Nicholas Verne authored
If Chrome crashes while crostini is running, old mount points for the sshfs file system are still polluting mtab, and if we don't remove them here, then on restarting the VM we still won't be able to use Linux files in the files app. Hence we remove the old mounts at session startup if it's an unclean startup. Bug: 1057899 Change-Id: Ib5082c973e245800ac976efcecfd0aad96fe998d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089538 Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#748081}
-
Maggie Cai authored
This reverts commit d6d50478. Reason for revert: This CL is very likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/68631. Original change's description: > Feed refactor: Proto conversion > > Add StreamModelUpdateRequest and functions for converting wire protos into store protos > > Bug: 1044139 > Change-Id: I243ebabc331884500dec480c69d843d38546a34e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020545 > Commit-Queue: Ian Wells <iwells@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747983} TBR=iwells@chromium.org,harringtond@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1044139 Change-Id: Ide56a6466080cd643c9cf27632d158d8323fef07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094476Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b18390699ea2..475b9d0fb796 git log b18390699ea2..475b9d0fb796 --date=short --first-parent --format='%ad %ae %s' 2020-03-08 chrdavis@microsoft.com Remove global static mutex in SkScalerContext_win_dw.cpp Created with: gclient setdep -r src/third_party/skia@475b9d0fb796 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I2872bdd6bc0224ad1c058445516fc75d92db10c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093528Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd2dfc45b8a1..6ff3f116a334 Created with: gclient setdep -r src-internal@6ff3f116a334 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I80307c3fd4572aafbda25ef88aadb0af9690b129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093527Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748078}
-
John Palmer authored
1) Actually use the mode parsing function 2) Default to "" rather than "text" which brings the behaviour to be more like what would be expected Change-Id: I6a46437ac797d59810e099af1ddf564d532e05b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087497Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#748077}
-
Timothy Loh authored
This CL updates the task manager so that the "End process" button will force kill Plugin VMs, instead of attempting to gracefully shut them down (which can be done via the shelf context menu). Bug: 1059152 Change-Id: I407ff4248625f8510e951227ec2ece66948e4c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087328Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748076}
-
nancy authored
BUG=1038487 Change-Id: If6e135795924159775428b4f10a95101dc506f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093074Reviewed-by:
-
Rachel Carpenter authored
This reverts commit 25d52129. Reason for revert: Launch being punted to M83. Original change's description: > Enable kHelpAppV2 by default. > > For M82. > Launch bug: https://crbug.com/1042109 > > Bug: 1012578 > Change-Id: I76e80ed1f8afc5a34f76fbad30ebef731fd84ff0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076738 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Rachel Carpenter <carpenterr@google.com> > Cr-Commit-Position: refs/heads/master@{#744935} TBR=tapted@chromium.org,alemate@chromium.org,carpenterr@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1012578 Change-Id: Ia50fb959b29c97d5e839fd67ecb5a562fadb45d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089537Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#748074}
-
Rachel Wong authored
This change implements logging of features that are shared by all quick settings logging functions. - Audio feature was previously only logged for a volume change, but has been moved to become a shared feature. - There is also some reordering of the header file for readability reasons. Bug: 1014839 Change-Id: I4fc6cc9dc4d76acae5450894ec49258320b02d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087300Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#748073}
-
Raul Tambre authored
The L suffix was removed in Python 3. Fortunately this can be simply removed. The long type was also removed in Python 3, where int does the same thing. Simply alias long to int on Python 3. Works on both now Python 2 and 3 now, producing the same results as before. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_names.py", line 33, in <module> import hasher File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\hasher.py", line 26 return uint32_t(long.__rshift__(self, other) & ((1L << 32) - 1)) ^ SyntaxError: invalid syntax Bug: 941669 Change-Id: Ib0369ebce8c3bd843ebbbe24188fbe941fa1a2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093471 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: -
chrome://media-appTrent Apted authored
Currently there is only one typechecking pass for chrome://media-app. This means the two JS contexts are being typechecked together, and the compiler doesn't complain if receiver.js uses function signatures in launch.js even though they are isolated from each other. Create one type check target for each .html file, listing the .js files included in each (via script tags). Bug: 996088 Change-Id: I7d24a54a1869a535721ef162ec15d268b3b00171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091092Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#748071}
-
Hiroki Sato authored
This CL adds HasStandardAction in arc accessibility util. Bug: none. Test: unit_test Change-Id: I1380f1f89647bbe2b39dedc3da0f28ffb3fd90b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091098Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#748070}
-
Raul Tambre authored
iteritems() was removed in Python 3. items() does the same on both. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_feature_policy_helper.py", line 79, in <module> json5_generator.Maker(FeaturePolicyFeatureWriter).main() File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 337, in main writer = self._writer_class(args.files, args.output_dir) File "../../third_party/blink/renderer/build/scripts/make_feature_policy_helper.py", line 15, in __init__ super(FeaturePolicyFeatureWriter, self).__init__( File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 276, in __init__ self.json5_file = Json5File.load_from_files( File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 140, in load_from_files return Json5File(file_paths, merged_doc, default_metadata, File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 124, in __init__ self._process(doc) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 155, in _process entry = self._get_entry(item) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 197, in _get_entry self._validate_parameter(self.parameters[key], value) File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 218, in _validate_parameter elif not _is_valid(valid_values, value, valid_keys): File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 106, in _is_valid for key, val in value.iteritems()]) AttributeError: 'dict' object has no attribute 'iteritems' Bug: 941669 Change-Id: I5a60c0b54584a743ec86e51902e061af08c59c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093213 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: -
Jia authored
We're consolidating exact & fuzzy string match to be both supported by the search service. In this cl, we add case-insensitive exact match to TokenizedStringMatch and remove it from app_search_provider. Note, fuzzy string match already performs case-insensitive exact match internally. Bug: 1018613 Change-Id: Ia7d17352e3b263ab09fac1e590748a08d7b16eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089534Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748068}
-
- 08 Mar, 2020 16 commits
-
-
Noel Gordon authored
Provides an aria-aware drop-down menu with keyboard/mouse/scroll events support and allows clients to provide and style drop-down menu items. Not used yet, so no change in behavior. Tbr: alex Bug: 1035691 Change-Id: Ib189e01ed95d6dc9e28d86e4db9d7cb20b4b9ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094415Reviewed-by:
-
Eric Willigers authored
A new AppMatcher class is introduced, and used by AppShortcutLauncherItemController to match browser web contents against app id. No extensions APIs are used for bookmark apps. Bug: 1048055 Change-Id: I16197a28d89140bd4c863fb4891878720ba378f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087323 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#748066}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a0756a09cce..dd2dfc45b8a1 Created with: gclient setdep -r src-internal@dd2dfc45b8a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I292abe716f1af773b9a971f0b15f0e5d0231a42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093526Reviewed-by:
-
Mike West authored
This addresses only the IDL changes. We'll need to decide how the CSP integration ought to work (e.g. whether `require-sri-for` has any impact on non-secure pages) in the next CL. Bug: 1059554 Change-Id: Ie67a3cc1dbaac1e52e2d63bed45b43eb2ffa020b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093214 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#748064}
-
Jia authored
Doing some cleanup as part of search consolidation. FuzzyTokenizedStringMatch::IsRelevant already checks case-insensitve matches between query & text: https://cs.chromium.org/chromium/src/chrome/common/string_matching/fuzzy_tokenized_string_match.cc?g=0&l=278-287 Hence we don't need to repeat the check. Note (i). |query_terms| is tokenized string of |query_|. (ii). |indexed_name| is tokenized string of |app->name()|. Bug: 990684 Change-Id: I91ec0d659e9c7f92a84264c0243b5569b0f88bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089442Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
-
S. Ganesh authored
mini_installer_tests ChromeUserLevel and ChromeUserLevelUpdate are failing with the following error: AssertionError: In state 'chrome_user_installed_not_inuse', Registry key HKEY_LOCAL_MACHINE\Software\Chromium exists. This is most likely due to the change I made in change 2086353 to delete a value instead of the key. Now the test will delete the key if the test is the one that created the key in the first place. Bug: 1059314 Change-Id: I2b85e1f4c979c52a41aebb41c4951b60cf58a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092939 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748062}
-
Domenic Denicola authored
Bug: 931263 Change-Id: I7612194316c15aa264ef6caafced46445a752928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078735Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#748061}
-
Charlie Hu authored
This CL removes tests under directory third_party/blink/web_tests/external/wpt/feature-policy/parameters/ because params are no longer to be supported for feature policy. All parameterized policy are going to be migrated to document policy. Change-Id: I758f3834459bfb0404b4edf09d31af190b619c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089618 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#748060}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/454474d4f31c..3f3ca3d9d2ba git log 454474d4f31c..3f3ca3d9d2ba --date=short --first-parent --format='%ad %ae %s' 2020-03-08 treehugger-gerrit@google.com Merge "heapprofd: mitigate potential data race during UnwindingWorker destruction" Created with: gclient setdep -r src/third_party/perfetto@3f3ca3d9d2ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibdbc2c81f2da32ced35209b988d31a61dcf54325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093525Reviewed-by:
-
Ken Rockot authored
Also moves some longer bits of code out-of-line. Bug: 1059389 Change-Id: Idd1b3606e26504ab92e9aefebc933823919a2431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092695 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748058}
-
rajendrant authored
When enable_lite_page_redirect is unset, the subresource redirect throttle should not restart the requests. TBR=mcrouse@chromium.org Bug: 1059606 Change-Id: Id80ae397d831d4b99e41b5bc10a22ee548f49fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094319Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#748057}
-
Ken Rockot authored
Uses new GN-based typemap definitions to replace some typemap files in mojo/public/cpp/base. Bug: 1059389 Change-Id: If1389c9ceec8ae90df753895af0abd9f72c704a0 Tbr: dtapuska@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090723Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5fdb22e99bcd65286f76ca93d2ac53929174822e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093520Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6931a535daf4..2a0756a09cce Created with: gclient setdep -r src-internal@2a0756a09cce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iebcc20ec44f5a70063dedaad669b3fc5f29c9651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093519Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b1a8bf4ac4c..6931a535daf4 Created with: gclient setdep -r src-internal@6931a535daf4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I77dbed810449ab0f81ea54c0f9aee00618e839de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093516Reviewed-by:
-
Mostyn Bramley-Moore authored
BUG=994387 Change-Id: I1ff1e5f0b33330b80d08c4363b6bdff7fa59dbd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093473Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@chromium.org> Cr-Commit-Position: refs/heads/master@{#748052}
-
