GitLab

Revert of Try yet again to flip official win builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2192303002/ )

Reason for revert:
All the NaCl tests are crashing with "Actual: "Plugin crashed. 'NaCl module crashed" since
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504

This seems to be the most likely cause :(

There's also an outstanding issue with win-pgo (see BUG=)

BUG=632864

Original issue's description:
> Try yet again to flip official win builders to GN.
>
> TBR=brettw@chromium.org
> NOTRY=true
> BUG=623659
>
> Committed: https://crrev.com/00b24690630408d352edb0eb825423a71eccecb3
> Cr-Commit-Position: refs/heads/master@{#408782}

TBR=brettw@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623659
NOTRY=true

Review-Url: https://codereview.chromium.org/2196993002
Cr-Commit-Position: refs/heads/master@{#408896}

NetBSD is BSD and POSIX-like OS.

BUG=

Review-Url: https://codereview.chromium.org/2195203002
Cr-Commit-Position: refs/heads/master@{#408895}

This correctly matches the GYP behavior.

R=brettw@chromium.org, sebmarchand@chromium.org
BUG=632563

Review-Url: https://codereview.chromium.org/2199603002
Cr-Commit-Position: refs/heads/master@{#408894}

Also, add a watchlist entry for modifications to gyp files.

R=brettw@chromium.org
BUG=432967

Review-Url: https://codereview.chromium.org/2194043004
Cr-Commit-Position: refs/heads/master@{#408893}

TBR=smut@google.com
BUG=

Review-Url: https://codereview.chromium.org/2195213002
Cr-Commit-Position: refs/heads/master@{#408892}

TBR=brettw@chromium.org
BUG=432967

Review-Url: https://codereview.chromium.org/2200573002
Cr-Commit-Position: refs/heads/master@{#408891}

(Apart from the dedicated GYP builders, of course).

This affects:

- chromium.fyi
  - Closure Compilation Linux
  - CrWinAsan
  - CrWinAsan(dll)
  - CrWinAsanCov
- chromium.lkgr
  - Win ASan Release Coverage
  - Win ASan Release Media
  - Win ASan Release
- chromium.mac
  - ios-simulator
- chromium.memory.full
  - Chromium Windows Builder (DrMemory x64)
  - Chromium Windows Builder (DrMemory)
- tryserver.chromium.linux
  - closure_compilation
- tryserver.chromium.mac
  - ios-simulator

Though the closure compilation builder doesn't really use GN or MB yet.

TBR=brettw@chromium.org
BUG=605318, 621708

Review-Url: https://codereview.chromium.org/2198693002
Cr-Commit-Position: refs/heads/master@{#408890}

BUG=474273

Review-Url: https://codereview.chromium.org/2188413005
Cr-Commit-Position: refs/heads/master@{#408889}

Drop use of GarbageCollectedFinalized<>; not needed for this
class.

R=
BUG=

Review-Url: https://codereview.chromium.org/2192373002
Cr-Commit-Position: refs/heads/master@{#408888}

Leftover from r408135, remove the generated isT(*RefPtr<T>)
overloads also.

R=
BUG=

Review-Url: https://codereview.chromium.org/2201633002
Cr-Commit-Position: refs/heads/master@{#408887}

Some of postTask() implementation in Worker code don't have
WebTraceLocation parameter, and pass wrong FROM_HEREs. That
make it hard to follow the call stack in a crash report.

This adds the missing WebTraceLocation parameter, puts correct
FROM_HEREs and adds alias() to ensure it's in the crash report.

Review-Url: https://codereview.chromium.org/2196833002
Cr-Commit-Position: refs/heads/master@{#408886}

Previously, we would fade out the fakebox and fade in the real omnibox during
the scroll transition, which created discrepancies. With this change, the
toolbar omnibox does the full transition. The search box on the NTP is still
kept, both to get the starting point of the transition, and for the tablet
toolbar, where the omnibox stays at the top, so there are two boxes.

Because the two boxes now have to match, their dimensions and padding are
slightly updated. The height is 56dp, and the padding on the sides is 12dp.

Also, in the focused state the omnibox now has 1dp bleed at the sides,
which moves the rounded corners out of view.

The remaining changes are not user-visible:
* Opacity of the fakebox is now driven by the toolbar. This lets us centralize
  the logic (the toolbar can decide its own opacity and the opacity of the
  fakebox) and use different behavior on tablets, where the fakebox will simply
  fade out as before.
* Rename variables to (hopefully) make them more consistent / self-explanatory.
* |mLocationBarBackgroundBounds| (formerly |mUrlViewportBounds|) more accurately
  reflects the visible omnibox bounds in the absence of the NTP / when the NTP
  is scrolled so that the omnibox is at the top. To do that, we no longer
  include the Y translation we apply to position it where the fakebox is (it's
  instead applied to the |mLocationBarBackgroundNtpOffset|), and we always use
  an expansion value of 1 if the current tab is an NTP.
* Remove the |inset_textbox| drawable -- it was the same as |textbox|, but with
  a margin added at the top and bottom (but *not* left or right). Since we
  calculate the omnibox bounds manually anyway, this allows us to account for
  the omnibox padding in the same way in either dimension.
* Remove the |isInTabSwitcherMode| parameter from some methods in favor of using
  the member variable.

BUG=605054,625108,618955,616728,612520

Review-Url: https://codereview.chromium.org/2134663002
Cr-Commit-Position: refs/heads/master@{#408885}

Cr-Commit-Position: refs/heads/master@{#408884}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e07fc752..462f4bd5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2192363002
Cr-Commit-Position: refs/heads/master@{#408883}

Cr-Commit-Position: refs/heads/master@{#408882}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3a5efbf0..e07fc752

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2196063002
Cr-Commit-Position: refs/heads/master@{#408881}

Revert of Linux: Sync GetDesktopName in gtk2_util.cc (patchset #2 id:20001 of https://codereview.chromium.org/2195063003/ )

Reason for revert:
Broke Linux GN build on my desktop (linker error):

obj/chrome/browser/ui/libgtk2ui/libgtk2ui/gtk2_util.o:../../chrome/browser/ui/libgtk2ui/gtk2_util.cc:function libgtk2ui::GetDesktopName(base::Environment*): error: undefined reference to 'chrome::GetChannel()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Contents of my out/Release/args.gn:

  is_component_build = true
  is_debug = false
  is_chrome_branded = true
  dcheck_always_on = true
  use_goma = true

Original issue's description:
> Linux: Sync GetDesktopName in gtk2_util.cc
>
> BUG=632841
>
> Committed: https://crrev.com/12d7c7f1f6a38f067803c676e5cac9cccc11dab2
> Cr-Commit-Position: refs/heads/master@{#408846}

TBR=thestig@chromium.org,thomasanderson@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632841

Review-Url: https://codereview.chromium.org/2196073002
Cr-Commit-Position: refs/heads/master@{#408880}

https://chromium.googlesource.com/skia.git/+log/570f8af47305..02aed95f9c7c

$ git log 570f8af47..02aed95f9 --date=short --no-merges --format='%ad %ae %s'
2016-07-30 mtklein Revert of GrFP can express distance vector field req.,  program builder declares variable for it (patchset #20 id:370001 of https://codereview.chromium.org/2114993002/ )
2016-07-30 mtklein Revert of Tidy up SkNx_neon. (patchset #3 id:40001 of https://codereview.chromium.org/2196773002/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2201593003
Cr-Commit-Position: refs/heads/master@{#408879}

https://chromium.googlesource.com/skia.git/+log/73106225d1fc..570f8af47305

$ git log 73106225d..570f8af47 --date=short --no-merges --format='%ad %ae %s'
2016-07-30 mtklein Revert of Added distance vector support for CircleGeometryProcessor (patchset #4 id:60001 of https://codereview.chromium.org/2190023002/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2195183002
Cr-Commit-Position: refs/heads/master@{#408878}

As part of a discussion about Timing-Allow-Origin and multiple origins in that syntax[1], the possibility of a change to the syntax was raised. In order for that to be considered, we need to check usage.

This CL does that by adding a counter when there's more than 1 origin in that header.

[1] https://github.com/w3c/resource-timing/issues/62
BUG=

Review-Url: https://codereview.chromium.org/2178973002
Cr-Commit-Position: refs/heads/master@{#408877}

So after run gclient runhooks, we don't need to manually add java build path in eclipse.

Review-Url: https://codereview.chromium.org/2193133003
Cr-Commit-Position: refs/heads/master@{#408876}

The patch avoids throwing exception in the following scenario:
- add any non-existing property in SSP, e.g. "foo: bar;"
- observe a yellow triangle next to the property
- try clicking this triangle

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2191413003
Cr-Commit-Position: refs/heads/master@{#408875}

Currently, in some circumstances, filter_try_jobs may throw an error depending on the state of the current try jobs.

This CL changes just this method so that it doesn't throw a KeyError if there are jobs with no build number passed in.

Review-Url: https://codereview.chromium.org/2182413004
Cr-Commit-Position: refs/heads/master@{#408874}

BUG=632875
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2196003002
Cr-Commit-Position: refs/heads/master@{#408873}

https://chromium.googlesource.com/skia.git/+log/fe2042e60fa7..73106225d1fc

$ git log fe2042e60..73106225d --date=short --no-merges --format='%ad %ae %s'
2016-07-30 mtklein Docs: ooops, debug is the default in GN.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2196033002
Cr-Commit-Position: refs/heads/master@{#408872}

Follow-up to https://codereview.chromium.org/2071463002/

BUG=none

Review-Url: https://codereview.chromium.org/2193023003
Cr-Commit-Position: refs/heads/master@{#408871}

If the HWID is invalid (for instance, "unknown") and the firmware ID is non-Chrome ("nonchrome") then assume that we're running in a VM and do not report a factory
error. A warning message is added to the log.

BUG=b:30155895

Review-Url: https://codereview.chromium.org/2187473006
Cr-Commit-Position: refs/heads/master@{#408870}

reserveCapacity allocates the exact capacity specified which means
when we had a 16bit buffer in StringBuilder and were appending 8bit
strings to it we were constantly reallocating and copying the buffer.

Instead we can just call Vector::append() directly since it has a
template overload that can accept implicitly convertible types.

I noticed this when looking at lever.co's web app loading in
Instruments, it was spending 15% of the main thread time inside
TextResource::decodedText which was 83% memmove, and 11% munmap.

Switching to Vector::append should restore the correct size
doubling behavior when appending LChars to a UChar StringBuilder
and make this much faster.

This was a regression from when I switched to using a Vector
inside StringBuilder in:
https://codereview.chromium.org/2046353002

Review-Url: https://codereview.chromium.org/2192293002
Cr-Commit-Position: refs/heads/master@{#408869}

Cr-Commit-Position: refs/heads/master@{#408868}

This change implements size change notification algorithm.
Design doc at https://docs.google.com/document/d/1G4OmqqlFY3H3erQAUmteKES02-bIECikDjWBrDKH9PA/edit?usp=sharing

Size change notification
We collect and deliver notifications about all Elements
whose size has changed inside the event loop.
The algorithm loops until all notifications are delivered,
or it hits the depth limit.

c = ResizeObserverController();
for (limit = c.gatherObservations(0);
      limit != ResizeObserverController::kDepthLimit;
      limit = c.gatherObservations(limit)) {
      	c.deliverObservations();
      }
      if (c.skippedObservations()) {
        c.clearObservations();
        sendError()
      }

For efficiency, we avoid continuosly polling all elements
for size changes. Instead, an Element notifies ResizeObservation
when its size might have changed. ResizeObservation propagates
this change to ResizeObserver, which propagates to
ResizeObserverController. All of them set a flag indicating that
they might have been changed.
The flag is cleared when observations are delivered.

BUG=612962

Review-Url: https://codereview.chromium.org/2188983003
Cr-Commit-Position: refs/heads/master@{#408867}

Several BUILD.gn files were bundling icudtl.dat even when
icu_use_data_file = false (i.e. icudata is statically linked).

The TEST below was done with https://codereview.chromium.org/2174993002/ on
the ICU side. This CL still can get in without that change, though.

BUG=630929
TEST='gn args <outdir>' with icu_use_data_file=false generates ninja files.
TEST=chrome / content_shell can be built.
TEST=In Chrome/content_shell, go to a non-UTF-8 page (www.hankyung.com) or
     run `(new Date()).toLocaleString("de")` to make sure that ICU data
     is accessible.

Review-Url: https://codereview.chromium.org/2181043003
Cr-Commit-Position: refs/heads/master@{#408866}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6b119eb8..3a5efbf0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2195893003
Cr-Commit-Position: refs/heads/master@{#408865}

Compositor frames submitted by mus clients include a flag to indicate whether the
client is playing a video or not. This information is plumbed through from
cc::Layer to cc::LayerImpl to cc::CompositorFrame[Metadata].

BUG=627140
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2140783002
Cr-Commit-Position: refs/heads/master@{#408864}

We used to just extract string from the error, which didn't allow to inspect the error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG=631162,632405

Review-Url: https://codereview.chromium.org/2170263002
Cr-Commit-Position: refs/heads/master@{#408863}

https://pdfium.googlesource.com/pdfium.git/+log/6f10254..3e454bf

BUG=409472,629839

TEST=bots
TBR=ochang@chromium.org

Review-Url: https://codereview.chromium.org/2193623005
Cr-Commit-Position: refs/heads/master@{#408862}

- Use the right repo for Ubuntu ARM(64)
- Add checks for valid architectures so the "All" commands work.
- Try to fix up some bashisms
- And give up on the rest and just switch to bash

BUG=632522

Review-Url: https://codereview.chromium.org/2193903004
Cr-Commit-Position: refs/heads/master@{#408861}

Print preview closed in gmail when gmail navigated to a new
URL fragment. This occurred if print preview was requested
just after making changes to an e-mail draft in a compose
message window. Added check that will ensure print preview
remains open in this case.

BUG= 614998

Review-Url: https://codereview.chromium.org/2201543002
Cr-Commit-Position: refs/heads/master@{#408860}

Make it always show all the object properties.

BUG=632917

Review-Url: https://codereview.chromium.org/2188413004
Cr-Commit-Position: refs/heads/master@{#408859}

BUG=None

Review-Url: https://codereview.chromium.org/2198633002
Cr-Commit-Position: refs/heads/master@{#408858}

This is a step toward a working Asan build with GN.
There are still a few missing pieces to land.

This patch is fixing an assert triggering due to courgette using an
harcoded toolchains.

----------------------
 ERROR at //build/config/sanitizers/sanitizers.gni:12:1: Assertion failed.
  assert(!using_sanitizer || is_clang,
  ^-----
  Sanitizers (is_*san) require setting is_clang = true in 'gn args'
----------------------

This patch is also fixing the compiler-rt runtime paths for a x64 bit
build. The port of WinASAN-64 is almost done and should part of the next
clang roll-deps.

R=thakis@chromium.org, dpranke@chromium.org
TBR=brettw@chromium.org
BUG=598761

Review-Url: https://codereview.chromium.org/2192833002
Cr-Commit-Position: refs/heads/master@{#408857}