Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 11 Jan, 2017 3 commits
    • timloh's avatar
      Revert of Sub-sample accurate start of OscillatorNode (patchset #11 id:200001... · 30ffb0ff
      timloh authored 
      Revert of Sub-sample accurate start of OscillatorNode (patchset #11 id:200001 of https://codereview.chromium.org/2186813003/ )

Reason for revert:
Added test is failing on WebKit Mac10.11 (retina)

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29

Original issue's description:
> Sub-sample accurate start of OscillatorNode
>
> Previously, an oscillator would start at the nearest sample frame
> boundary.  This can produce noticeable effects.
>
> Instead, make the oscillator start at the requested sample time and
> sample the curve appropriately.
>
> BUG=631576
> TEST=Oscillator/start-sampling.html
>
> Review-Url: https://codereview.chromium.org/2186813003
> Cr-Commit-Position: refs/heads/master@{#442669}
> Committed: https://chromium.googlesource.com/chromium/src/+/7909df464ca46a1ea121b0c54e5d04cfa521e38c

TBR=hongchan@chromium.org,rtoy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631576

Review-Url: https://codereview.chromium.org/2623063002
Cr-Commit-Position: refs/heads/master@{#442739}
      30ffb0ff
    • rlanday's avatar
      Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() · 7efe2301
      rlanday authored 
      Android InputConnection has two related methods

- setComposingText() replaces the current compose region with a given piece of
  text and sets a composing span around the new text

- commitText() replaces the text the same way but then closes out the compose
  region instead of putting it around the new text.

Support was added for parsing BackgroundSpan and UnderlineSpan annotations in
setComposingText() to support the Google Japanese Input IME (newly entered text
in the compose region is underlined and highlighted in a blue background).

The Android Voice IME instead uses commitText() because it wants the highlighted
regions to persist after the compose region is closed out. Closing out the
compose region after calling setComposingText() would clear the highlight
regions. So to support this, we need to parse the spans for commitText() in
ImeAdapterAndroid just as we do for setComposingText(), and also thread this
information all the way back to InputMethodController as we do for
setComposingText().

I tested this by forwarding calls of setComposingText() to commitText() and
verifying that highlighting works for the Google Japanese IME. It's highlighting
the character immediately ahead of the insertion point instead of the newly
typed character when I do this; I suspect this may be because the IME is
expecting something about the setComposingText() behavior (e.g. the compose
range) that's different in commitText(), but it's also possible I have a bug in
the new logic.

Once I write some code to start parsing out SuggestionSpans from the Voice IME,
I'll be able to test this better (I might be able to get this done tomorrow).

BUG=673491

Review-Url: https://codereview.chromium.org/2568093003
Cr-Commit-Position: refs/heads/master@{#442738}
      7efe2301
    • mcasas's avatar
      Shape Detection: resolve with empty results if any input element's dimension is zero · abcbc58f
      mcasas authored 
      This CL homogenises the behaviour of the ShapeDetector's
detect() in case of an input element with any zero dimension.
Assuming such input element pass the cross origin test and
its underlying pixel data can be retrieved, then if either width
or height is zero, detect() Promise is resolved with an empty
array.

LayoutTests are adapted/extended/cleaned up.

BUG=674306

Review-Url: https://codereview.chromium.org/2626743002
Cr-Commit-Position: refs/heads/master@{#442737}
      abcbc58f
  3. 10 Jan, 2017 37 commits