GitLab

Revert of Use new people.get api instead of oauth2/v1/userinfo. (https://codereview.chromium.org/257773002/)

Reason for revert:
[Sheriff]Speculative revert for breaking CrOS:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/23489

Will reland if it doesn't help.

Original issue's description:
> Use new people.get api instead of oauth2/v1/userinfo.
> Consolidate all uses into main helper class.
> 
> Details about new api: https://developers.google.com/+/api/latest/people/get
> 
> Format of returned response: https://developers.google.com/+/api/latest/people#resource
> 
> BUG=320354
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267068

TBR=atwilson@chromium.org,noms@chromium.org,guohui@chromium.org,gene@chromium.org,rogerta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=320354

Review URL: https://codereview.chromium.org/265563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267114 0039d316-1c4b-4281-b951-d872f2087c98

(Before I refactor message_in_transit.cc some more.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/259373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267111 0039d316-1c4b-4281-b951-d872f2087c98

Should depend on the model (CVC) and gets its View when adding to the
view heirarchy.
BUG=360664

Review URL: https://codereview.chromium.org/258123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267110 0039d316-1c4b-4281-b951-d872f2087c98

This patch forwards NotifyTileInitialized to layer_impl, which makes
it easier to add more special handling per layer, instead of putting
extra logic in LTHI.

R=enne

Review URL: https://codereview.chromium.org/252293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267109 0039d316-1c4b-4281-b951-d872f2087c98

We don't need to log these events since we already have kAVFrameEncoded
and kAVPacketSentToNetwork.

BUG=366198

Review URL: https://codereview.chromium.org/256943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267108 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267107 0039d316-1c4b-4281-b951-d872f2087c98

BrowsingDataRemover causes shutdown problems if interrupted. Avoid test
flakiness by letting it run to completion.

BUG=316225, 340855

Review URL: https://codereview.chromium.org/250663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267106 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172886:172887&mode=html

The try jobs for this roll passed in:
https://codereview.chromium.org/263543002/
(the roll was split into 172818->172885 and
172885->172887 because r172885 and r172887 are
major changes we want in separate rolls)

TBR=
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/254203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267105 0039d316-1c4b-4281-b951-d872f2087c98

Defer until both OnProcessLaunched and ConnectTo have been called.

BUG=366644

Review URL: https://codereview.chromium.org/253843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267104 0039d316-1c4b-4281-b951-d872f2087c98

This is the second go at the CL originally 
http://crrev.com/234563004, that landed and got reverted 
due to a series of crashes caused by inappropriate handling
of the iterator in -CrAVFoundationDeviceObserver::dealloc

** This CL lands the original code plus some new code centered and
limited to the mentioned -dealloc (device_monitor_mac.mm:351). **

Original description follows: ------------------------------------------
Mac AVFoundation: Enumerate devices in device/audio thread.

Bug http://crbug.com/359589 describes a Chrome hang
where two threads are calling [AVCaptureDeviceGlue devices]
at the same time to enumerate the devices. The first call
comes from DeviceMonitorMac::StartMonitoring() on UI
thread while the second call comes from the Audio Thread,
a.k.a. Device Thread on
+VideoCaptureDeviceAVFoundation::getDeviceNames:.

DMM == DeviceMonitorMac

The solution proposed here is to do as much as possible
on Device thread :
- when there is a device change via DMM::OnDeviceChanged(),
enumerate on Device Thread, then consolidate the device
list on UI thread.
- First |suspend_observer_| registration happens on Device
Thread. This suspend observer lives in device thread.
- Observer removal happens dutifully on Device Thread
destructor in -CrAVFoundationDeviceObserver::dealloc

BUG=288562, 359589

Review URL: https://codereview.chromium.org/252893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267103 0039d316-1c4b-4281-b951-d872f2087c98

Currently it is not possible to build snappy_unittest target on Linux with the following command line:

$ ninja -C out/Debug snappy_unittest

This patch fixes this problem.

BUG=None
TEST=build snappy_unittest on Linux.
R=jsbell@chromium.org

Review URL: https://codereview.chromium.org/236323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267102 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Ignoring minimum size requirements for maximized windows, full screen windows and too small screens (https://codereview.chromium.org/255063004/)

Reason for revert:
[Sheriff] Breaks NormalOrPanel/DockedWindowLayoutManagerTest.WidthMoreThanMax/1 on CrOS:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/42711

Original issue's description:
> Ignoring minimum size requirements for maximized windows, full screen windows and too small screens
> 
> BUG=366315
> TEST=ash_unittest's and visual tests
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267084

TBR=ben@chromium.org,skuhne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=366315

Review URL: https://codereview.chromium.org/262593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267101 0039d316-1c4b-4281-b951-d872f2087c98

It may have caused Android Builder to fail:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/38786/steps/compile/logs/stdio
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/56685/steps/compile/logs/stdio

"error: undefined reference to 'NTPUserDataLogger::GetOrCreateFromWebContents(content::WebContents*)'" etc.

> Remove WebUI NTP on Android.
> 
> Chrome for Android has transitioned to using native NTP. This CL removes
> the WebUI classes and resources.
> 
> BUG=284770
> 
> Review URL: https://codereview.chromium.org/256763004

TBR=aurimas@chromium.org

Review URL: https://codereview.chromium.org/264543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267100 0039d316-1c4b-4281-b951-d872f2087c98

This policy is more in accord with the design doc changes. Moves to
showing the dialog upon DOMContentLoaded in source pages, and then
subsequently for user gestures.

R=leng@chromium.org
BUG=332115,364159

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266855

Review URL: https://codereview.chromium.org/243543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267099 0039d316-1c4b-4281-b951-d872f2087c98

The code was using splice_buffers_index_ >= splice_buffer.size()
to indicate that all pre splice buffers have been handed out.

However this meant that the config change after handing out all
pre splice buffers would incorrectly use the config id of the
splice container instead of the last buffer (which is the first
post splice buffer).  See GetConfigId() for more details.

This change fixes several tests and adds a new one to catch this
explicitly.

BUG=334493
TEST=new unittests, fixed existing tests!

Review URL: https://codereview.chromium.org/251903008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267098 0039d316-1c4b-4281-b951-d872f2087c98

This is just refactoring, there should be no behavior changes.
I realized that most of the functionality of
BrowserAccessibilityDelegate was implemented by
RenderWidgetHostImpl, but each RenderWidgetHostView*
was actually implementing the interface, resulting in
extra code. It's simpler to have RWHI implement it and
just call into RWHV for the few cases where the view is
involved.

This also removes the parallel mac-only delegate, since
it was duplicating most of the same functionality.
Calling OriginInScreen is a couple of extra lines of code
because it needs to convert from NSPoint & NSSize to
gfx::Rect, but in every other case it's the same or simpler
this way.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/246773008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267097 0039d316-1c4b-4281-b951-d872f2087c98

AXTreeSerializer was instructing its client to delete the whole
subtree whenever it got a notification on a new node, but that
isn't actually necessary. It was causing the whole tree to be
recreated unneccessarily. Existing unit tests still pass, and
they're comprehensive.

BUG=368295
NOTRY=true

Review URL: https://codereview.chromium.org/260463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267096 0039d316-1c4b-4281-b951-d872f2087c98

Chrome for Android has transitioned to using native NTP. This CL removes
the WebUI classes and resources.

BUG=284770

Review URL: https://codereview.chromium.org/256763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267095 0039d316-1c4b-4281-b951-d872f2087c98

This isn't necessary anymore with the legacy 2D path gone. Also remove some UpdateRect parameters that aren't used anymore.

BUG=362164

Review URL: https://codereview.chromium.org/253913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366710

Review URL: https://codereview.chromium.org/254753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267093 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267092 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=10&start=14440
TBR=
BUG=

Review URL: https://codereview.chromium.org/252283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239879

Review URL: https://codereview.chromium.org/253163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364934

Review URL: https://codereview.chromium.org/253153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267089 0039d316-1c4b-4281-b951-d872f2087c98

Record the total visible content area and the approximated visible content
area. Approximated area is the visible area covered by low-res or missing tiles.
These statistics will be used in a follow-up patch to report the percentage of
pixels that were approximated in smoothness benchmark.

R=vmpstr@chromium.org,enne@chromium.org,
BUG=308652

Review URL: https://codereview.chromium.org/258093005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267088 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/252893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=None

R=brettw@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/259823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267086 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368255

Review URL: https://codereview.chromium.org/259183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366315
TEST=ash_unittest's and visual tests

Review URL: https://codereview.chromium.org/255063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267084 0039d316-1c4b-4281-b951-d872f2087c98

function doesn't require divergent return value semantics depending on subclass.

BUG=365732
R=rockot@chromium.org
TBR=pkasting@chromium.org,dtseng@chromium.org

Review URL: https://codereview.chromium.org/252653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267083 0039d316-1c4b-4281-b951-d872f2087c98

Implementation is not complete yet, but enabling to shake out bugs.

BUG=354841

Review URL: https://codereview.chromium.org/255143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267082 0039d316-1c4b-4281-b951-d872f2087c98

The user has to grant permission to specific files via a file picker,
which is considered permission enough.

BUG=363399

Review URL: https://codereview.chromium.org/253433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267081 0039d316-1c4b-4281-b951-d872f2087c98

See mock at slides 29-34 of
https://docs.google.com/a/google.com/presentation/d/1UMAexroivw01osOXpnEqbQcE3FMyDkc9eZoIszm4DP4/edit#slide=id.g12716c613_09

Snapshot at
https://x20web.corp.google.com/users/gu/guohui/www/question_mark.png
https://x20web.corp.google.com/users/gu/guohui/www/feedback_tutorial.png
https://x20web.corp.google.com/users/gu/guohui/www/disable_mirror_view.png

BUG=358265

Review URL: https://codereview.chromium.org/255203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267080 0039d316-1c4b-4281-b951-d872f2087c98

2. Introduce a template class GuestView<T> to handle the    *guestview-specific functions in guestview.h:
   . Rename GuestView to GuestViewBase, introduce GuestView<T> class, and move *ViewGuest-specific functions to     GuestView<T>:
        -- FromWebContents<T>(...)
        -- From<T>(...).
   . Introduce a template member function As() in      GuestViewBase to replace all of the As*View functions.

3. In each derived *ViewGuest class , e.g., WebViewGuest &    AdViewGuest, define a static variable to show its view type    (string).


BUG=351824

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266297

Review URL: https://codereview.chromium.org/237533008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267079 0039d316-1c4b-4281-b951-d872f2087c98

This patch modifies judgment condition whether is equal to zero for double type, avoid unnecessary sqrt calls in more case.
If "a" and "b" are both equal to zero, and "c" is less then zero, currently ScaleOnAxis will return "c" which is negative. So, we should ensure that the result is greater than zero.

BUG=none.

Review URL: https://codereview.chromium.org/253083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267078 0039d316-1c4b-4281-b951-d872f2087c98

chrome.test.fail cannot be used as ErrorCallback because it throws exception when the number of arguments doesn't match.
This wrong use of chrome.test.fail makes the error output useless when something goes wrong.

BUG=None
TEST=browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266271

Review URL: https://codereview.chromium.org/258523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267077 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267076 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172819:172885&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/260523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117261

Review URL: https://codereview.chromium.org/257983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267073 0039d316-1c4b-4281-b951-d872f2087c98

It is true that kModeDraw will be called with UI blocked. But it is
possible for kModeProcess to be called asynchronously. We don't access
the state object in kModeProcess, but better be safe than sorry.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/260213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267072 0039d316-1c4b-4281-b951-d872f2087c98