GitLab

- OverviewGridTest.SnappedWindow
- SplitViewOverviewSessionTest.OverviewDragControllerBehavior.

Test: ash_unittests *Overview*
Bug: none
Change-Id: Iec84d264f6f572cf8f84a16ed597e00bc0b2995d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992019
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729965}

Bug: 245409
Change-Id: I6a96fcf3ab975146631137322f338d0841da3ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993678
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729964}

When relocating the pinned app across pages, a proxy image view is
created in ScrollableShelfView. The proxy image view has the identical
bounds with ShelfView::|drag_view_|. However, |drag_view_|'s bounds
are adjusted to fit into the targeting icon slot. It is why the
dragged icon may move under the finger by itself. To fix the issue,
the proxy image's bounds should rely on the mouse/gesture event's
location.

This CL also adds the animation to move the drag icon from event
location to the ideal place after drag ends.

Bug: 1031367
Change-Id: I539abc1b97e061a50c2a53b1cc6b784e78c14983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990565
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729963}

A folow-up on CL:1988989 with a couple of things I realized can be done
better:
*   use presenter_.GetTargetVisibility() to check if app list has been
    previously shown
*   Show app list in tablet mode using HomeScreenController::Show (it
    handles some additional tablet mode specific things - e.g. sets the
    show source)
*   Use last_target_visible_ to check if app list should be visible when
    session changes to active (instead of trying to recalculate target
    visibility state again)

BUG=1038512

Change-Id: I6a1aa7613935ed042a45b4aa622bd7cf2203a071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992242Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729962}

When closing the last tab through tab switcher longpress menu, there
exists one monent at which there is no visible tab. Color.WHITE is
hard-coded but the browser control background color should be
determined based on whether chrome is on dark mode or light mode.

Bug: 1034843
Change-Id: I332fee777cbc095704e19e786905c983778fcacf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976434Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#729961}

R=estevenson

Bug: None
Change-Id: Ib35be0e583d9b5edcbd137a60cd51b3c4274fc0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994242
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Auto-Submit: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729960}

Bug: None
Change-Id: I69df296a38cf8f082cff6e05b6fc5c81cce9da90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991751
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729959}

This simplifies the code a bit and removes any possibilities of
mixing RenderProcessHost IDs and frame routing IDs.

Change-Id: I0d7c8df9b6ebc9c7e20d5fbc6f36074125761f74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977966
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729958}

This connects adds a paint_preview_base_service dependency on the
player.

Bug: 1019885
Change-Id: Ia1055d83591e828c3a945b0ddc948ec5496b2edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955819Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729957}

This prepares adding more pages to the customize dialog.

Bug: 1040256
Change-Id: Ia16b4d7b50b630b7b1b0ce66768980027b628908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990879Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729956}

OpenXR supports HTC Vive controller by adding the bindings.

Fixed: 1034180
Change-Id: Id9a4acd7355dde7c205adf7483a7dd144d3044a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984620
Commit-Queue: Zheng Qin <zheqi@microsoft.com>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729955}

https://swiftshader.googlesource.com/SwiftShader.git/+log/f6a6a4162f28..a7e42ba7f855

git log f6a6a4162f28..a7e42ba7f855 --date=short --first-parent --format='%ad %ae %s'
2020-01-09 bclayton@google.com Kokoro: Disable ASAN for debug mac builds

Created with:
  gclient setdep -r src/third_party/swiftshader@a7e42ba7f855

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: If67a94492a914b1ed5f8493bc8d753399849130b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993884Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729954}

Bug: 1013685
Change-Id: I875b920fbdd77b07d8f8ad4dea4d712393c8aeff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993675Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729953}

This CL restricts the type of ActivationSequence to StrongAlias
instead of int, so that it cannot be used interchangeably with int
anymore. This CL also moves the definition to //extensions/common so
that renderer/ can use it.

This CL doesn't produce any behavior changes.

Bug: 1970854
Change-Id: I30a5acc19c87bb4d6d4ab8f3cb36f8b9af12c2ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986327Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729952}

But drop unused .SingleTab/.MultiTabs suffix.
Current histogram values kept for posterity @
https://docs.google.com/document/d/18uYnVwLly7C_ckGsDbqdNs-AgAAt3AmUmn7wYLkyBN0/edit#heading=h.yy3qczapsgy7

R=fdoray@chromium.org, rkaplow@chromium.org

Bug: 1037318
Change-Id: Ice8efe602d65c24d88d03bfb37882202e4c35881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990990
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729951}

Previous patch did not update GLTextureRepresentation's clear region
on begin access. This allowed it to get out of sync if other (non-GL)
components modified the clear rect.

This patch updates the cleared rect on each begin access.

Bug: 1039232
Change-Id: Iacc6e65b25d770e1d17e51a5f1c2c632dfad0101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990195Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729950}

Versions of vim with +python3 but -python currently display an error message
at startup if they use ninja-build.vim. We can support these versions along
with existing +python -python3 versions of vim by using pythonx instead.

Change-Id: I389486aa5b49b3466514e98fa57b5dce3115273a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994080Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729949}

In https://chromium-review.googlesource.com/c/chromium/src/+/1955823 the
code was updated to match the terminology in the readme (blob key vs blob
number), however in doing so accidentally the readme was also modified.

This reverts the changes to the readme, as it already used the correct
terminology for blob numbers and blob keys.

Bug: 1027737
Change-Id: Ie4012688901b9813248e99bce93ee6b454eba53e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993872
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729948}

These metrics were originally added in order to explore possible limits
on ad CPU usage before and after page interactive for the heavy ad
intervention.

These metrics are no longer used, and total CPU usage is instead used
as intervention criteria. The metrics are also somewhat difficult to
interpret due to the complexity of TTI.

Bug: 1013388
Change-Id: I944c3769514f8d4a03ac507796336aa55bcd5b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992166Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729947}

Instead of

foo("bar") {
  deps = [ ":repack" ]
  data = [ "$root_out_dir/repack_output.pak" ]
}

use

foo("bar") {
  data_deps = [ ":repack" ]
}

This happens to remove `$root_out_dir/locales/` from data,
which is good for correct incremental builds (see bug).

I didn't touch android and iOS, since I don't know the
android_assets() / the copy_data_to_bundle approach used
in iOS well.

(For similar bundling reasons, most of the `data` lines were already in
!is_mac blocks.)

While comparing browser_tests.runtime_deps as described in comment 18
on the linked bug, I noticed that we include .pak.info files in the
isolate for repack()ed files. Since those are build-time things, remove
them from repack() outputs, so that data_deps doesn't add these to the
.runtime_deps files. (For the build, the removal is harmless since deps
are still tracked through the action stamp files.)

One side effect of this change is that most test binaries defined
in chrome/test now get all locales in their isolate, instead of just
en-US or en-US and fr previously.

The target that includes ui_tests.pak is //ui/resources:ui_test_pak_data,
switch to that in a few places -- the previous ui_test_pak target
pulled in ui/en-US.pak which apparently isn't needed anywhere.

TBR=torne,sergeyu

Bug: 912946
Change-Id: I0d9c6ff0d3b00cd5a876443b61b083a1aabf24d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989515
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729946}

The new build_hwasan_splits flag causes HWASAN splits to be created for
the Monochrome6432 and TrichromeChrome6432 bundles, as well as any of its
DFMs that contain native code. The intent is that this flag will eventually
default to true in official builds.

The library is deliberately installed in TrichromeChrome6432 rather than
TrichromeLibrary6432 (where the regular native library lives) because the
Android platform does not support splits for the library containing the
WebView implementation. This means that only Chrome will use the HWASANified
native library, and WebView will use the regular native library.

Bug: 916828
Change-Id: Ie92bb36e83df245ab431b0123a44b0f0a3182100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769731
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729945}

This enables clang-format-style autoformatting via YAPF.

Bug: 846432
Change-Id: I212c731c53a7cd2b8da839f30688c5c23d3b7c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989232
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729944}

The activation of the keytype suppression was by mistake removed in
Chrome for all calls running the processing in the renderer process.
The CL that caused this was
https://chromium-review.googlesource.com/c/chromium/src/+/1495528

This CL re-enables keytype suppression.

Bug: chromium:1033455
Change-Id: Ieaeafc53f2d4b0d8e87400544e859fd0e0e68886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984305Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Per Åhgren <peah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729943}

The metric tracks whether the invalid DM token was stored successfully.

Bug: 1039399
Change-Id: I8e1cf72b65353e378841dfc1642d9176638a748a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988674Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729942}

I submitted https://chromium-review.googlesource.com/c/chromium/src/+/1992807
without adequate testing, and of course it didn't quite work:
https://chrome-swarming.appspot.com/user/task/49a3b1ea6bb41910
Traceback (most recent call last):
  File ../../testing/scripts/run_performance_tests.py, line 290, in execute_gtest_perf_test
    e)
TypeError: not enough arguments for format string

For this changelist, I fix the bugs and add a test case for it.

Note that lots of terrible unrelated git cl format changes were forced on this
change. I filed crbug.com/1040604 for this.

R=bsheedy@chromium.org, wenbinzhang@google.com

Bug: 1040300, 1039019
Change-Id: Ib1d22f655b58dc70790ca701cb028bbb6d599a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993443Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729941}

Users with BrowserThread traits can just use the getter to get a new
pointer to the existing task runner each time (the BrowserThread API
will soon move to content::GetUIThreadTaskRunner() and this call will
make even more sense then the current one using "create" semantics).

This is necessary in order to rename LazyTaskRunner to
LazyThreadPoolTaskRunner and having it automatically call into the
upcoming base::ThreadPool:: APIs (destination as an API rather than as
a trait).

See Task Posting APIs v3 for details:
https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit

R=fdoray@chromium.org

Bug: 1026641
Change-Id: I03e84ad5f607c93c4e2d649820954f0a4b08df56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988682
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729940}

The deletion of obsolete clients after 2 minutes causes crashes if
chrome shutsdown before that time. Make sure shared db is not destroyed
while running the destroy task by holding a reference. Add a test to
verify crash is fixed.

BUG=1014088

Change-Id: Ia5ddf51f29254416a93ee7f3416b96d60794e473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925754
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729939}

Currently, the decision on whether a scroll should be animated or not
occurs in InputHandlerProxy. This makes the compositor scroll interface
more complicated than it needs to be and exposes details about scrolling
that should be encapsulated in the compositor.

This CL moves the |smooth_scroll_enabled| from an ad hoc bit in the
InputHandlerProxy into a real setting in LayerTreeSettings. We then
rearrange the public interface of the compositor input handler so that
we only have a ScrollUpdate method. This method now checks whether a
given scroll should be animated or not and delegates to the old ScrollBy
or ScrollAnimated methods, based on the answer. Finally, we remove some
of the divergence between animated and non-animated paths in
InputHandlerProxy so that both kinds of scrolls are handed in the same
way.

Bug: 1016229
Change-Id: I2143cf27aeb6aca905b59b817fe8e3f1b14b7858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981711
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729938}

This CL plumbs the power experiment state to the media players in the
renderer that they are / are not the only playing player.  This
lets the renderer decide whether to start measuring power usage.

Bug: 1017783
Change-Id: I17e9b453c63482b20bf2b9c4d802ff346f7bd44e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992686Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729937}

Screen width of some devices does not have enough space for the logo.
See screenshot here:
https://drive.google.com/drive/folders/1-ZYyD0KSYr2wLEzBHZ9UFIP-K7D79tDV?usp=sharing

This CL removes the logo if there is not enough space at the first layout.

Known issues:
If device is rotates, screen width may change.

Bug: 1025296, 1027324
Change-Id: Ib5e17a8b49bd70c304d8e38e95d5de4123cf4ea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976311Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mia Glaese <glamia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729936}

Reverts CL:1903901, which was added as a workaround for an issue where
focusing web contents in Assistant UI would cause app list to revert
back from assistant to "apps" state. The issue was caused by calls to
OnHomeLauncherGainingFocusWithoutAnimation() whose logis was resetting
app list state - this logic has since been removed from the method
(in CL:1966374), which made this workaround unnecessary.

BUG=1026727, b:144056527

TEST=Open embedded Assistant UI, tap "What can you do", verify that
     Assistant UI remains open after tapping grid items (and shows the
     UI associated with the grid item)*
* Unless the grid item is expected to open a browser tab, in which case
the assistant UI is expected to be hidden.

Change-Id: Ibf91647ddceb40dcacf054c66aec6205eac097ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994121Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729935}

These are no longer recorded, and likely haven't been for some time.

Bug: 1037096
Change-Id: I2d3f6febc2a0fda20dea02dc6473c3dcca81d3c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993621Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729934}

This CL adds an axe accessibility test for the threads pane.

Bug: 963183
Change-Id: I35dc2738f7bd5fce2e4b24aaa6a86b51b671b982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707832Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#729933}

This reverts commit 514a76b7.

Reason for revert: This was removing the tests from the wrong location,
it was removing them from WPT folder instead of fast/css-grid-layout/.

Original change's description:
> [css-grid] Remove outdated css-grid-layout alignment tests
> 
> The alignment tests in question have been moved from WebKit to WPT
> with the following PR:
> * https://github.com/web-platform-tests/wpt/pull/19828
> * https://github.com/web-platform-tests/wpt/pull/20088
> * https://github.com/web-platform-tests/wpt/pull/19809
> * https://github.com/web-platform-tests/wpt/pull/19665
> * https://github.com/web-platform-tests/wpt/pull/20110
> 
> The removed tests that are now in WPT can be found under:
> third_party/blink/web_tests/external/wpt/css/css-grid/alignment/
> 
> This patch removes the outdated version of the tests from
> third_party/blink/web_tests/fast/css-grid-layout/
> 
> Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531
> Commit-Queue: Manuel Rego <rego@igalia.com>
> Reviewed-by: Manuel Rego <rego@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#729346}

TBR=jfernandez@igalia.com,rego@igalia.com,obrufau@igalia.com,rmonteriso@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I18d98894d82e9800024d0fd23ee11c82432a0e64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993801Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#729932}

The existing OpenCoverageFile and SetCoverageFile implementation is
causing lots of timeouts when running fuzzing testcases. Either because
there is a hardcoded child_pool of size 4, or maybe because of the lock
mechanism being used.

This change allows not to use this logic when dumping code coverage in
a fuzzing build. The fuzzing coverage bots are using --disable-sandbox
anyway, so this just improves their stability and performance.

This change may be reverted in future if/when the underlying issue in
OpenCoverageFile/SetCoverageFile gets resolved. It does not affect non
fuzzing builds (e.g. blink layout tests), therefore is not a priority.

Bug: 1002058,957581
Change-Id: Ic847aaadf9dd2c4a8130f9736b15f9c2cb3171ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981022Reviewed-by: Sajjad Mirza <sajjadm@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729931}

InspectorTaskRunner queues itself for a V8 interrupt, but V8 doesn't
automatically increment the task runner's refcount. As a result,
InspectorTaskRunner needs to manually increment and decrement its
own refcount to ensure that it doesn't get deleted, which would
otherwise result in V8 hanging onto a dangling pointer.

Bug: 933128
Change-Id: I715734015bbf810ecbba5f4e509fcc924b3aa1b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993436Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#729930}

Whenever there is a MediaRoute update for an existing media notification
item, update the view if necessary.

Bug: 1040207
Change-Id: Ie8c28237fee56268f20dd57e08f9cf405fdb79cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992690Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729929}

https://pdfium.googlesource.com/pdfium.git/+log/f793e3abc4ec..3c04fb3a9464

git log f793e3abc4ec..3c04fb3a9464 --date=short --first-parent --format='%ad %ae %s'
2020-01-09 tsepez@chromium.org Cover FPDF_GetDefaultTTFMap() from embedder tests.
2020-01-09 tsepez@chromium.org Watch CFXA_FFWidgets across more On* methods.
2020-01-09 tsepez@chromium.org Ensure CFWL_Widget::m_pTextOut is initialized.

Created with:
  gclient setdep -r src/third_party/pdfium@3c04fb3a9464

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I18e4257ed9a16265973dfb124855b024adb0903c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993881Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729928}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/797d74a266bb..12f8d69f1288

git log 797d74a266bb..12f8d69f1288 --date=short --first-parent --format='%ad %ae %s'
2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@12f8d69f1288

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Id353d9adffbf9e54e2cee6cce71f410ea4f9a731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993571Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729927}

Ignore existing presubmit errors in preference_spinner_*.xml

NOPRESUBMIT=true

Bug: 1035928
Change-Id: I3c25864ff3e3e82ecc6bffbbd30a945df6539f42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992815Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729926}