GitLab

BUG=304341

Review URL: https://codereview.chromium.org/118553006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327911

Review URL: https://codereview.chromium.org/123733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243207 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331177, 330993, 331285

Review URL: https://codereview.chromium.org/118033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243206 0039d316-1c4b-4281-b951-d872f2087c98

Versions 0.2 of PPB_AudioInput_Dev and PPB_VideoCapture_Dev are no longer used.

BUG=

Review URL: https://codereview.chromium.org/115343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243205 0039d316-1c4b-4281-b951-d872f2087c98

TouchCommon utils are preferable for test use because they work
even if there is a crash dialog on the screen from a previous test.
This makes the tests run more robustly.

BUG=320084
NOTRY=true

Review URL: https://codereview.chromium.org/105173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243203 0039d316-1c4b-4281-b951-d872f2087c98

Valgrind: Remove obsolete suppressions.

BUG=147755,310348
NOTRY=true
TBR=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/122313006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243202 0039d316-1c4b-4281-b951-d872f2087c98

Refactors histogram increments into virtual methods for mocking.

Adds unit tests that expect the correct metrics calls.

Fixes timing of RecordDataReductionInit() so that it happens when the
proxy is unavailable.


BUG=328579

Review URL: https://codereview.chromium.org/111113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243201 0039d316-1c4b-4281-b951-d872f2087c98

Report known bisect results at the end of each step. This will allow jobs that fail unexpectedly to be easily resubmitted with a reduced range by perf sheriffs.

Example output:

@@@SEED_STEP Working on [519ed0d5]@@@
@@@STEP_CURSOR Working on [519ed0d5]@@@
@@@STEP_STARTED@@@

Working on revision: [519ed0d5]

Partial results:
         Depot                         Commit SHA                     Mean       Std. Error       State    
        chromium        400664c4      0.00         +-0.00          Bad     
        chromium        fc062604      0.00         +-0.00          Bad     
        chromium        1ce41529      0.00         +-0.00          Bad     
        chromium        519ed0d5      0.00         +-0.00          Bad     

        chromium        48193642      0.00         +-0.00          Good    

@@@STEP_CLOSED@@@


BUG=331802
NOTRY=true

Review URL: https://codereview.chromium.org/122613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243200 0039d316-1c4b-4281-b951-d872f2087c98

The code has other protections to ensure all programs will be eventually deleted, and only once for each time they're created.

BUG=326328
R=hclam@chromium.org

Review URL: https://codereview.chromium.org/123613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243196 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/107703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243195 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326635
TEST=Existing
R=jdduke

Review URL: https://codereview.chromium.org/124283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243194 0039d316-1c4b-4281-b951-d872f2087c98

This also adds the inline sign-in views to the bubble.

Screenshot: https://drive.google.com/file/d/0B1B1Up4p2NRMbGRkQ3FpWFZweVU/edit?usp=sharing
BUG=324036
TEST=Start Chrome with --new-profile-management and --enable-inline-sign-in flags. 
For a local profile, click on the avatar button and press the "Sign in to 
Chromium" link from the avatar bubble. This should display an inline sign-in
view inside the bubble. For a signed in profile, press the "Manage accounts" 
link. This should show you the email accounts linked to this profile. Clicking 
the big "add account" button should show you the inline sign-in view 
embedded in the bubble. Once an email has been added, the account 
management view should refresh and display this new email account.

Review URL: https://codereview.chromium.org/114143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243193 0039d316-1c4b-4281-b951-d872f2087c98

Valgrind: Suppress an occasional leak inside net::URLFetcherCore::StartURLRequestWhenAppropriate. Remove a similar, but obsolete suppression.

BUG=80663,331925
NOTRY=true
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/119903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243192 0039d316-1c4b-4281-b951-d872f2087c98

Previous CL: https://codereview.chromium.org/109793006/

BUG=328246

Review URL: https://codereview.chromium.org/115973007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243191 0039d316-1c4b-4281-b951-d872f2087c98

The android directory has otherwise been empty since r203351.

TBR=jamesr,mkosiba
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/110893008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243190 0039d316-1c4b-4281-b951-d872f2087c98

This change will cause slightly different translations and address layout to
show when the --enable-autofill-address-i18n flag is passed.

Next up:
- pull translations from chrome rather than libaddressinput
- show country combobox and rebuild inputs on switch

Based on https://codereview.chromium.org/25620002 by Rouslan Solomakhin <rouslan@chromium.org>.

BUG=317837
TBR=aruslan

Review URL: https://codereview.chromium.org/63053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243189 0039d316-1c4b-4281-b951-d872f2087c98

This uses the same histogram name as the existing NTP (Tab.NewTabOnload) which
should make it easy to see how it compares to the old load times.

BUG=325228
TESTED=manually, looking at about://histograms

Review URL: https://codereview.chromium.org/112453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243188 0039d316-1c4b-4281-b951-d872f2087c98

This is a huge change, but it's all refactoring / renaming.
There should be no new logic.

BUG=316726
R=dtseng@chromium.org, jam@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/116293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243187 0039d316-1c4b-4281-b951-d872f2087c98

Telemetry uses a '.' to delimit chart_name and trace_names in Value types, so
trace names cannot include a '.' in them.

BUG=329845

Review URL: https://codereview.chromium.org/116043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243186 0039d316-1c4b-4281-b951-d872f2087c98

Cleaned up a few of the existing tests.

BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/100143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243185 0039d316-1c4b-4281-b951-d872f2087c98

Remove calls of PrerenderTracker::TryCancel and TryCancelOnIOThread in ChromeResourceDispatcherHostDelegate. These short-circuited cancelling the prerendering on the IO thread. Instead, I moved cancelling the prerender on the UI thread since both of these calls end up going to the UI thread right after.

This also removes the last calls of ResourceRequestInfo::GetAssociatedRenderView, which I will remove in a followup.

BUG=304341
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/124113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243184 0039d316-1c4b-4281-b951-d872f2087c98

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/108723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243183 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: This CL is causing crbug.com/331773. We intentionally leave the codepath for android in https://chromiumcodereview.appspot.com/11742017.

TBR=jam@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/105273013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243181 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Visual
1. in chrome://flags verify that ash-disable-docked-windows is present.
2. in chrome://flags verify that ash-enable-docked-windows is absent.
3. When running chrome without ash-enable-docked-windows it should be possible to dock a window at a screen edge.
TEST=ash_unittests --gtest_filter=*Dock*

Review URL: https://codereview.chromium.org/123743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243178 0039d316-1c4b-4281-b951-d872f2087c98

Add EasyResizeWindowTargeter to allow easily resizing windows with mouse/touch
with the new event-dispatch code. This will eventually allow getting rid of
Window::SetHitTestBoundsOverrideOuter() once the new event-dispatch code is used
for all event types. This patch installs an EasyResizeWindowTargeter for the
shelf and status-area widgets. Subsequent CLs will install such targeters for the
toplevel windows too.

Collateral change includes adding some dependencies on wm_public (in DEPS and gyp).

BUG=318879
R=ben@chromium.org

Review URL: https://codereview.chromium.org/118553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243177 0039d316-1c4b-4281-b951-d872f2087c98

(Still need to implement for two-phase writes.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/98013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/122443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243175 0039d316-1c4b-4281-b951-d872f2087c98

The Download.ShowDangerousDownloadConfirmationPrompt UMA stat tells us
how often people go through the last step of recovering a malicious
binary from chrome://downloads.

This UMA stat was added for GTK, but was missing for Win/CrOS. This CL
adds it to the Views (Win/CrOS) version of the dialog.

BUG=331603

Review URL: https://codereview.chromium.org/114003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243172 0039d316-1c4b-4281-b951-d872f2087c98

Installers should no longer pick it up already.

Also add a note to chrome_repack_chrome.gypi mentioning that it's on the way out.

BUG=52609
NOTRY=true

Review URL: https://codereview.chromium.org/102283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243171 0039d316-1c4b-4281-b951-d872f2087c98

Many unit tests only run on the first stream. With the upcoming changes to
SimpleCache, each stream will have a different implementation. This CL ensures
test are ran on all streams.

BUG=173398

Review URL: https://codereview.chromium.org/23702024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243170 0039d316-1c4b-4281-b951-d872f2087c98

Add BrowserViewLayoutDelegate::GetContentsWebView helper.
(avoids direct BrowserView usage by BrowserViewLayout)
Consider the latest dialog position *AND* size on updates.
(previously, the maximum dialog size was incorrectly ignored)
Only use the contents WebView bounds, not its container.
(the container also includes the dev tools view bounds)
Minor BrowserViewLayout cleanup and refactoring.

BUG=328798
TEST=Collected Cookies and Print Preview dialogs resize as the web tools height is manually adjusted.
R=ben@chromium.org

Review URL: https://codereview.chromium.org/99153012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243168 0039d316-1c4b-4281-b951-d872f2087c98

Previous CL: https://codereview.chromium.org/99463006/

BUG=329088

Review URL: https://codereview.chromium.org/121083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243166 0039d316-1c4b-4281-b951-d872f2087c98

This makes it match its sibling, AudioDecoder.

BUG=329379

Review URL: https://codereview.chromium.org/123213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243163 0039d316-1c4b-4281-b951-d872f2087c98

Previously on a TracingController error, OnBeginRequest returns false,
and then WebUIDataSource will return the default resource (tracing.html).
This will cause a successful XHR request and a JSON parse failure in
tracing frontend code. Return "##ERROR##" to express the error so that
the frontend can handle the error.

BUG=331286

Review URL: https://codereview.chromium.org/117323008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243162 0039d316-1c4b-4281-b951-d872f2087c98

dtseng and plundblad are now primary owners, zork and hashimoto are no
longer working on accessibility.

BUG=none
R=zork@chromium.org

Review URL: https://codereview.chromium.org/102963008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243161 0039d316-1c4b-4281-b951-d872f2087c98

TabBase will build it's own native component if nobody overrides initializeNative().

BUG=277135

Review URL: https://codereview.chromium.org/108803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243160 0039d316-1c4b-4281-b951-d872f2087c98

This CL contains supporting code for C++ APIs and the C++ equivalent of chrome.alarms.

BUG=327197
TEST=None

Review URL: https://codereview.chromium.org/116963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243158 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327834
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/125313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243153 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/123473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243152 0039d316-1c4b-4281-b951-d872f2087c98

  a secondary sort key when there are multiple configs with the same
  primary time.
- Fixes to QuicCryptoServerConfig::SetConfigs to allow replacing all
  configs including the primary config in one go.
- Change the name of QuicCryptoServerConfig::DefaultConfig to
  GenerateConfig.
- Generalize the method of the StrikeRegisterClient interface used to
  verify orbits of new configs so that it allows for orbit changes or
  strike registers that know about multiple orbits.

Merge internal change: 58556020

R=rch@chromium.org

Review URL: https://codereview.chromium.org/113883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243151 0039d316-1c4b-4281-b951-d872f2087c98