GitLab

For some reason the toolbar title text size is not font scale dependent.
Increasing the font size in Accessibility->Font Size will change the text
size everywhere except the app title. This CL fixes this problem by defining
the title text size explicitly in sp.

BUG=635584

Review-Url: https://codereview.chromium.org/2270283003
Cr-Commit-Position: refs/heads/master@{#414230}

Pretty trivial as they were already implemented and just needed to be
hooked up.

BUG=639949

Review-Url: https://codereview.chromium.org/2263423002
Cr-Commit-Position: refs/heads/master@{#414229}

add toString() funtion in DOMMatrixReadOnly.
refer to detail spec([1])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-stringifier

BUG=388780

Review-Url: https://codereview.chromium.org/2273663002
Cr-Commit-Position: refs/heads/master@{#414228}

Though ComputeTranslation should result in a translation transform, we
can end up with non-translation transforms when we have noisy transforms.

BUG=639203
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2271273003
Cr-Commit-Position: refs/heads/master@{#414227}

This CL also makes the AddToHomescreenDataFetcher::Observer overrides private

BUG=627250

Review-Url: https://codereview.chromium.org/2278693002
Cr-Commit-Position: refs/heads/master@{#414226}

This is more of a kill switch than a feature flag, so it deserves to be
enabled until deemed harmful.

BUG=

Review-Url: https://codereview.chromium.org/2273873002
Cr-Commit-Position: refs/heads/master@{#414225}

BUG=639095

Review-Url: https://codereview.chromium.org/2274223003
Cr-Commit-Position: refs/heads/master@{#414224}

This was temporarily introduced to A/B test MultibufferDataSource
which has been stable since M52 now. Time to delete!

BUG=588903
TEST=compile

Review-Url: https://codereview.chromium.org/2272163002
Cr-Commit-Position: refs/heads/master@{#414223}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/74225cd7..d09641f4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2271313003
Cr-Commit-Position: refs/heads/master@{#414222}

The user action pseudo classes rely on affectedBy bits to be correctly
set on ComputedStyle in order to recalculate style for such changes
later on. If two elements may otherwise share style, but will have the
affectedBy bits set differently, they may not share style.

Example:

  <style>[attr]:hover {}</style>
  <div></div>
  <div attr></div>

The second div may share style with the first one when none of them is
hovered. However, matching the selector against the first div will fail
on the attribute selector before we try to match :hover, hence the flag
for affectedByHover will not be set. If we share that ComputedStyle
object with the second div, hovering the second div later will have no
effect.

Instead we always match :hover/:active/:focus/:-webkit-drag when
matching rules for style sharing (attribute and sibling rules). That
will lead to the attribute selector in the example above to match which
will cause style sharing to be rejected for the second div.

R=meade@chromium.org
BUG=639561

Review-Url: https://codereview.chromium.org/2272683002
Cr-Commit-Position: refs/heads/master@{#414221}

The surface is fully transparent when alpha is 0 and we can then
avoid to create a texture quad completely. Failing to do so
currently results in unnecessary compositing.

BUG=640805
TEST=exo_unittests

Review-Url: https://codereview.chromium.org/2277833004
Cr-Commit-Position: refs/heads/master@{#414220}

Previously the restoreBreakpoints method implictly relied on the inspected URL being set
to the current inspected URL. This CL simplifies the logic for setting the inspected URL
and ensures that the inspected URL is always accurate in the process of restoring breakpoints.

BUG=627296

Review-Url: https://codereview.chromium.org/2277543002
Cr-Commit-Position: refs/heads/master@{#414219}

The code is mistaking a missing reader for an error, but readers are now destroyed and re-created on demand.
Adding a new variable to explicitly track failures fixes the problem.

BUG=639690

Review-Url: https://codereview.chromium.org/2271313002
Cr-Commit-Position: refs/heads/master@{#414218}

Security review recommends explicitly setting the 'exported' property
in the Android manifest. This avoids exposing private items on older
versions of Android.

According to
https://developer.android.com/guide/topics/manifest/activity-element.html#exported
this setting defaults to true for Activities with Intent filters, false
otherwise.

BUG=638032

Review-Url: https://codereview.chromium.org/2272883003
Cr-Commit-Position: refs/heads/master@{#414217}

Revert of clang plugin: Remove check-templates toggle. (patchset #1 id:1 of https://codereview.chromium.org/2267713003/ )

Reason for revert:
This broke the weak_ptr_factory.cpp test: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/6121/steps/gclient%20runhooks/logs/stdio

I think this check effectively always disabled the check-templates flag instead of always enabling it.

And it sucks that we didn't notice for two days :-(

Original issue's description:
> clang plugin: Remove check-templates toggle.
>
> It's been on by default for a long time.
>
> BUG=441916
>
> Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
> Cr-Commit-Position: refs/heads/master@{#413546}

TBR=dcheng@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=441916

Review-Url: https://codereview.chromium.org/2278603004
Cr-Commit-Position: refs/heads/master@{#414216}

This is mostly a follow-up to an unintentional behavior change in
https://codereview.chromium.org/2255403002/ .  I decided to treat 0 size as
invalid as well.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2278743002
Cr-Commit-Position: refs/heads/master@{#414215}

This UMA records the time taken between sending an event IPC from
the browser process to a Service Worker and executing the event
handler in the Service Worker.

This CL depends on https://codereview.chromium.org/2249063004/.

BUG=561209

Review-Url: https://codereview.chromium.org/2218943002
Cr-Commit-Position: refs/heads/master@{#414214}

set the callback. Should help explain how we're crashing in
http://crbug.com/640288

BUG=640288

Review-Url: https://codereview.chromium.org/2267283003
Cr-Commit-Position: refs/heads/master@{#414213}

The one left that gets used is max_texture_size, for scrollbars. Since
painted scrollbars only happen on desktop, and we just make them blurry
if they exceed the max size, we just hardcode a limit of 2048 which
should be supported on any desktop device (it's guaranteed by DirectX9)
and we're fine with scrollbars becoming less than pixel-perfect if you
pinch zoom in and they become larger than max-texture-size anyhow.

Everything else is unused or already deleted, so kill the structures
and the thread/ipc messages related to them.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2267263002
Cr-Commit-Position: refs/heads/master@{#414212}

This is Apple's new gamepad API for Mac and iOS devices, which imposes a ridgid
set of guidelines on controller capabilities, similar to XInput on Windows. This
allows us to provide a "standard" mapping for every compatible controller. While
there aren't many on the market right now, it should make us more future proof
and provide better compatibility with newer controllers.

BUG=638588

Review-Url: https://codereview.chromium.org/2271353002
Cr-Commit-Position: refs/heads/master@{#414211}

The heap profiler gets context for each allocation only from trace
events whose category is enabled for recording. This CL changes:
1. The AddTraceEvent was called only for trace events with categories
   that are enabled for recording modes, but now it gets called for all
   categories including ones specified in filters.
2. Trace events are not added to traces if the category is enabled for
   filtering but not enabled for recording, irrespective of the filter
   result.
3. Add new filter "heap_profiler_predicate" that tracks trace events and
   adds to heap profiler pseudo stack. This filter returns true only for
   the events enabled for recording mode (only the recording mode is
   affected by filters, not etw and event callback modes).
4. When "memory-infra" is enabled with heap profiler flag turned on,
   then the heap profiler filter is installed by default and filters all
   categories and adds to trace only if the category is enabled for
   recording.

This ensures that the heap profiler filter always gets all trace events
and they only get added to trace file if they are enabled for recording,
or they are enabled by other filters.

BUG=598426, 625170

Review-Url: https://codereview.chromium.org/2259493003
Cr-Commit-Position: refs/heads/master@{#414210}

This only affects the printing of web pages directly on the host.

- Renderer tells the browser if the print job is HTML. (AKA modifiable)
-- Browser does lots of plumbing to get the bool into PrintSettings.
-- Print preview already sends this info and it just needs extraction.
- Add --disable-gdi-text-printing for reverting to old behavior.
- Browser plumbs bool to PdfToEmfConverter to the utility process.
- Utility plumbs bool into the PDF plugin code into PDFium.
- Move unused PreCacheFontCharacters code out of RenderThreadImpl.
-- Use it in PrintingHandler instead.
- Remove dead code, fix lint errors / typos.

BUG=409472

Review-Url: https://codereview.chromium.org/2114583002
Cr-Commit-Position: refs/heads/master@{#414209}

BUG=627517
TBR=

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2263843002
Cr-Commit-Position: refs/heads/master@{#414208}

The session restore logic (specifically when exiting and restarting)
depends on NOTIFICATION_NAV_ENTRY_CHANGED notifications for subframes.
In the old navigation logic, this happened for subframes during the
first UpdateState after an AUTO_SUBFRAME commit.  In the new navigation
logic, we have already put the PageState on the FrameNavigationEntry
at commit time, so the UpdateState typically looks like a no-op and
doesn't generate a notification.

To fix this (and get the notification out as early as possible), this
CL notifies at commit time for AUTO_SUBFRAMEs.

BUG=638088
TEST=Visit chrome://help, then chrome://restart.
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2275643003
Cr-Commit-Position: refs/heads/master@{#414207}

QUIC sockets.

BUG=636544

Review-Url: https://codereview.chromium.org/2235973002
Cr-Commit-Position: refs/heads/master@{#414206}

R=haraken
BUG=none

Review-Url: https://codereview.chromium.org/2273873004
Cr-Commit-Position: refs/heads/master@{#414205}

This CL optimizes memory usage of cc::ContiguousContainer by deferring memory
allocation in ContiguousContainerBase::Buffer until the first Allocate() call.
Previously memory was allocated in the Buffer constructor, and sometimes was
never written to (see the bug for more info).

BUG=635142
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2277433002
Cr-Commit-Position: refs/heads/master@{#414204}

Since I recently changed my chromium account alias, updating OWNERS files
to match.

R=afakhry@chromium.org
BUG=None.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2270033005
Cr-Commit-Position: refs/heads/master@{#414203}

Instead of trying to figure out what the max texture size is on the
main thread, and scale raster to meet that, just raster freely. Then
when uploading the UIResource to a texture, we can easily tell what
the max texture size is, and if the UIResource is too large, scale it
down to fit in a texture.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2276633003
Cr-Commit-Position: refs/heads/master@{#414202}

BUG=598405

Review-Url: https://codereview.chromium.org/2262733004
Cr-Commit-Position: refs/heads/master@{#414201}

. Rename GpuServiceMus to GpuServiceInternal.
. Rename GpuServiceImpl to GpuServiceProxy, and move it into the
  window-server directory.
. Instead of creating a new instance of GpuServiceProxy for each
  client, update GpuServiceProxy so that a single instance can service
  all clients

BUG=613366

Review-Url: https://codereview.chromium.org/2276433004
Cr-Commit-Position: refs/heads/master@{#414200}

Prepare to remove it as it can be computed out of samples.
Also rename CPUProfile to Profile.

BUG=635947

Review-Url: https://codereview.chromium.org/2279513002
Cr-Commit-Position: refs/heads/master@{#414199}

This was reverted because of flake on linux. I've identified why the
flake was happening and filed a bug, so I'm leaving the enabling as
only chromeos and windows at this time.

These tests were disabled because the resize lock can trigger at
random points, blocking event delivery and breaking the tests. I've
added a switch to disable the resize lock so that events now have
known delivery order.

BUG=331924, 640741
TEST=none
R=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2277923002
Cr-Commit-Position: refs/heads/master@{#414198}

* Replaces MessageFilter with MessageReceiver
* Updates FilterChain to always end on the sink, short-circuiting
  if any "filter" (receiver) rejects along the way
* Adds a new AddFilter() interface to mojo::Binding and
  mojo::AssociatedBinding, allowing users to inject MessageReceiver
  filters to be run immediately before every message dispatch

BUG=612500
R=yzshen@chromium.org
TBR=tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2276043002
Cr-Commit-Position: refs/heads/master@{#414197}

I came across these in looking at some other stuff.

BUG=none
TEST=none
R=thomasanderson@google.com

Review-Url: https://codereview.chromium.org/2276153002
Cr-Commit-Position: refs/heads/master@{#414196}

disable_outdated_build_detector_unittests only builds on 32-bit so having it
as a target on a 64-bit bot makes no sense.

BUG=640667
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2268823005
Cr-Commit-Position: refs/heads/master@{#414195}

There is an old tab_state file in the tabbed mode state directory. If
it is not deleted and the new tab state is written to the new
tab_state0 file, then when it comes time to run the migration code in
TabPersistentStore the old tab_state file will be given preference
and overwrite the new one with all the document mode tabs that were
just migrated. Thus we need to delete the old tab_state file if it
exists.

BUG=640625

Review-Url: https://codereview.chromium.org/2274943002
Cr-Commit-Position: refs/heads/master@{#414194}

BUG=626752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2264673002
Cr-Commit-Position: refs/heads/master@{#414193}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bf97a9b56b2e52c181449842c6661bff57f7bed9 [Skia] Handle Gerrit patches in swarm_trigger for the Infra-PerCommit bot. (rmistry@google.com)
  https://crrev.com/5c8f9ca183558efd72da8de33fc764f2083ff054 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/da7d759d2b8a6a43fbbc882bd6e0fb5f6847f4d2 Make webrtc recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/48c9aab3cb53a5c254ec5d2d6fcf62e8c6d6fd0e Make bisection recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/12067f7d61f048f13b41feb9a59635df911af6af Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/a6d4645baf26287ae6c0870a1206624bfa59fd83 Make skia recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/ecde496f342028076fcfe127b34955524824b477 Created a line of summary and enabled suite name onclick function. (hzl@google.com)
depot_tools:
  https://crrev.com/eab3c0431157226b2638af23545d3f17bd04a25d Change "tryjob" -> "try job" in git_cl.py and trychange.py. (qyearsley@chromium.org)
  https://crrev.com/12fa6ff69b21737c315ccad0d92f1bccf83fee6c Run auto-spell-checker (codespell) on files in depot_tools. (qyearsley@chromium.org)
  https://crrev.com/92bec4f56f991d35ddcf9c4d8a0bdd8ce1b10735 Delete gcl, drover, and trychange (agable@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=475321,640251,skia:5627

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2271243003
Cr-Commit-Position: refs/heads/master@{#414192}

R=sebmarchand@chromium.org
BUG=314403

Review-Url: https://codereview.chromium.org/2278713002
Cr-Commit-Position: refs/heads/master@{#414191}