- 05 Mar, 2019 40 commits
-
-
Roberto Carrillo authored
R=bpastene,jbudorick,liaoyuke,stgao,sajjadm@google.com Change-Id: I3d5da142211c4d8ce33288b6bdaf202710952963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484731Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#637547}
-
Xiaocheng Hu authored
This patch changes almost all VisibleSelectionInFlatTree-typed local variables into SelectionInFlatTree as a preparation to remove unnecessary canonicalizations from SelectionController. Bug: 657237 Change-Id: Id6234ddf3a920f31a02a7474975c6b029c49a56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500699Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#637546}
-
Ahmed Fakhry authored
This CL is a follow-up https://crrev.com/c/1475159 to add the animations for the desk mini views creation and removal. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=866622#c7 BUG=866622 Change-Id: If34cb407ac6617e71a66f11f914d94e91148f7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500253 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#637545}
-
Robbie McElrath authored
Bug: 937139 Change-Id: Icbf0141a8561179eb3a26e6112f66764f1db7af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496603 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#637544}
-
Jeffrey Cohen authored
This will avoid each client having to individually interact with a history service, and consolidate the code needed to link SendTabToSelf and the history services under//components/send_tab_to_self. Bug: 910390 Change-Id: I8c53e63d0a28a398385533446170408483db8b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500834 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#637543}
-
dstockwell authored
Bug: 902646, 933205 Change-Id: I7ddb3da8ac6131532896f886a03451351b3780aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482356 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#637542}
-
Dan Beam authored
Screenshot: https://imgur.com/a/ieMzOhL R=aee@chromium.org BUG=883049 Change-Id: Ia993dc5c2661c1d033f0c0191b29a352e79b13c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501352 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#637541}
-
Jacob DeWitt authored
According to WebXR spec https://immersive-web.github.io/webxr/#dom-xrframe-getpose Bug: 922202 Change-Id: Ia7af7156e4195cb01d1eebda2701520d2ab836b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480272Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#637540}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8949933bd5aa..ccc29087522a git log 8949933bd5aa..ccc29087522a --date=short --no-merges --format='%ad %ae %s' 2019-03-04 mattm@chromium.org Fix areValidConstants checking timeTickOffset twice with different expectations. 2019-03-04 benjhayden@chromium.org Add alerts-section to chromeperf-app. Created with: gclient setdep -r src/third_party/catapult@ccc29087522a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:917273,chromium:918193 TBR=sullivan@chromium.org Change-Id: Iea7ce1376b0639a993827a5bb9c146e754242f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637539}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I775d749c6fde7f7ebfcbbd5f9a6ef75bccce37b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501273Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#637538}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a3be9a522b8a..cf661acb705f git log a3be9a522b8a..cf661acb705f --date=short --no-merges --format='%ad %ae %s' 2019-03-04 iannucci@chromium.org [bot_update] Downstream change for buildbucket proto update. Created with: gclient setdep -r src/third_party/depot_tools@cf661acb705f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:930761,chromium:927716 TBR=agable@chromium.org Change-Id: I7349eca1cd1a542b20469e1de3c736e4de769b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637537}
-
Maggie Cai authored
Currently the sort on All Sites page only sorts the etld+1, not the origins under the etld+1. This CL updates to sort the origins under each etld+1 as well. BUG=922847,835712 Change-Id: Ifcfdb71fa344839e9270d26bc182fa061e3fbca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491056Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637536}
-
Chase Phillips authored
We previously had no way to remove a cursor mojo binding when, for example, we received an abort from the renderer. To remove a cursor mojo binding, we need to save the mojo::BindingId returned by the AddBinding() call. We also will need to access the BindingSet where the binding is stored, which is held by the IndexedDBDispatcherHost instance. Save both a base::WeakPtr<IndexedDBDispatcherHost> and the mojo::BindingId in the IndexedDBCursor instance so we can later remove the binding. Then, on abort, call the new RemoveBinding() function on the cursor object to trigger the removal. Bug: 717812 Change-Id: Ia6c0373d4e62b1bd5b80d2edb15c8bc15a208754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480697 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#637535}
-
John Rummell authored
Rather than checking if MediaDrm supports persistent licenses, check if per-origin provisioning is supported. If it is, require an origin ID to be used. BUG=917527 TEST=existing origin_id tests pass Change-Id: Ifa58cc7260d3a1255ea8f42ba2035fa912d3cbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493203 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#637534}
-
Josh Nohle authored
Bug: 899080 Change-Id: Ic3428f5c3c1387ca63138f20b6e52d588a9a8619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499835 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#637533}
-
Aidan Wolter authored
BUILD.gn cleanup. Bug: internal b/126768956 Test: CQ Change-Id: I8cf95cbe493a99f8f448ee2a9b883ab2e346678d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496420 Commit-Queue: Aidan Wolter <awolter@chromium.org> Auto-Submit: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#637532}
-
Scott Violet authored
Specifically for the time it takes to send an event to the client BUG=none TEST=none Change-Id: Ib7e0342e395ce247c340c8d361d55efaf34565ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500626 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637531}
-
John Budorick authored
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: 928475 Change-Id: I6c3931bc6e6ec0fa9d2bab375a97975e8a531043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476262Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#637530}
-
Wenzhao Zang authored
Bug: 894270 Change-Id: Idc475dd5ed0b192f0fbdfa4322a3bb72886d16ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478400 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#637529}
-
Dan Beam authored
R=thestig@chromium.org BUG=883049 Change-Id: Iebd3774ea60fddcdecf1e6329a9b4a6a44f63f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500627 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#637528}
-
Gyuyoung Kim authored
Apply new review comments to the original CL more. This CL makes to use alternative ones instead of LocalFrame in the first argument of UseCounter::Count. Bug: 936187 Change-Id: Id667b57aa596f37e19dd283b53f3857142e81603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498256Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#637527}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/081d5c2f6480..c8eff1c1e1b8 git log 081d5c2f6480..c8eff1c1e1b8 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 enga@chromium.org Remove export of GLVersion from GLAD Created with: gclient setdep -r src/third_party/dawn@c8eff1c1e1b8 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:877147 TBR=cwallez@chromium.org Change-Id: I16eb931126e8a800f26d3d30524300aa1e004fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500624Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637526}
-
Devlin Cronin authored
Extension bindings use a custom console object so that untrusted script can't intercept any calls. This custom console reports messages via RenderFrame::AddMessageToConsole(), which reports the messages to the developer console and the browser process, which also logs them to the terminal if appropriate (e.g., in debug mode or with --enable-logging). These logs are both important for developers (when something goes wrong so they can see it in the console) and to browser tests (so that we get detailed errors and can debug). Unfortunately, these aren't currently logged for ServiceWorker contexts, because there is no RenderFrame to log the message with. Fix this by adding a new WebConsoleMessage::LogWebConsoleMessage() static method that takes a v8::Context and logs the message in the execution context associated with that context. This works for both frame-based and worker-based contexts. Additionally, expose a OnReportConsoleMessage() virtual method on ServiceWorkerContextObserver to allow extensions code to observe console messages. This allows us to test this behavior, and could also be used to hook into recording error messages in extensions (e.g. for the extensions::ErrorConsole). Bug: 933941 Change-Id: Ic67ed46a608c3b4340e25fe695689d2cfeca30aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495045 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#637525}
-
Min Qin authored
just for safety purpose. Change-Id: I51b3bf11604ab43966343ed1b348cdf8d5ec0227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501335Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637524}
-
Yi Gu authored
Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ProcessMemoryMetricsEmitterTest.ForegroundAndBackgroundPages TBR=fdoray@chromium.org Bug: 938054 Change-Id: I44755371221cfc92ffad710a5e2da77e59578c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500630Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637523}
-
Antoine Labour authored
We create shared images instead of GLES2 textures so that we can use APIs other than GL (Vulkan, etc.). Bug: 882568 Change-Id: Ibc688e49a0680d5b1397a0995a4544db42c42e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480395 Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#637522}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82b33f4ea601..156cf83837bc git log 82b33f4ea601..156cf83837bc --date=short --no-merges --format='%ad %ae %s' 2019-03-04 hjd@google.com Fix for Chromium roll 2019-03-04 primiano@google.com Merge "TraceProcessor: improve process tracking to follow fork()/clone()" 2019-03-04 eseckler@google.com base: Fix windows compile for chromium roll. 2019-03-04 hjd@google.com Merge "trace_processor: Fix trace_processor fuzzer" 2019-03-04 taylori@google.com Merge "perfetto-ui: Quantize cpu frequency track" 2019-03-04 eseckler@google.com Merge "proto: Make LegacyEvent proto flags more descriptive" 2019-03-04 primiano@google.com Merge "Add find() and rfind() methods to base::StringView" Created with: gclient setdep -r src/third_party/perfetto@156cf83837bc The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I96ed3cb31cf7d744c69d955683b88755ca3b1bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637521}
-
Aran Gilman authored
Change-Id: I81848803bac5c462da39147f0e21c45b957470bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497213 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Auto-Submit: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#637520}
-
Steven Bennetts authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1469521 This CL: * Introduces a NetworkIconState to cache state that the network icon code cares about in an intermediate format that will be compatable with Mojo network state. * Fixes a rather bad edge case (that I previously introduced) where ActiveNetworkIcon stores pointers to NetworkState that could possibly be accessed after being deleted. * Modifies the criteria for ActiveNetworksChanged() to include significant changes to signal strength. * Adds some verbose logging for continued debugging. R=tbarzic@chromium.org, khorimoto@chromium.org Bug: 923444 Change-Id: Ifb3aafa06028957403c2df3ea71d9993a9572e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500595 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#637519}
-
Yi Gu authored
Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Fexternal%2Fwpt%2Fanimation-worklet%2Fworklet-animation-pause-resume.https.html%20 Mark test flaky only on linux to bring test coverage back on mac / win. TBR=majidvp@chromium.org NOTRY=true Bug: 915352 Change-Id: I8ddb92ccecd43b2c4c6588558526f39cc841c4e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501513Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637518}
-
Salvador Guerrero authored
When a shared leveldb_proto database is requested for the first time with create_if_missing false and the database doesn't exist then it returns kInvalidArgument which is correct, the second time it is requested it returns kError, because it attempts to initialize the metadata database which was already initialized on the first init. This CL adds status checks to shared_proto_database to avoid initializing the metadata database twice. Bug: 870813 Change-Id: I00ce592202a18909ba0258f1393b816a572b228f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497223 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#637517}
-
Aidan Wolter authored
This target should conceptually depend only on content/public/browser interfaces and things it depends on, not on //content itself or other targets. Bug: internal b/126768956 Test: CQ Change-Id: I2215f12e5ed16fe0c711a6fd6bce10b775e95b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496421 Auto-Submit: Aidan Wolter <awolter@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#637516}
-
Kevin Marshall authored
This reverts commit 9b0f9f43, but keeps the naming of the "fuchsia_artifacts" directory intact so that the official builders don't break. Bug: 936645, 772252 Change-Id: I9fdc6100e47775afeafd1b7ab3d81b707c689397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500606Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#637515}
-
Jay Harris authored
Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=380627&signed_aid=jfI6IT-5WqkzZM52gCoCpw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382384&signed_aid=kzQkeS4IcgXr6YwzIwFhig==&inline=1 Bug: 853593 Change-Id: I3e869f474b911eaec1a1fbfa94121b54c998f01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480300 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#637514}
-
Takuto Ikuta authored
I'm considering to replace deps for proto_library to proto_deps or link_deps for better build dependency management and performance. Especially, I'd like to use link_deps for dependency from proto_library target to proto_library target. e.g. https://cs.chromium.org/chromium/src/components/send_tab_to_self/proto/BUILD.gn?l=27&rcl=6bdb263ca522ba42fdbd910769dcd869050d3d75 Bug: 938011 Change-Id: I67ef8b534d0ae89fdaf9f5f9f2520a1fbdcdbf98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498264 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#637513}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d838178daa49..b36f7a25a8a4 git log d838178daa49..b36f7a25a8a4 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 kpschoedel@google.com Update gpu_test_expectations 2019-03-04 tobine@google.com Vulkan:Add SecondaryCommandBuffer class 2019-03-04 jmadill@google.com Revert "Vulkan: Update code hash after roll." 2019-03-04 geofflang@chromium.org D3D: Asynchronously load program binaries. Created with: gclient setdep -r src/third_party/angle@b36f7a25a8a4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie07e6a62e4ac54d80cec82906c84c9dff0ed201a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637512}
-
Maggie Chen authored
This is done by setting interpolation mode to linear in direct composition visual. The visual default is nearest mode and the quality is not good. The upscaling quality improves after calling SetBitmapInterpolationMode() to change the interpolation mode to linear. Bug: 936538 Change-Id: Iabdf25e2035fc6423362dc16efea7045a60f386f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497422 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#637511}
-
Dan Beam authored
R=aee@chromium.org BUG=923597 Change-Id: Ic651d4a6b8cbbcb71bc5c23cd2ea30d75291f81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500837 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#637510}
-
Kyle Milka authored
Give #user-content a z-index of -1, this sends it to the background so it doesn't prevent clicks on background attributions. Bug: 937207 Change-Id: I91bf2c65bf06cd0f914964fc8d53b08c976c531f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500835 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#637509}
-
Daniel Rubery authored
This reverts commit 720f60e6. Reason for revert: This has broken the ClientSideDetection. Pings have dropped 35% in Canary. Original change's description: > Remove PhishingDetectorClient mojo interface > > This interface was used to receive the results of a call to > StartPhishingDetection on the PhishingDetector interface. It's more > flexible to pass a callback as part of StartPhishingDetection, and > removes a mojo interface. > > Bug: 925464 > Change-Id: I20a02e7bf8951d77fdc71d1baeb81f5afb601558 > Reviewed-on: https://chromium-review.googlesource.com/c/1477940 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636175} TBR=kenrb@chromium.org,vakh@chromium.org,drubery@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 925464 Change-Id: I3380ad87bcfe37e555fb334e3dc07320e733947e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500845Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#637508}
-