GitLab

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/185563010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255705 0039d316-1c4b-4281-b951-d872f2087c98

When setting a texture mailbox on TextureLayer, reusing the same
TextureMailbox is very fishy since the gpu::Mailbox would end up
being released back to the client multiple times.

However since pepper does magical bad things by using a single
texture that somehow is double buffered (this is wrong and
to be fixed), it needs to give the texture to cc multiple times.
It is safer in this case since its ReleaseCallback is empty. We
can encode this with a SetTextureMailboxWithoutReleaseCallback
method on TextureLayer that pepper can use, and it avoids this
DCHECK.

The method comes with a big warning. Pepper should be fixed to
avoid visual tearing, and this method should go away.

R=piman
BUG=350204

Review URL: https://codereview.chromium.org/189333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255704 0039d316-1c4b-4281-b951-d872f2087c98

(Crashy on today's canary)
> Make chrome_elf use thunks instead of function pointers.
> 
> 1. Add functionality to ServiceResolverThunk to copy a thunk without patching.
> 2. Move chrome_elf thunk-handling code to a common location.
> 3. Use a thunk instead of a f'n ptr for redirects.
> 
> BUG=334379
> 
> Review URL: https://codereview.chromium.org/183833004

TBR=caitkp@chromium.org

Review URL: https://codereview.chromium.org/189803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255703 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255702 0039d316-1c4b-4281-b951-d872f2087c98

Fails to compile on "Android Webview AOSP Builder"

http://build.chromium.org/p/chromium.linux/builders/Android%20Webview%20AOSP%20Builder/builds/9360

> Blink roll 168699:168744
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=168700:168744&mode=html
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/190633004

TBR=arv@chromium.org

Review URL: https://codereview.chromium.org/189373011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255701 0039d316-1c4b-4281-b951-d872f2087c98

If a seed is received that fails verification, don't store it.
Similarly, on startup discard the seed if it fails verification.

Refactors some of the code to make tests pass (since they're
not testing signed data). Additionally, deprecates the previous
seed hashing code.

BUG=336536

Review URL: https://codereview.chromium.org/183003008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255697 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255695 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=168700:168744&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/190633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255694 0039d316-1c4b-4281-b951-d872f2087c98

Quickoffice will not be included in webview. But there are
some issues on the android license check bot.

BUG=350472
NOTRY=true
NOTREECHECKS=true
R=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/191323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255693 0039d316-1c4b-4281-b951-d872f2087c98

OWNER reviewer: arv

BUG=341256

Review URL: https://codereview.chromium.org/176823009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255692 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow up of r254755 that updated the pointer to the chunk with the
highest address in the region when the highest chunk in the region was being
split (during an allocation reusing a free chunk).

While this was enough to fix the bug specified below, it was only partly
addressing the problem since this pointer also needs to be updated when free
chunks are merged. This CL fixes this issue and adds an extra DCHECK() exposing
the problem with the existing unit tests.

BUG=347919

Review URL: https://codereview.chromium.org/183763037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95758

Review URL: https://codereview.chromium.org/183223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255690 0039d316-1c4b-4281-b951-d872f2087c98

It works similarly as getRawEvents() with the following differences:
- it returns a dictionary that can be read more easily by the
app.
- it reads from LoggingStats. We should probably refactor it into a
subscriber implementation in a later CL.
- currently it doesn't reset stats.

Also fixes bug 347750 on the side.
Also fixes bug where we are doing std::copy to an
uninitialized range. Fix is to use a back_inserter.

Making minimal changes to the cast library to get this working. More
changes to cast library to come in future CLs.

BUG=347750,301920,338574,348491

Review URL: https://codereview.chromium.org/184853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255689 0039d316-1c4b-4281-b951-d872f2087c98

BUG=259116

Review URL: https://codereview.chromium.org/189213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255688 0039d316-1c4b-4281-b951-d872f2087c98

In addition to the current functionality, this adds:
* Detection of default capture devices (communication and console).
* Detection of changes to the default communication render device.

While doing this, I decided to also make 'effects' visible in the media-internals page which was very helpful in tracking down the source of the problem I was running into.

BUG=347531

Review URL: https://codereview.chromium.org/187593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255687 0039d316-1c4b-4281-b951-d872f2087c98

Failure to do so leads to a CHECK() in the browser under the IPC fuzzing
tests, which generates a lot of false positives.  Instead, we can invert
the situation and blame the renderer.

BUG=349572

Review URL: https://codereview.chromium.org/183023016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255686 0039d316-1c4b-4281-b951-d872f2087c98

Suspected as crasher.

> Bind before sandbox lockdown on Windows.
> Linux is unaffected. All changed code already is inside sandbox.
> 
> BUG=348692
> 
> Review URL: https://codereview.chromium.org/185293014

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/191403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255685 0039d316-1c4b-4281-b951-d872f2087c98

It's no longer needed.

BUG=350416
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/190543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255684 0039d316-1c4b-4281-b951-d872f2087c98

The feature has been stable a long time now.

(This CL is part of the command line flag removal effort.)

BUG=

Review URL: https://codereview.chromium.org/190603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255682 0039d316-1c4b-4281-b951-d872f2087c98

> base: Disable win::ScopedHandle
> 
> This patch is intended for M34
> 
> BUG=350063
> TBR=cpu@chromium.org
> 
> Review URL: https://codereview.chromium.org/188793004

TBR=rvargas@chromium.org

Review URL: https://codereview.chromium.org/191133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255681 0039d316-1c4b-4281-b951-d872f2087c98

In this way, more information can be added (currently added 'description' and 'owner' for each action) 

A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms.

CL 149503005 broke in http://crrev.com/255357. Add a patch to fix histograms presubmit. 

BUG=340735
NOTRY=true

Review URL: https://codereview.chromium.org/180743027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255680 0039d316-1c4b-4281-b951-d872f2087c98

Fix SDP filtering issue on Android. rtpmap 101 is a data codec and it shouldn't be removed.

Some tests are fixed by this patch:
WebRtcBrowserTest.CanSetupLegacyCall
WebRtcBrowserTest.CallWithDataOnly
WebRtcBrowserTest.CallWithDataAndMedia
WebRtcAecDumpBrowserTest.CallWithAecDump

Some tests have been disabled in the source code:
WebRtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiate
WebRtcBrowserTest.CallWithDataAndLaterAddMedia
WebRTCInternalsBrowserTest.WithRealPeerConnectionCall

Some tests are no longer there:
WebRTCInternalsBrowserTest.NegotiateUnsupportedVideoCodec
WebRTCInternalsBrowserTest.NegotiateNonCryptoCall

BUG=181069
R=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/189433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347424

Review URL: https://codereview.chromium.org/188293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255678 0039d316-1c4b-4281-b951-d872f2087c98

Stale, unused debugging code.

BUG=None
R=jennyz@chromium.org

Review URL: https://codereview.chromium.org/189173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255677 0039d316-1c4b-4281-b951-d872f2087c98

Modify the existing EME browser tests to include testing EME WD.

BUG=224791
TEST=new browser tests pass

Review URL: https://codereview.chromium.org/182113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350323

Review URL: https://codereview.chromium.org/190473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255675 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348003

Review URL: https://codereview.chromium.org/189093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255674 0039d316-1c4b-4281-b951-d872f2087c98

Chrome introduced a transaction timeout to deal with potentially wedged
renderers (e.g. JS execution halted, etc) failing to complete transactions,
leaving the browser's transaction queue in a bad state. This was done
for all transactions, but since read-only transactions don't hold up
the queue it's safe to ignore them, which can reduce false-positives.

BUG=339229

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254846

Review URL: https://codereview.chromium.org/180163010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255673 0039d316-1c4b-4281-b951-d872f2087c98

RenderViewContextMenu has recently become aware of the frame it is being called for. This makes it possible direct the InspectElement message to the correct renderer which is necessary of the "Inspect Element" action to work correctly with OOP iframes.

This automatically works correctly for BrowserPlugin as well, so WebContents::GetRenderViewHostAtPosition and all supporting code across can be removed now.

BUG=345700

Review URL: https://codereview.chromium.org/187673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284553
R=kalman@chromium.org, mkearney@chromium.org

Review URL: https://codereview.chromium.org/145443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255671 0039d316-1c4b-4281-b951-d872f2087c98

When the center is off the tiling, then the unclamped calculations
are incorrect. That is, instead of values being rounded down in
integer divides, they are instead rounded toward zero.

This patch reworks the way the around coordinates are calculated.
Instead of relying on unclamped version of existing functions,
we instead explicitly check whether the src coord is within the
tiling total size.

R=enne

Review URL: https://codereview.chromium.org/188863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255670 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270362
R=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/187313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255669 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350124
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/189383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255668 0039d316-1c4b-4281-b951-d872f2087c98

Now we use clang-format in the end, so no need to format it before.

BUG=
TEST=bots
R=bajones@chromium.org, dmichael@chromium.org

Review URL: https://codereview.chromium.org/189373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255666 0039d316-1c4b-4281-b951-d872f2087c98

> Style nits
> 
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/189293003

TBR=matthew@dempsky.org

Review URL: https://codereview.chromium.org/190543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255665 0039d316-1c4b-4281-b951-d872f2087c98

For the moment, extension and internal code relies on navigator.language
to return the browser UI language but it should return the preferred
language for fingerprinting reasons, see http://crbug.com/101138.

BUG=348402

Review URL: https://codereview.chromium.org/185423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255663 0039d316-1c4b-4281-b951-d872f2087c98

Currently the visible_rect is implicitly set to the quad's |rect| value
then later changed by the occlusion/culling code. Instead we want to
compute this value up front and set it on the quad when the quad is
created. So add it to the SetNew() method. Currently it should always
be set to the same value as the |rect|.

R=enne
BUG=344962

Review URL: https://codereview.chromium.org/185563008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255662 0039d316-1c4b-4281-b951-d872f2087c98

These are unit tests so they should be in the unit_tests target. A
TODO says this did not work before, but they appear to pass as unit
tests now, so this is just a code move.

BUG=270918
R=droger@chromium.org, hajimehoshi@chromium.org

Review URL: https://codereview.chromium.org/186063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255661 0039d316-1c4b-4281-b951-d872f2087c98

This change is in support of later changes moving the bookmarks_ui
manifest key from chrome_settings_overrides to chrome_ui_overrides.

BUG=349049
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/188813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338855
TEST=manual
NOTRY=true
R=jhawkins@chromium.org, zork@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255380

Review URL: https://codereview.chromium.org/187983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255659 0039d316-1c4b-4281-b951-d872f2087c98