- 27 Mar, 2019 38 commits
-
-
Peter Kasting authored
Bug: 946024 Change-Id: I62b07d3899814007a6ba3331c4888b9475f29033 TBR: noel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539133Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#644639}
-
Renjie authored
https://quiche.googlesource.com/quiche.git/+log/60e6ed1b3d4e..9132654c7968 $ git log 60e6ed1b3..9132654c7 --date=short --no-merges --format='%ad %ae %s' 2019-03-25 quiche-dev Use 'bytes' instead of 'string' for holding binary data 2019-03-23 quiche-dev Add a QUIC_BUG to ensure that whenever an ACK cannot be written, the writer is write blocked. Protected by existing flag gfe2_reloadable_flag_quic_use_uber_loss_algorithm. 2019-03-23 quiche-dev Add a test making sure ACK alarm is canceled on write blocked when supporting multiple packet number spaces. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I92ab51e46327e3fce41f6540dcf6382d2f5dbc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538880Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#644638}
-
Peter Kasting authored
This reverts commit efbe41b8. Reason for revert: Mac bots are failing consistently, see e.g. https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/40949 Original change's description: > Change unoptimized-images feature policy to unoptimized-lossy-images. > > This makes it more clear that this policy applies only to lossy image > types (for now, just JPEG). This patch also makes the implementation > more generic in order to make the policy compatible with parsed > policy values and to pave the way for implementing a > lossless-enforcing version of the unoptimized-images policy as well. > > These changes have been pulled from a larger partially reviewed CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1524869 > > Bug: 942659 > Change-Id: I0242ac900b1653b89d6d8dbd63616003dcaaba62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531354 > Commit-Queue: Paul Meyer <paulmeyer@chromium.org> > Reviewed-by: Paul Meyer <paulmeyer@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644488} TBR=flackr@chromium.org,kenrb@chromium.org,pdr@chromium.org,paulmeyer@chromium.org,iclelland@chromium.org Change-Id: I0dc0449dc2d07c5dafa84c7123ec664c902a73fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540145Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#644637}
-
Brian Sheedy authored
Fixes flakiness in VrBrowserNativeUiTest#testVoiceInputUnavailableIfSiteUsingMicrophone caused by not waiting for residual animations from navigating before attempting to display the permission prompt. Change-Id: Ie530f12d9595869ea56cf351652665043f377d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540685Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#644636}
-
Xianzhu Wang authored
This reverts commit 24025d13. Reason for revert: crbug.com/945152 has been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1536992. Original change's description: > Revert "[BlinkGenPropertyTrees] Paint frame overlay in correct property tree state" > > This reverts commit c656dcba. > > Reason for revert: crbug.com/945152 > > Original change's description: > > [BlinkGenPropertyTrees] Paint frame overlay in correct property tree state > > > > Frame overlays should use the device emulation transform node if exists > > as the transform state. > > > > Because the node is ready only after PrePaint, we need to let frame > > overlays update graphics layer status at the end of PrePaint, instead of > > previously unclear (maybe during layout, or paint etc.) > > > > Bug: 934300 > > Change-Id: Ic6e2fe5d29f444dba1a3bf206ffa1775df4adc3d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525199 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#642184} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 934300, 945152 > Change-Id: Ie50c55532da20dbe44da94c90f93a3ed20bd2a6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536912 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643731} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I2c7b123bdd6ddf0d813008196864425d9daed8e8 Bug: 934300, 945152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537780 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644635}
-
Matt Menke authored
This CL makes it so that WebSocketTransportClientSocketPool no longer inherits from TransportClientSocketPool. Since it has almost no shared logic, this inheritence was unnecessary and a little confusing. Bug: 944097 Change-Id: I5c70257e3b48bf05bf5e7e9c5732cedb24166904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532919 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#644634}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/css, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This CL is the seventh clean up in core/css. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I12a1a76762791edb72c893a4ed73c93ea1a5cf76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539325Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#644633}
-
Simon Que authored
Bug: 945731 Change-Id: Iebda88878c34687f4d60172b2ba07141a54d5cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539632Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#644632}
-
Oksana Zhuravlova authored
This change adds annotations for mojom entities in the generated headers. These annotations will be used for creating codesearch-related metadata. They are only generated if enable_kythe_annotations build flag (also added by this change) is true (it defaults to false). Bug: 943856 Change-Id: I94a16fc8fb95045ec80e893157b733b4cb8da0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534342 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#644631}
-
Yusuf Ozuysal authored
1) Routes swipe down through a delegate OverviewModeController passed during construction in LayoutManagerChrome. This keeps default behavior as is but swipes down to the Grid when Grid or TabGroups is enabled. 2) Gets back swipe to side for both grid and tab groups. This was disabled while looking for a solution to 1) above. Now the only caveat is swipe to side scrolls between tabgroups if there are tabgroups which is WAI. 3) Disables both side swipe and swipe down from the bottom toolbar for the tab groups case where tabstrip needs the swiping gesture as it technically can become long enough that it needs to scroll BUG=941676 Change-Id: I706a3aa778ab08c5e46fbbcaaec40eb7f69c56fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537250Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#644630}
-
Maksym Onufriienko authored
Bug: 912323 Change-Id: I15aa8fe90fff81bdec97ba03eea07b57b4c280e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529622Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#644629}
-
Taylor Bergquist authored
Tabs opened from a link with middle click, shift middle click, or'Open in new tab' from the link's context menu will open in the current tab's group. This CL is part of the prototype of the above-described tab groups feature. The prototype will allow users to create and manipulate groups primarily via tab context menus, and will display tab group affiliation in the tabstrip. Future work will include persisting and syncing groups, manipulating groups via tab dragging, and a dropdown menu for the group headers. See go/chrome-tab-groups-design Bug: 905491 Change-Id: Ibc75d39ca3bfb30bcd0ff34de9db2a8a841d57ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1441493 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#644628}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/css, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This CL is the fifth clean up in core/css. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ibf76598bef9077f26622619ad93ca96820acae5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538264Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#644627}
-
Peter Kasting authored
Bug: 946023 Change-Id: Ia8873635b8c1363eeca69ab0600eb8a8a656cbc8 TBR: noel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540680Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#644626}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/de253137e334..1a9f8ed9bf54 git log de253137e334..1a9f8ed9bf54 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 tsepez@chromium.org Tidy some warnings from clang-tidy 2019-03-26 thestig@chromium.org Avoid 0 byte reads in ParseAndAppendCrossRefSubsectionData(). 2019-03-26 thestig@chromium.org Make CXFA_NodeHelper::GetNameExpression() a member of CXFA_Node. 2019-03-26 thestig@chromium.org Make CXFA_NodeHelper::NodeIsTransparent() a member of CXFA_Node. Created with: gclient setdep -r src/third_party/pdfium@1a9f8ed9bf54 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:945624 TBR=dsinclair@chromium.org Change-Id: I7b42a886ae518b8649d6dc4e8365f8960596827c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540537Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644625}
-
Staphany Park authored
Bug: 918293 Change-Id: I4f16640f06feac009d6bbbb624951da6d2669f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488059 Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#644624}
-
Nico Weber authored
Else they'll hang around and slowly fill up bot disks. TBR=hans Bug: 464945 Change-Id: Iecb8e3b24dd1585e89567025614389296f895d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540481Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#644623}
-
Nate Fischer authored
This adds AllowFileSchemeCookies() to the CookieManager mojo interface to support WebView's #setAcceptFileSchemeCookies() API. This must be a dynamic API instead of a NetworkContextParam because apps may legitimately call the Java API after the NetworkContext has been initialized (so long as they call it before the first use of the underlying CookieStore). We currently accommodate this in the legacy code path by lazily creating the CookieStore the first time it's used. To properly support the corresponding getter API, this CL modifies CookieMonster::SetCookieableSchemes to pass a boolean success value to a callback (which network::CookieManager also exposes as a callback). This adds test coverage for the getter API, including covering the call-after-cookie-store-initialization case, where it's no longer possible to enable file:// scheme cookies. As we haven't yet finalized a solution for using the CookieManager prior to content-layer initialization (http://crbug.com/933461), this CL does not attempt to resolve synchronization issues with that case. Design: http://go/wv-ns-cookie-apis#bookmark=id.hq3jcr72p6ai Bug: 933458 Test: $ run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: -f CookieManagerTest.*FileScheme* Test: $ net_unittests --gtest_filter=SQLitePersistentCookieStoreTest.* \ Test: :CookieMonsterTest.* Cq-Include-Trybots: luci.chromium.try:android_mojo Change-Id: I1c7c9ef3919686df39abc7ac760fddf91e176e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533486 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#644622}
-
Xing Liu authored
On Android Q, Environment.DIRECTORY_DOWNLOADS is an invalid directory, and all disk space queries like getUsableSpace() or getTotalSpace() will return 0, and other related calls may throw exception. This is because we didn't create the directory in external storage. Q basically exposes a bug in our code. This CL adds a utility function to retrieve the directory and tries to create it. Also updates DownloadUtils.isInPrimaryStorageDownloadDirectory to work with content URI file path on Q. Bug: 945028 Change-Id: I22cce2e5ac81bd574eee96719648689c5a8cdbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538876Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644621}
-
Daniel Bratell authored
The mojo type GpuPreferences did not depend on the implementation classes. Since the implementation classes in turn depends on the mojo bindings, there is a dependency cycle. This patch describes that in the build system in a way that is accepted by gn check --check-generated An example of an error: ERROR at //out/Default/gen/gpu/ipc/common/gpu_preferences.mojom-forward.h:40:11: Include not allowed. #include "gpu/config/gpu_preferences.h" ^--------------------------- It is not in any dependency of //gpu/ipc/common:gpu_preferences_interface The include file is in the target(s): //gpu/config:config_sources which should somehow be reachable. ___________________ Bug: 938893 Change-Id: I18a9c0c8684ffbbdbe5d47573150434de397061f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538423 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#644620}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/45d5f702133e..2b7cca4cd8e4 git log 45d5f702133e..2b7cca4cd8e4 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader cc6473f7d80d..e747b3c3c9d9 (1 commits) Created with: gclient setdep -r src/third_party/skia@2b7cca4cd8e4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ic17beb077c07e37060cc02046c7461906533726c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540538Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644619}
-
Adam Ettenberger authored
1. Adding or mapping generated events for relevant properties : - ENABLED_CHANGED (IntAttribute::kRestriction) - READONLY_CHANGED (IntAttribute::kRestriction) - VALUE_CHANGED (FloatAttribute::kValueForRange) - VALUE_MAX_CHANGED (FloatAttribute::kMaxValueForRange) - VALUE_MIN_CHANGED (FloatAttribute::kMinValueForRange) - VALUE_STEP_CHANGED (FloatAttribute::kStepValueForRange) 2. Firing UIA Property Changed events : - UIA_IsEnabledPropertyId - UIA_RangeValueIsReadOnlyPropertyId - UIA_RangeValueLargeChangePropertyId - UIA_RangeValueMaximumPropertyId - UIA_RangeValueMinimumPropertyId - UIA_RangeValueSmallChangePropertyId - UIA_RangeValueValuePropertyId - UIA_ValueIsReadOnlyPropertyId - UIA_ValueValuePropertyId 3. Ethan found a bug with AccessibilityEventRecorderUia which was causing event tests with multiple 'go()' calls to timeout. Cherry picked the fix from his CL : https://chromium-review.googlesource.com/c/chromium/src/+/1518407 Bug: 844149 Change-Id: Icf10385faf2ba84a49747298692bed409a862886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534286 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644618}
-
Bruno Santos authored
Bug: 927809 Change-Id: I0fe5c9c5763e39948d26b6f8d69764a9cd5dd4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538888 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#644617}
-
Dmitry Gozman authored
We cannot route flatten protocol to node targets, so we should keep wrapping node subtragets with Target.sendMessageToTarget. Bug: 941608 Change-Id: I0b04379e143c32b61c3ede6047d6c967cd96af06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538484Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644616}
-
Charlene Yan authored
Renamed MenuButtonEventHandler to MenuButtonController since it contains more than just EventHandling logic. Bug: 901183 Change-Id: Ibb983144b9f5713d69298ca5dff13dc3de9d7c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539917Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#644615}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4864e0cd1960..518c679da109 git log 4864e0cd1960..518c679da109 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 jonahr@google.com Clean up test_expectations to merge with angle style/convention. Created with: gclient setdep -r src/third_party/angle@518c679da109 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org Change-Id: I5e563c1e161227952298d438c510900f30789795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644614}
-
Jun Mukai authored
When the device-scale-factor changes, the change is currently handled in the window server. The server re-generate the local surface id and notifies to the client through OnWindowBoundsChanged. When this mojo call arrives to the client, it's propagated to TopLevelAllocator::OnDeviceScaleFactorChange, and it re-generate again the local surface id, and sends back to the window server through SetWindowBounds(). This causes some troubles. This means that TopLevelAllocator does not have to generate the local surface id on DSF change since it's already handled in the server. This CL skips this regeneration. Bug: 942647 Test: the new test case in aura_unittests Change-Id: I86f9d8952082f1b2e7bb9ab74e38f556783447f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540069Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#644613}
-
Eric Lawrence authored
Updates the network documentation to reflect that the network service may not be running in the browser process. Also, fixes some minor typos. Change-Id: Ie89fe73c55640a404daca618de0f32ef5fa472dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540364Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#644612}
-
Matt Menke authored
A lot of places were using TransportClientSocketPool::SocketParams to refer to the class. Bug: 944095 Change-Id: I4d5638e43a46ced2a3ef1f293b616b2b549fa69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532913 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#644611}
-
Matthew Denton authored
Adding an LPM-based disk cache fuzzer so we can more comprehensively test disk cache implementations, including any new ones that might come around. Bug: 939131 Change-Id: Iede24aff96776c99d53d74a07f8b8324a0e58979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507113 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#644610}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id387d2ec03a63b60620bd516b1b1c92008df946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644609}
-
Aga Wronska authored
This new component will encapsulate information needed to calculate work area for root window. It is in 1:1 relationship with RootWindowController and owned by it. Caching height on accessibility panel is restored in this change for consistency with docked magnifier and for performance reasons (avoid frequent calculation of this value). Test: manually with 2 displays + existing unit tests Bug: 944685 Change-Id: Ib76f144a54408a769ec101e15f6a2f2512aa4ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538689 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#644608}
-
Joanmarie Diggs authored
* Add support in AXPlatformNodeAuraLinux::AddAccessibilityTreeProperties and use in AccessibilityTreeFormatterAuraLinux::ProcessTreeForOutput. * By default, output all relation types but embedded-by (which appears on all top-level documents). * Update auralinux expectations where relations are implemented. Bug: 946016 Change-Id: I8792ddf23f23ad74b1b378f9cfb01f906b967590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540283 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Auto-Submit: Joanmarie Diggs <joanmarie.diggs@gmail.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#644607}
-
Christian Biesinger authored
Because it contains a CHECK() call, it is somewhat slow even in release builds. Instead use begin() and end() here. R=kojii@chromium.org Change-Id: I1b653235ba01443572959c1c464d10c13463a54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540257 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#644606}
-
Thomas Guilbert authored
This CL cleans up the technical debt introduced by adding MPR/MPRClient specific methods to general purpose interfaces. When adding MediaPlayerRenderer (MPR), a few 1-off methods were tacked on to existing interfaces, to avoid plumbing new paths through the entire media pipeline. Thanks to the CreateRenderer split, it is now easier to extract these functions into strongly typed, specialized Mojo interfaces, that are only used by the classes that need them. The CL add renderer_extensions.mojom, which defines the MediaPlayerRendererExt and the MediaPlayerRendereClientExt. MediaPlayerRendererClientExt defines the events that the MPRC needs to listen to, coming from the MPR in the browser process. It allows us to remove RendererClient::OnDurationChanged(), and bubbles up duration changes via ForwardDurationChangeToDemuxerHost(). It also allows us to send video size change events directly to the MPRC, which can now avoid implementing RendererClient pass-through methods, just to update its StreamTextureWrapper. MediaPlayerRendererExt defines the extra methods that the MPR needs to expose to the MPRC. It allows us to move InitiateScopedSurfaceRequest() out of MojoRenderer, and paves the way to simplifying the "bad call" logic is in place in the MojoRendererService. Bug: 669606 Change-Id: I2a8a537beb2e4d8f8d34b6256f5a2b4ab6af0715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524525 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#644605}
-
Bill Orr authored
WebXR may not submit frames if pose data is null. Pose data will be null if WebXR isn't visible. However, we want at least one pose data to be non-null to know that WebXR is ready to submit frames. The fix is to hand out a non-null pose data. Also, fix a crash. graphics_ is set to null when UI hides, but we may still have an outstanding frame callback. Change-Id: Ib304a0b56d8737da1d8200cbb6257645755c99ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540616Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#644604}
-
Julie Jeongeun Kim authored
This CL moves public/platform/modules/frame_sinks to public/mojom to gather mojom files to mojom folder and updates paths for embedded_frame_sink.mojom. Bug: 919393 Change-Id: If73981416f251d651fa34f114a68d9f58a14a268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534585Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#644603}
-
Peter Kasting authored
Bug: 945846 TBR: noel Change-Id: I9b62ee039e537cc6485514d7e744b6a702b2bb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539212Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#644602}
-
- 26 Mar, 2019 2 commits
-
-
Tom Anderson authored
Rolling for [1] to fix bug 944391. [1] https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/955113db37563c8632e31ddcff2047845553d7ff https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+log/4daecde1d737..955113db3756 $ git log 4daecde1d..955113db3 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 thomasanderson [libc++] Fix return value of snprintf_l() on Windows when buffer is too small 2019-03-26 modocache Revert "[coroutines] Add std::experimental::task<T> type" 2019-03-26 modocache [coroutines] Add std::experimental::task<T> type 2019-03-25 mclow.lists Cleaup of requirements for optional. While researching LWG3196, I realized that optional did not reject 'const in_place_t' like it should. Added a test as well, and a check for arrays (which were already disallowed, but now we get a better error message). Should not affect anyone's code. 2019-03-25 ldionne [libc++][CMake] Allow merging libc++abi.a into libc++ even on Apple platforms 2019-03-22 mclow.lists Fix a minor bug with std::next and prev not and negative numbers. In particular, std::prev cannot require Bidirectional Iterators, because you might 'go back' -1 places, which goes forward. Thanks to Ville and Jonathan for the bug report. 2019-03-22 ldionne [libc++] Update the list of symbols exported from libc++abi for new/delete 2019-03-22 ldionne [libc++] Re-export the sjlj ABI v2 for ARM architectures 2019-03-22 mclow.lists Fix a vector test to not use a local type as a template parameter. This causes a warning on C++03. NFC 2019-03-21 ldionne [libc++] Remove too-stringent XFAILs for file_clock tests 2019-03-21 ldionne [NFC][libc++] Reindent #ifdefs 2019-03-21 ldionne [libc++] Re-document how to use <filesystem> with various versions of libc++ 2019-03-21 sbenza Add relational benchmark against a string constant. 2019-03-21 ldionne [libc++] Mark bad_any_cast tests as unsupported when the dylib doesn't support bad_any_cast Created with: roll-dep src/buildtools/third_party/libc++/trunk BUG=944391 R=thakis Change-Id: Ib0c7ec64c706afe31c46feed581577d4b8f7c926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540288 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#644601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bcf82c47e836..ed0cd5dc2078 Created with: gclient setdep -r src-internal@ed0cd5dc2078 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: I230620a573ebd4725683167152e7d68ffedc23b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540460Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644600}
-