Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 28 Jul, 2018 30 commits
  3. 27 Jul, 2018 10 commits
    • Jordy Greenblatt's avatar
      [CrOS MultiDevice] Feature toggle element for controlling prefs · c8df356d
      Jordy Greenblatt authored 
      Toggle button that controls a given pref.

The element uses the SettingsBooleanControlBehavior, which causes its
behavior to parallel that of settings-toggle-button. However, the
settings-toggle-button has a few disadvantages for the MultiDevice Settings
UI use case that made it expedient to create this new element to use
instead:

(1) The settings-toggle-button is designed as an entire row (as opposed to
just a toggle) and it does not allow a button to replace the feature toggle
in the DOM. Because the type of user input varies depending on the state of
the user's GAIA account, this UI would have either have to completely detach
and reattach its items when they switched input types or else it would have
to change the settings-toggle-button to allow it to detach or at least hide
its toggle.
(2) In order to match the pattern of the network-summary-item used for the
Instant Tethering feature our items have SVG icons, which would require
further refactoring of the settings-toggle-button to accommodate.
(3) We need toggles to control the unified MultiDevice feature suite and
toggles for individual features. The latter case requires more explanation
and as a result has some identifying features that do not necessarily
apprear in the former case.


Bug: 824568
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I986382a8aac31781e3d27c1f44397ddb048761f4
Reviewed-on: https://chromium-review.googlesource.com/1149001
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578869}
      c8df356d
    • Daniel Murphy's avatar
      Revert "[DOMStorage] Moving cached namespaces to std::map" · 198b861b
      Daniel Murphy authored 
      This reverts commit 080fe17e.

Reason for revert: The corruption is still there, but now failing on Windows.

Bug: 865393

Original change's description:
> [DOMStorage] Moving cached namespaces to std::map
> 
> There has been a bunch of memory-corruption-smelling crashes around this
> area. Changing the container to a std::map should give us more
> information about where this is happening, and maybe cause it to crash
> somewhere else.
> 
> R=​mek@chromium.org
> 
> Bug: 845400,821371,857464
> Change-Id: Ife8cb10336a4f0752db89e2bca836ed873f7c711
> Reviewed-on: https://chromium-review.googlesource.com/1129849
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573452}

TBR=dmurph@chromium.org,mek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 845400, 821371, 857464
Change-Id: Ie120acf347713d9c6172f26082ed9b18c3cc38bc
Reviewed-on: https://chromium-review.googlesource.com/1153987
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578868}
      198b861b
    • Lu Chen's avatar
      Record timing information of anchor element clicks. · bec13327
      Lu Chen authored 
      Record duration between page load and first click, and intervals
between consecutive clicks. This timing information can help us
analyze the available opportunities to perform preload (and other
pre* mechanisms).

Bug: 850624
Change-Id: I8924d6409ce5695e0d9eb56e9be87b7bf5bfc5c3
Reviewed-on: https://chromium-review.googlesource.com/1149415
Commit-Queue: Lu Chen <chelu@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578867}
      bec13327
    • angle-chromium-autoroll's avatar
      Roll src/third_party/angle 9bf86f07acd5..306b6c168dc7 (2 commits) · 3e236e93
      angle-chromium-autoroll authored 
      https://chromium.googlesource.com/angle/angle.git/+log/9bf86f07acd5..306b6c168dc7


git log 9bf86f07acd5..306b6c168dc7 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 jmadill@chromium.org D3D11: Use angle::Result error pattern. 1/3
2018-07-27 geofflang@chromium.org Fix/supress issues with EGL images on Android.


Created with:
  gclient setdep -r src/third_party/angle@306b6c168dc7

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I01ee932f0a5415853216c178e2b860ba85be4ddf
Reviewed-on: https://chromium-review.googlesource.com/1153767Reviewed-by: default avatarangle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578866}
      3e236e93
    • Penny MacNeil's avatar
      [ui/display] Change component name on Windows. · 9b65c69b
      Penny MacNeil authored 
      "display.dll" is a Windows system dll.  This causes a clash in debug component builds.
Change the GN output_name for the display component to "ui_display".

Ref: crbug/818388

Test: chromium.gpu waterfall bot (debug component), or chromium.gpu.fyi.
Change-Id: Ibdb41cb6841708c61893a0e05d00f5af17b583cd
Reviewed-on: https://chromium-review.googlesource.com/1152099Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
Commit-Queue: Penny MacNeil <pennymac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578865}
      9b65c69b
    • Kenneth Russell's avatar
      Update shaderoperator_common_functions suppression. · 84424c67
      Kenneth Russell authored 
      It should be applied on all macOS versions, not just Sierra. This
affects the following WebGL 2.0 conformance test:
  deqp/functional/gles3/shaderoperator/common_functions.html

Tbr: kainino@chromium.org
Bug: 820225
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib0ff46c871d8ab74e56026aff96cd150e61a33d9
Reviewed-on: https://chromium-review.googlesource.com/1152452Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578864}
      84424c67
    • Weiyong Yao's avatar
      Add braveyao as OWNERS in desktopCapture related logic in Chromium · 631d8192
      Weiyong Yao authored 
      Bug: 867003
Change-Id: I2ef56eeafcee60f23fbd2d67fb3193eb9cd360d4
Reviewed-on: https://chromium-review.googlesource.com/1148694
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578863}
      631d8192
    • Scott Violet's avatar
      Revert "Misc. cleanup to browser_theme_pack_unittest.cc; no functional change." · 2411cb26
      Scott Violet authored 
      This reverts commit ec2cd434.

Reason for revert: Reverting in hopes of fixing unit_tests on chromeos bot. This one will hopefully take. Sorry for so many reverts here. The chain of patches made it difficult.

Original change's description:
> Misc. cleanup to browser_theme_pack_unittest.cc; no functional change.
> 
> * Add GetDefaultColor() mapping function to make it easy to fix DCHECKs due to
>   this code using raw _INCOGNITO color constants but
>   ThemeProperties::GetDefaultColor() not expecting them.  This is the change
>   that led me to get annoyed and do all the other stuff here.
> * Convert typedefs to type aliases.
> * Add TP = ThemeProperties type alias for brevity.
> * Use =default.
> * Mark functions that don't touch member variables "static".
> * Fix wrapping issues.
> * Because the class here is so long, split it into declaration and definition
>   pieces so it's easier to see what's the API and what's helper functions.
> * Make the API protected; make helpers private.
> * Make data members private.  Add a const accessor for the one member tests use.
> 
> Bug: none
> Change-Id: I4cc058bb29747cfa84835edbc5ce765401e14527
> Reviewed-on: https://chromium-review.googlesource.com/1152108
> Reviewed-by: Evan Stade <estade@chromium.org>
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578775}

TBR=pkasting@chromium.org,estade@chromium.org

Change-Id: I2407b13ff9c69c240bb7479e21a515c17c1388b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/1153991Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578862}
      2411cb26
    • Scott Violet's avatar
      Revert "Add background tab colors and inactive images to the theme system." · 62a8750b
      Scott Violet authored 
      This reverts commit 8c35e22c.

Reason for revert: Reverting to fix unit_tests on chromeos bot. This is next in the chain. Ugh!

Original change's description:
> Add background tab colors and inactive images to the theme system.
> 
> These will eventually be used for three purposes:
> (1) To allow generating different background tab images from a common tint for
>     the inactive and incognito cases, thus allowing background tabs that blend
>     into the frame for custom themes.
> (2) To allow autogenerating the background tab colors from the background tab
>     images, thus letting us autocalculate better tab text/separator/etc. colors.
> (3) To allow theme authors to customize/override this behavior more precisely.
> 
> Reasons (1) and (2) dictated the design here; reason (3) is basically a free
> bonus.  I thought about not making these resources overrideable by theme
> authors, but there was some technical reason that turned out to not be easily
> feasible, and there seems little reason to prevent it.
> 
> This also allows us to read THEME_TAB_BACKGROUND_INCOGNITO on Mac (Views).
> 
> This shouldn't result in a visual change on its own.
> 
> Bug: 862664
> Change-Id: Icc57f78fd526d68b83c692fbac669a7371bb38ff
> Reviewed-on: https://chromium-review.googlesource.com/1147869
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578790}

TBR=pkasting@chromium.org,oshima@chromium.org,estade@chromium.org,bsep@chromium.org,kylixrd@chromium.org

Change-Id: I6abe212768916890c11aec28aac5fc96891ac695
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862664
Reviewed-on: https://chromium-review.googlesource.com/1153990Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578861}
      62a8750b
    • Scott Violet's avatar
      Revert "Add background tab text colors for inactive and incognito windows." · 67f5bec3
      Scott Violet authored 
      This reverts commit 3b7859cb.

Reason for revert: Reverting in hopes of get unit_tests passing on chromeos bot. This appears to be next in the chain to revert.

Original change's description:
> Add background tab text colors for inactive and incognito windows.
> 
> With the default behavior of Chrome being to not show a tab background, we want
> to change themes to default to that as well, unless the theme author actually
> supplies an image/color for this explicitly.  To do this, we need to support
> different tab text colors for the cases where the frame colors can vary.  This
> adds the framework for that support.
> 
> Right now, the default is to use the same text colors in inactive windows as
> active ones.
> 
> This also gives themes that want normal and incognito windows to differ greatly
> (as the built-in theme's does) the ability to implement that and still have
> readable tab titles.
> 
> Bug: 866672
> Change-Id: I032a72bc799d0675c517db10283513a30db23328
> Reviewed-on: https://chromium-review.googlesource.com/1152418
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578807}

TBR=pkasting@chromium.org,estade@chromium.org,bsep@chromium.org

Change-Id: I5e3a5772cea3f7a0d3f790d27dcccc66c51cb161
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866672
Reviewed-on: https://chromium-review.googlesource.com/1154067Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578860}
      67f5bec3