GitLab

* Give it its own copy of its test data, instead of sharing with other
unrelated tests that live in src/chrome.
* Introduce ChromeComponentExtensionResourceManagerTest to address a TODO
and eliminate the src/chrome dependency.

BUG=397164
TEST=unit_tests, extensions_unittests

Review URL: https://codereview.chromium.org/439023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287885 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't seem to be a problem for release builds, but in debug builds the invalid array access causes STL errors:

    error: attempt to subscript container with out-of-bounds index 0, but
    container only holds 0 elements.

BUG=401161

Review URL: https://codereview.chromium.org/446853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287884 0039d316-1c4b-4281-b951-d872f2087c98

If new assertions fire or crashes occur, these PDBs are needed in
order to generate reasonable stack traces. Remove the comment about
their presence being temporary.

BUG=383963,385976

Review URL: https://codereview.chromium.org/448773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287882 0039d316-1c4b-4281-b951-d872f2087c98

This method is taking a non-trivial amount of time during a typical scroll
sequence, so convert the instant trace into a proper scoped trace.

BUG=401204
NOTRY=true

Review URL: https://codereview.chromium.org/446063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385992
TEST=MultiUserWindowManagerChromeOSTest.TestBlackBarCover & visual inspection

Review URL: https://codereview.chromium.org/448493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287880 0039d316-1c4b-4281-b951-d872f2087c98

Put the .d file in the same directory as the output from grit. Currently it
uses the default location for the .d file all the time, even in cases where the
output directory is overridden and the rest of the files go somewhere else.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/450483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287877 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=None, internal comment only change.

Review URL: https://codereview.chromium.org/427183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287876 0039d316-1c4b-4281-b951-d872f2087c98

The test case is a modification of the test html in the bug. The image was replaced and the code was reformatted because it was poorly spaced. The new test case still shows the same behavior. 

BUG=326834
NOTRY=true

Review URL: https://codereview.chromium.org/438963008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=356763

Review URL: https://codereview.chromium.org/414253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287874 0039d316-1c4b-4281-b951-d872f2087c98

This uses the new "trim" input conversion option and also the default arguments to exec script to clean up some calls.

R=bbudge@chromium.org, bbudge

Review URL: https://codereview.chromium.org/138693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287873 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the precision requirements for
DrawPolygonTransformTest.TransformNormal.  This is required since it currently
fails on Arm64 due to gcc's use of a fused multiple instruction on mapMScalars.

Details of this issue are available on the associated bug.

BUG=401117

Review URL: https://codereview.chromium.org/443903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287871 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tbreisacher@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/445183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287870 0039d316-1c4b-4281-b951-d872f2087c98

This test was disabled for a memory leak. The bug was fixed already
but this test case was forgotten to be re-enabled.

BUG=399241
R=flackr@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/443273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392891

Review URL: https://codereview.chromium.org/450493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287868 0039d316-1c4b-4281-b951-d872f2087c98

Specifically linux_chromium_rel_swarming.

BUG=109173
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/451473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287866 0039d316-1c4b-4281-b951-d872f2087c98

This vector is now used to store all config lists. Previously the code did a bunch of work to uniquify configs at certain points (in target.cc) but direct_dependent_configs still ended up with lots of duplicates.

Before this patch the chrome/browser target has 41098 direct_dependent_configs, and after this patch it has 7. Apparently we were also spending a lot of time on these. Before this patch Windows wall clock time was 1031ms, and after this patch it's 831ms. Linux was 834ms before and 593ms after.

Also fix minor build issues in base I noticed while working on this.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/26537002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287865 0039d316-1c4b-4281-b951-d872f2087c98

RenderWidgetHostImpl tracks its visibility using the |is_hidden_| field.
This value should be not be reset when the renderer crashes, otherwise a
widget that crashes in backround will think it's already visible when
put in foreground, messing up process visibility accounting.

This patch fixes process visibility for processes that crashed in
background and are respawned upon foregrounding by preserving the
|is_hidden_| field through renderer crashes.

BUG=399521
R=aelias@chromium.org

Review URL: https://codereview.chromium.org/443133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287864 0039d316-1c4b-4281-b951-d872f2087c98

Currently NOTREACHED() is reached when the KDE file chooser is active.

TEST=Manually:
1. Start Chrome in a KDE environment
2. Visit data:text/html,<input type=file webkitdirectory>
3. Click on the file chooser and select any directory.
4. In KDE environments, NOTREACHED() is reached.

5. Repeat the same steps with the env var NO_CHROME_KDE_FILE_DIALOG=1,
   and observe that NOTREACHED() is not reached any more, because the
   gtk fallback is used (which works correctly since r240564).

Review URL: https://codereview.chromium.org/445883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399835

Review URL: https://codereview.chromium.org/446553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400538

Review URL: https://codereview.chromium.org/439893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287861 0039d316-1c4b-4281-b951-d872f2087c98

The cause of the secure QUIC performance degradation has been
identified and fixed in r286400.

> Disable two recent Channel ID-related CLs to investigate a secure QUIC performance degradation.
>
> The change to quic_stream_factory.cc disables
> https://codereview.chromium.org/346323002/
>
> The change to quic_crypto_client_stream.cc disables
> https://codereview.chromium.org/355293003/
>
> R=rch@chromium.org
> BUG=396185
>
> Review URL: https://codereview.chromium.org/414523004

R=rch@chromium.org
BUG=396185

Review URL: https://codereview.chromium.org/444123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287860 0039d316-1c4b-4281-b951-d872f2087c98

Crashes are reported around getting root window in UpdateShelf(),
however the new AshPopupAlignmentDelegate is mostly same as
old WorkAreaObserver. One difference is the location of getting
root window. This could fix the problem.

If this doesn't fix the problem, then the problem happens outside
of this file.

BUG=400492
R=stevenjb@chromium.org
TEST=None

Review URL: https://codereview.chromium.org/441013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287859 0039d316-1c4b-4281-b951-d872f2087c98

See the bug for more details about the Finch experiment results.
BUG=372570

Review URL: https://codereview.chromium.org/438073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287856 0039d316-1c4b-4281-b951-d872f2087c98

2. Adds a couple of functions to return different fingerprint value for tamper detection.

3. Adds a function to remove Chrome-Proxy header's fingerprint from its header values, and return the rest of header values.

4. Changes HasDataReductionProxyViaHeader to also tell 
whether data reduction proxy Via header occurs at the last 
or not.


BUG=381907

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287561

Review URL: https://codereview.chromium.org/387353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287855 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287854 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179579:179631&mode=html
TBR=jbroman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/442393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287853 0039d316-1c4b-4281-b951-d872f2087c98

This prevents an ASSERT failure in ServiceWorker::from() when it's
passed an existing SW from a different execution context. Since
ServiceWorkers minted in different documents should have
different prototypes, we shouldn't expect JavaScript equality so don't
need to share ServiceWorkerHandles.

BUG=400980
TEST=https://codereview.chromium.org/443883003/

Review URL: https://codereview.chromium.org/440403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287852 0039d316-1c4b-4281-b951-d872f2087c98

String may be empty. Base64-decode may fail.

BUG=none

Review URL: https://codereview.chromium.org/427303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287851 0039d316-1c4b-4281-b951-d872f2087c98

Fixes some memory leak issues that were present in the first instance
of this CL.  Original description follows:

Introduces the framework for dealing with sync encryption in
non-blocking types.  Unlike directory sync types, non-blocking type
encryption only encrypts data before it is sent to the server.
Encrypting the data on-disk is a separate problem.

Adds code to the ModelTypeSyncWorker so it can access the directory's
cryptographer (through a CryptographerProvider interface) and use it to
encrypt entities before it sends them to the server.  If the
cryptographer is unable to encrypt with the desired key, the worker will
not commit until the cryptographer returns to a good state.

Adds the concept of a "desired encryption key" to the data type state.
When the cryptographer key to be used to encrypt a type changes, this
will be reflected in the data type state.  The ModelTypeSyncProxy is
responsible for ensuring that all items which have not yet been
encrypted with this desired key are enqueued for commit.

Makes the ModelTypeSyncWorker, EntityTracker, and ModelTypeSyncProxy
collaborate on the management of undecryptable (inapplicable) updates.
The EntityTracker keeps track of their version numbers and content, and
prevents the committing of new items to the server until the
inapplicable update has been dealt with.  The ModelTypeSyncProxy is
responsible for saving inapplicable updates across restarts.

This CL alone is not enough to enable encryption support for
non-blocking types.  It requires additional code to hook up the
ModelTypeSyncWorkers to receive cryptographer events.  This will be
added in a future commit.  In the meantime, this CL includes plenty
of unit tests to verify the functionality that's being added.

BUG=351005

Review URL: https://codereview.chromium.org/442053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287849 0039d316-1c4b-4281-b951-d872f2087c98

Removing an old UMA prefix as per crbug.com/390221.

BUG=390221
TEST=None

Review URL: https://codereview.chromium.org/395983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287848 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for using {{patterns}} in toolchain definitions. It makes them
more generic and usable for this, without actually implementing any new features or
changing behavior. The only external change should be that the $in variable is used for
actions instead of making a redundant new variable (used to be called $source).

It removes the FileTemplate class and explodes it into several files: the type list and
helpers (substitution_type), a single pattern (substitution_pattern), a list of patterns
(substitution_list), and a class of helper functions for processing templates in various
ways (substitution_writer).

Previously, the things needing substitutions (args, outputs, depfile) were stored as
strings and parsed in to FileTemplates as needed. This new method stores the
SubstitutionList/Pattern directly on the target. This allows it to issue parse errors
(previously such errors were ignored since errors weren't reportable when writing Ninja
files) and cleans up a lot of the code that uses it.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/429423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287847 0039d316-1c4b-4281-b951-d872f2087c98

This patch ensures that we heapify pointers instead of objects in
priority queue eviction.

Performance data:
Before:
tile_manager_eviction_tile_queue_construct:
2= 411875.46875 runs/s
10= 8762.1435546875 runs/s
50= 48.008880615234375 runs/s

tile_manager_eviction_tile_queue_construct_and_iterate:
2_16= 3337.1767578125 runs/s
2_32= 3041.9306640625 runs/s
2_64= 2513.700439453125 runs/s
2_128= 1940.756591796875 runs/s

After:
tile_manager_eviction_tile_queue_construct:
2= 391767.84375 runs/s (-5%)
10= 8705.869140625 runs/s (-2%)
50= 49.93892288208008 runs/s (+4%)

tile_manager_eviction_tile_queue_construct_and_iterate:
2_16= 3691.25146484375 runs/s (+10%)
2_32= 3666.619384765625 runs/s (+20%)
2_64= 3544.351318359375 runs/s (+41%)
2_128= 3341.751708984375 runs/s (+72%)

R=reveman

Review URL: https://codereview.chromium.org/430053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287846 0039d316-1c4b-4281-b951-d872f2087c98

An unhandled context menu may result in the showing of the paste popup. However,
this paste popup notification is not well-ordered with respect to other
notifications that determine insertion handle state, namely, position and
region editability updates. Consequently, the paste popup may be shown without
a corresponding insertion handle. Resolve this by forcing an editability and
position update when the paste popup notification is received.

BUG=400304,400330,396997

Review URL: https://codereview.chromium.org/447493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287845 0039d316-1c4b-4281-b951-d872f2087c98

The tests are part of https://codereview.chromium.org/406713002/

BUG=None
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/444743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287844 0039d316-1c4b-4281-b951-d872f2087c98

Mock at https://docs.google.com/a/google.com/presentation/d/1GUagduYmawbUHiWwhQdtyxCUFugv2BPPCH0eHhIWGO8/edit#slide=id.g354ad708b_00

BUG=401147

Review URL: https://codereview.chromium.org/435423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287843 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the binary assets for https://codereview.chromium.org/438513002/
This will allow trybots to run and the commit queue to actually pass :)

R=xiyuan@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/444773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287842 0039d316-1c4b-4281-b951-d872f2087c98

- LLVM now uses C++11, so need to use LLVM_OVERRIDE anymore.
- Small changes in Clang interfaces for flags and FrontendFactory
  instantiation.
- clang-format-diff.py works slightly differently now, so update the
  run_tool.py wrapper to invoke it correctly.
- Delete tools that are no longer needed.

BUG=
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/448693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401092

Review URL: https://codereview.chromium.org/449523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287840 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287839 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400484
R=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/442423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287838 0039d316-1c4b-4281-b951-d872f2087c98