- 05 Oct, 2018 40 commits
-
-
John Chen authored
Group the command endpoints based on the sources that defined the commands, to improve maintainability. Change-Id: I0bdf68bc2bd56703fa87ca8486f1550ca6bb3c86 Reviewed-on: https://chromium-review.googlesource.com/c/1263875Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597176}
-
Jaeyong Bae authored
If any of sizes or purpose are missing in ImageResource, provide default values for 'purpose' and 'sizes'. Bug: 868875 Change-Id: I2e88144e1d098a18c740ffeaf9a2fb474db031a1 Reviewed-on: https://chromium-review.googlesource.com/c/1244176 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#597175}
-
Christopher Cameron authored
This fix has two parts. First, call -[NSView addSubview:] in views::NativeViewHostMac, instead of calling it in views::BridgedNativeWidgetHostImpl. This will set up the browser-side NSView hierarchy, even when the browser-side NSViews are not visible (because the app-side NSViews are). Second, in BridgedNativeWidgetHostImpl::OnWindowGeometryChanged, update the geometry of the browser-side doppelganger NSWindow to match the geometry of the app-side true NSWindow. This ensures that the context menu appears in the right place. Both of these fixes are band-aids on the larger issue that we should change the gfx::NativeView and gfx::NativeWindow types to be a wrapper interface that will clearly delineate the where the native types are actually manipulated, and where the native types are just plumbed through. Bug: 859152 Change-Id: I8428166dd889f45888432220be70de340574c385 Reviewed-on: https://chromium-review.googlesource.com/c/1263592Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#597174}
-
Adam Langley authored
These are needed in order to avoid unpleasant snake-casing around numbers in, for example, 'webgl_2' caused by a subsequent change that will will use NameStyleConverter more uniformly in bindings generation. Change-Id: I58ac7ca03bf169fdca1c2918848c9f0e3450d422 Reviewed-on: https://chromium-review.googlesource.com/c/1261963 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#597173}
-
Marijn Kruisselbrink authored
This reverts commit 7d7cc8da. Reason for revert: The new browser tests are very flaky and fail regularly, for example in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/29408: [9182:775:1005/081300.634221:INFO:CONSOLE(4)] "Throttling navigation to prevent the browser from hanging. See https://crbug.com/882238 and chrome://flags/#disable-ipc-flooding-protection", source: (4) ../../content/browser/navigation_browsertest.cc:1281: Failure Expected equality of these values: 100 count_replace_state Which is: 202 Original change's description: > Prevent renderer process flooding the browser with IPC. > > Some javascript function called in an infinite loop can cause the > browser process to be flooded by IPC and become unresponsive. > > Limit the number of IPC sent to 10 per second per frame. > > This was already done for: > - history.pushState() > - history.replaceState() > > This is extended to: > - history.back() > - history.forward() > - history.go() > - navigations... > > 3 tests added. > > Bug: 882238 > Change-Id: I821ff742307ab471ca52f27c6003d003ee978a46 > Reviewed-on: https://chromium-review.googlesource.com/c/1230067 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596715} TBR=palmer@chromium.org,dcheng@chromium.org,clamy@chromium.org,arthursonzogni@chromium.org Change-Id: I27843365fff5da639091524af85791af0af9ce6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882238 Reviewed-on: https://chromium-review.googlesource.com/c/1265060Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597172}
-
Sebastien Marchand authored
Bug: 876348 Change-Id: Ib932652af7814f421009be79a7e9a1e5413fffd7 Reviewed-on: https://chromium-review.googlesource.com/c/1228505 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#597171}
-
Victor Costan authored
Switching from enum to class enum removes the implicit conversions to int. This CL also switches DeliveryType members from SHOUTY_CASE to kModernConstCase and de-virtualizes a few AppCacheJob methods with a simple implementation. These changes are intended to improve the code's readability. Change-Id: I35f8e8007f7abce2371c3cc8200c9e756529ba1f Reviewed-on: https://chromium-review.googlesource.com/c/1263890Reviewed-by:
-
Greg Kerr authored
Flash player DRM videos are currently broken because the V2 sandbox blocks access to the window server. This allows the access. Bug: 891823 Change-Id: I06116f1de78480fe80b01465a6b9b097066b7278 Reviewed-on: https://chromium-review.googlesource.com/c/1263282Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597169}
-
bsheedy authored
Automates all the manual tests from https://crbug.com/887523, which all relate to omnibox text entry and navigation while in the VR browser. Bug: 887523 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0db4cc10def31779b8a59f63e2a1f227cf0a6e29 Reviewed-on: https://chromium-review.googlesource.com/c/1263433Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#597168}
-
Jacob Dufault authored
Change-Id: I9674404c054854d0653a0f2cd61a3b52a85707a8 Reviewed-on: https://chromium-review.googlesource.com/c/1265077Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#597167}
-
Nektarios Paisios authored
Reland "If the caret is at the boundary of a misspelling, getting > > If the caret is at the boundary of a misspelling, getting suggestions via context menu should work If a screen reader user tries to get spelling suggestions for a misspelled word, they usually first move to the beginning of the word using Ctrl+Left/Right and then invoke the context menu. On Windows, Ctrl+Left/Right always moves to the start of the word. On other platforms, Ctrl or Cmd + Left moves to the start whilst Ctrl / Cmd + Right moves to the end of the word. When any of the above keystrokes are pressed, the user hears the whole word. It is not reasonable to expect the user to first press Ctrl+Left/Right to navigate through the line until they find the spelling mistake and then have to additionally press cursor right, (or cursor left when using Cmd-Right on Mac), so that the caret is within the word before invoking the context menu. The result is that many screen reader users might have the mistaken believe that our spell checker is broken. Tested: Manually, unit tests, layout tests Bug: 790828 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I847419f299e1a56c4e32a7d00368f663f66072ff Reviewed-on: https://chromium-review.googlesource.com/c/1252247Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#597166}
-
Henrique Grandinetti authored
Some of the tests make assetions on pref values, but they were doing so without guarantees that the latest value were available. To solve the proble, I forced the pending values to be written to the prefs and moved the assertion to the callback that is invoked when this operation has finished. Bug: 891573 Change-Id: I76411e6d93f061b12af2144cc88e9339531dd3a0 Reviewed-on: https://chromium-review.googlesource.com/c/1261995 Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#597165}
-
Stephane Zermatten authored
Before this patch, WebController could not find the form data if that form data was in an iframe. The logic that cleaned up the selector of the element that was clicked on to pass to GetElementFormAndFieldData didn't trigger, as the frame index reported in FindElementResult was 0. This patch takes another approach: it always only pass the last selector to GetElementFormAndFieldData, which should make sense, since we're in the same context as the element that was clicked on. With this patch, Autofill works even when forms are in an iframe. Bug: 806868 Change-Id: Ic7deaf863373659e9143c38cf01a6ca1406e6521 Reviewed-on: https://chromium-review.googlesource.com/c/1264600 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597164}
-
Tarun Bansal authored
Remove DelayRequestsOnMultiplexedConnections from field trial testing config since the experiment is now default enabled in Chromium. Bug: 836552 Change-Id: I9c0e0e233a47f9a92ea0562b77f6dcadea727e5b Reviewed-on: https://chromium-review.googlesource.com/c/1259963Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597163}
-
Xi Cheng authored
Change-Id: I6dbc74bfa3e1cd27b9893c1d55c3e9277dc08d32 Reviewed-on: https://chromium-review.googlesource.com/c/1261968Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#597162}
-
Becky Zhou authored
Bug: 888996 Change-Id: I00f30d4e2ea06be82d5f8872b2e31cf6a6bd1415 Reviewed-on: https://chromium-review.googlesource.com/c/1263556Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#597161}
-
Stephane Zermatten authored
Before this patch, WaitForDomAction could get into situation where rounds was < 0 and crash in debug mode. This could happen if timeout_ms was very small or at the end, if the element was not found. This patch fixes the round counting and dchecks. With this patch, WaitForDomAction won't crash in debug mode when the element cannot be found. Bug: 806868 Change-Id: I308883441876df66225550b9ddc43d1894a48de6 Reviewed-on: https://chromium-review.googlesource.com/c/1264576Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#597160}
-
Ben Pastene authored
If chrome crashes on startup, the test itself will fail gracefully after ~7 min. Bumping timeout let's us hit that reliably, and lets the test do some cleanup. (Instead of killing it early.) R=jbudorick Change-Id: I9c23198e3267b3a438b9a41daadb4ba70e20de4d Reviewed-on: https://chromium-review.googlesource.com/c/1262799Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#597159}
-
Robert Ogden authored
The rest of the strings in the Preview Page Info dialog don't have periods at the end, so remove this one too. Bug: 871839 Change-Id: I3d70e667aaace71df1586bf670c03e1fac55d02e Reviewed-on: https://chromium-review.googlesource.com/c/1264935Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#597158}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4c11f3dcc855..f8ef3c03bb5d git log 4c11f3dcc855..f8ef3c03bb5d --date=short --no-merges --format='%ad %ae %s' 2018-10-05 lalitm@google.com Merge "trace_processor: fix sorting of events in sched tracker" Created with: gclient setdep -r src/third_party/perfetto@f8ef3c03bb5d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibd2a135f8f13d9e6401a5eb19c145500a27a766f Reviewed-on: https://chromium-review.googlesource.com/c/1264631Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597157}
-
manuk authored
A line was accidentally left out when moving code in the previous cl [1] resulting in outputs from the previous query not being cleared when making a new query when the `Show incomplete results` option was enabled. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1252324 Change-Id: I12f8465898171badff2e6c4f69fcbcaf121f680b Bug: 891303 Reviewed-on: https://chromium-review.googlesource.com/c/1264815Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#597156}
-
kylechar authored
Three video related tests are failing flakily on the Android FYI trybots. Failures have been seen on Nexus 9 and Nvidia Shield primarily, so will set them flaky for nvidia boards. TBR: kbr@chromium.org Bug: 891456 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I64d768be4cabf246b6e0ab007c87c2292a8adf42 Reviewed-on: https://chromium-review.googlesource.com/c/1263037Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#597155}
-
Stephane Zermatten authored
Before this patch, the overlay was displayed when Autofill Assistant was created. This is confusing: the overlay is meant to reflect the fact that scripts are running, but no scripts are running at that point and there might never be any scripts. With this patch, the overlay is only displayed when a script is run. Bug: 806868 Change-Id: I2e1916a0253efb164b4b000c92f2cfef6a1703ad Reviewed-on: https://chromium-review.googlesource.com/c/1264677Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/060ca87d..949f77f4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5cfbc94e8650675582b8f2e6169b9cb6943e6e93 Reviewed-on: https://chromium-review.googlesource.com/c/1264735Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597153}
-
Robert Ma authored
This reverts commit e9f339db. Reason for revert: issue has been solved. Original change's description: > [WPT export] More temporary logging to debug crash > > The working theory is that the locale isn't correctly set in the > Python process. The interactive shell on the bot does have a UTF-8 > locale, but the environment of the Python process could be different. To > verify this, we add some more logging to wpt-export. > > This CL will be reverted once the issue is resolved. > > Bug: 891831 > Change-Id: Ice6478a2b4f3805f2a68b4e2b782f0f23e9aeb99 > Reviewed-on: https://chromium-review.googlesource.com/c/1261974 > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Commit-Queue: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596782} TBR=qyearsley@chromium.org,robertma@chromium.org Change-Id: Icf05a7a7163a948fba10ff3991df2ccc34b4865a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891831 Reviewed-on: https://chromium-review.googlesource.com/c/1265017Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#597152}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 72378c90. With Chromium commits locally applied on WPT: 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25878 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I01f5467192473c33c0fbec6d80115159657bba63 Reviewed-on: https://chromium-review.googlesource.com/c/1264738 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#597151}
-
Xiyuan Xia authored
Speculative fix to single process mash content_browsertests start-up hang by allowing nested task while waiting for display. Bug: 892173 Change-Id: Ia146293d8f2553cd8233feae80786e56402c7c55 Reviewed-on: https://chromium-review.googlesource.com/c/1262925Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597150}
-
Becca Hughes authored
Add two UKM fields to Media.Engagement.SessionFinished to track the total playbacks from audio contexts and media elements. BUG=887619 Change-Id: Icb1ed1300114b09737bab2393b5c3d40e870fc5f Reviewed-on: https://chromium-review.googlesource.com/c/1236924Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#597149}
-
Victor Miura authored
BUG=892436 Change-Id: I1576d16bb1c370710a6374482fd146e639145b91 Reviewed-on: https://chromium-review.googlesource.com/c/1263353Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#597148}
-
Mustaq Ahmed authored
Change-Id: I7c061bdd3c4cc4ee084b0a9311a0c1d65f533494 TBR: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1259290 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#597147}
-
Ahmed Fakhry authored
Opening a drop-down menu in a webpage will create a new RenderWidget with a new LayerTreeHostImpl, whose value of the top_controls_shown_ratio_ (initialized to 0) will be pushed to the browser when a new compositor frame is generated. This will cause top-chrome to hide briefly on opening the menu which will result in closing the menu immediately. This CL fixes the issue by allowing only the main frame widget to set the shown ratio. BUG=891471 TEST=Manual, added a new browser test. Change-Id: I8ead7f903d56e68523a7654abc21aa6e5ca7b690 Reviewed-on: https://chromium-review.googlesource.com/c/1258348Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
rbpotter authored
Ensure the print button starts out with a default "Print" value instead of waiting for the destination to load to display text. Bug: 892093 Change-Id: I1ca54476107a112ac4cccde463b8f1def1e6e501 Reviewed-on: https://chromium-review.googlesource.com/c/1262619 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#597145}
-
Ryan Harrison authored
The current implementation of find in the the PDF viewer will not find a match for text, if the matching text in the document is broken over two lines. This is rooted in the fact that the page text will have extra characters like \r and \n representing the line break in it. This CL adds in collapsing all line breaks and whitespace regions into single ' ' characters when searching. A test has been added to confirm that searching over line breaks works correctly. Originally landed as https://chromium-review.googlesource.com/c/1258042 Reverted in https://chromium-review.googlesource.com/c/1262618, due to an old version of the CL being landed. BUG=chromium:58402 Change-Id: Iad69ab5e9965658f89df4b209dba06a322b15374 Reviewed-on: https://chromium-review.googlesource.com/c/1262658 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#597144}
-
Etienne Pierre-doray authored
Only DetachTimeFg16x is added because it is the most different variation from control, while other variations test values in between. Bug: 847501 Change-Id: Ifbf70af688249d48772779229e2af56a12e1b274 Reviewed-on: https://chromium-review.googlesource.com/c/1263042Reviewed-by:
-
kylechar authored
TBR: weiliangc@chromium.org Bug: none Change-Id: I0809911bbd85d7b7431c052422ce28437b33af4a Reviewed-on: https://chromium-review.googlesource.com/c/1264817 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3ce196a4d9d..032f2756df64 git log b3ce196a4d9d..032f2756df64 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@032f2756df64 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Icf07e3b693c664b66ab4b8b2228ff08c55672549 Reviewed-on: https://chromium-review.googlesource.com/c/1264630Reviewed-by:
-
Xi Han authored
The tests are failed due to FieldTrialSynchronizer is created early and posts task to BrowserThread::UI before the UI thread is initialized. In this case, the FieldTrialSynchronizer doesn't need to post task to UI thread since the renderers are not created yet. Bug: 892636 Change-Id: Ib7d46709f3fca6a749b82d0ba2f601dcf551a8d0 Reviewed-on: https://chromium-review.googlesource.com/c/1264737 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#597140}
-
Tarun Bansal authored
The same anchor element may be stored more than once in anchor_element_metrics_sender. Use a HashSet to avoid duplicate storage. This allows the navigation prediction logic in browser process is unable to accurately determine the visibility ratio of a target HREF. Change-Id: I087e653f15094f8e32d66daa0d2cc6464d90f306 Bug: 891719 Reviewed-on: https://chromium-review.googlesource.com/c/1258822Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597139}
-
Rune Lillesveen authored
Style sharing is gone. No need for SetUnique here. Change-Id: I1959397a2939ee2ab86e7301ac4fb5a47a8cd100 Reviewed-on: https://chromium-review.googlesource.com/c/1264581Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#597138}
-
Sadrul Habib Chowdhury authored
This is a reland of 581a728b Fix for the revert in http://crrev.com/c/1264175 Original change's description: > synthetic gesture: Allow high-frequency dispatch. > > For synthesized scroll/drag/pinch gestures, dispatch the events > at a high frequency (120Hz) so that there's at least one event in > each frame. Dispatching events at a lower frequency (60Hz) means > the timer can go out of sync with begin-frame, and so there can > be frames where there was to event dispatch. Our telemetry code > reports this as jank, which is incorrect. Dispatching at a higher > frequency for the scroll/drag/pinch gestures resolves this issue. > > BUG=783034 > > Change-Id: I1102f76ed743231cbb10fdb872e8c66f895fa223 > Reviewed-on: https://chromium-review.googlesource.com/c/1255152 > Reviewed-by: Victor Miura <vmiura@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596507} TBR=vmiura@, nzolghadr@, lanwei@ since reland without changes Bug: 783034 Change-Id: I7cb96177df54729b24f5414c897cca97456e9484 Reviewed-on: https://chromium-review.googlesource.com/c/1263882Reviewed-by:
-
