- 30 Oct, 2020 40 commits
-
-
Richard Knoll authored
This adds metrics for actions of the muted notification as well as stats once the screen capture session ends. Bug: 1131375 Change-Id: I47a5fc9bf6677f3cc248d727b9a95c4048983870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467941 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#822681}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: I7ceebe66bc953a0a1211896244fe3bf9e47f1aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508201 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#822680}
-
Parastoo Geranmayeh authored
Change-Id: Ib9e6c047c410e2060b8f08d91863fea8372eec5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507669Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#822679}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010300700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/wwoFvUm67SLBY3_HfnEX0lkXxs04pITqyLjVOEmfCZAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/171158139,b/171263711,b/172022118 Tbr: help-app@grotations.appspotmail.com Change-Id: Ib87fc65cd51378ba2059fb6acfe5d791ef54f7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510317Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822678}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie92ef5bf2825c272c5fb30774703e50aabdf7e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510234Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#822677}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9615bcf71f2a..b7fc7a467710 2020-10-30 egdaniel@google.com Allow wrapping of protected AHB into vulkan SkSurfaces. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I76e9614f19f477d4d1262489e6e72b241501f731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822676}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603918565-280375955eaa6ff7fe0c1e66a947d33ea408d529.profdata to chrome-win32-master-1604026576-e94043a9563f776b405eb4e60412f883a861885d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I54ced00fa9656a8c1c0e749e99a6cb6bd4a0ee9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508567Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822675}
-
Anastasiia N authored
Bug: 1135980 Change-Id: I904276282f6ede9d47c51b5316f528af4c84e017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487082Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#822674}
-
Nazerke authored
This CL creates a mediator for connecting TabStrip to WebStateList and as for now the TabStrip shows the number of tabs open. Bug: 1136834,1128249 Change-Id: I9082b675f88a30002f9113a363b1b1e7c2b62465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461010 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#822673}
-
NORTHAMERICA\samtan authored
Adds and binds a blink feature flag to control web app protocol handling features. A previous CL has already added the runtime_enabled_features.json5 entry: https://chromium-review.googlesource.com/c/chromium/src/+/2211200 Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/URLProtocolHandler/explainer.md Design doc: https://docs.google.com/document/d/1NHlWLjAPZ-dyxcz3AoTWibeerDeHW7Vqrx6FmhB0XmE/edit Bug: 1019239 Change-Id: I5ef9ac247f180f5edd4f0734422de5826c0d3465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506395Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Samuel Tang <samtan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#822672}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010300700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/yybQT1NgYyoLnnwaj0ajD2KILEngxWARvh81yQLwFQEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162467266,b/168070003,b/171263711,b/171332474 Tbr: media-app@grotations.appspotmail.com Change-Id: I33ed1adedde8cff267f1217a6cd70b9b03818d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510315Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822671}
-
Fredrik Söderqvist authored
These need to take any potential view spec into account, so it makes more sense to let them live in SVGSVGElement. Other users are trivial and can be open-coded. Bug: 427650 Change-Id: Ib0c9d3378cb08613356207ac3f062d66747ee14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510129Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#822670}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1459d852b166..e0de282e678b 2020-10-30 sugoi@google.com Merge changes Idde36437,Id477959d,I68027fa8,I8e6cf710 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id1d25ec38d634ac9be2d775ef736d342bdd640b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510313Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822669}
-
Mark Yacoub authored
As erasing hardware display controller for mirrored displays happen after the modeset occurs, no checks for mirroring is needed at modeset time. Even if a controller is mirrored, perform a regular Modeset and handle erasing the extra controller at update. BUG=1082882 TEST=enabling mirror mode on an eDP and 2 monitors (DP & MST) Change-Id: Ia2417c501833b4f95afcdbbe4c10d839e3fe04ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505586 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#822668}
-
Ryan Sturm authored
This clears all prefetches and timers in the search prefetch service when the user clears their data (time is not considered in determining which prefetches to clear). Added a couple of nullptr checks to prefetch service as well. Bug: 1138645, 1138644 Change-Id: Icbfbd0c7363e55f758c801faa91b100eaa7a365f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493727Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#822667}
-
Avi Drissman authored
Bug: 1142508 Change-Id: I8e310994740653c0d5174528b5b0ef36e9b0e32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499881Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822666}
-
danakj authored
Currently it's created with the ChromeContentBrowserClient, and a raw pointer is passed to it, which it stores. It is primarily used by ChromeContentBrowserClient. The ChromeMainDelegate has to manage the lifetime of the two objects instead of one. We can simplify the relationship here by having the StartupData owned by ChromeContentBrowserClient instead. Since ChromeMainDelegate already has a pointer to the ChromeContentBrowserClient it creates, it can use the StartupData from there. This makes it clear in the ChromeMainDelegate code that it depends on the ContentBrowserClient being created already when using the StartupData. R=avi@chromium.org Bug: 811470 Change-Id: Ia099042e11f2adc6abb5186f57925fae05343da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508231 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822665}
-
Tanmoy Mollik authored
Replace register and unregister with onAttached and onDetached methods in SignInPreference Bug: 1127990 Change-Id: If4f385691b44ea2845428c9c76143d566c82cce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409964 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#822664}
-
Xiyuan Xia authored
ui::AnimationMetricsReporter is deprecating. Replace it with ui::AnimationThroughputReporter for simple layer animations and ui::ThroughputTracker for complicated ones. Bug: 11434673 Change-Id: I8e1b8319c0142dcea3f64a9a0ac7428d8a35a298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508184Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822663}
-
Ramin Halavati authored
Enabling user triggered screenshots in Incognito mode is not possible now due to an external dependency (b/145247758). As a short term solution until the dependency is fixed, a flag is added to enable it for users/developers who need it. Bug: 985245 Change-Id: Ib1b467ec4ad0f9aa216f040b19dc2670aa0184d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505211Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#822662}
-
Fredrik Söderqvist authored
This provides a more succinct way to express a potentially missing value, and allows dropping the separate HasIntrinsic{Width,Height}. For the usage in SVGSVGElement::CurrentViewBoxRect, just drop the use of IntrinsicWidth/Height() since we resolve percentages against the current viewport - which matches what a plain SVGLengthContext resolve does in this case. Change-Id: I0f6b36e4f34e3ef42adc374100d6a82647301c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509853Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#822661}
-
Fredrik Söderqvist authored
This is just an alias for documentElement(), which should preferably only be used by the SVGDocument (DOM) property. Change-Id: I2bae17b4efd30b5be6488166d511879eaa0196b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509577 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#822660}
-
Nico Weber authored
https://reviews.llvm.org/rL356148 landed 1.5 years ago, it's hopefully available in Xcode now. Also, we no longer support use_system_xcode builds in chromium/ios. Bug: 926235 Change-Id: I50e77e1b4c2e7419ab6be40fc00eb62b44548c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510190 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#822659}
-
Anton Bikineev authored
This also makes PartitionRoot::total_size_of_*_pages atomic. Since there are no side effects around reading/writing them (other than the invariant check), using the relaxed semantics should be safe. Bug: 11297512 Change-Id: Ibeb74484f25ba915a1b31659f3c2d6e13560f83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506441Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#822658}
-
Fredrik Söderqvist authored
This moves all code that has direct dependencies on a Parent() being available to the end of the functions and adds a common early-out. Calls to the parent class' StyleDidChange() is moved first. Bug: 1028061, 1028063 Change-Id: Ibd0b9d710128eff6383d3b48223bf838a553bacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509751 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#822657}
-
Kyle Williams authored
Create a feature trial parameter to support enabling telemetry through encrypted reporting pipeline on cfm specific devices. Create helper function to easily query CfmMojoServices feature flag. BUG=chromium:1105567,b:137780359 TEST='Ensure feature parameter is enabled through command line' Change-Id: I607a1d153811d6847b1fed5429c4146387853c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506264 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#822656}
-
Koji Ishii authored
Also removes one use of |ContainingBlockFlowFragment|, which calls |CurrentFragment|. One more use of |ContainingBlockFlowFragment| is left, only in |NGPaintFragment| codepath. There should be no behavior changes. Bug: 1061423 Change-Id: I47cafd9ed0f1d04bd9cb886ebf8d9a2bb17f6282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509154Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#822655}
-
dpapad authored
This is in preparation of removing <include src="assert.js"> and flattenhtml="true" from js/util.js and js/cr/ui/array_data_model.js, which in turn is necessary to auto-generate grd entries for ui/webui/resources/js/cr/ui/. Bug: 1143194 Change-Id: I9d69b9597ee228aacdc186e2e158d8ebea25558c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508355 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#822654}
-
Vasiliy Telezhnikov authored
This is a reland of 483ed255 Changes from the original: * Removed glPolygonMode -- it's not gles state. * Changed blending for ExternalStencil, sometimes WebView contents doesn't cover the whole scissor rect. Original change's description: > aw: Add missed GL state restoration > > SkiaRenderer (especially when we remove ES2 downgrade) changes more > state then before. This CL adds missed state tracking to > ScopedAppGLStateRestorer and AwGLSurfaceExternalStencil. > > Bug: 1136975 > Change-Id: I55be2bec69c18bff33a3cb18a313a93da10ba088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506116 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822211} Bug: 1136975, 1143984 Change-Id: I1077e3f7753d9010a8660d8d3b54f771939717b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508756 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822653}
-
Peng Huang authored
Bug: 1135112 Change-Id: I59ed3e3c52244f808a951ad0ecaa3125a5ceb2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508976 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#822652}
-
Vladimir Levin authored
This patch refactors some items from the PrewalkSurface function into its own function. These items declare the given and used resources from the surface to the display resource provider. I also added my comments from the understanding of what it is doing. R=weiliangc@chromium.org, kylechar@chromium.org Change-Id: I1a5643a2f8003631a29b452d7eae135356b128ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508442Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#822651}
-
David Bienvenu authored
Also fix a few lint errors; no functional changes. Bug: 1010217 Change-Id: Ie5c783ef4a900931aa40c5e030036b3c1fa4c950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508313Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822650}
-
Kent Tamura authored
- Hold ruby_text_child as NGBlockNode instead of NGLayoutInputNode - Rename LayoutRubyText to HandleRubyText for consistency with other function members - Pass a NGBlockNode instance to HandleRubyTest. We don't need to pass it via a pointer. This CL has no behavior changes. Change-Id: Ic2c2dd48a9996ac5f91255a2b13eebfc26a2e140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509152 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#822649}
-
Koji Ishii authored
After recent removals of calls to |LayoutBlockFlow:: FragmentItems|, only unsed test code was left. This patch removes it along with the function itself. Bug: 1061423 Change-Id: I84edecc0cd742269df04067dec5741c75c0a66c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507414Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#822648}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604037316-5e92166f122bfd61a727a711ba5668734a1ff275.profdata to chrome-mac-master-1604059108-cc1e9f40825b0164b708aba4465bfece5e57e39b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic8b179012aa9b65871f68b587c35606b7f69468d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510123Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e96b7cfe71db..7060721b4ec0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mastiz@google.com,pmonette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:897470 Tbr: mastiz@google.com,pmonette@google.com Change-Id: I8658776232ec4ee9a436e41a43ec703dfe4b39c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822646}
-
Guillaume Jenkins authored
Adds a simple unit test case for the ReportGeneratorIOS class. The test generates a full report and checks that the values in the proto make sense. Bug: 1114853 Change-Id: Ic1ad0979b2adfa41adf93c7ba9298102c23bd830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508553Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#822645}
-
Nico Weber authored
Bug: 1143700 Change-Id: If1110313fda223d83d17db5600f2041c3e1f6f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510229 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#822644}
-
Mark Yacoub authored
Refactor: Move finding a primary plane for Test Modeset or Commit Modeset early on so the plane args could be extended and manipulated in tests, and test would fail quick on failure to find a plane. BUG: 979736 TEST: Test & Commit succeeds. Change-Id: I88de210a59dba67912227a94f542ccff7f771e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505938Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#822643}
-
Nate Fischer authored
No change to logic, only docs. This changes the "Android 10" section to be "Android 10 and later" since Trichrome still applies in R (and will continue to be the format for the foreseeable future). Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia3fc77f32a778be7845ef3afba1215d5d5d5fe75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508317 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#822642}
-