GitLab

This CL rewrites WebContentsUserData using org.chromium.base.UserData.
There should be no functional change. WebContentsUserData is deleted.

Bug: 877878
Change-Id: Ib8f5b2267bf9d21f84661d2e747d8a6c9c1d9d66
Reviewed-on: https://chromium-review.googlesource.com/1189584
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589456}

This CL fixes a bug where permission prompts and page info dialogs go off screen when
hosted app windows are maximised. This only affects platforms that don't support bubble
anchor adjustment (see calls to set_adjust_if_offscreen(false) in
BubbleDialogDelegateView::CreateBubble()). These platforms are Linux, Mac and Windows 7
with Aero disabled.

This patch fixes the issue by making permission and page info dialogs anchored off
the app menu use TOP_RIGHT instead of TOP_LEFT for their arrow position leading the
bubble to position itself within the main window's bounds by default.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355950&signed_aid=ziHkOFUJALIjs_7uaUaPtQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=355951&signed_aid=9B2p0GLHiuHOMC-Ha-rXBQ==&inline=1

Bug: 877032
Change-Id: I98b1fe1e4fe8018886ae960c8601f5d518c9ea5e
Reviewed-on: https://chromium-review.googlesource.com/1201507
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589455}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e1220339..104cb056

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib6e3006420aa1afdcb60de363d4d5029e7f16750
Reviewed-on: https://chromium-review.googlesource.com/1212745Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589454}

Change-Id: Ib45039f33313e2fe950967d6ad2b9d2ee956bf81
Reviewed-on: https://chromium-review.googlesource.com/1199966Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589453}

Upload the keyboard property file for keyboard emulator to remove the
dependency to /usr/local/autotest/cros/input_playback/keyboard.prop.

Bug: chromium:881240
Change-Id: I65daf0326d9237ac5a904f2966be4e95c6f8e210
Reviewed-on: https://chromium-review.googlesource.com/1209135
Commit-Queue: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589452}

The are no unencodable characters in UTF-8, however previously callers
to blink::TextCoder::Encode had to pass a dummy UnencodableHandling
argument. Add a kNoUnencodables value to the UnencodableHandling which is
an explicit no-op. Also add DCHECKs that is is only used for UTF-8 or
UTF-16.

Convert callers to use kNoUnencodables where the encoding is statically
known to be UTF-8.

It's still valid to use other values for the UnencodableHandling
argument with UTF-8 or UTF-16; kNoUnencodables simply documents that it
makes no difference.

Change-Id: I5eebe4c76ae4006ee91f3884f94ec3b5e410685b
Reviewed-on: https://chromium-review.googlesource.com/1206055Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589451}

This reverts commit e7492cbb.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 589442 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U3NDkyY2JiM2M4N2MxNWE3YTE3YjlkMjI4YTcyNmE4ZTYxNTEzMWEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/40795

Sample Failed Step: compile

Original change's description:
> CrOS FilesApp: refactor strings to allow reuse in tests
> 
> Created static FileManagerPrivateStrings::GetStrings() which is called
> by fileManagerPrivate.getStrings() extension function, and can now also
> be called by utility executable to generate strings.js file for
> testing rather than having strings duplicated.
> 
> Bug: 813477
> Change-Id: Ife2ac1b018660451a8c32180e5260f1d9fb6baf2
> Reviewed-on: https://chromium-review.googlesource.com/1208993
> Commit-Queue: Joel Hockey <joelhockey@chromium.org>
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589442}

Change-Id: I4b29ee18d2a663e08108aaf796bcae2aa0728d9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813477
Reviewed-on: https://chromium-review.googlesource.com/1212486
Cr-Commit-Position: refs/heads/master@{#589450}

This allows CrostiniManager to handle states where a VM hasn't finished
starting/stopping fully.

BUG=880165

Change-Id: Ia94bf4059c4bfbf41c3fe920873fa7c8bc2aea18
Reviewed-on: https://chromium-review.googlesource.com/1212206Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Josh Pratt <jopra@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589449}

This is a speculative fix for crash in drive::FileSystem::OnTeamDrivesChanged,
that appears to be caused by passing an invalid iterator to map.erase().

The change uses the key rather than in iterator, which will not crash if the key
is not present.

We have test coverage for this code path, but the fake_drive_service does not
support us triggering this issue, which I think it a race between loading the
initial list of team drives and processing the users first change list.
Instead I added a unit test to ensure that removing a team drive id that is
not in the map will not cause a crash.

Bug: 881679
Change-Id: I16f71f7984b5d4f7fed4cb9e939824fac1c813e8
Reviewed-on: https://chromium-review.googlesource.com/1212371
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589448}

Currently the Runtime flag is setted as test, change it experimental instead
for the test in local.

Change-Id: I633fc63720022214e4857395763843db9c1d578a
Reviewed-on: https://chromium-review.googlesource.com/1212203Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Kyoko Muto <kymuto@google.com>
Cr-Commit-Position: refs/heads/master@{#589447}

This is a reland of bd27fde7

Original change's description:
> FetchManager should not set "referer" HTTP header
>
> Instead it should use ResourceRequest::SetReferrerString and
> ResourceRequest::SetReferrerPolicy.
>
> Bug: 863769
> Change-Id: I4de47bae9aa259ace5ffb5bbdd17d6cf423931d7
> Reviewed-on: https://chromium-review.googlesource.com/1203474
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#589159}

Bug: 863769
Change-Id: Ie01801ef1ab7adec166832511539b19b707ab220
Tbr: domfarolino@gmail.com
Reviewed-on: https://chromium-review.googlesource.com/1212208Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589446}

Adding searching for Chrome binaries in the system PATH as well.


bug: chromedriver:2550
Change-Id: I42c3ad1618e324c964e9b420b2399ce5c8039dab
Reviewed-on: https://chromium-review.googlesource.com/1211744
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589445}

Enables other components to depend on this file instead of the entire
ARC library for UMA recording.

Required for upcoming change in //ash/system/message_center/arc:arc
to record user interactions to UMA.

Bug: 862001
Change-Id: I3100879344a95313963e9b2bf1861a8f8206a416
Reviewed-on: https://chromium-review.googlesource.com/1212429Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589444}

This reverts commit 91779560.

Reason for revert: The layout object to paint text clip might not be
LayoutBlock.

Bug: 881644

Original change's description:
> [PE] Support float, block, table descendants for background-clip:text
> 
> In https://chromium-review.googlesource.com/c/chromium/src/+/1197462
> we changed box_model_.Paint() to LineBoxListPainter so we no longer
> supported text clip for descendants other than inline contents.
> 
> This CL calls ToLayoutBlock(box_model_).PaintObject() to support text
> clip of other descendants, and still avoid the original double paint
> offset issue of box_model_.Paint().
> 
> Bug: 880825
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I2c4b0e23df11bf300c01f9c804fb7e7d129f3aa0
> Reviewed-on: https://chromium-review.googlesource.com/1211244
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589314}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: Id26f9f690884300fceb4bdaf3e4f3fb2aad4fc04
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 880825
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1212483Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589443}

Created static FileManagerPrivateStrings::GetStrings() which is called
by fileManagerPrivate.getStrings() extension function, and can now also
be called by utility executable to generate strings.js file for
testing rather than having strings duplicated.

Bug: 813477
Change-Id: Ife2ac1b018660451a8c32180e5260f1d9fb6baf2
Reviewed-on: https://chromium-review.googlesource.com/1208993
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589442}

It is possible for Crostini apps to be disallowed by policy. This can change
at any time for a give machine, so we always need to check.

While the pinning bug is still happening, we also need this as a failsafe.

Bug: 881681
Change-Id: I2e2497ef9cdaee7f989d38931a88886d52535cf9
Reviewed-on: https://chromium-review.googlesource.com/1212373Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589441}

Adds a new level of "invisible" attribute: "static", which prohibits
custom element upgrade inside invisible-static subtree unless authors
explicitly call CustomElementRegistry.upgrade()

See design doc at https://goo.gl/sEJt3e
I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Icw_sU6PqVA/8hwXw0jTDwAJ

Bug: 873057
Change-Id: I5c2a88446ca3a758b28917fcae349c5cdadd0132
Reviewed-on: https://chromium-review.googlesource.com/1204373Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589440}

Tremplin now sends a signal indication percent downloaded for a container.
This is bounced to the appropriate observers (in this case, the
CrostiniInstallerView). The install progress bar now indicates install
progress based on download percent and estimated time for each stage.

Bug: 860094
Change-Id: Iaa4dfe3464e30931d8ae1fce15a46f2d5ffbe7b5
Reviewed-on: https://chromium-review.googlesource.com/1201647Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589439}

https://webrtc.googlesource.com/src.git/+log/ea8b6f95c763..7cd2a9514837


git log ea8b6f95c763..7cd2a9514837 --date=short --no-merges --format='%ad %ae %s'
2018-09-07 buildbot@webrtc.org Roll chromium_revision 450316ff..d03e9be2 (589248:589368)
2018-09-06 emircan@webrtc.org Multiplex codec cleanups
2018-09-06 peah@webrtc.org AEC3: Parametrize the delay estimator to leverage strong echo paths
2018-09-06 benwright@webrtc.org Updated FrameEncryptorInterface and FrameDecryptorInterface with status code.
2018-09-06 sukhanov@webrtc.org Interface for media transport
2018-09-06 buildbot@webrtc.org Roll chromium_revision fcd25fc0..450316ff (589073:589248)


Created with:
  gclient setdep -r src/third_party/webrtc@7cd2a9514837

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium: 880686,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I056a13c149b75fb27ccef3358e6fdbac8f772e85
Reviewed-on: https://chromium-review.googlesource.com/1212563Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589438}

The //ui/file_manager/common/js:util target has a dependency on the
file_manager_private extern. Break out that extern to a separate target
to bundle its hidden dependencies together, since multiple things
depend on it.

Bug: 860355
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Icfa65dff5c692b6bd415f9f2d5c67b14a0db0ef6
Reviewed-on: https://chromium-review.googlesource.com/1212706Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589437}

Change-Id: I35304eb77e8e09d971b1854416c121bc5ec0935e
Reviewed-on: https://chromium-review.googlesource.com/1212369Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589436}

Runtime flag is now removed so adjusted comment accordingly.
IsActiveV0InsertionPoint required pulling in v0_insertion_point.h, so
dropped doing that.

Change-Id: I914c1567c6a90473b53b470ff34d35b32b2530d2
Reviewed-on: https://chromium-review.googlesource.com/1209502Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589435}

This is a reland of 074455de

Original change's description:
> Strengthen requirements on CORS-safelisted request-headers
>
> With this CL, some request headers that used to be treated as
> CORS-safelisted are not CORS-safelisted any more. Specifically,
>
>  - "accept", "accept-language" and "content-language" have a stronger
>    check on its value
>  - All headers whose value exceeds 128 bytes are treated as not
>    CORS-safelisted
>  - If the sum of value length of CORS-safelisted headers exceeds 1024,
>    then all of them are treated as not CORS-safelisted.
>
> This CL also implements
> https://fetch.spec.whatwg.org/#no-cors-safelisted-request-header.
>
> This is for https://github.com/whatwg/fetch/pull/736.
>
> Bug: 824130
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Ib12a7dbff6367717a43130ae59304dca55b7bf4e
> Reviewed-on: https://chromium-review.googlesource.com/1196563
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589153}

Bug: 824130
Change-Id: Ia5caad12a51ee44713cf4cf11f42b1fc9ab831a9
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Tbr: toyoshim@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1212425
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589434}

Fixes for comments on crrev.com/c/1192424 after merge.

Bug: 851636
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id742b36e6f46a647b510f81307f371b51bac7b3f
Reviewed-on: https://chromium-review.googlesource.com/1208463
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589433}

The function is renamed from CanIncreaseCurrentThreadPriority() to
CanIncreaseThreadPriority() so it's clear that it doesn't return a
per-thread value.

Also, a ThreadPriority argument is added to allow implementations to
return a different value depending on the target priority. On Linux
for example, a priority increase should succeed if the target priority
is within the range allowed by RLIMIT_NICE.

This is a no-op CL from an execution point of view.

Bug: 816389
Change-Id: I98cb640527cc2cccb85db45395210e41d6bc5f64
Reviewed-on: https://chromium-review.googlesource.com/1187506
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589432}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd2c588e3811..515e7fe03790


git log dd2c588e3811..515e7fe03790 --date=short --no-merges --format='%ad %ae %s'
2018-09-07 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@515e7fe03790

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I7225adeec45924aad4c223b18c7fb0a05d633502
Reviewed-on: https://chromium-review.googlesource.com/1212562Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589431}

Using wpt-import in Chromium bfbc8215.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24205

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: I59e21a19eda15b910d8b482231dd98a93d76aac4
Reviewed-on: https://chromium-review.googlesource.com/1212354
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589430}

N SimulateEtc methods were replaced with 1 method.

Change-Id: I0b9b0701959de1cbc0c8b273cd5f59a929766de7
Reviewed-on: https://chromium-review.googlesource.com/1208990Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589429}

This change updates the service_manager::Instance code to reference its
options_.can_connect_to_other_services_with_any_instance_name value
instead of "service_manager:instance_name" in the "required" section
of its interface provider specs.
Tests and existing manifests were updated accordingly.

Bug: 866967
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7811919f86470cb098d588710e9aa3f2dd497e32
Reviewed-on: https://chromium-review.googlesource.com/1208710Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589428}

This CL adds a parameter to fieldtrial_testing_config to test a new feature of Oomintervention in
 finch now that canary/dev results look good.

Bug: 879026,764481
Change-Id: I44f0c472db191ce92404a714ef33304992e251b4
Reviewed-on: https://chromium-review.googlesource.com/1183043
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589427}

BUG=b:112181526
BUG=881669
TEST=build

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ife2de572cad1a47c0e98a6b9f792cfd962af96f0
Reviewed-on: https://chromium-review.googlesource.com/1212204
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589426}

Bug: 877724
Change-Id: Iaa71eda0e0fa94f9d23c9bc71b12d2abd3ec4224
Reviewed-on: https://chromium-review.googlesource.com/1209001
Commit-Queue: Chris Hall <chrishall@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589425}

The situation should never happen, but nevertheless seems to.

Bug: 880930

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1dec6cdb3cb2c004511646a7133c4564a5a4f4ca
Reviewed-on: https://chromium-review.googlesource.com/1211872
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589424}

This reverts commit ebe80ad0.

Reason for revert: Suspicious to break MSan Tests.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/11452

Original change's description:
> Wait for ukm entry in TryAutoplay
> 
> The test fails due to a race of UkmRecorder::AddEntry with DOMMessageQueue::Observe:
> https://cs.chromium.org/chromium/src/services/metrics/public/cpp/delegating_ukm_recorder.cc?q=src/services/metrics/public/cpp/delegating_ukm_recorder.cc&sq=package:chromium&g=0&l=137
> 
> Bug: 880217
> Change-Id: Icf099c3eb1094d8a571dc6f87b152e3c838807dc
> Reviewed-on: https://chromium-review.googlesource.com/1204011
> Reviewed-by: Tommi <tommi@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Steven Holte <holte@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589317}

TBR=tommi@chromium.org,holte@chromium.org,jochen@chromium.org,rkuksin@yandex-team.ru

Change-Id: I2c930e1d9ac74bd63ab876f06e494824fd4524d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 880217
Reviewed-on: https://chromium-review.googlesource.com/1212245Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589423}

Test: ash_unittests ShelfLayoutManagerTest.VisibleInOverview
Bug: 881153
Change-Id: I2b5b8122831b5c71bc4ee4fcf4360d7626e11f0b
Reviewed-on: https://chromium-review.googlesource.com/1211741
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589422}

This reverts commit da27378f.

Reason for revert: This CL caused many crashes in the wild. (crbug.com/881348)

Original change's description:
> Split implementation of EventListener and EventHandler
>
> This CL add new class blink::V8EventListenerImpl which implements
> ONLY EventListener (not EventHandler). It has a blink::V8EventListener
> which inherits blink::CallbackInterfaceBase. As a result, EventListener
> will start to handle incumbent realm. EventHandler will still be
> offered by blink::V8AbstractEventListener (this class is renamed to
> blink::V8AbstractEventHandler in this CL) after this CL submitted.
> Also, entry realm was set to wrong one (event target's one) with
> blink::V8AbstractEventLisntener so this CL set it to listener's one as
> defined in standard.
>
> Regarding crbug.com/872138 :
> Current blink::V8AbstractEventListener implements both of EventListener
> and EventHandler, so I am trying to implement new class for
> EventListener first to separate these. EventHandler will be modified in following CLs.
>
> Regarding crbug.com/878658 :
> This CL modifies expectation file for layout test:
> fast/events/touch/gesture/gesture-tap-frame-removed.html
> This is because event listener starts to remember incumbent realm after
> this CL and it results in incorrect behavior as explained in the BUG.
> This is not a regression, but have to be resolved in following CLs.
>
> Bug: 872138, 878658, 606900, 849236
> Change-Id: I4bf7fe2f4fd51287f873c2377edfd57e4bb2a54a
> Reviewed-on: https://chromium-review.googlesource.com/1172234
> Commit-Queue: Yuki Yamada <yukiy@google.com>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588748}

TBR=peria@chromium.org,yukishiino@chromium.org,hayato@chromium.org,haraken@chromium.org,yukiy@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 872138, 878658, 606900, 849236, 881348
Change-Id: Ie981df66657c8868c769cb8d18bf799605cfd004
Reviewed-on: https://chromium-review.googlesource.com/1212202
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589421}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: Ibfab68882fda3e5eb65b90a02a48246c2549d20f
Reviewed-on: https://chromium-review.googlesource.com/1212007Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589420}

This should fix crash/caab6eb137e58385

This CL addresses the unhandled case in crrev.com/582126

TBR=falken@chromium.org

Bug: 881126, 868592
Change-Id: I906eecc3bf21aa9900355b1f312bd5025375fa8d
Reviewed-on: https://chromium-review.googlesource.com/1207781
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589419}

This CL changes the CrostiniManager from being a global singleton to a
profile keyed service. This tidies up the implementation as we can now
assume that we have a valid Profile, so don't need to sanity check the
owner_id/cryptohome_id arguments that used to be passed into arguments,
and also simplify the members by dropping the owner_id keys. Tests will
now use individual CrostiniManager objects instead of re-using the same
CrostiniManager, avoiding test runs influencing other test runs.

This CL also removes the CrostiniRestarterServiceFactory, and moves the
functionality of CrostiniRestarterService into the CrostiniManager. One
side-effect of this CL is that the on-login component update will occur
on each (primary profile) log-in, instead of once per Chrome restart.

Change-Id: If76895cfc3994cb0bda3504e09bae452955dbe6b
Reviewed-on: https://chromium-review.googlesource.com/1201646Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589418}

Bug: 856209
Change-Id: Ifcb55f5e3f7e50ff94ebfe1a6e607e06c22d4add
Reviewed-on: https://chromium-review.googlesource.com/1212363Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589417}