- 08 Oct, 2020 40 commits
-
-
Mei Liang authored
This CL mainly focus on moving the onOverviewModeStateChanged() signal out of the OverviewModeObserver interface. That signal only matters when StartSurface is enabled, so the signal is merged to StartSurface.StateObserver.onStateChanged. With the above change, this CL allows features to attach the StartSurface.StateObserver to StartSurface via the ObservableSupplier pattern. In addition, this CL renames OverviewModeState to StartSurfaceState. Change-Id: Iebaa907fca4baf6a1fee819b31fbd57370126dbc Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315823 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#814994}
-
Makoto Shimazu authored
This reverts commit d22c8914. Reason for revert: This test continuously fails on linux-chromeos-dbg. Sample build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20743 Original change's description: > Switch Access: Add test for keyboard node. > > This change adds a test to ensure Switch Access state gets updated > when the virtual keyboard is opened and closed. > > Fixed: 1135248 > AX-Relnotes: N/A > Change-Id: I1b894bce635f1790cee1111f50992c9136d3ded7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453899 > Commit-Queue: Akihiro Ota <akihiroota@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814745} TBR=dtseng@chromium.org,akihiroota@chromium.org Change-Id: Icafd07fedf3f65fb637e8383aaaf57457efc709e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459698Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814993}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. Tests like ShelfAppBrowserTest no longer need to be parameterized. Bug: 1065748 Change-Id: I42616fdd0d22d8f9b96bac88bd71269045737fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454777 Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#814992}
-
Maggie Cai authored
This CL: - Update the installation of test arc app and PWA to allow actual app launch. - Add test callback in intent picker bubble view for bubble shown. - Update the tests to test show bubble on icon clicked. - Update the tests to test arc app and PWA launch. - Update the PWA only test case to work with kIntentPickerPWAPersistence flag. These changes also make the test for app preference and the test for desktop version intent picker bubble possible. There will be follow up CLs to add these tests. BUG=853604 Change-Id: I11a1b98d3005d5ac9c00408ac9c99d7fa968fc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439996 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814991}
-
Daniel Hosseinian authored
Resolution (aka DPI) support can already be read from PPDs and through IPP. Therefore, the options are already shown in Print Preview. However, the user's resolution option is not passed to the print job. Use PMPrinterSetOutputResolution() from the Core Printing API [1] to programmatically control the output resolution. While only supported resolutions will be passed to the job, the API also matches the passed in resolution to the closest resolution setting supported by the destination. [1] https://developer.apple.com/documentation/applicationservices/1459931-pmprintersetoutputresolution Bug: 123124 Change-Id: I836ff21a052c7a8a6cf27dbe4dd02de19f3c85ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459129 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#814990}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602093472-1d23f3e20a4e345891a53ac8f50b5338bb0c8ae6.profdata to chrome-mac-master-1602115190-6522495ca352d45be49e234f0c6bf7d20bdcb906.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7fc72acd65d6a7e9ab175e8db274fc2191afe4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814989}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ae1f2502..7b603fae Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3392663dd0124ea78c0fd4a360aaa48b40505c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459707Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814988}
-
Makoto Shimazu authored
This reverts commit 6860e109. Reason for revert: Speculative revert to fix fast/frames/iframe-scaling-with-scroll.html. https://crbug.com/1136335 Original change's description: > Limit minimum scale of PaintedScrollbarLayer to 1 > > This is to avoid too low scale when animating scale above the > scrollbar layer. > > This is not ideal. In the future we should move rasterization of > scrollbar layers to impl-side to better handle scales > (crbug.com/1009291). > > Bug: 1133997 > Change-Id: I3364754f530914816fe8526c627e6cf12e7942ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453436 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814681} TBR=wangxianzhu@chromium.org,bokan@chromium.org Change-Id: I4554c428bcc5a3d5fef9033e6772f53932d0e256 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133997, 1136335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459087Reviewed-by:
-
Samuel Huang authored
This reverts commit a4d34d8a. Reason for revert: This causes chromeos-amd64-generic-lacros-builder-perf to fail, likely due to missing eu-strip. Original change's description: > [Lacros] Size dashboard: Track stripped size of ELF files. > > This CL modifies lacros_resource_sizes.py to identify ELF files, and > also track their stripped sizes (using eu-strip) as well as compressed > stripped sizes. These news info are recorded for chrome and the Total. > > If eu-strip fails for a file then we simply ignore its stripping > results and print warning. Known-bad files include .nexe files and > libwidevinecdm.so. These are explicitly excluded to denoise the system. > > Bug: 1106626 > Change-Id: I9cb47bb41baa2b73996e6662db2fe4bc537338d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458869 > Commit-Queue: Samuel Huang <huangs@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814972} TBR=huangs@chromium.org,erikchen@chromium.org Change-Id: I580c4ea4a125fef785cdb0c6de1c31846a7e8180 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459794Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#814986}
-
Xiaoqian Dai authored
In different capture mode type and source, we may show different icons/ messages in middle of the screen or in middle of the captured region and prompt the user to do the next step. And in video recording scenario, this message will transform into a 3-seconds countdown timer before starting video recording. This CL implements - showing different icon/text message in different scenarios - showing a 3-seconds countdown UI before video recording Animation is not implemented in this CL and will be addressed in a following CL. Bug: 1126669 Change-Id: Id07b4c1137eb77946695899603ae43aeda84c643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439778Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#814985}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7c1a3543d64eb534e89eb631f0ee64f897be8ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459892Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3419b3b485ba..9fb07662e436 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifcd18a2ee715f3c144b2d38d3ce08e1602311e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459791Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e20d8219. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I6bf865b599ed9b7e6a6cd38c60bf8d57e4e75b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459171Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814982}
-
Sinan Sahin authored
This CL brings the direct share actions closer to other context menu actions by delegating them to the ContextMenuPopulator instead of handling them explicitly in the coordinator. Change-Id: If15d7f5e1bf5e540ca1bd4ded2470afe9dbf8352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458526 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
-
David Tseng authored
Moves text-to-speech playback from js-based web audio to C++. See bug for more details. Depends on https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2456208/1 Fixed: 1134289 Change-Id: I7ecfa800f6b688f6a3d0d655f557e86efa73188a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435919 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#814980}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iae4c666e2d130dc2208198cde061cc608f3a7375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459587Reviewed-by:
-
Alexander Cooper authored
Switches ArCoreInstallUtils off of base.ApplicationStatus and onto the built-in ActivityLifecycleCallbacks. Despite being in base, per crbug.com/470582, ApplicationStatus is not suitable to use in components (where ArCoreInstallUtils is moving). This thus directly implements and leverages the ActivityLifecycleCallbacks through means of a thin wrapper class in ArCoreInstallUtils, so that the code may thus be moved to components. Bug: 1064073,960542 Change-Id: I2ea69b19aaa4a3219fa7d9d4a66c07cbaafca7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459267 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#814978}
-
Scott Violet authored
FillLayerInfo wants to know if the box is a scroll-container, not whether it has non-visible clip. BUG=1134937 TEST=external/wpt/css/css-overflow/overflow-clip-002-crash.html Change-Id: I316d25bab1a15bebef46324eaf72a6ccc6c2d8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450695 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#814977}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4171134daf9d..6b4a4a85dfd7 2020-10-07 kainino@chromium.org Fix EntryPointTests WGSL shaders for Tint roll If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I2b7b80b7274b6f99b6105ddf822e5eaf22bceca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459890Reviewed-by:
-
Karthika Pai authored
The values are passed from the VariationsService to the VariationsIdsProvider. This is needed to include the low_entropy_source_value in the X-Client-Data header. Change-Id: I81141eb22396c31c05101229b900631bd0a9a5b8 Bug: 1134444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444137Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Karthika Pai <karthikapai@google.com> Cr-Commit-Position: refs/heads/master@{#814975}
-
Vikas Soni authored
Bug: 1091945 Change-Id: I9c7227fcaa0e74c92194fc4c5b5a785d4e6b42ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456632Reviewed-by:
-
yilkal authored
This cl adds edu_account_login web ui handler. This cl adds edu_coexistence_browser_proxy.js to relay calls from js to the appropriate c++ handlers. Bug: 1131174 Change-Id: Id10b8078de37718c69e457e6b3ed66fd23eb9baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424072 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#814973}
-
Samuel Huang authored
This CL modifies lacros_resource_sizes.py to identify ELF files, and also track their stripped sizes (using eu-strip) as well as compressed stripped sizes. These news info are recorded for chrome and the Total. If eu-strip fails for a file then we simply ignore its stripping results and print warning. Known-bad files include .nexe files and libwidevinecdm.so. These are explicitly excluded to denoise the system. Bug: 1106626 Change-Id: I9cb47bb41baa2b73996e6662db2fe4bc537338d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458869 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#814972}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a989f948c4e0..acdf3c1947a2 2020-10-07 chonggu@google.com [Fuchsia] Add specific Fuchsia device type tags. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1096431 Tbr: zhanliang@google.com Change-Id: Ie8db0c71639006a64106e38cae77de22f8a9d733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459408Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f38cef2f4642..a1334f20f4cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com,kmilka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1134473,chromium:912681 Tbr: shimazu@google.com,kmilka@google.com Change-Id: I6608ef8e1c2309654aed9a860ccbd1ede125e7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459726Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814970}
-
Jonathan Freed authored
Bug: 1089067, 1089107, 1089099, 1089100, 1089102, 1089101 Change-Id: Ic4c258662857e5e4d741e593e0bc28758ae31dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453431Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#814969}
-
Jeffrey Young authored
This is a reland of a81c2688 Original change's description: > ambient: cache two backup photos > > Handle failure cases better by having backup photos on disk. > Refresh these images after user logs in. > > BUG=b:167332126 > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: I7046a20ed9606638e851247f8c213d112af6c30b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429585 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813904} Bug: b:167332126 Bug: b:170312454 Change-Id: If5306f627e1a6dfb5e4eb37842a470d17968ad4e Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458894 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#814968}
-
Yu Su authored
Lens Controller - add a queryImage method to support passing back app intent key from Lens Prime SDK. The app intent key will be used when generate the Lens deeplink intent in LensUtils.java. Change-Id: I40a58eaabaadb23a3113825400c3be95396aa4f0 Bug: 170126006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450709 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#814967}
-
Sam Maier authored
Bug: 1134209 Change-Id: Iafefd9550c1cb6451cf5ce89a3a12b4046893231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459111 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#814966}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I3d72b6051e0de93b328ae1d93036584a71f7cf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458872Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814965}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c48f5ba0b57d..3b5d31305f58 2020-10-07 btolsch@chromium.org Re-enable gcc bot 2020-10-07 btolsch@chromium.org Add CastSocket close e2e test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135966 Tbr: jophba@chromium.org Change-Id: Ib40e84df2417c383fbd82464d1d83abc752cee7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458844Reviewed-by:
-
Jesse Schettler authored
Using arrow functions is recommended over binding since arrow functions permit explicitly specifying which parameters to pass to the callbacks. Bug: 1059779 Change-Id: I25279d8e39f6635a41719e794620c76ee956545f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457406Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#814963}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3419b3b485ba..9fb07662e436 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I30152f5e97ec7bd11d2569b5872f874306b2f5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458883Reviewed-by:
-
Azeem Arshad authored
This is a reland of 991f4851 NOPRESUBMIT=true Original change's description: > [ShapeDetection] Add barhopper impl for BarcodeDetection. > > This CL adds BarcodeDetection and BarcodeDetectionProvider > implementations based on the barhopper barcode detection > library. > > NOPRESUBMIT=true > > Bug: 1093185 > Change-Id: I29b233418108482ebc80bce7c34888fa2081068f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419911 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813335} Bug: 1093185 Change-Id: I25475c3e1c2a19732e98822053a7e9d87c12d7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450330Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#814961}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3ce148638bdc..2067d1a93e6e 2020-10-07 dneto@google.com Add test case for read-only storage texture passed to helper function (#2414) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC timvp@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: timvp@google.com,radial-bots+chrome-roll@google.com Change-Id: Id1c49cb3ca0769b9b58c029461099eb4043fcea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459251Reviewed-by:
-
Xinghui Lu authored
Mocks: http://slides/1YgDDFKSXoIFreM19fBQZx71Kfa1Gh7Tmywqhmo-pkLY/view# slide=id.g97a0aac007_0_43 Screenshots: Desktop SB: http://screen/3LzbFP3BhJcH8jt Desktop SSL: http://screen/AqReWuvxFPxzYdh Android SB: http://screen/9v4wQeCtqWsmteC Android SSL: http://screen/AWJekyhEeHu94ds Bug: 1130721 Change-Id: Ifc63a24b280410bccec13ec06bf13e5022242c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434767Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814959}
-
Vikas Soni authored
Although the SharedImageBackingFactoryAHB do not perform any AHB related operations in its constructor, we still want its object to be created only when AHB is supported to make sure we are not unnecessarily creating the object and not using it. As an example for Android N, since AHB is not supported, this object will never be used but we were still creating this object. This resulted in crash on android N though actual reason of crash is still unknown. Bug: 1128900 Change-Id: If1e9949c9d415bce0ed856f94c437802c4896ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459347 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#814958}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 126802 Test: none Change-Id: I6d116ae884ffc38300b538f4863179c01fd5e1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459394 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#814957}
-
Nnamdi Theodore Johnson-Kanu authored
- Updates cellular setup mojom interface provider - Adds fake cellular setup remote - Updates psim test to use fake cellular setup remote - Updates nameOfCarrierPendingSetup to use cellular metadata Screenshot: https://screenshot.googleplex.com/6FvKzBoWQf4hGGQ.png Bug: 1093185 Change-Id: Iabd1e0df3c02e192fbb1b109140d5d8d6c891284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443073 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#814956}
-
Erik Chen authored
Bug: 1135494 Change-Id: Ife13223dea213e57427803bc6cae97e492608a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458848 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#814955}
-
