GitLab

BUG=334309,161119
NOTRY=true

Review URL: https://codereview.chromium.org/130263007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251163 0039d316-1c4b-4281-b951-d872f2087c98

when they block a URLRequest.

BUG=294920

Review URL: https://codereview.chromium.org/153503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251161 0039d316-1c4b-4281-b951-d872f2087c98

Because the docserver now redirects foo.html to foo, presubmit tests
have been changed to query extensionless URLs for corresponding template
files.

BUG=343614
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/164493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251158 0039d316-1c4b-4281-b951-d872f2087c98

The Chrome OS out-of-memory tab discarder uses the "last selected" time as a signal for which tab to discard. This starts at 0 for freshly created background tabs, like those created with a control-click. The user probably doesn't want to discard those tabs, since they just opened them.

Since the only other user of WebContents::GetLastSelectedTime() is devtools, which uses it for a similar kind of sorting based on activity, rename the method to GetLastActiveTime() and start the value with the tab creation time.

BUG=338735
TEST=content_unittests WebContentsImpl.GetLastActiveTime
TBR=torne@chromium.org for rename touching android_webview

Review URL: https://codereview.chromium.org/138913021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168518
NOTRY=true

Review URL: https://codereview.chromium.org/163923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251153 0039d316-1c4b-4281-b951-d872f2087c98

Follow up of crrev.com/141893009.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/164023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251152 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/164293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251151 0039d316-1c4b-4281-b951-d872f2087c98

This is to ensure that we mark these processes as DPI aware at startup. Needed because NPAPI plugins perform UI operations like
creating windows parented to the browser etc.

BUG=341543
R=cpu@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/139253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251150 0039d316-1c4b-4281-b951-d872f2087c98

Flakily fails: MSE_ClearKey/EncryptedMediaTest.ConfigChangeVideo/0

NOTRY=true
TBR=yfriedman
BUG=343604

Review URL: https://codereview.chromium.org/163503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251149 0039d316-1c4b-4281-b951-d872f2087c98

TEST=browser_tests
BUG=342546

Review URL: https://codereview.chromium.org/153263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251148 0039d316-1c4b-4281-b951-d872f2087c98

This is the first change to allow RtcpSender to send redundant events.
Rtcp and RtcpSender interface used to accept receiver events logs. They
are now changed to accept ReceiverRtcpEventSubscriber. This allows
RtcpSender to fetch event logs from the subscriber directly.

No functional change other than passing event subscriber instead of
event logs.

Review URL: https://codereview.chromium.org/162333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251147 0039d316-1c4b-4281-b951-d872f2087c98

This is a short term workaround. Will revert promptly.

BUG=342061
TEST=launch app in kiosk mode and make sure things are still working, and RenderWidget::CreateOutputSurface() does not allocate DelegatedCompositorOutputSurface.
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/164683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251146 0039d316-1c4b-4281-b951-d872f2087c98

This change also reverts https://codereview.chromium.org/133273033/
because you don't need to fire onPageFinished separately for ssl error cancel.

BUG=342859

Review URL: https://codereview.chromium.org/144283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251145 0039d316-1c4b-4281-b951-d872f2087c98

A tool to print out static initializers in the format below.

These static initializers cause problems for some sneakier CRT initialization
tricks we do, and they also were measured to have an appreciable slowdown
on startup time (at least on CrOS) so generally trending towards 0 is
desirable.

The basic approach is looking for symbols that have the magic VS name
`dynamic initializer for ' which is the demangled name that's used for
global C++ initializers. The binary is processed by using the DIA SDK
(some of the code is from the Dia2Dump sample), which means that the
target binary requires being built with symbols for this tool to work.

The intention is that a run of this tool will be hooked into the 'sizes'
step on clobber builders on the waterfall, similar to Linux and Mac.

===
Static initializers in a.exe:
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_Generic_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_Iostream_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::_Error_objects<int>::_System_object''
d:\src\cr2\src\tools\win\static-initializers\a.obj: `dynamic initializer for 'std::num_put<char,std::back_insert_iterator<std::basic_string<char,std::char_traits<char>,std::allocator<char> > > >::id''
...
===

See https://code.google.com/p/chromium/issues/detail?id=341941#c7 for logs of those found in Chromium.

R=cpu@chromium.org
BUG=341941

Review URL: https://codereview.chromium.org/66613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251144 0039d316-1c4b-4281-b951-d872f2087c98

(This reverts the revert, which was r250856).

TBR=jamesr@chromium.org
BUG=327471

Review URL: https://codereview.chromium.org/164033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251143 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds several changes:
- enables the JS handler to turn on and off the hotword recognizer
- adds a pref 'hotword.app_list_enabled' to customize the plugin usage
- synchronization logic, so if the user explicitly turns off
  hotword.search_enabled, hotword.app_list_enabled goes off too
- extract the language check of HotwordService as a static method
  and let StartPageHandler check it, because our hotword
  "Ok, Google" is US-English only

BUG=341710, 341779
R=xiyuan@chromium.org, rlp@chromium.org, estade@chromium.org
TBR=samarth@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/158143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251142 0039d316-1c4b-4281-b951-d872f2087c98

Don't attempt to unload the same extension twice if multiple ExtensionHost instances existed for the extension.

This makes sure ExtensionService doesn't schedule a second
TrackTerminatedExtension call if one call is already in progress.

BUG=327735

Review URL: https://codereview.chromium.org/162183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251141 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig@chromium.org
BUG=340752

Review URL: https://codereview.chromium.org/164193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251140 0039d316-1c4b-4281-b951-d872f2087c98

By adding rel=next as an origin, we get histogram reporting on many of
our existing histograms.

The one tricky decision is that a prerender can have multiple rel
types (both next and prerender), and that by origin we currently
distinguish samedomain vs crossdomain.

In this CL we treat a prerender with both next and prerender rel types
as rel=prerender, and we do not distinguish cross vs same domain on
rel=next prerenders.

R=tburkard,davidben,isherman@chromium.org
BUG=329963

Review URL: https://codereview.chromium.org/121293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251139 0039d316-1c4b-4281-b951-d872f2087c98

Clients should set the host_os gyp variable instead. (As far as I can tell,
this flag was added for the webview build, and this CL updates gyp_webview
to use the gyp define instead. I haven't found other clients.)

Since several gyp targets check the value of host_os in a
target_conditions block and most of the build/common.gypi variables
aren't available during target_conditions processing time, use the same
trick that chromium_code uses to make host_os available at target_conditions
time.

BUG=330631
NOTRY=true

Review URL: https://codereview.chromium.org/153623011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251138 0039d316-1c4b-4281-b951-d872f2087c98

1. Build a standalone remoting_native_messaging_host.exe. remoting_host.exe is a win32 application (as opposed to console application) thus not suitable as a native messaging host.
2. Initialize the pairing registry reg keys in the native messaging host.
3. GetPairdClients doesn't require elevation.
4. Add the native messaging host binary and manifest and the pairing reg keys to the installer.


Enable pairing registry in Me2Me native messaging host on Windows.

BUG=325567

Review URL: https://codereview.chromium.org/143303007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251137 0039d316-1c4b-4281-b951-d872f2087c98

* Adds an AppBannerManager that will be used to manage a single
  AppBannerView.
* Each AppBannerManager is owned by a particular TabBase and is
  alerted to changes its TabBase by a TabObserver.
  The TabObserver's main use is to update the AppBannerManager
  when the WebContents has changed.

Note that this class is a skeleton: most of the real functionality
(like creating a AppBannerView) has been parted off.

BUG=341556

Review URL: https://codereview.chromium.org/155503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251136 0039d316-1c4b-4281-b951-d872f2087c98

Messages are collapsed based on app + token as long as they have not
been sent over the wire yet. If messages are resent (because original send
failed for some reason) no collapsing is done at this point in time.

BUG=284553

Review URL: https://codereview.chromium.org/148293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251135 0039d316-1c4b-4281-b951-d872f2087c98

Speculative re-land to see if this causes sync tests failures again.
If it does, then we will know if this is the cause.

> Revert 250828 "Add a UMA stat to track if the Browser blacklist ..."
> 
> Speculative revert for failures here:
> 
> http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201
> 
> > Add a UMA stat to track if the Browser blacklist is Set on the Renderer
> > 
> > This shouldn't be happening, but we got some crash reports suggesting it
> > does. Unable to repo locally so this stat will verify it does occur and
> > then can be used to verify our fixes actually fix it.
> > 
> > BUG=329023
> > 
> > Review URL: https://codereview.chromium.org/140763008
> 
> TBR=csharp@chromium.org
> 
> Review URL: https://codereview.chromium.org/163633005

TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/164833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332073

Review URL: https://codereview.chromium.org/163413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251133 0039d316-1c4b-4281-b951-d872f2087c98

When a resource request gets pre-empted in favor of either a stream or user
certificate installation, do not trigger CrossSiteResourceHandler behavior.

Add a regression test to ensure the DCHECK does not fire.

BUG=342999

Review URL: https://codereview.chromium.org/161003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251132 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328960

Review URL: https://codereview.chromium.org/156943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251131 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://codereview.chromium.org/161173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342832

Review URL: https://codereview.chromium.org/162363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251128 0039d316-1c4b-4281-b951-d872f2087c98

This adds didRequestMainThreadFrame() and didDrawFrame() so we can better
track impl-side frame lifecycle in DevTools

R=danakj, nduca

Review URL: https://codereview.chromium.org/144463016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251127 0039d316-1c4b-4281-b951-d872f2087c98

Chrome needs a pre-existing or creatable user-data-dir to run.
ChromeMainDelegate::PreSandboxStartup was CHECK'ing for this.
(crashing on startup with --user-data-dir="M:\invalid")
(crashing on startup with --user-data-dir="C:\windows")

Supposedly, we had a dialog to let users choose another dir.
(I've never gotten this to work on M28-M32 stable versions)

Revise the user-data-dir code to warn on invalid paths.
(see crbug.com/318999#c18 for the warning screenshot)
Then attempt to use the default directory as a backup.
(no alternate dir selection UI, users can try again)

This should avoid many of the numerous related crashes.

BUG=318999
TEST=Supplying an invalid --user-data-dir=<path> will warn users and attempt to use the default directory instead of silently crashing.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/123693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251126 0039d316-1c4b-4281-b951-d872f2087c98

Before, the CanOffer method could return true, while the web based signin was disabled through about:flags. This meant that neither the save password prompt, nor the sign-in interstitial were shown.

This CL ensures that CanOffer returns false if the web based signing is disabled in about:flags.

BUG=339804

Review URL: https://codereview.chromium.org/160363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251125 0039d316-1c4b-4281-b951-d872f2087c98

Rework the wait functions to use a TestNavigationObserver (waits for
DidStopLoading) rather than the commit, to avoid potential flakiness where the
load is still progressing. (prerender_loader_with_session_storage.html only
updates sessionStorage.counter at onload.)

BUG=249179,121130

Review URL: https://codereview.chromium.org/161323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251124 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334624

Review URL: https://codereview.chromium.org/130813009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251123 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334665

Review URL: https://codereview.chromium.org/160463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251122 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251120 0039d316-1c4b-4281-b951-d872f2087c98

R=danno@chromium.org

Review URL: https://codereview.chromium.org/164593002

Patch from Michael Starzinger <mstarzinger@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251119 0039d316-1c4b-4281-b951-d872f2087c98

The current mechanism by which these convenience macros find their
backend is confusing, at best; the macro has the form of our include
guard macros, but describes a CC file. Embedded within the
histogram_macros.h then is an abstraction violation: it just knows
which object has backend information depending on which file it was
included from.

Some downstream reviews have made this even more confusing; rather
than continue this, let's parameterize the backend object to the
convenience macros, so each translation unit is responsible for
knowing its own context.

R=mmenke@chromium.org, rvargas@chromium.org
TBR=mmenke@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/140893013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251116 0039d316-1c4b-4281-b951-d872f2087c98

The test runner can then inject dependencies into it (just as we do for
system and gles2).

This removes public/tests's base dependency.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/160003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251115 0039d316-1c4b-4281-b951-d872f2087c98

> Revert of [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService (https://codereview.chromium.org/137753012/)
> 
> Reason for revert:
> Possible build bustage on Win64.
> 
> Original issue's description:
> > [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService
> > 
> > BUG=80194
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250814
> 
> TBR=bauerb@chromium.org,rogerta@chromium.org,pavely@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=80194
> 
> Review URL: https://codereview.chromium.org/162943002

TBR=tim@chromium.org

Review URL: https://codereview.chromium.org/163983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251114 0039d316-1c4b-4281-b951-d872f2087c98