- 10 Dec, 2020 40 commits
-
-
Henrique Nakashima authored
TabModelSelectorImpl does not create or destroy TabPersistentStore anymore. Instead, TabModelOrchestrators manage the lifetime of TabModelSelectorImpl and TabPersistentStore. Give TabModelSelectorImpl a Supplier<TabPersistentStore> instead of passing TabPersistentStore directly. This is a step to break the two-way dependency between TabModelSelectorImpl and TabPersistentStore. Bug: 1138561 Change-Id: Ie2fa4a2735e509ff816b3e2cf5f8f6fffda7999c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572639 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#835819}
-
Kyle Williams authored
Minor fix to prevent prematurely starting the service. BUG=chromium:1105567 TEST='autoninja -C out/Default/ chrome/test:unit_tests && xvfb-run ./out/Default/unit_tests --gtest_filter=CfmLoggerServiceTest.*' Change-Id: Ifea6b11b79a1076c88310de84c87fa1c43e92ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585625Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#835818}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/145deff4ccea..b5da31f17214 2020-12-10 chrche@microsoft.com [Loc] Migrate cookie_table to Localization V2 2020-12-10 andoli@chromium.org [module.json extensions] Migrate network views 2020-12-10 leese@chromium.org Fix test flakes in multi-workers and issues tab tests 2020-12-10 morlovich@chromium.org Add a utility for structured header handling (2/3) 2020-12-10 andoli@chromium.org [module.json extensions] sources views If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073406,chromium:1073909,chromium:1134103,chromium:1136655,chromium:1157427,chromium:1157455 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I309a4dd4b55d5c6254ed4ecbdd2bb12c8f0ef070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835817}
-
Nina Satragno authored
We show a generic error sheet when the authenticator is missing a capability or is locked. For any of these cases, the user might have tapped the wrong authenticator, or they may unplug and replug their authenticator. We should show a "try again" button like we do for other errors. Fixed: 1144183 Change-Id: I0bcd658becf18b50cc04737179764f7db77b38aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579826Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#835816}
-
Edward Lesmes authored
Bug: 1113033 Change-Id: I4739a56b308d818b65c29c5f60a7a2af57ac52c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582829 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#835815}
-
Scott Violet authored
The issue is the LocalMainFrame interface is registered on the renderer side once the LocalFrame is created. This means that if LocalMainFrame is requested before the renderer is created, any calls sent along the interface are effectively dropped. I tried adding a DCHECK in GetAssociatedLocalMainFrame() that it's only called if IsRenderFrameCreated() is true, but that hits in tests. BUG=1154852 TEST=comment change only Change-Id: Id602b1883c7b554f07fc50ecc78c7fa8e041602b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585306Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#835814}
-
Xianzhu Wang authored
In paint properties, if both mask and mask-based clip-path exist, we make the ClipPathMask effect node as a child of Mask node, which requires us to paint mask before clip-path mask. The latter applies on the former to create an intersection of the masks, then the intersection will be applied to the masked content. Previously the clip-path mask was painted before the mask, and the former applies to a transparent backdrop which had no effect. Bug: 1155384 Change-Id: Ic40c8254193c141a286c4b323515fabf8a76e11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583154 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#835813}
-
Stephanie Kim authored
linux-warmed-orchestrator triggers linux-warmed if patch requires compile. Uses a new chromium-mini-orchestrator@ service account. Pass in trigger_count 2 into try-warmer so there's more led warmer builds queued up Bug: 1149606 Change-Id: I15206e501371e1bf20f6af1a821c9441e4363a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572576 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#835812}
-
Amr Aboelkher authored
As the Hash dance UMA histograms will be used for testing, it's preferred to use their constants rather than literal strings. This CL is exposing all Hash dance UMA histograms to policy namespace. BUG=chromium:1157317 Change-Id: Idf72d0d66cf0d2585d77e2b811f5ec0fc78a4041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582339 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#835811}
-
Yue Zhang authored
TosAndUmaFirstRunFragmentWithEnterpriseSupportTest# testRenderWithPolicy is flaky on multiple bots. TBR: twellington@chromium.org Bug: 1157521 Change-Id: I3a890fa79b57e1de0bf090d42b8a4cafbcf06a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585551Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835810}
-
Kent Tamura authored
'counter-increment' and 'counter-set' properties ListItemOrdinal::CalcValue() should refer to these properties. Bug: 1157365 Change-Id: I30bb015935b4cd076a5054dddee062d73145c089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583595Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#835809}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6def748c92e9..f83a0f03ccf4 2020-12-10 fmayer@google.com Merge "Allow to pass path to LocalSymbolizer." 2020-12-10 gijosh@google.com Merge "Add missing include to fix windows build" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If45e88dedf3a72c5086d705f417d8723aa26087f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584689Reviewed-by:
-
Andrey Kosyakov authored
Bug: 1156334 Change-Id: Ib5c7cc364391ab75a4394bc480f09dea9e76f8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583602 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#835807}
-
Lei Shi authored
When a user resumes from a pause, STS will speak from the beginning of the current sentence. If the user paused on a sentence start, STS will continue reading from the pause. This CL also refactors the functions in sentence_utils.js and uses staticTextNode directly to query sentenceStarts. AX-Relnotes: N/A Bug: 1143817 Change-Id: Iaf73a5656273db499604d3f7f4a008c37e5a4eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572905 Commit-Queue: Lei Shi <leileilei@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835806}
-
Yicheng Li authored
prompts for user verification. After verification, Chrome shows "Something went wrong, Your identity couldn't be verified" and device-log shows u2fd returns MakeCredentialStatus::EXCLUDED_CREDENTIAL_ID. Bug: 1157538 Test: On a test website, specify "Use excluded credentials", ChromeOS Change-Id: I308fcbcf8ac53abf293e759ee079eb7bd8a34e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585706 Commit-Queue: Yicheng Li <yichengli@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by: -
Mike Dougherty authored
Bug: 949178 Change-Id: I1af6125928a3f75e782d435016aca68a2e3435f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578700Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#835804}
-
Marijn Kruisselbrink authored
While not a very strong security boundary, making it possible for users to know what extension a file will be saved with is a good idea. This also fixes support for compound extensions with the File System Access API (i.e. ".tar.gz"). The mac file dialog already had a workaround if the default path ended in such an extension, but the same problem occurs if the file type filters include a type with a compound extension. Bug: 1137247 Change-Id: I492bf36baced3de044b8fed5d57fc7b9b5b64400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582842Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#835803}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607601127-f1e339917d2389833bdc9a06d67f5d834b6fad5c.profdata to chrome-linux-master-1607622801-752d4072c7d48988cef666b2cc2834c70f6a2f6e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3ff9e1dbd95b24cf175d8ecbeaeefb5ab82799be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585545Reviewed-by:
-
Chris Lu authored
Remove the now launched default browser fullscreen promo experiment and add a new feature flag for fullscreen promo UI experimenting. Bug: 1155778 Change-Id: Id5177c59cb02f355df5e5e806da33d5d9ee51c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575902 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#835801}
-
Michael Thiessen authored
Bug: 1139437 Change-Id: I71789d696eab9e692c30d963d16382f9105e8a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485307 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835800}
-
David Dorwin authored
When explicit_sites_filter_error_page is present in CreateFrameParams, use SafeSitesNavigationThrottle to filter explicit pages. Bug: 1147231 Change-Id: Ie722d9e409ed480fe1956f0aacc7198d7076d4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531653Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835799}
-
Gavin Williams authored
Creates a function in ScanningHandler to centralize the logic for localizing plural strings. Bug: 1059779 Change-Id: I5cdd80ccf04e16945ae1a273941f846e1f39c75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584292 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#835798}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0443332fe2b9..c566c247eb76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I207b8d1c1db2194ea82d6d621506a42c86369639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585227Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607601127-39be490f57372d47d2538fb844f282b5fe546632.profdata to chrome-mac-master-1607622801-911c34fc75b181768a2abc88929167cca3e2a50d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I339d91626d73a1ce8c26471aeb593018f7af6d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585110Reviewed-by:
-
Yi Gu authored
During the initial implementation of recording |UserCancelled| as an |Outcome|, we didn't use |kUserCancelled| because it could not resolve the promise upon user dismissing the prompt. We used |kCancelled| as a temporary workaround to resolve the promise. This patch removes the workaround because we are now able to resolve promises after crrev.com/c/2569946. Bug: 1138454 Change-Id: Id91180b7624e5f0687b37a0864a1d64e406baf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579988 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#835795}
-
Dominic Battre authored
Bug: 1080636 Change-Id: Ifde1a1196d214de0e19fd42a0877d500008b958f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579964Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#835794}
-
Guillaume Jenkins authored
Makes the sign-in promo view mediator aware of the kSigninAllowed pref and makes it skip the sign-in promos in the bookmarks and the settings if sign-in is disabled by policy. Also makes a similar change in the sign-in utils so the sign-in promo after a version upgrade is skipped if sign-in is disabled by policy. Change-Id: Ia84e43f9db317f9454d662ea998758be66ffa801 Bug: 1155745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562778 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#835793}
-
Will Cassella authored
This CL removes the call to `media::InitializeMediaLibrary` in the browser main loop. Initializing the media library in the browser process should not be necessary, and it's done elsewhere for the renderer process. Change-Id: I0b430245019b519fe1614dc9d3e9263b59a3b2a0 Bug: 1003535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577877Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#835792}
-
Lloyd Pique authored
The overlay window should be closed if the host window is closed, or if the controller is destroyed. BUG=crbug:1156540 TEST=Close Test app while overlay is displayed Change-Id: I7d0dadc697535694952bc9be02c88d4c7a28977a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582816 Commit-Queue: Lloyd Pique <lpique@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#835791}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ice40a50cfcf4768f5d08ee3142f2fad0a1b76901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584352Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/e28aa0ca9448..b2522b5f9832 2020-12-10 miu@chromium.org LoopingFileSender uses same Environment as SenderSession (and Senders). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I925224f2e5dec0bd1f06e63653a3b2b17b56f73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584692Reviewed-by:
-
Xianzhu Wang authored
We assume that a) ShouldCheckForPaintInvalidation is set if ShouldCheckGeometryForPaintInvalidation is set, b) ShouldCheckForPaintInvalidation is set if any non-display-locked descendant has ShouldCheckForPaintInvalidation, c) DescendantShouldCheckGeometryForPaintInvalidation is set if any non-display-blocked descendant has ShouldCheckGeometryForPaintInvalidation. Previously, the assumptions were broken in 2 cases: 1. When a LayoutObject having ShouldCheckForPaintInvalidation only was inserted into the child list of a parent, the parent would not set ShouldCheckForPaintInvalidation. Then when the child is set to also need to check geometry, this might set the parent's DescendantShouldCheckGeometryForPaintInvalidation only. If the child had both flags, the parent would not set either of the flags. 2. When a LayoutObject in a display-locked subtree was marked to have both flags, depending on the current flags, the parent might set DescendantShouldCheckGeometryForPaintInvalidation only. To fix 1, now we call parent->SetShouldCheckForPaintInvalidation(). To fix 2, now when we set ShouldCheckGeometryForPaintInvalidation or DescendantShouldCheckGeometryForPaintInvalidation, always set ShouldCheckForPaintInvalidation at the same time. For 2, we could also stop at display locking boundary and mark DisplayLockContext for dirty descendant flags and propagate the flags to ancestors on unlocking, but because setting paint invalidation flags in a locked subtree is rare, I choose the simpler method instead. Bug: 1157226 Change-Id: I261ee6f51e34a610ddf5c837b058cd9f786429b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583158 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#835788}
-
Leonid Baraz authored
Added has_encryption_key to relevant modules. Bug: b:170054326 Change-Id: Ic1a0b8cc548e5c29015a4fd604bcc3138092d867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581006 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#835787}
-
Stefan Zager authored
This fixes an bug with the recently-added feature to allow an observer's explicit root to be a document. In such cases, if a target element is not in the root document, it should be reported as "not intersecting". Change-Id: Iea6bc2444fc5b2bf2dca50cf242d46324a502dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583217 Commit-Queue: Stefan Zager <szager@chromium.org> Auto-Submit: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#835786}
-
Ian Kilpatrick authored
It was possible to have some zero sized shelves in the NGExclusionSpace. This typically didn't cause any issues, but it was possible for zero sized elements, and things with shape exclusions to be placed in invalid places due to this. The updated unittest actually shows an invalid layout opportunity. The updated png-test was also something which appears we got wrong when we rolled out LayoutNG initially. (we are now changing it "back" to the original ref). Bug: 1156154 Change-Id: Ia275255683764376d4d9e343bacb063d628fbaee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581885 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#835785}
-
Michael Thiessen authored
This test is probably still flaky, but I can't repro and there isn't enough data on the flakiness dashboard to figure out what configurations this test is flaky on. If this test is still highly flaky I'll revert this change. Bug: 1153686 Change-Id: Icf2d73c4e9901a4a590dd03a668cb72cb609971f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584648Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835784}
-
Ben Pastene authored
Machines are allocated in crrev.com/i/3459783 This'll be the last builder in the 8-core xenial builderless to be migrated. chromium_presubmit will remain since it's not as affected by cache age, and it will also provide signal to how the pool is doing since it'll be the only alertable builder that remains. Bug: 1140727 Change-Id: I5b78d52e67e48f4dc0dc6c7edc20b6f2faa559b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585385Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
Nico Weber authored
...and a few more, final simplifying touches. No behavior change. Bug: 1147069 Change-Id: I0b3d1ffbf7f8ea89facd1fc6bb4776c7a4deade5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584609 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835782}
-
Majid Valipour authored
This patch introduces the basic API for IDP to provide an id_token. The id_token is passed to the pending id request callback. The callback is simply held as part of UserData for the provider's web contents. This works because we create a new web content for each request. To enable this without introducing new content/public changes we moved the creation of the idp web contents to occur inside FederatedAuthRequestImpl which also adds the callback and then passes it to the ui dialog controller. Bug: 1141125 Change-Id: Ic5d48642c952ac510ce8aa8cfaf53962a916f9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576432Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Auto-Submit: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#835781}
-
Garrett Beaty authored
This is being modified so that the builder function can be modified to accept multiple console view entries. Change-Id: Ifb42b098cdd0a6d07a42ded71d88fee1a485a836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585049 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#835780}
-
