GitLab

This change makes tab hover cards reappear immediately when hovering over a tab if the mouse hover has only been out of the tab strip for 0.5 seconds. This is to prevent wait time when a user unintentionally hovers out of the tab strip while searching for a tab.

Bug: 910739
Change-Id: I47cae3e64fcf86eff12884a3ed63945632d7fd07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603054
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659159}

Bug: 961816
Change-Id: Ie17882325e9acb124843e8a1f70e5a570738e2a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601653
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659158}

This modifies the WebHID IDL to address comments in a previous CL:

https://chromium-review.googlesource.com/c/chromium/src/+/1559344

In the prior commit, HIDReportItem held raw indices into the USB
string table (|stringMinimum| and |stringMaximum|). These members
are removed in favor of a new |strings| member which will return
the actual device data.

|designatorMinimum| and |designatorMaximum|, which held indices
into the physical descriptor table, are removed.

HIDReportItem held a |unit| member which described the unit factors
that make up the unit definition. The member was a 32-bit value composed
of 7 4-bit values and 4 reserved bits. These nibbles have been split
into separate members for the unit system and unit factor exponents.

In HIDCollectionInfo, the |reportIds| member is removed as its utility
is duplicated by the report information.

BUG=890096

Change-Id: I8403f9b7e275d97e58bb6c9ad73c2e2654f9d3d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583427Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659157}

Remove custom link pills for themes without image and use NTP_TEXT
theme property for custom link titles color.

As pills will be used only with themes that have images, which in
dark mode didn't change to dark, then this change eliminates the need
for dark pill for custom link titles.

Default:
https://screenshot.googleplex.com/iNq8NShsd9a.png

Defaul, dark mode:
https://screenshot.googleplex.com/ebiCRAxdqth.png

GTK:
https://screenshot.googleplex.com/LqMk30Zf91r.png

theme, no image:
https://screenshot.googleplex.com/NA8jugTz7xy.png

theme, no image, dark mode:
https://screenshot.googleplex.com/qFyj5R6Y40S.png

theme with image
https://screenshot.googleplex.com/7fHXFUjGF6q.png

theme with image, dark mode:
https://screenshot.googleplex.com/fHVRb9yAzcj.png

theme and custom background:
https://screenshot.googleplex.com/uahXOYpPdzx.png

theme and custom background, dark mode:
https://screenshot.googleplex.com/J5w8UaV3sTJ.png

Bug: 959377
Change-Id: I4b5e10c4392f57cdb9b1471c3ea49802cfc902ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597639
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659156}

Dedicated thread wastes resources and causes races in tests where
it can outlive thread pools.

Bug: 938126
Change-Id: I335d719d72c6291c03ef33480a81b7cda719b877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609883
Auto-Submit: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659155}

Rename
web_app_controller() to app_controller()
as return type was recently renamed
from WebAppBrowserController*
to AppBrowserController*

Change-Id: I297ae05b5751454c07ee478dfc99d4094fc50839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601614
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659154}

https://skia.googlesource.com/skia.git/+log/9b86955c65aa..d696f8e6bca3


git log 9b86955c65aa..d696f8e6bca3 --date=short --no-merges --format='%ad %ae %s'
2019-05-13 bsalomon@google.com Support GL_ANGLE_texture_rectangle.


Created with:
  gclient setdep -r src/third_party/skia@d696f8e6bca3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Change-Id: I429a06c36acd801abe05a91c51ce2fa69ff37e83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610442Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659153}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2947e88f7938..e935dac9ef8a


git log 2947e88f7938..e935dac9ef8a --date=short --no-merges --format='%ad %ae %s'
2019-05-13 stevenperron@google.com Make pointers to isomorphic type interchangeable with option. (#2570)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@e935dac9ef8a

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=radial-bots+chrome-roll@google.com,syoussefi@google.com

Change-Id: I76bee692be829c25266527d1cc8ba0e461fb5aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610449Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659152}

Bug: 958163
Change-Id: I356398a77cee42c71ccc6c722523b832a0b9d649
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610639Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659151}

Bug: 891908
Change-Id: I105d94fc7c03764215f07f6c3f298ff488724c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608970
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659150}

Ahmed asked about the difference between ScopedExclude and
ScopedForceVisible, which tells me the docs aren't good enough.
Attempts to better describe what happens with the two.

BUG=none
TEST=doc only change

Change-Id: Ia3b798b77f7609ad70dd9f8bed0f50157b10a6e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604327
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659149}

Instead of always getting redirected to 'chrome://settings/help', the
back button now goes back in the tab's history. If the tab has no
history, it falls back to the old behavior.

Bug: 959258
Change-Id: I32c6700648839b23879c48dd69878fa74ef42986
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606190Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659148}

- Fix ITableItemProvider implementation to retrieve column/row header
items from the containing table.
- Eliminate S_FALSE return from ITableItemProvider methods.
- Return empty SAFEARRAYs as nullptr across all properties and control
patterns. This is the same behavior as EdgeHTML.
- Add missing tests for ITableItemProvider and update ITableProvider
tests to cover paths checking for invalid item references. To assist
with this, I split apart the SAFEARRAY testing macros to take either a
property ID or a SAFEARRAY directly.

Bug: 847971
Change-Id: If6f38d7ac7526fa374840f5755eb5aeb99a1b6d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601633
Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#659147}

Checks in the arm64 variant of the test DLL. Values in the unit test
have been updated using the output from dumpbin.

Bug: 925584, 893460
Change-Id: Iab41f94283d88d39a986ca100c9538b4ba61228f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599594Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Cr-Commit-Position: refs/heads/master@{#659146}

The some changes of element will not cause remove/add LayoutText,
instead, LayoutText is changed.

This patch supports the content change in this case, DidUpdateContent()
is added and invoked after new content is sent.

Bug: 952973
Change-Id: Ia530e7e71570801f1f494bd584526cc7dc3ccba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598310
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659145}

This CL adds browser tests that verify that guest signing becomes
visible when available and clicking on the link starts a guest session.

Bug: 959340
Change-Id: I5e52b2a93818c11779b573d71ccc1174c5b48977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606574
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659144}

https://webrtc.googlesource.com/src.git/+log/2ebf5239782b..3dfb68082e1a


git log 2ebf5239782b..3dfb68082e1a --date=short --no-merges --format='%ad %ae %s'
2019-05-13 yvesg@webrtc.org Use robust variance computation in RollingAccumulator.


Created with:
  gclient setdep -r src/third_party/webrtc@3dfb68082e1a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7dc8c6aacf1939fe64854a9e59093c1a3943582a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610447Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659143}

This fixes most of the presubmit errors you get when
modifying those files

Bug: 714018
Change-Id: I5581e3264ea172e725a9dae07f3a734d845d92aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592766
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659142}

Bug: 891908
Change-Id: I43fae34afee2c5b278cd652908eb6ff666e0020e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608871Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#659141}

Bug: 961307
Change-Id: I55619a8c5994bd7008db9bf2baad700efe496e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606644
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659140}

If Recent Tabs is invoked from incognito, restored tabs are placed in
the non-OTR WebStateList.  Before this CL, the current non-OTR WebState
was clobbered and replaced, resulting in a crash if the WebStateList was
empty.  This CL forces restoration to happen in a new WebState, which
sidesteps the crash.

BUG=960742
TEST=Restore a tab from incognito, with no non-Incognito tabs open.  The app should not crash, but the app will also not switch to show the newly-restored tab.

Change-Id: Id38e74cb9bfdada160f1fa049d02219a3a9f1f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605788
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659139}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/02f2aec13451..a69e8c1681da


Created with:
  gclient setdep -r src-internal@a69e8c1681da

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=anthonyvd@google.com,alph@google.com,battre@google.com

Change-Id: I74b0d456a6b9313c29f88ea447f8806683f4ad8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610446Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659138}

Bug: 668690
Change-Id: Iac624c067336b2f2479a6541a5d2fc7566f4dd5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603065Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659137}

This was used only to guard calls to the static method
LayoutThemeDefault::SetSelectionColors. This static methods should
have been virtual on blink::LayoutTheme to begin with. It also
shouldn't be routed through blink::WebView (rather, it should be
called directly, like the adjacent blink::SetFocusRingColor).

Note that after changing selection colors, we call both
blink::WebWidget::ThemeChanged and blink::Page::PlatformColorsChanged.
I don't know the distinction between the two.

Bug: 961342
Change-Id: I3edd3d41d6ad6de1fc3331bb03308f2dc7c6a683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606185
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659136}

This CL adds logic to dispatch periodic Background Sync event,
and updates BackgroundSyncManager unit tests to verify that the event
is fired correctly when expected.

Bug: 925297
Change-Id: I6f3c32d63d8950ea4fc17bb145a704e276ffd627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591619Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659135}

Both these DCHECKs attempted to use <= on floating point numbers, and
were failing on within epsilon equality.

Bug: 962138
Change-Id: I005f9503b325b07401c95bec2b3620c0b1ac4a3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610145Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659134}

This patch addresses review comment on crrev.com/c/1607719
by adding more comments.

No behavior changes.

Change-Id: I1362fd4dd18467eeb0e30aecb0e80c7cf9bd43cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609718Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659133}

Bug: 960101
Change-Id: I50e5332f85ee9078eae6b2d3aaecc23fd7f5c301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595454Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659132}

This change skips long_running:tools:gmail-background,
long_running:tools:gmail-foreground, and load:games:spychase:2018
on ChromeOS because they are failing.

The whole system_health.memory_desktop suite is not running, and we
hope disabling some flaky or long-running stories may bring it back.

NOTRY=true
TBR=perezju@chromium.org
CC=cbruni@chromium.org,rnephew@chromium.org

Bug: 959418
Change-Id: I8b500a6d8ed2d8ca07fca31d87728aea1c2867d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610084Reviewed-by: Madeleine Barowsky <mbarowsky@chromium.org>
Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659131}

https://pdfium.googlesource.com/pdfium.git/+log/6f8388801226..87bafc38b0d0


git log 6f8388801226..87bafc38b0d0 --date=short --no-merges --format='%ad %ae %s'
2019-05-13 tsepez@chromium.org Rename CXFA_LayoutItem methods to match fxcrt::TreeNode.


Created with:
  gclient setdep -r src/third_party/pdfium@87bafc38b0d0

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Change-Id: Iab7e811ba0bd393ab3c1eba7b2363056518c2cb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610439Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659130}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42db0b42abad..a04028c2e67b


git log 42db0b42abad..a04028c2e67b --date=short --no-merges --format='%ad %ae %s'
2019-05-13 raul@tambre.ee Fix invalid Python file encoding "utf8"


Created with:
  gclient setdep -r src/third_party/depot_tools@a04028c2e67b

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:962277
TBR=agable@chromium.org

Change-Id: I26e77664220b9bd742ebe415c818edc46a2b4e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610445Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659129}

BrowserTestBase decides to run ContentMain() or BrowserMain()
based on the OS. On Android it uses BrowserMain() instead. When
using BrowserMain() on Android, the test harness reimplements
some of ContentMain() before calling BrowserMain(). This is done
in the ContentBrowserTestSuite currently, but that can not be
shared with chrome browser tests, which inherit
ContentTestSuiteBase but not ContentBrowserTestSuite. To promote
code sharing and move the logic to the same place where the
ContentMain() decision is made, we move this setup code over
to BrowserTestBase.

While doing so, we update the code to more closely match what
ContentMain() does. This makes Android existing browser test
suites act more like desktop browser tests, which go through
ContentMain() already:
- Instead of hardcoding using ShellContentClient, we use the
ContentMainDelegate to create the ContentClient (which will be
a ShellContentClient in existing cases, but will differ in
chrome browser tests).
- Ordering is adjusted to match.
- The ContentMainDelegate is used and called throughout the
setup process the same way that ContentMain() would, including
calls to ShouldCreateFeatureList(), PostFieldTrialInitialization(),
PreCreateMainMessageLoop(), PostEarlyInitialization(),
PostTaskSchedulerStart(), and BasicStartupComplete().

Using the ContentMainDelegate doesn't change existing behaviour for
the most part though, as the ShellMainDelegate overrides largely set
up for web test mode, which browser tests do not run in (content shell
is run separately for that).

The InitMessagePumpForUIFactory() call from ContentBrowserTestSuite
must be made before the test suite is initialized, however, so it can
not move to BrowserTestBase. Instead we put it in the JNI_Onload method
of each browser test target. This ensures it is run first, and we
DCHECK that it succeeded.

In single process mode, we also must initialize a ContentRendererClient
which was being done in ContentBrowserTest, so moved this up to
the BrowserTestBase.

R=avi@chromium.org

Bug: 961849
Change-Id: Iefc105e3dc9f142774331aa97b0f1006bd701c0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606424
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659128}

The new styling should only apply to the new
customization menu.

Bug: 962353
Change-Id: I8f9ff9dc925a58c9403576c0d33b845d8673d523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609601Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659127}

Change-Id: I6917c4ad8ae90d797e87db6a5b9409f4ae54c8ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608963Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659126}

This flag was just for debugging so it is more appropriate as a
command line switch. Also, this function is called in hot code, and
feature flag queries are slow. A command line switch is safer to
cache; tests are allowed to enable or disable feature flags on the
fly, hence caching a feature flag lookup breaks this contract.

This allows for caching the result without breaking expectations.

Bug: 960913
Change-Id: Ibb9f9b7b7db7b9329984d71318c7488534e04f9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600494Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659125}

Refactors all the classes in
//device/vr/windows_mixed_reality/wrappers/wmr_origins.h to inherit
from an interface, and switches the mock versions to inherit from the
same interface instead of subclassing the real versions.

Also moves the static creation functions into factories in
//device/vr/windows_mixed_reality/wrappers/wmr_wrapper_factories.h,
which now guarantee that the mock and real classes can't be mixed
together.

Bug: 961020
Change-Id: I0928bcadc9d942bd6ea513c156c832ffcaf0433f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603748Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659124}

https://chromium.googlesource.com/angle/angle.git/+log/f1e3609c24ce..e1de1ab33d7f


git log f1e3609c24ce..e1de1ab33d7f --date=short --no-merges --format='%ad %ae %s'
2019-05-13 geofflang@chromium.org D3D: Store error message by std::string instead of const char*.


Created with:
  gclient setdep -r src/third_party/angle@e1de1ab33d7f

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:962439
TBR=syoussefi@google.com

Change-Id: I546638d3392c0bfa60b032cf2b1a26668c243aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610457Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659123}

add utility functions to determine when to display the STTS UI

Bug: 959475
Change-Id: I0318090e1b018bb4be874f967bbee0500dcff39b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597909Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659122}

BUG=958241
TEST=purely dead code removal

Change-Id: If1235ea072f867a0cdbbbe09ece1586015e40d3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605163
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659121}

- Create WebUI
- Add PostMessageAPI* and AddSupervisionAPI* JS classes for communication
with web-content.
- Added switch to control the feature:  ChromeOSAddSupervision


Bug: 937995
Change-Id: I1e65b1a899776b5aa9028921d028030d147baaec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500832
Commit-Queue: Danan S <danan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659120}