GitLab

Before this CL, logic to wait for a WorkCallback to run or be
abandoned was duplicated in multiple
ModelSafeWorker::DoWorkAndWaitUntilDoneImpl() implementations.

With this CL, ModelSafeWorker::DoWorkAndWaitUntilDoneImpl() is
replaced with ModelSafeWorker::ScheduleWork(). Implementations
are merely responsible for scheduling the callback that they
receive; they don't have to wait for it to run or be abandoned.

The logic to wait for the callback to run or be abandoned is moved
into ModelSafeWorker::DoWorkAndWaitUntilDone().
ModelSafeWorker::DoWorkAndWaitUntilDone() calls
ModelSafeWorker::ScheduleWork(). Then, it waits until either the
callback that it passed to ModelSafeWorker::ScheduleWork() is deleted
(may or may not have run) or ModelSafeWorker::RequestStop() is called
before the callback has started to run. Additionnaly, calling
ModelSafeWorker::RequestStop() transforms into no-op further
invocations of callbacks passed to ModelSafeWorker::ScheduleWork().

Unblocking ModelSafeWorker::DoWorkAndWaitUntilDone() when
ModelSafeWorker::RequestStop() is called is important to
prevent deadlocks in workers that schedule work on the UI
thread. Indeed, in Chrome, no tasks are scheduled on the UI
thread after ModelSafeWorker::RequestStop() is called and
pending UI tasks are not scheduled until after the sync thread
is joined.

BUG=663600

Review-Url: https://codereview.chromium.org/2782573002
Cr-Commit-Position: refs/heads/master@{#463413}

BUG=661810

Review-Url: https://codereview.chromium.org/2813713002
Cr-Commit-Position: refs/heads/master@{#463412}

This generalizes the fall-back to using base::debug::StackTrace to
capture stack traces in builds which lack frame pointers, allowing
native heap profiling to generate useful data, albeit with a more
significant performance penalty.

Changes made in the earlier patch for native heap profiling stack
capture under Windows are un-done in favour of the following:
1. MemoryDumpManager always allows native heap profiling[1].
2. HeapProfilerAllocationContextTracker chooses whether to use
   base::debug::StackTrace or TraceStackFramePointers() based on
   the value of BUILDFLAG(CAN_UNWIND_WITH_FRAME_POINTERS).
3. BUILDFLAG(CAN_UNWIND_WITH_FRAME_POINTERS) is no longer defined in
   configurations which we cannot use frame pointers for unwinding[2].

[1] Though note that only certain build configs actually support
    the necessary allocator shims; this will be addressed later.
[2] Frame pointers are only available in profiling & Debug builds on
    some platforms, and are available but unsuitable for us to use for
    stack unwinding, on others.

BUG=686208

Review-Url: https://codereview.chromium.org/2757123002
Cr-Original-Commit-Position: refs/heads/master@{#460311}
Committed: https://chromium.googlesource.com/chromium/src/+/22b017b9b241c47db8cf25c57c89c0b0d7fcfbe2
Review-Url: https://codereview.chromium.org/2757123002
Cr-Commit-Position: refs/heads/master@{#463411}

Change dest_language to target_language in the logistic regression model for consistency with google3 proto and translate_event_protos.

BUG=646711

Review-Url: https://codereview.chromium.org/2803353002
Cr-Commit-Position: refs/heads/master@{#463410}

Plugin (WebPluginContainerImpl) does not keep its own state about
visibility of parent, and once it is no longer inheriting from
FrameViewBase, it will not implement any ParentVisible methods.
If required, it could always call parent_.IsVisible.

BUG=637460

Review-Url: https://codereview.chromium.org/2808723002
Cr-Commit-Position: refs/heads/master@{#463409}

Fixing checkbox resizing, making them disabled and a bit transparent
when blocking overall is disabled, enabling blocking when adding a new
pattern.

BUG=709943

Review-Url: https://codereview.chromium.org/2814563004
Cr-Commit-Position: refs/heads/master@{#463408}

The intent of this change is to add some signal data to the bottom of
a MHTML file when generating an offline file if the new OfflinePagesLoadSignalCollecting flag is set.  The signal data
will be analyzed to find a better time to take snapshots, and will eventually be used to decide at runtime when to take snapshots.  Design docs here:
https://docs.google.com/document/d/1AcoZOIb81V68_KDSOCatFSYYMLOTSYj6resg-VAxLgo

BUG=706628

Review-Url: https://codereview.chromium.org/2683493002
Cr-Commit-Position: refs/heads/master@{#463407}

BUG=709571
TEST=browser_tests
TBR=mahmadi

Review-Url: https://codereview.chromium.org/2805263003
Cr-Commit-Position: refs/heads/master@{#463406}

Currently, we show keyboard on window focus gain only when we previously
lost window visibility, which we introduced to fix crbug.com/168288.

Extending the current logic to resume keyboard input when regaining
focus from a pop-up window such as voice input window.

BUG=344235

Review-Url: https://codereview.chromium.org/2806383003
Cr-Commit-Position: refs/heads/master@{#463405}

WillDrawSurface is no longer being used on the client side. Removing it would
reduce the number of IPCs we send.

BUG=671202
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2801313002
Cr-Commit-Position: refs/heads/master@{#463404}

[Media Capabilities] Rename query() to decodingInfo() and MediaDecodingAbility to MediaCapabilitiesInfo

This is matching recent spec changes:
https://github.com/WICG/media-capabilities/pull/31

The MediaConfiguration changes are not reflected in this CL.

BUG=690380
R=mcasas@chromium.org,sandersd@chromium.org

Review-Url: https://codereview.chromium.org/2807713002
Cr-Commit-Position: refs/heads/master@{#463403}

Revert of Only create sticky position constraints for constrained sticky position. (patchset #4 id:60001 of https://codereview.chromium.org/2769353002/ )

Reason for revert:
It causes telemetry_perf_unittests failing on chromium.android/Android N5X Swarm Builder.

crbug.com/710142.

Original issue's description:
> Only create sticky position constraints for constrained sticky position.
>
> If sticky position is unconstrained we don't need to create constraints for it,
> or add it to viewport constrained objects (causing scroll on main), or repaint
> on scroll.
>
> BUG=704817
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2769353002
> Cr-Commit-Position: refs/heads/master@{#463316}
> Committed: https://chromium.googlesource.com/chromium/src/+/06e9b5a6a5649e4d842f40ad667554c58dc26c29

TBR=chrishtr@chromium.org,flackr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=704817

Review-Url: https://codereview.chromium.org/2811803003
Cr-Commit-Position: refs/heads/master@{#463402}

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/core/fileapi

BUG=707641

Review-Url: https://codereview.chromium.org/2804403003
Cr-Commit-Position: refs/heads/master@{#463401}

This CL fixes/refactors two layout tests that used to depend on ability
to find the opener via window.open, even in case of ctrl-click or
shift-click.  This dependency is incorrect and will be broken once
https://crbug.com/658386 is fixed.

The tests had to be refactored so that they don't depend on ability to
communicate back with the main test window.  After this CL the tests
report their results via testRunner.setCustomTextOutput (rather than
sending the results back to the main window using window.postMessage).

In the 2 tests here, the custom text dump is being set from a secondary
test window - the CL also needs to relax the condition that limited
propagation of LayoutTestRuntimeFlags to the main test window.  The
intent of the original condition should have covered both secondary
and main windows (i.e. the intent was to just check if the renderer
has received a LayoutTestRuntimeFlags).  It seems desirable overall
to also propagate LayoutTestRuntimeFlags changes originating from
secondary test windows.

BUG=658386

Review-Url: https://codereview.chromium.org/2689483007
Cr-Commit-Position: refs/heads/master@{#463400}

Revert of Followup comments from r460581. (patchset #1 id:1 of https://codereview.chromium.org/2781383002/ )

Reason for revert:
Exposed races with FrameHostMsg_DidStopLoading

BUG=710062

Original issue's description:
> Followup comments from r460581.
>
> BUG=365039, 705559
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2781383002
> Cr-Commit-Position: refs/heads/master@{#461012}
> Committed: https://chromium.googlesource.com/chromium/src/+/8393de464114cb0a3d5e82a93a491728aa49e043

TBR=nasko@chromium.org,dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=365039, 705559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2808953002
Cr-Commit-Position: refs/heads/master@{#463399}

Revert of Improve unit tests for OnQueueNextWakeUpChanged (patchset #1 id:1 of https://codereview.chromium.org/2810663002/ )

Reason for revert:
Revert of https://codereview.chromium.org/2798563003 will invalidate this patchset.

Original issue's description:
> Improve unit tests for OnQueueNextWakeUpChanged
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2810663002
> Cr-Commit-Position: refs/heads/master@{#463247}
> Committed: https://chromium.googlesource.com/chromium/src/+/e206dbe248c7727f81424d6b89274a52def52e6a

TBR=skyostil@chromium.org,altimin@chromium.org,alexclarke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2810683003
Cr-Commit-Position: refs/heads/master@{#463398}

Things like kInvalid and kCreated are too generic to end up in the
top-level Blink namespace. Changing this to be a scoped enum revealed
some difficulties with using/testing scoped enums in Blink which will be
addressed in followup CLs.

Bug: 709817
Change-Id: Ied242566e204fb3ad6cbf7e703727eada698b57e
Reviewed-on: https://chromium-review.googlesource.com/473469Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463397}

The JumpListIcons delete task deletes the existing icons in JumpListIcons,
while the update task creates the new icons, writes them into JumpListIcons
and notifies the shell. It is better to separate them so we can track
the individual cost. Since a base::SingleThreadTaskRunner is used for
posting these tasks, the tasks are always running in the correct order.

This CL also adds a base::SequencedTaskRunner for JumpListIconsOld
delete tasks as they are not required to run on a single thread.

BUG=40407, 179576

Review-Url: https://codereview.chromium.org/2807883002
Cr-Commit-Position: refs/heads/master@{#463396}

If the browser has started shutting down, then do not attempt to relaunch
the gpu process.

BUG=709890

Review-Url: https://codereview.chromium.org/2810763002
Cr-Commit-Position: refs/heads/master@{#463395}

This CL replaces uses of ScriptState::GetExecutionContext with ExecutionContext::From in the bindings generator code.

BUG=682322

Review-Url: https://codereview.chromium.org/2811833002
Cr-Commit-Position: refs/heads/master@{#463394}

This is a follow up to issue 2795603002.

BUG=691108

Review-Url: https://codereview.chromium.org/2808973002
Cr-Commit-Position: refs/heads/master@{#463393}

Manually converted tests to use new Audit.

BUG=704967
TEST=
ChannelMerger/audiochannelmerger-basic.html
ChannelMerger/audiochannelmerger-cycle.html
ChannelMerger/audiochannelmerger-disconnect.html
ChannelMerger/audiochannelmerger-input-non-default.html
ChannelMerger/audiochannelmerger-input.html

Review-Url: https://codereview.chromium.org/2781123002
Cr-Commit-Position: refs/heads/master@{#463392}

After the CL: https://codereview.chromium.org/2235283003 which implemented composition
range information tracking on the browser side for Mac, the method TIM::GetCompositionRangeInfo
was changed to take the RenderWidgetHostView for which the information is required. However,
the view pointer is not actually used and the method returns the stored information for |active_view_|
instead.

BUG=NONE

Review-Url: https://codereview.chromium.org/2814443003
Cr-Commit-Position: refs/heads/master@{#463391}

This ensure that when an activity loses input focus (OnWindowFocusChanged), that the web page is blurred and not considered to be focused.

BUG=686232

Review-Url: https://codereview.chromium.org/2779033004
Cr-Commit-Position: refs/heads/master@{#463390}

I'm not actually sure why this was on the list of conflicting method
names, but it doesn't appear to be necessary.

Bug: 709987
Change-Id: Ib2841a19243f485b9191dd933b92fdd3223470d2
Reviewed-on: https://chromium-review.googlesource.com/473367
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463389}

Revert of add a new set of commands to resize and position windows (patchset #35 id:680001 of https://codereview.chromium.org/2734123004/ )

Reason for revert:
It cause flaky browser tests on mac10.10

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests?numbuilds=100

Original issue's description:
> add a new set of commands to resize and position windows
>
> https://docs.google.com/document/d/1Q0kuHgU1d-sj8gePjEU9nHtlQzz5rNvvGH8fCJ3iBq4/edit?usp=sharing
>
> Devtools side, add a new UI domain and methods:
> method: getWindowForTarget, param: targetID, return: windowID, bounds.
> method: setWindowBounds, param: windowID, bounds
> method: getWindowBounds, param: windowID, return: bounds
>
> bounds object: left, top, width, height, window_state (minimized, maximized, fullscreen, normal)
>
> BUG=604324
>
> Review-Url: https://codereview.chromium.org/2734123004
> Cr-Commit-Position: refs/heads/master@{#463110}
> Committed: https://chromium.googlesource.com/chromium/src/+/24a8ad434aab59c8c8a08ba02d934ca5fdfdc7dd

TBR=dgozman@chromium.org,pfeldman@chromium.org,samuong@chromium.org

Review-Url: https://codereview.chromium.org/2808923002
Cr-Commit-Position: refs/heads/master@{#463388}

Revert of android: Async setupConnection binder call (patchset #4 id:60001 of https://codereview.chromium.org/2810433002/ )

Reason for revert:
Appears to have broken ChildProcessLauncherTest_testBindServiceFromMultipleProcesses/0 on https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/41605

junit.framework.AssertionFailedError
	at org.chromium.content.browser.ChildProcessLauncherTest.testBindServiceFromMultipleProcesses(ChildProcessLauncherTest.java:448)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Original issue's description:
> android: Async setupConnection binder call
>
> Make setupConnection oneway/async. Add a ICallbackInt interface to
> return the PID of the child process. The reply is then posted back to
> launcher thread. Connection setup is already mostly async so only
> involves moving related code to the reply callback.
>
> One caveat is that getCallingPid no longer works and just returns 0
> for oneway calls. The pid check is not strictly necessary, so dropped
> the from setupConnection instead.
>
> BUG=689758, 690118
>
> Review-Url: https://codereview.chromium.org/2810433002
> Cr-Commit-Position: refs/heads/master@{#463332}
> Committed: https://chromium.googlesource.com/chromium/src/+/39c7bd71dc2f9c9f692dd346e4e4e525af25ede1

TBR=rsesek@chromium.org,jcivelli@chromium.org,torne@chromium.org,boliu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=689758, 690118

Review-Url: https://codereview.chromium.org/2806343003
Cr-Commit-Position: refs/heads/master@{#463387}

BUG=699328

Review-Url: https://codereview.chromium.org/2802093007
Cr-Commit-Position: refs/heads/master@{#463386}

A couple methods in biod_client.h do not have any indicators of success or failure. Modify these functions to uses VoidDBusMethodCallbaks so users have some indication of D-Bus failures.

TEST=chromeos_unittests --gtest_filter="BiodClientTest.*"
BUG=700933

Review-Url: https://codereview.chromium.org/2799043007
Cr-Commit-Position: refs/heads/master@{#463385}

base/android/context_utils.* is being removed.

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

BUG=646094

Review-Url: https://codereview.chromium.org/2807263002
Cr-Commit-Position: refs/heads/master@{#463384}

The original CL was reverted due to a unit_tests debug failure:
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24583
This is the same (just sync'ed & rebased), but depends on a related fix:
  https://codereview.chromium.org/2812693002

=====================================================================
ORIGINAL DESCRIPTION from https://codereview.chromium.org/2798173002:

mash: Remove ChromeLauncherController's |id_to_item_controller_map_|.

Remove CLC::id_to_item_controller_map_; rely on ShelfModel instead.
Skip removing shelf items in CLC destruction; rely on ~ShelfModel instead.

Remove CLC::[Get|Set]ShelfItemDelegate helpers; inline ShelfModel calls.
Remove moot ShelfModelObserver::OnSetShelfItemDelegate.

Rename CLC::LauncherItemClosed -> RemoveShelfItem.
Rename test helper GetAppLaunchers -> GetPinnedAppIds.

Inline ShelfModel::RemoveShelfItemDelegate helper function.
Avoid GetItemIndexForType, use GetShelfIDForAppID instead.
Use ItemTypeIsPinned helper function.

BUG=557406
TEST=Automated; no Chrome OS shelf behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2811853002
Cr-Commit-Position: refs/heads/master@{#463383}

BUG=571506

Review-Url: https://codereview.chromium.org/2807793003
Cr-Commit-Position: refs/heads/master@{#463382}

There is a bug that headless lib doesn't complie when users set
enable_basic_printing to false in their args.gn file.

The patch ensure that the printing support is only avaliable when
enable_basic_printing is true.
When it is false, the PrintToPDF devtools command would return an error instead.

BUG=603559

Review-Url: https://codereview.chromium.org/2808653002
Cr-Commit-Position: refs/heads/master@{#463381}

BUG=693650

Review-Url: https://codereview.chromium.org/2802863003
Cr-Commit-Position: refs/heads/master@{#463380}

Revert of Enable find-in-page across GuestViews. (patchset #6 id:270001 of https://codereview.chromium.org/2700613003/ )

Reason for revert:
Suspected cause of crashes: https://bugs.chromium.org/p/chromium/issues/detail?id=709478

Original issue's description:
> Enable find-in-page across GuestViews.
>
> This patch enables find-in-page to work across GuestViews, including
> WebViews and PDFs, as explained in this design doc:
> https://drive.google.com/open?id=1tl1L99oTgqQxolV7jRvDLzFQ9K251rQ_E16mOwB-BuU.
> Specifically, this will allow find-in-page to work with embedded PDFs,
> which has been a (very) longstanding bug in Chrome.
>
> This patch also cleans up code that was previously used to route find
> requests to the guest WebContents in the case of full-page GuestViews.
> This shortcut is no longer needed, as this patch implements a more general
> solution to traversing frames across all WebContentses during a find
> session.
>
> BUG=55421
>
> Review-Url: https://codereview.chromium.org/2700613003
> Cr-Commit-Position: refs/heads/master@{#462327}
> Committed: https://chromium.googlesource.com/chromium/src/+/9dedb9f32fca0666761f83c405c5959c148ea751

TBR=nick@chromium.org,lfg@chromium.org,thestig@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=55421

Review-Url: https://codereview.chromium.org/2808923003
Cr-Commit-Position: refs/heads/master@{#463379}

When shrinking-to-fit a container don't let the current width affect its
preferred widths. This will happen if we let percent margins on child inlines
calculate themselves against the block's current calculated width. To avoid
this reset the container's width to zero so that percent margins are ignored
in the preferred width calculation.

BUG=598711

Review-Url: https://codereview.chromium.org/2802413002
Cr-Commit-Position: refs/heads/master@{#463378}

BUG=703113
TEST=create html notification, exit browser, wait until notification closes and/or close notification.

Review-Url: https://codereview.chromium.org/2803593003
Cr-Commit-Position: refs/heads/master@{#463377}

Cr-Commit-Position: refs/heads/master@{#463376}

This patch fixes a null deref crash during detachLayoutTree.

BUG=709916
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2809563003
Cr-Commit-Position: refs/heads/master@{#463375}

The method is unused. It was introduced in https://codereview.chromium.org/2445193005.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2803163003
Cr-Commit-Position: refs/heads/master@{#463374}