- 14 May, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/13e06be378d8..9d5d210a420f git log 13e06be378d8..9d5d210a420f --date=short --no-merges --format='%ad %ae %s' 2019-05-14 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@9d5d210a420f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id3d0d60b026959f757c9d6d7b369706be838b998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611646Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659578}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/491b47da442e..d56a905e68a2 Created with: gclient setdep -r src-internal@d56a905e68a2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: Icb9d48ec0a0617c75f2a00b4ef36408004c84616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611642Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659577}
-
Tim Song authored
Currently, the message center closes apbruptly after the last notification slides out. It should instead gracefully animate being hidden. Video: https://screencast.googleplex.com/cast/NTQzNTM4NTg3MjEyMTg1Nnw2NmNlZThiNi1lZA TEST=manually verified, updated unit test BUG=958603 Change-Id: If1c9e6ced1670bc208af281d42f687af3084a488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610651Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#659576}
-
Maksim Sisov authored
After https://crrev.com/c/1570014, Chromium started to crash immediately because of null accelerated widget provided to the WaylandBufferManager and hitting data validation error when --enable-native-gpu-memory-buffer with the --enable-gpu-rasterization passed. The problem was that the raster buffer provided can create a staging buffer for rasterization, which is not tight to any of the existing widgets. Thus, it seems like it just passes a null widget [1][2]. But, when the GbmPixmapWayland was created and the dmabuf handle was passed to the WaylandBufferManager to import a wl_buffer, it crashed on the data validation, because the widget was null. Thus, when a null widget is passed, just create a native pixmap and do not call the WaylandBufferManager with a request to import a wl_buffer as long as they can also be used as staging buffers and not meant for attaching to Wayland surfaces. [1] https://cs.chromium.org/chromium/src/cc/raster/one_copy_raster_buffer_provider.cc?type=cs&g=0&l=296 [2] https://cs.chromium.org/chromium/src/cc/raster/zero_copy_raster_buffer_provider.cc?type=cs&g=0&l=125 Bug: 962466 Change-Id: Ied6fd6d3e29fdd21939c8b159682537f9239ab84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609781Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#659575}
-
Becky Zhou authored
Bug: 957262 Change-Id: I37d425113c55ad479becd15f3734bee4ed305346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610208Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#659574}
-
Jamie Walch authored
Change-Id: I1a12c5d90da11d43774a1306fa2459b30685badb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609596 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#659573}
-
Sylvain Defresne authored
The documentation on base::Callback<...> (src/docs/callback.md) recommends against using base::Passed(...) with base::BindOnce. > Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()` > does the same thing and is more familiar. This CL was uploaded by git cl split. Bug: none Change-Id: I6500004a85690c1d10ba9b1e1bad9e4912982448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611879 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
-
lonyele authored
chrome.tabs.move doesn't always move the tab to the requested index due to browser constraints. In these cases, an incorrect tab index might be returned to the chrome.tabs.move callback. Fix this and add regression tests. BUG=938881 Change-Id: I010cc390c1088936f6f2e0dedf1445918eaa4e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517973 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659571}
-
Fabrice de Gans-Riberi authored
The test is still flaky but the extra bot output has allowed to find a way to reproduce the failure locally. Bug: 760687 Change-Id: I8ee78da2a174937bd6b668f94efb48a8b87290b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611205 Commit-Queue: Ben Kelly <wanderview@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#659570}
-
Eugene But authored
ShellEarlGrey allows to keep old style for test helpers, but also allows logging file name and line number during the failures. Bug: None Change-Id: Ide6a1be98f03e29cd0a1bd3802d7e02852da5020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597957 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#659569}
-
Kyle Milka authored
This line was incorrectly removed in https://crrev.com/c/1610485. Bug: 937570 Change-Id: Ief210fbfce4cb993a75406716eabd2debff2d8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611302Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659568}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8a96493270cb..25eb8e4680ac git log 8a96493270cb..25eb8e4680ac --date=short --no-merges --format='%ad %ae %s' 2019-05-14 raul@tambre.ee Update colorama to 0.4.1 Created with: gclient setdep -r src/third_party/depot_tools@25eb8e4680ac The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:958138,chromium:958321 TBR=agable@chromium.org Change-Id: If2b6e01b1d14d8da7d6a5643480decd4588aad29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611960Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0ee3cd37199b..221ab9bee1be git log 0ee3cd37199b..221ab9bee1be --date=short --no-merges --format='%ad %ae %s' 2019-05-14 fmayer@google.com Consistenly increment heapprofd_invalid_string_id counter. 2019-05-14 fmayer@google.com Merge "Set timestamps in heap_profile_allocation." 2019-05-14 ilkos@google.com Merge "Add stats for invalid task state and fail more gracefully" Created with: gclient setdep -r src/third_party/perfetto@221ab9bee1be The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I103997255d562be6a661453faa794e9019faf671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611486Reviewed-by:
-
Victor Fei authored
- Implemented firing property changed event for UIA_AriaPropertiesPropertyId and associated unit and browser dump tests for the following AriaProperties: - posinset - pressed - readonly - relevant - Added dump test for testing when multiple aria attributes of one element change at once to test the logic for consolidating UIA_AriaPropertiesPropertyId events introduced in part 1 (CL:1574834) - Modified comments on expected behaviors for various aria-*-changed.html dump test files. - Breakdown of UI Automation AriaProperties need to be implemented: atomic [part 1] busy [part 1] channel [part 2] checked [part 1] disabled [part 3] dropeffect [part 2] expanded [part 1] grabbed [part 2] haspopup [part 1] hidden [not implemented] invalid [part 1] level [part 3] live [part 3] multiline [part 1] multiselectable [part 3] posinset [part 4, this cl] pressed [part 4, this cl] readonly [part 4, this cl] relevant [part 4, this cl] required [part 1] secret [part 2] selected [part 1] setsize [part 5] sort [part 5] tabindex [part 2] valuemax [part 5] valuemin [part 5] valuenow [part 5] valuetext [part 5] - Documentation on UI Automation AriaProperties (see the second table's last column for AriaProperties properties): https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification - Link to part 1, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1574834 - Link to part 2, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1576280 - Link to part 3, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1589100 - Link to part 4, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1592640 - Link to part 5, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1591487 Bug: 928949 Change-Id: Ica97e0a3afc850ad323bee25e6a778a073ac055f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592640Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#659565}
-
Mohammad Refaat authored
The main part here is to find a replacement to |didChangeTab|. It appears that, there is only need to change the leading/trailing edge sideSwipe state when didFinishNavigation so i added that. Also for webState, added a forwarder to forwarder to observe webStates through the WebStateList. TEST=Test that side swipe to navigate still works with slimnav off (or to and from NTP with either slimnav state). Also test that swipe to change tabs continues to work. Bug: 911350 Change-Id: I18148c0ed59c0a95b4f3cdfe868d4faa1a8b5ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610154 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659564}
-
Richard Townsend authored
The existing implementation relied on Intel changing its stack pointer predictably for leaf functions. Bug: 925584, 893460 Change-Id: I7d6c7ef5c77d7f1f9f5131dde262fb9f4ac2cbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593362 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659563}
-
Yutaka Hirano authored
We need to attach an origin header when the request's method is neither GET nor HEAD. For requests made by an extension content scripts, we want to attach page's origin, whereas the request's origin is the content script's origin. See https://crbug.com/944704 for details. Revert this CL once 940068 is fixed, as this potentially weakens the security and is also a layering violation. Bug: 944704, 940068, 962870 Change-Id: I477230d72f38f44deccffaf54e873ba148a97004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610667 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#659562}
-
Yoshifumi Inoue authored
Make NGAbstractInlineTextBox::GetText() to handle collapsed white space with soft line break correctly This patch changes |NGAbstractInlineTextBox::NeedsTrailingSpace()| to use |NGOffsetMapping| to check a space character collapsed by soft line wrap comes from same layout object. This patch also introduces unit test in |AbstractInlineTextBox| to cover following failed tests introduced by CL[1]: * DumpAccessibilityTreeTest.AccessibilityInputTextValue/blink <label>Email</label> <span>... => "Email " * DumpAccessibilityTreeTest.AccessibilitySpanLineBreak/blink abc<span> </span> => "abc " Note: This patch passes all DumpAccessibilityTreeTest in content_browsertest locally. [1] http://crrev.com/c/1609003 Make NGAbstractInlineTextBox::GetText() to include a collapsed space at soft line wrap Change-Id: Ib83c3042aedca33bd23280af98e42fc68108e865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610664 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#659561}
-
Caroline Rising authored
Make tab hover cards hit test transparent and add capability for any bubble frame view to be hit test transparent. Bug: 910739 Change-Id: Icbaf84b1aa4d0d2dcbdc45595f17618e5f1bc3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610469Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#659560}
-
Daniel Cheng authored
If the current working directory isn't the same as the directory the test binary is built in, the library load fails. Oops. Bug: 962911 Change-Id: I34704ad06ee79e697dbae119b190c4ace2b15366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611894 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#659559}
-
Christopher Cameron authored
use_default_render_theme is equivalent to use_aura and is being used to guard files that should be behind use_aura. Remove guards around setting and reading RendererPreferences. Have non-Aura platforms specify RendererPreferences::use_custom_colors to be false. Bug: 961342 Change-Id: I8e239a9fb576986eb1f33b250ff2d6718b609920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610596Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#659558}
-
Ben Kelly authored
Currently the CacheStorageScheduler use ThreadTaskRunnerHandler::Get() to get the TaskRunner used to schedule operations. In crbug.com/960012 we want to experiment with running the cache_storage code on a SequencedTaskRunner instead of the IO thread. As a first step this CL refactors the code so we can pass a specific SequencedTaskRunner down to the scheduler. Bug: 960012 Change-Id: Icdb52a01ca4eee9afe8b30f5f04cf1ef04c1eaa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599304Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#659557}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bcbd30b7dcaf..209ebc015a2f git log bcbd30b7dcaf..209ebc015a2f --date=short --no-merges --format='%ad %ae %s' 2019-05-14 herb@google.com Add thread annotations to SkSharedMutex Created with: gclient setdep -r src/third_party/skia@209ebc015a2f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Ibfaf449ecb72885f48854d8ec19637e2f117dc54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611485Reviewed-by:
-
Peter Boström authored
Adds back the ability to trigger extensions from the extensions menu. Triggering click-to-script extensions or pinning extensions are both still missing and will be added in later CLs. Bug: chromium:943702 Change-Id: I53fc2949233df012ada0100183e75b0da737b7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596570 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659555}
-
Yves Arrouye authored
And provide a concrete MachineCertificateUploaderImpl implementation. BUG=chromium:934426 TEST=unit tests Change-Id: Ib985316f6f6d13fb814f64a4d7383716065e253f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610755Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#659554}
-
sczs authored
Adds an identifying IconButton to passwordItem that toggles the Masking/Unmasking of the password. Bug: 945478 Change-Id: I6b5d05728342f19fdf2d8f7907ce8012ae31fd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611221Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#659553}
-
Koji Ishii authored
This patch puts LayoutNG line cache under a new runtime flag which is not enabled by default. There have been discussions on this, for its cost/risk and benefits. As we approach to ship, more risk cases were found. Also with recent normal layout caching work by ikilpatrick@, we're hoping to find better integration of line caching with block caching. It is known that this hinders the performance on appending micro benchmarks and in editing. We will probably need to revisit in post-phase 1, but we can polish it better with the data and the experiences we've got so far. Bug: 962008, 962141 Change-Id: Iee162be41b36ce5462a89efbbdd7abe796c3a14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611068Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
jonross authored
We would like to experiment with newer versions of Ubuntu on the GPU bots. As a first step we are pinning the non-experimental mixin to target Ubuntu-14.04. Bug: 953535 Change-Id: I2237861e6074b2e67b4999e02d1fe1f494055e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611283Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#659551}
-
Ali Juma authored
In http://crrev.com/c/1554352, the logic for loading error pages on back/ forward navigation was changed to do a full placeholder load instead of directly loading the error page, to workaround WebKit caching a blank error page. However, when navigating back to a page which previously loaded successfully but is no longer accessible (e.g., because of being in airplane mode), a full placeholder load destroys forward history. This CL modifies that change to rewrite the current URL to a placeholder URL using loadHTMLString, rather than doing a full placeholder load. This preserves the previous fix while also preserving forward history. The bug that the previous CL fixed was caused by the following sequence of loads on forward navigation to an inaccessible page: (1) A successful placeholder load, caused by forward navigation to an item whose URL is a placeholder. (2) An empty loadHTMLString with the actual URL caused by ErrorRetryState::kRetryPlaceholderNavigation. (3) An attempt to reload the actual URL, cause by ErrorRetryState::kNavigatingToFailedNavigationItem. (4) A loadHTMLSring with the actual URL, to load the error page. In the above sequence, the failed load step (3) would invalidate the PageCache entry for the current navigation item. At this point, the item still has a placeholder URL, so the load in (4) is considered to be a Standard load, causing the existing content to get added to PageCache for this item. The URL in the PageCache is that of the DocumentLoader for the existing content (from (2)), so it's the actual URL. After (4), navigating away from the page (e.g., going Back) doesn't update the PageCache, since the item doesn't have a PageCache entry. Then, on the next forward navigation to this item, WebKit loads the cached content from (2) along with the actual URL, so when we get the didFinishNavigation call for this load, we're in case ErrorRetryState::kDisplayingWebErrorForFailedNavigation and can't tell whether the page was loaded successfully or not, so assume that it was and leave it up to the user to reload. At this point the blank content from (2) is displayed. The previous CL solves this by doing a full placeholder load after (3). The problem is that if the page had previously loaded successfully before, this is a Standard load in WebKit (because it's a loadRequest with URL that doesn't match the current one), so Forward history is destroyed. The test added in that CL (ErrorPageTest.BackForwardErrorPage) doesn't catch this, because the page with the error never has a successful load. This CL rewrites the URL to a placeholder URL using loadHTMLString rather than loadRequest. This prevents forward history from being destroyed. It also still fixes the caching bug: In the sequence above, there will now be a step (3.5) for the loadHTMLString with empty content and the placeholder URL. This is the content that will be cached by WebKit. So this item's URL will still be the placeholder URL on futurue visits, meaning the ErrorRetryStateMachine will no longer wind up in a state where it can't tell whether the page has loaded successfully; instead, since the URL is a placeholder, it will wind up in ErrorRetryState::kNavigatingToFailedNavigationItem. Bug: 950489 Change-Id: Ib9437578a84e564fc87702e3a344454baae39029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610480Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#659550}
-
sczs authored
There's no UI functionality changes, but this opens the possibility to tap on this icon later on. It will be used to mask/unmask a password in the Password InfobarModal Bug: 945478 Change-Id: I67398a5a001056164db1d2ec2a2d0b927244158c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607434 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Guohui Deng authored
To enable the extended shutdown feature, when a new video decoder is requested, old backend that uses video decoder must be revoked so the video decoder is available for the current active application. Bug: b/69180616 Test: 1. Successive flings (different URLs) can now success even with ENABLE_EXTENDED_SHUTDOWN feature flag enabled. 2. Cast youtube and GPM without issues. Change-Id: I49331b047168b7f73c0fc7eb592b077cad143b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1415301 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#659548}
-
Greg Kerr authored
Bug: 961005 Change-Id: Ifa23d9c6d9c58444af9ab8d8fe052e2923cd3781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611638 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Cr-Commit-Position: refs/heads/master@{#659547}
-
Dana Fried authored
Needed to take the reason for bubble closing into account - if focus passed to another window we shouldn't reset the focus. Bug: 962411 Change-Id: Ic88a1151706613287e3f1bcb2f3c8dff39feb9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610307Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#659546}
-
Abigail Klein authored
To test, open a video that has a WebVTT captions file. For example, https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html is a nice example. Get foreground opacity from mac settings and apply it to the text color of the WebVTT caption HTML element. Bug: 897730 Change-Id: If3d14db0a1eeabbc335d6a801f22d2a9e80e80dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611784 Auto-Submit: Abigail Klein <abigailbklein@google.com> Reviewed-by:
-
Patrick Noland authored
Bug: 961939 Change-Id: I9c9917db89662ae9f7a707b35173d07b79104e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606801Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#659544}
-
Justin Tervay authored
Bug: 962958 Change-Id: Id471869ddae0382ed54c96bf4ed0716cee2a069f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611902Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Justin Tervay <tervay@google.com> Cr-Commit-Position: refs/heads/master@{#659543}
-
Ryan Hansberry authored
Bug: 961053 Change-Id: Ic70034f021943c316f5f922b4c75d4cb7952ded4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611084 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659542}
-
Alex Ilin authored
This CL disabled the test only on Android K where it's flaky. TBR: mvanouwerkerk@chromium.org Bug: 962974 Change-Id: I6c4c4ce318dc2d1a31d9caf3e39048e0bc20a10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611978Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659541}
-
Ehsan Karamad authored
With MimeHandlerViewInCrossProcessFrame, input should be directly routed to the GuestWebContents; it does not do the round trip to embedder's renderer any more since it does not rely on BrowserPlugin. Bug: 961786 Change-Id: Ib9a326fb61a42b359bc9d3fb97bee84fcbcbd330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610027 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#659540}
-
Ehsan Karamad authored
Currently, any MimeHandlerViewGuest created by MimeHandlerViewEmbedder is considered to be a full page plugin. This is not true when the MHVG was created due to appending an <embed> or <object> with a relevant MimeHandlerView MIME type. This CL fixes the issue which would then make the tests PDFExtensionTest.TabTitle* all pass with MimeHandlerViewInCrossProcessFrame. Bug: 961786 Change-Id: Ib6500082fbff39c6fa58a278852a53b839fc7014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610753Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#659539}
-
