- 31 Jan, 2018 40 commits
-
-
Mohamad Ahmadi authored
This CL fixes a bug where the value of the currency amount was being checked against the maximum allowed string length not the length of the value string. Bug: 806666 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8897c93f06e8cb590c5414497b53ab87fa291e77 Reviewed-on: https://chromium-review.googlesource.com/895546Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533317}
-
bsheedy authored
Adds bsheedy as an owner of chrome/android/BUILD.gn for changes related to VR Javatests so that other owners don't have to be bothered by VR-only changes. Change-Id: I0d84468848d1e6a8b43f2a4844edfdbad3e78ca9 Reviewed-on: https://chromium-review.googlesource.com/894362Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533316}
-
Danyao Wang authored
location.replace changes the URL of WKBackForwardListItem. Update the URL of NavigationItem to that of the host WKBackForwardListItem upon access. It's done this way because location.replace cannot be reliably distinguished from normal navigations in either WKNavigationDelegate callback or URL KVO. This fixes NavigationTestCase/testWindowLocationReplaceAndChangeHash. Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaef4ed5efd788283050b43a3b4e988311ec9cf76 Reviewed-on: https://chromium-review.googlesource.com/894490 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533315}
-
Raymond Toy authored
This is a reland of 53b1b7da. Original change's description: > Remove Dezippering from BiquadFilter > > Remove dezippering from all of the attributes. The value will now > change immediately instead of gradually changing from the old value > to the new value. > > Chromium Feature: https://www.chromestatus.com/features/5287995770929152 > Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ > > Bug: 752986 > Test: BiquadFilter/dezipper.html > Change-Id: I86840159709158fd52a69a7c3c5f279267277d44 > Reviewed-on: https://chromium-review.googlesource.com/612104 > Commit-Queue: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532910} Bug: 752986 Change-Id: Ia911c6e93d7dd7da1dea6290ac4201f81f42da3a Reviewed-on: https://chromium-review.googlesource.com/894243Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533314}
-
Miguel Casas-Sanchez authored
This CL relands crrev.com/c/886543, enabling the GLImageBindTest for GLImageIOSUrface with the BufferFormat BGRX_1010102. The CL also adds a provision to swizzle the color channels when running on nVidia on High Sierra to workaround some bug that can be repro'ed on the bots and stand alone laptops. Bug: 803473 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5472606a82b393fe1d2375b3c644e836ea7f12cf Reviewed-on: https://chromium-review.googlesource.com/890007Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#533313}
-
Emily Stark authored
This transition (which is currently only possible with an experiment enabled) can look messy/confusing when animated, so do not animate it. Bug: 807075 Change-Id: Ib7bda303958739cd4840dbc57910c1c850c5e97a Reviewed-on: https://chromium-review.googlesource.com/891630Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#533312}
-
Sahel Sharifymoghaddam authored
This reverts commit 871421fc. Reason for revert: this change hasn't fixed the failing tests. Original change's description: > Fix SitePerProcessMouseWheelHitTestBrowserTest.* tests on Win official. > > https://chromium-review.googlesource.com/865558 fixes this flaky tests > on win7_chromium_rel_ng, but it only waits for dispatching of the > first wheel event before sending the others. > > This cl makes sure that each wheel event gets dispatched before sending > the next one. > > I haven't been able to reproduce the bug on my local windows official > build but I suspect that after using async wheel targeting for wheel > events some of the wheel events in RunTest get coalesced to each other > before getting dispatched. > > Bug: 800822 > Change-Id: Id693ef3beff19daf08c3e11c2119b2bf90ef6737 > Reviewed-on: https://chromium-review.googlesource.com/893803 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533002} TBR=kenrb@chromium.org,nasko@chromium.org,wjmaclean@chromium.org,sahel@chromium.org Change-Id: I62fa9ba2075ffaf7ac685dad56af84bd06237214 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800822 Reviewed-on: https://chromium-review.googlesource.com/894998Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533311}
-
François Beaufort authored
https://wicg.github.io/picture-in-picture/ The API is currently not working. It is mostly about implementing the shell: it exposes document.pictureInPictureEnabled, document.exitPictureInPicture(), and video.requestPictureInPicture(). It also adds the "picture-in-picture" feature policy. Everything is gated by the "PictureInPictureAPI" runtime feature. Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/U8Apo-WLBm4/03sO4ITYAQAJ Change-Id: I64d8e17c6975017565c850afeeca19d94e9f9ceb Bug: 806249 Reviewed-on: https://chromium-review.googlesource.com/867915 Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533310}
-
Elly Fong-Jones authored
Whenever any requests are running, ResourceDispatcherHostImpl polls for state changes to running requests, so that these can be reflected in the UI. However, ResourceDispatcherHostImpl doesn't remember the previous state of a request, so it always calls LoaderDelegate::LoadStateChanged() for any running request, at 4Hz. This calls into WebContentsImpl::LoadStateChanged(), which *does* have access to the previous state, which then notifies the UI of a change. Instead, WebContentsImpl should check if the state notification is redundant, and if so, should ignore it. This will save doing a bunch of work in the UI. In principle, ResourceDispatcherHostImpl could do this de-duplication instead, but that involves storing more data in RDHI for a very small further decrease in work done. This also fixes the root cause of an old bug where on Mac, the status bar would be clobbered (at 4Hz) whenever there was a pending request in the current tab. This bug was worked around in the Views status bar code by suppressing updates with no text changes, but that workaround never made it to the Cocoa status bar. Bug: 147303 Change-Id: Idbaded695b161543d1750aa9e6253c3bdd0a145a Reviewed-on: https://chromium-review.googlesource.com/895724Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#533309}
-
Jonathan Metzman authored
TBR=vitalybuka@chromium.org Bug: 539572 Change-Id: I1e7dbad47b8f5b4debfd4ab071ce946d07c0d93f Reviewed-on: https://chromium-review.googlesource.com/885085Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533308}
-
Peng Huang authored
Disable GL_EXT_disjoint_timer_query for Nexus5 and Nexus7v2, because glGetQueryObject(GL_QUERY_RESULT_AVAILABLE) blocks unexpectedly. Bug: 750306, 764526 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I752d51c05c26203a759b6c2ded961a84a90cc4cd Reviewed-on: https://chromium-review.googlesource.com/895246Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#533307}
-
W. James MacLean authored
With the new async hit-testing code, the RenderWidgetHostViewGuest- specific code in RenderWidgetHostInputEventRouter::FindMouseEventTarget no longer seems to be hit, and thus mouse events are bypassing the embedder (and hence the BrowserPlugin) for PDFs. This CL changes RenderWidgetHostViewGuest so that it refers tooltip text requests directly to the root view, instead of sending them to the BrowserPlugin. Bug: 807236 Change-Id: Ic943e6bca70035fb5ac9198281412fbc6b7887f1 Reviewed-on: https://chromium-review.googlesource.com/894145Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#533306}
-
Saman Sami authored
When the main thread receives DidCommitAndSwap from the impl thread and the main thread hasn't commited after resize, DidCommitAndSwap belongs to the previous commit and should not be used for acking the resize. In other words, (Resize,DidCommit,DidCommitAndSwap) should ack the resize but (DidCommit,Resize,DidCommitAndSwap) should not. Change-Id: Ib55c4acb82a90560e1a75d7327e08321b1bf7f0c Reviewed-on: https://chromium-review.googlesource.com/883909Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#533305}
-
Thiemo Nagel authored
No functional change. Bug: None Change-Id: Ie077b642c13f5b4b88f7940250912c6b032285cb Reviewed-on: https://chromium-review.googlesource.com/873632Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533304}
-
Justin Cohen authored
Bug: 803372 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icdfc2ee6450ab03cf357792cc3ad6d0060baf58e Reviewed-on: https://chromium-review.googlesource.com/891518 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#533303}
-
Peter E Conn authored
Chrome Custom Tabs have a menu item allowing users to open that page in their browser. Pass an extraCallback to the Custom Tab host to notify them. Bug: 806891 Change-Id: Ia67e8033d261f9be4735f446a3e5a96b58a24f6c Reviewed-on: https://chromium-review.googlesource.com/890746 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533302}
-
https://chromium.googlesource.com/angle/angle.git/+log/199f42941ab5..e13f7ebea887 $ git log 199f42941..e13f7ebea --date=short --no-merges --format='%ad %ae %s' 2018-01-26 oetuaho Make NVIDIA constant register zero skip specific to VS Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: If456703efa422a9ee7fdf236d8e0cb365f7c4ad3 Reviewed-on: https://chromium-review.googlesource.com/894715Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533301}
-
John Z Wu authored
One test that verifies fetching, filling, and clearing. Bug: 778764 Change-Id: I77653f323941a66bc1ae3c490cebb4d92de29b02 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/841342 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#532462} Reviewed-on: https://chromium-review.googlesource.com/894483 Cr-Commit-Position: refs/heads/master@{#533300}
-
Egor Pasko authored
This would allow M66 cap in the Finch config. Removing the Feature and OmniboxMode/etc will be slightly easier to do when Prerender gets hard-disabled, postponing the cleanup until then. Bug: 762489 Change-Id: Ica411ec05a211c8aa3bf779b6c8764403a36308d Reviewed-on: https://chromium-review.googlesource.com/895764Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#533299}
-
Stephen McGruer authored
We are aiming to deprecate this feature in M67. This warning may have some false positives (as it is legal to use '#' as a fragment identifier), but I have yet to find a case in the wild of someone actually doing that. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/_g_HnAHkMPo/1DrejG5mAgAJ Bug: 123004 Change-Id: Ibace7288ddb6a814f51faec85c47a49b0d69a273 Reviewed-on: https://chromium-review.googlesource.com/888762 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#533298}
-
https://webrtc.googlesource.com/src.git/+log/bbf46c27538c..f9e012149f27 $ git log bbf46c275..f9e012149 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I047e0fff680ae5079284dfaa1008befe287a0a05 Reviewed-on: https://chromium-review.googlesource.com/894898 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533297}
-
Andrew Grieve authored
No behaviour changes. Change-Id: I758665a5dfb20dce35394d083f7f2a9fc82115c0 Reviewed-on: https://chromium-review.googlesource.com/894474 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#533296}
-
Alan Cutter authored
From the header it's not obvious what Show/Hide means in terms of this class' behaviour. This CL adds clarification as to their effect on GetCurrentValue(). Change-Id: Ib5ebe34a687c6562442a27172b767b5d0f8fe3a7 Reviewed-on: https://chromium-review.googlesource.com/894862Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533295}
-
Shivani Sharma authored
This CL adds a flag to SubresourceFilter which is currently set based on the subresource filter rule set matching. Subsequently this will also be set when the initiator of this frame is an ad resource even if this does not match the subresource filter ruleset. Note that the matching already takes place in the browser process and this flag is set at commit time when the browser process communicates the status of matching to the renderer process. Note that this will work for both browser initiated and renderer initiated subframes (in PlzNavigate) as is currently the case with subresource filter matching. BUG: 807640 Change-Id: If883be8209a7756c6024c1c9eda1a8d081f815a1 Reviewed-on: https://chromium-review.googlesource.com/868261 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#533294}
-
Doug Arnett authored
When the user is viewing a preview page and selects "Show original", the client asks the NavigationController to Reload(DISABLE_PREVIEWS). It currently reloads the last committed URL which is a problem if the preview caused a client redirect to occur so that the last committed URL is a preview-specific URL. Really, we want to reload the original requested URL to show the original page. This CL updates the NavigatorImpl::NavigateToEntry() logic to use the original request URL for ReloadType::DISABLE_PREVIEWS just as it currently does for ReloadType::ORIGINAL_REQUEST_URL. Bug: 795940 Change-Id: Ic167afa48dca9e40eac3f0dabaf0fb5c5b6ddcdc Reviewed-on: https://chromium-review.googlesource.com/879026 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#533293}
-
Tatsuhisa Yamaguchi authored
Once loading of an archive has been started, it should not start loading the same file again. Existing logic returns "EXISTS" error via fileSystemProvider API when an archive is already mounted. However, it missed handling of a case where user requested opening the same archive while its loading is ongoing. It typically happens when an archive is on Drive and not yet cached. As a transitive fix, this change reuses the "scanning..." message to indiacte that user need to wait operation finish in such case. Bug: 807254 Test: manually tested on Files app as noted in the bug. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I90d5b8b2c157ea40b40ad106bbcb85b1bd022ea7 Reviewed-on: https://chromium-review.googlesource.com/895424 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#533292}
-
Jonathan Backer authored
This CL adds a few things: - autogenerated unittests - associated mocks - associated test drivers - enough implementation in raster_decoder.cc to make the tests pass No changes to GLES2 autogen. Bug: 789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iac2ee4922a21f3bd11ff58693e2e5fb1fe26bd45 Reviewed-on: https://chromium-review.googlesource.com/891988 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#533291}
-
Elly Fong-Jones authored
The code in [AppController shouldQuitWithInProgressDownloads] needs to account for the fact that incognito profiles have separate DownloadManagers from their parent profiles. This change does this by considering incognito profiles as though they were regular profiles. 1) Create a profile, create an incognito window from it, start a download, quit Chrome: a "cancel download?" prompt should now appear. 2) Create a profile, create an incognito window from it, quit Chrome: no "cancel download?" prompt should appear. 3) Create a profile, start a download, quit Chrome: a "cancel download?" prompt should appear as before. 4) Create a profile, quit Chrome: no "cancel download?" prompt should appear. Bug: 88419 Test: Manual Change-Id: Ib25995c45ae99f3b1fe00b15a37108399be06f77 Reviewed-on: https://chromium-review.googlesource.com/895802 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533290}
-
Friedrich Horschig authored
When the search view is collapsed, the search should be reset entirely. Bug: 807574, 807306 Change-Id: Id13eb9e119459d05751e06b515671eccacc776f2 Reviewed-on: https://chromium-review.googlesource.com/895485Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#533289}
-
Guido Urdaneta authored
This CL introduces two main updates to constraints processing for audio: 1. The SelectSettings() algorithm now considers audio-processing properties as belonging to each device instead of being considered independent of the device. The reason is that, while the audio-processing module can be applied to any source, once a source has processing applied, all tracks for that source must use the same audio-processing settings. 2. The getUserMedia() implementation leverages (1) and makes sure that candidate settings for audio sources already in use are limited to their current configuration. Bug: 802198 Change-Id: I3554206e852ff41116a1fe02be45a7a8dff4760d Reviewed-on: https://chromium-review.googlesource.com/881183Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#533288}
-
Miriam Gershenson authored
The DnsConfigService can't get a correct DNS config for a VPN until Android M. On earlier versions, check for a VPN and treat it as a config read failure. Bug: 805020 Change-Id: I696c52a2e012460ddd70381e5278c3abca9ca665 Reviewed-on: https://chromium-review.googlesource.com/894149Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#533287}
-
Rouslan Solomakhin authored
This reverts commit 6e232c77. Reason for revert: Possibly broke http/tests/devtools/tracing/timeline-style/timeline-recalculate-styles.js in https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66101 Original change's description: > Roll src/third_party/catapult/ 7c98d04db..12ffa8933 (2 commits) > > https://chromium.googlesource.com/catapult.git/+log/7c98d04db58b..12ffa8933991 > > $ git log 7c98d04db..12ffa8933 --date=short --no-merges --format='%ad %ae %s' > 2018-01-31 perezju [Devil] Dismiss errors in GetRecursiveDiskUsage > 2018-01-25 perezju [Telemetry] Move profile setup on desktop to its possible browser > > Created with: > roll-dep src/third_party/catapult > > > The AutoRoll server is located here: https://catapult-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel > TBR=sullivan@chromium.org > > Change-Id: I349d5d5c652ff38030b5ad74c49ad136e791b421 > Reviewed-on: https://chromium-review.googlesource.com/895406 > Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#533256} TBR=sullivan@chromium.org,catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: I881b5f5750cd5b49f073464647ae0c925db1a4b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/895663Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533286}
-
Balazs Engedy authored
This reverts commit aad276cb. Reason for revert: Suspected to be the culprit for breaking Mac browser_tests and unit_tests that use an local python test server, e.g.: RUN ] CloudPolicyTest.FetchPolicy [4513:779:0131/005831.599342:3098052568384:ERROR:local_test_server_posix.cc(81)] poll() timed out; bytes_read=0 [4513:779:0131/005831.599552:3098052743513:ERROR:local_test_server_posix.cc(168)] Could not read server_data_len ../../chrome/browser/policy/cloud/cloud_policy_browsertest.cc:190: Failure Value of: test_server_->Start() Actual: false Expected: true Original change's description: > Use vpython rather than python for GPU tests on the bots. > > From talking with iannucci@, this is the easiest way to use vpython > with these tests on the bots. Once the LUCI conversion is done, this > will be a no-op, and can be removed. > > Incorporate the newly deployed pyobjc wheels into Chromium's root > .vpython; they are needed by helper scripts in the GPU directory. > > Bug: 776804, 804174 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I1c720a9f7992e411aa85bcc7959de95ecc03c1f5 > Reviewed-on: https://chromium-review.googlesource.com/869512 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533226} TBR=iannucci@chromium.org,kbr@chromium.org,dnj@chromium.org,nednguyen@google.com Change-Id: Idb03a7a1176d79443b3a29267a16c7631fbf1be8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 776804, 804174 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/894208Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533285}
-
Andreas Haas authored
R=inferno@chromium.org Change-Id: Ida49d839c1a0ccfd60d4ba556f6225000c81f3a6 Reviewed-on: https://chromium-review.googlesource.com/895533Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#533284}
-
David Roger authored
Change-Id: I44027badf2aaa5d4aa556ab6bfb686b0e8913b98 Reviewed-on: https://chromium-review.googlesource.com/893562Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#533283}
-
Clemens Hammacher authored
The wasm call fuzzer is superseded by the wasm compile fuzzer, thus remove it. R=ahaas@chromium.org Change-Id: I732a3d2ca81a1642e862f2cf374e4adaf51e8f07 Reviewed-on: https://chromium-review.googlesource.com/895531 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#533282}
-
Andrii Shyshkalov authored
R=jbudorick@chromium.org Bug: 731553 Change-Id: I064be66068ef0a02e5bab21061112d6174395246 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/893654Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#533281}
-
Brian Salomon authored
Bug: 807055 Change-Id: Iccbce54b0ca478701575edee04558e081e3a70d7 Reviewed-on: https://chromium-review.googlesource.com/891485Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#533280}
-
https://pdfium.googlesource.com/pdfium.git/+log/2334660053e0..4b0c5b935471 $ git log 233466005..4b0c5b935 --date=short --no-merges --format='%ad %ae %s' 2018-01-31 dsinclair Remove NumericLimit params which are always the same Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2312f9ea3374e68a718d0dbb0bceebddf51e25dd Reviewed-on: https://chromium-review.googlesource.com/894672Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533279}
-
Sahel Sharify authored
This cl moves touchscreen handling logic from the renderer to the browser. The fling_controller handles a GSF and generates a fling curve, as long as the fling is active, the controller advances the fling progress and sends GSU events with computed scroll deltas to the renderer. At the end of the fling the controller generates and sends a GSE event. Deleted event_unittests are either covered in fling_controller_unittests and fling_booster_unittests or are not relevant anymore. Bug: 249063 TEST: FlingControllerTest.* Change-Id: I072da0ae726eed3d0a567843c9ccc84725074eb0 Reviewed-on: https://chromium-review.googlesource.com/879359Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533278}
-