- 02 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/42e7d9c929ef..0367d1a1fb0a git log 42e7d9c929ef..0367d1a1fb0a --date=short --no-merges --format='%ad %ae %s' 2018-11-02 yinwa@webrtc.org Adds a field trial parameter to configure waiting time before sending Nack packets. 2018-11-02 eladalon@webrtc.org Change to RtcEvent::Copy 2018-11-02 kwiberg@webrtc.org Hide the AudioEncoderCng class behind a create function Created with: gclient setdep -r src/third_party/webrtc@0367d1a1fb0a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7505ba5732a32e3caaf450b55955575211cf2d85 Reviewed-on: https://chromium-review.googlesource.com/c/1315333Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605002}
-
Ben Pastene authored
And remove cpu:x64 from the defaults. TBR=jbudorick Bug: 901205 Change-Id: I64be7685d85a2b5d895dafde6df0193b8db0c6bf Reviewed-on: https://chromium-review.googlesource.com/c/1315693Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#605001}
-
Peter Kotwicz authored
BUG=None Change-Id: Ibfccc7663c3d5091574af4cd50254e42dbb79190 Reviewed-on: https://chromium-review.googlesource.com/c/1313068 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#605000}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b49154954d1d..48a5c18d49ce Created with: gclient setdep -r src-internal@48a5c18d49ce The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734 TBR=mmoss@chromium.org Change-Id: Ifa643a4edbe8d08d71c2d71c826e2268945fbce6 Reviewed-on: https://chromium-review.googlesource.com/c/1315413Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604999}
-
Ryan Hansberry authored
Most usages of PA_LOG(INFO) did not need to be in the default stdout, and were spammy. This CL downgrades most to VERBOSE, but leaves a choice few as INFO: * //chrome/browser/chromeos/tether/tether_service.cc:519 * //chromeos/components/proximity_auth/unlock_manager_impl.cc:219 * //chromeos/components/proximity_auth/unlock_manager_impl.cc:466 * //chromeos/components/tether/active_host_network_state_updater.cc (all) * //chromeos/services/multidevice_setup/host_backend_delegate_impl.cc:237 * //chromeos/services/secure_channel/ble_connection_manager_impl.cc:261 * //chromeos/services/secure_channel/ble_scanner_impl.cc (all) * //chromeos/services/secure_channel/secure_channel_impl.cc:132 * //chromeos/services/secure_channel/secure_channel_impl.cc:177 * //components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc (all) * //components/cryptauth/cryptauth_device_manager_impl.cc:659 * //components/cryptauth/secure_channel.cc:269 Some others which were actually error or unexpected cases have been moved to WARNING or ERROR. Bug: 899100 Change-Id: I58c8b734138fcb4c19be940fe79327adebe4d568 Reviewed-on: https://chromium-review.googlesource.com/c/1313762 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604998}
-
Leonard Grey authored
This is a speculative fix for https://crbug.com/876493 There's an implicit but unenforced assumption that a widget doesn't have mouse capture when a move loop runs. Indeed, all implementations of RunMoveLoop besides Mac appear to do this directly or indirectly, and we even do a DCHECK in BridgedNativeWidget to ensure this is the case. As it happens, in most cases on Mac, this ends up being true by accident: When detaching a tab into a new window, we attempt to acquire capture in TabDragController::Attach, but fail because the window of the newly created widget is not yet showing. However, evidence from the field in the linked bug shows that in reality, sometimes we *do* have capture while running a move loop. So at a minimum, let's get our RunMoveLoop semantics in line with other platforms and see what happens, though there's a lot of other stuff wrong with this situation IMO. Bug: 876493 Change-Id: If4e7a260d7be4e5f9272eca4b8eec73a8b52e156 Reviewed-on: https://chromium-review.googlesource.com/c/1315170Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#604997}
-
John Rummell authored
Verify that we're not seeing double frees on DecoderBuffer. BUG=794740 TEST=media_unittests pass Change-Id: If280c93f065f7ea0254513af7f2d5efd1dc4ad0d Reviewed-on: https://chromium-review.googlesource.com/c/1313767 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604996}
-
Etienne Bergeron authored
This is moving the threshold to report a slow-reports with memory dump for a utility process. The chosen value is 250M, which is the 98th percentile based on UMA metrics. We are expecting to get about 3x more reports. The amount of reports is currently really low and harder to be actionnable. We believe this will help find new potential memory leaks in utility processes. R=erikchen@chromium.org Change-Id: I93f286d4603d612b4ad64f1573d5967a6ba87d0b Reviewed-on: https://chromium-review.googlesource.com/c/1315647Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604995}
-
Koji Ishii authored
This patch reorders members of NGConstraintSpace so that value (non-class/struct) members are placed at the end. Due to byte-align, it reduces the size from 96 bytes to 88 bytes on x64. Bug: 635619 Change-Id: I7d9471343f3c16d91f7534fd98e2b95f1d18f8c5 Reviewed-on: https://chromium-review.googlesource.com/c/1314070Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#604994}
-
Jazz Xu authored
Bug: 896255 Change-Id: I12f394272b9bec2f11ccfaf850ef03fffa8e484c Reviewed-on: https://chromium-review.googlesource.com/c/1313560Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#604993}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/86e5fbf71b88..d105d2e46b9a git log 86e5fbf71b88..d105d2e46b9a --date=short --no-merges --format='%ad %ae %s' 2018-11-02 tsepez@chromium.org Move CJS_PublicMethods::ParseString{String,Interger} to fx_date_helpers.cpp Created with: gclient setdep -r src/third_party/pdfium@d105d2e46b9a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I445bf670c166be40722388a3345108ebd73ad7b6 Reviewed-on: https://chromium-review.googlesource.com/c/1315329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604992}
-
Sean Topping authored
Bug: internal b/114464714 Test: CQ, verify Devtools is accessible on IPv4 and IPv6 Change-Id: I716643bb4c51cedaa0375ab51a9809246ecb64ab Reviewed-on: https://chromium-review.googlesource.com/c/1309101 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#604991}
-
kylechar authored
It doesn't look like these metrics have been recorded since M54. Bug: none Change-Id: I57aadf19add26f8d0d8d3d85e25f6fd9d599cbeb Reviewed-on: https://chromium-review.googlesource.com/c/1313552Reviewed-by:
Victor Miura <vmiura@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#604990}
-
Eric Karl authored
This swaps the deprecated 'arraysize' macro for base::size in the GPU command buffer generator scripts and generated files. No change to logic. Bug: 837308 Change-Id: I229a7f9ad9a25f0a7e40690aae5ff167a75aa804 Reviewed-on: https://chromium-review.googlesource.com/c/1313835Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#604989}
-
Eric Robinson authored
See: go/chromerulesetservicemerge This change removes references to ContentRulesetService in our codebase preferring RulesetService. It changes the direction of ownership of these classes, having the RulesetService own the ContentRulesetService. The publishing/distribution functionality is now called via the RulesetService itself, which makes calls to the virtual RulesetServiceDelegate implemented by the ContentRulesetService. Bug: 900292 Change-Id: I30420f0b36107e65d59d1911b506242c58886ecd Reviewed-on: https://chromium-review.googlesource.com/c/1294299Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#604988}
-
Li Lin authored
Enable personal readout to support personal features after we changed to use libassistant device ID. Bug: b/118782806 Change-Id: I9b3d08eb700f6f352f88c59c11bfbf3813f15c4f Reviewed-on: https://chromium-review.googlesource.com/c/1312293Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604987}
-
Robert Sesek authored
This reverts commit dcb738f9. Reason for revert: Broke mac-dbg compile https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-dbg/1596 Original change's description: > Reimplement GetAppOutput and friends on Mac with posix_spawn. > > Mac no longer uses launch_posix.cc and all process creation goes through > posix_spawn now. > > Bug: 179923 > Change-Id: I5206cace69ea7863a72b58e1a59f2465492d4cbd > Reviewed-on: https://chromium-review.googlesource.com/c/1313334 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604982} TBR=rsesek@chromium.org,mark@chromium.org Change-Id: I9fd7e4c80f66de9acd35c7626cc65fdd5007d474 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 179923 Reviewed-on: https://chromium-review.googlesource.com/c/1315708Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#604986}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a6ef719b69f4..a8f088180a1c git log a6ef719b69f4..a8f088180a1c --date=short --no-merges --format='%ad %ae %s' 2018-11-02 chiniforooshan@chromium.org Telemetry: migrate thread_*_cpu_time_per_frame 2018-11-02 erikchen@chromium.org [Reland 1] ADB commands should only retry errors, not exceptions. Created with: gclient setdep -r src/third_party/catapult@a8f088180a1c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890757,chromium:895027 TBR=sullivan@chromium.org Change-Id: I070af3f6172541300ce6dc4d5ac183f117dd1db6 Reviewed-on: https://chromium-review.googlesource.com/c/1315408Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604985}
-
Ben Pastene authored
Its bots will be everything in: https://chromium-swarm-dev.appspot.com/botlist?c=id&c=os&c=task&c=status&f=os%3AChromeOS&l=100&q=os%3AChr&s=id%3Aasc Bug: 901205 Change-Id: I0266b1c75deacdd0b287bcd9cc7f8b247a4792af Reviewed-on: https://chromium-review.googlesource.com/c/1313836Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#604984}
-
Matthew Jones authored
This patch moves the responsibility of updating the scrim for the toolbar over to the ToolbarManager. This allows for the removal of a fair amount of plumbing for the scrim and some questionable casting. Change-Id: I3ee397c2444d96da9e9a32bb7652134989ffedad Reviewed-on: https://chromium-review.googlesource.com/c/1313115 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604983}
-
Robert Sesek authored
Mac no longer uses launch_posix.cc and all process creation goes through posix_spawn now. Bug: 179923 Change-Id: I5206cace69ea7863a72b58e1a59f2465492d4cbd Reviewed-on: https://chromium-review.googlesource.com/c/1313334Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#604982}
-
Xing Liu authored
In normal profile, the small icon uses different default icons based on download state. Incognito mode should do the same since download state is not privacy information. Other systems try to use download notification currently don't plumb the small icon into DownloadNotificationFactory. Bug: 901141 Change-Id: I3f813adab15484b1e97e8d1592979f8f381ad8d0 Reviewed-on: https://chromium-review.googlesource.com/c/1313928Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#604981}
-
Alex Clarke authored
It's important to cap delays at one day or bad things can happen on certain platforms. Also removes a redundant call to ScheduleDelayedWork. Bug: 863341, 850450 Change-Id: Idfb95a5e5d800255caff74d0718db600b9348335 Reviewed-on: https://chromium-review.googlesource.com/c/1314489Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604980}
-
Wan-Teh Chang authored
https://aomedia.googlesource.com/aom.git/+log/8f2210a2e54a..35171107616f $ git log 8f2210a2e..351711076 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 johann.koenig INTERNAL_STATS: move ssim_opt_x86_64 2018-10-29 yunqingwang Use 8-tap interp filter in temporal filtering 2018-10-29 wtc Re-enable the NotEnoughBuffers and NoRelease tests. 2018-10-31 urvang av1_highbd_dr_prediction_z2_c: Add an assertion. 2018-10-30 sarahparker Solve a 2x2 system for optical flow computation 2018-10-31 sachin.kumargarg Fix issue in AV1HighBDJNTCOMPAVGUPSAMPLEDTest 2018-10-30 sarahparker Add function to compute matrices for DISflow system 2018-10-22 sarahparker Add x and y gradients to image pyramid 2018-10-30 bruno.berthier Fix build with -DCONFIG_WEBM_IO=0 -DCONFIG_LOWBITDEPTH=0 2018-10-29 david.turner Remove CONFIG_INTEGERIZE_SGR build flag 2018-10-29 david.turner Fix issues with SIMD horver_correlation_full 2018-10-22 debargha Enhance selective_ref_frame for use in speed 0 2018-10-23 wenyao.liu reduce memory usage in PICK__MODE_CONTEXT 2018-10-26 sarahparker Add macro to determine type of global motion computation 2018-10-24 ravi.chaudhary Fix issues in ARNR filtering 2018-10-26 wtc Propagate img->fb_priv when film grain enabled. 2018-10-27 wtc Fix the ExtFBMD5Match test. 2018-10-26 yunqingwang Remove rst_end_stripe in struct AV1Common 2018-10-26 johannkoenig change CONFIG_SHARP_SETTINGS description 2018-10-26 debargha Revert horver calculation to C version temporarily (...) Created with: roll-dep src/third_party/libaom/source/libaom R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@chromium.org Bug: aomedia:1255 Bug: 867613 Change-Id: I1dd800038d5ec8e80b4eefc851173d1ca8427e1c Reviewed-on: https://chromium-review.googlesource.com/c/1313765Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#604979}
-
Xiaocheng Hu authored
This patch converts some layout tests with testharness to reduce usage of deprecated js-test.js. It's also a preparation for using Element.innerText as layout test text dump to avoid confusiong text dumps. These tests contain <option> with text like "failure", which doesn't appear in old text dump but appears in innerText. By converting with testharness, we don't have such confusing text dumps. Bug: 887148 Change-Id: I38cc38cb395318bb9ddd38d655c99bd4f47bb846 Reviewed-on: https://chromium-review.googlesource.com/c/1314131Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604978}
-
Bin Wu authored
In function QuicSocketAddressImpl::generic_address(), zero-initialize the returned sockaddr_storage. This is how Google's internal implementation behaves. Change-Id: I99e3ded71060027c9cd01ffb58330597a12aa880 Reviewed-on: https://chromium-review.googlesource.com/c/1313676 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#604977}
-
Christian Biesinger authored
The flexbox ones were likely fixed by crrev.com/c/1310475, which now sets constraint_space.IsNewFormattingContext() correctly for flex items with ng flex. The other two were fixed by crrev.com/c/1306968, I believe. TBR=dgrogan@chromium.org Change-Id: If44d1d34f416078d3768a9a518390a3fd3072d06 Reviewed-on: https://chromium-review.googlesource.com/c/1315169 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#604976}
-
Tomas Popela authored
We have to remove the square brackets if presented otherwise the array variable will be passed as variable[] and that will cause a build failure: gen/modules/desktop_capture/linux/pipewire_stubs.cc:85:26: error: expected expression pw_init_ptr(argc, argv[]); ^ Change-Id: I60595a0ce4a4f618fcb904cc3654ce4304fd1ff9 Reviewed-on: https://chromium-review.googlesource.com/c/1312950Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#604975}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20f38b3d064b..b49154954d1d Created with: gclient setdep -r src-internal@b49154954d1d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic10f92d3d57c4ed21c851c51f7fbe4a5172c4930 Reviewed-on: https://chromium-review.googlesource.com/c/1315328Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604974}
-
Yao Xiao authored
Also splitted the metrics into 2 (MainFrame, Subframe), so that the subframe metrics can be constructed using bitwise operations. Bug: 881345 Change-Id: I9e0e9aeb3d518e3fa5afbc3ff101705e04d87232 Reviewed-on: https://chromium-review.googlesource.com/c/1309096Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#604973}
-
Jun Mukai authored
This is used to test asynchronous behaviors of touch in interactive ui tests for ChromeOS, which also fits with the design of Mash. See https://docs.google.com/document/d/1h6-dBGUUF2Us4C8ELzqlNyZx1VzcGlenLPDeOBJDJJw/edit?usp=sharing for the details of the failure reason. BUG=890071 TEST=tab_drag_controller_intearctive_uitest Change-Id: I07a292e8f8cd69afa4212f90a52400d612cf6f63 Reviewed-on: https://chromium-review.googlesource.com/c/1309093Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#604972}
-
Weidong Guo authored
Changes: Extract logic triggered by app list shelf button into common function which is also used by search key. Bug: 896895 Change-Id: Ie81ef2aee94cc56270842887c7554297b1a94575 Reviewed-on: https://chromium-review.googlesource.com/c/1313057Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604971}
-
Weidong Guo authored
The crash may occur when dragging an item for reparant in root level while we need to add a page break item between two items in root level. The two items happened to have the same position which triggers a position fix causing a LoadFromMetadata() call during SaveToMetadata(). Changes: Remove observer when add page break item. Bug: 900427 Change-Id: Ie416eeb81de47cd531a6c25a16761ce1d141847f Reviewed-on: https://chromium-review.googlesource.com/c/1313054Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604970}
-
Xi Han authored
This relands commit aa60c219. The original CL (https://crrev.com/c/1113802) got reverted becuase FeatureList and field trials are not setup properly in early startup in Android WebView, but ServiceMangerContext has checked features. See crbug.com/899376. The fix is in a separate CL: https://crrev.com/c/1305876. Another related precursor CL is: https://crrev.com/c/1308096. This CL is an exact copy of the original CL. The original cl description is: This CL instantiates the ServiceManagerContext before creating the BrowserMainRunner. It splits the startup path into two, with/without starting the full browser. The changes are implemented behind a flag "allow-start-service-manager-only". Bug: 846846,729596 TBR: jam@chromium.org Change-Id: I5214af850d4ef256c9d223db059ed009a42de714 Reviewed-on: https://chromium-review.googlesource.com/c/1305822 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#604969}
-
Lily Chen authored
Each pending request in a socket pool group now keeps track of which ConnectJob is assigned to it, through a pointer to the corresponding ConnectJob. If there are more ConnectJobs than pending requests in a group, pointers to the excess jobs are kept in a list of unassigned jobs. Associating requests with jobs will make it easier to keep job priorities in sync with request priorities when reprioritizing requests. Bug: 166689 Change-Id: I6bb4adb3d8504d55ae58204398f783f9fa0d62cb Reviewed-on: https://chromium-review.googlesource.com/c/1305393 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604968}
-
Adithya Srinivasan authored
Bug: 724543 Change-Id: If4da5b51ad6886063801b6e224a0acedd57995cc Reviewed-on: https://chromium-review.googlesource.com/c/1314612Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#604967}
-
Kevin McNee authored
When GuestViewCrossProcessFrames is enabled, we overwrite certain methods in the guest view js implementation. It appears that the intended naming convention is to have the methods that are overwritten end with a "$". However, this was not done consistently. Bug: None Change-Id: Iac035cd43264d20e46036581bcaa070d2edd6bb7 Reviewed-on: https://chromium-review.googlesource.com/c/1311076 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604966}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/56ef305b6767..42e7d9c929ef git log 56ef305b6767..42e7d9c929ef --date=short --no-merges --format='%ad %ae %s' 2018-11-02 ilnik@webrtc.org Enable rtc event log in *_loopback tools running with renderers 2018-11-02 asapersson@webrtc.org Add field trial for vp8 cpu speed configuration for arm. Created with: gclient setdep -r src/third_party/webrtc@42e7d9c929ef The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3fa1831a097c3edd152002d40c041e5cbef67750 Reviewed-on: https://chromium-review.googlesource.com/c/1315407Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604965}
-
Dale Curtis authored
TEST=clang-cl on Linux works again. Change-Id: Ie18d17418bf517dd231b5dd68b2a8d9c39d221ed Reviewed-on: https://chromium-review.googlesource.com/c/1313871Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#604964}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/30edaaac1da4..d029c0e83734 git log 30edaaac1da4..d029c0e83734 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 caryclark@skia.org remove color 16 implementation out of public 2018-11-02 mtklein@google.com move SkICC::WriteToICC out of line 2018-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 42e8e54e3049..155f802a6be3 (2 commits) Created with: gclient setdep -r src/third_party/skia@d029c0e83734 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ibde90606404db52e9227ac6f86653230a681eba1 Reviewed-on: https://chromium-review.googlesource.com/c/1315409Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604963}
-