GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e8e10fdf..8b8cc1cc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2247a14f81593c17916bd8eb32ba3d9e13df235c
Reviewed-on: https://chromium-review.googlesource.com/1156992Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579489}

TBR=marq@chromium.org

Bug: 869477
Change-Id: I74a659e745f2480e2a35535085e837b6b5e5bc73
Reviewed-on: https://chromium-review.googlesource.com/1157066Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579488}

All tests should be using MD for secondary UI by default, so this call
is now a no-op.

Bug: 867557
Change-Id: Ia0d6f774543425c56084894f15f4d262f9071f7c
Reviewed-on: https://chromium-review.googlesource.com/1155632Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579487}

Currently, 50 to 60% of CollectInlines are spent in
ExpandCapacity to reallocate the vector buffer. This patch
makes rough estimation from the number of direct children
to reduce the number of reallocations.

Currently, slow tests such as storage/indexdb/* creates
more than 1,000 items by appending the test results in
<span></span><br> structure. This patch reduces vector
allocation in such cases to once or twice.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I2b5b1462dc59091cc534a2f143b54567d31b863a
Reviewed-on: https://chromium-review.googlesource.com/1155268Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579486}

This CL moves mSigninAccessPoint from SigninFragmentBase to
SigninFragment. SigninFragmentBase will be used for as the base class
for the consent bump fragment and for the consent bump there's no notion
of the access point. This CL also reimplements how SigninFragmentBase
determines the text for the cancel button, because it's been using
mSigninAccessPoint.

Bug: 869426
Change-Id: I8361965a9c9df62d86e058b01f4a06f88e7bfbda
Reviewed-on: https://chromium-review.googlesource.com/1156701Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579485}

Follow-up to http://crrev.com/579256

Bug: 869112
Change-Id: Ie8d560bf0a01fa811dfa5529269a9756ae81447b
Reviewed-on: https://chromium-review.googlesource.com/1156996
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579484}

Since these types were moved back to DRM, we can use DrmDevice* instead
of GbmDeviceLinux* again.

Bug: 869206
Test: compile

Change-Id: I61d69e16c4e8d93f5bc913698ee0fab410c3db2e
Reviewed-on: https://chromium-review.googlesource.com/1155909
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579483}

Currently on MacOS the pen behaves like a mouse input, because we
generate mouse events for the pen input. We agreed that the pen input
should behave like a touch input, so we now send touch events instead.

Bug: 854354
Change-Id: Iac7910e250020a8125a57fb6055fb282db3faf0e
Reviewed-on: https://chromium-review.googlesource.com/1136721
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579482}

See whether passing --disable-features=UseSurfaceLayerForVideo
improves the reliability of these tests.

Tbr: kainino@chromium.org
Tbr: dalecurtis@chromium.org
Bug: 830901
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id56d57c331ae416b5492a25609d869ebdba26ec3
Reviewed-on: https://chromium-review.googlesource.com/1155940
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579481}

An upcoming change to base::Bind rejects binding ref counted objects
if their ref count is zero, as this is an error prone pattern.
And DevToolsDeviceDiscovery::DiscoveryRequest hits the check, as its
first reference is made in its constructor through base::Bind, though
its usage is valid and the check failure is a false positive case.

To avoid the check failure, this CL moves base::Bind out from the
constructor, and keeps a reference to the instance separately.

Bug: 866456
Change-Id: Ic90d78981ac03accbb98e5536b64b576f8147f09
Reviewed-on: https://chromium-review.googlesource.com/1156328Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579480}

- Changes ReadingListTableVC section rowAnimation to
UITableViewRowAnimationMiddle and UITableViewRowAnimationFade.

- Constraints were breaking while animating, this because of a
known bug that was fixed in other headers (crbug.com/854117).
In order to fix this all the padding constraints priority was
lowered.

Video:
https://drive.google.com/open?id=1jf1n56P4apUCHjC6ZqZlLe0mCEORsIzG

Bug: 868228
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5580fe7377f16070fc43b1bc283754d4b00d60ef
Reviewed-on: https://chromium-review.googlesource.com/1155923
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579479}

Also add tests for Dictation

Bug: 866521
Change-Id: I551b97cdc9d7f0374985438b94c538c45daddf52
Reviewed-on: https://chromium-review.googlesource.com/1152514Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579478}

The new Cast streamType kOther maps to STREAM_VOICE_CALL in Android, which
doesn't allow a volume of 0 (i.e., volume index=0).

Basically we need to honor the minimum volume index in the VolumeMap/Control
logic. For VolumeMap, all volumes below min_volume share the same dB value as
the min_volume one. For VolumeControl, when setting a new volume, we round it
up to min_volume if necessary.

Bug: internal b/111838985
Test: No more exeption triggered.

Change-Id: I67315bfa877875d9de3cc06d37e8a1fa72994004
Reviewed-on: https://chromium-review.googlesource.com/1154145Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579477}

Bug: 854704
Change-Id: Ic3dcef42f108beb02a398302f3ecd70dd72c0f2d
Reviewed-on: https://chromium-review.googlesource.com/1153777
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579476}

1. Removed mapped_paths_cstr in LaunchProcess() - it wasn't used.
2. Updated base::fuchsia::GetHandleFromFile() to handle
   fdio_transfer_fd() failures properly: fdio_transfer_fd() consumes FD
   on failure, but GetHandleFromFile() was still trying to close it.

Change-Id: If9283fd0271128659dc4ab7633d7b9ec0a093a1f
Reviewed-on: https://chromium-review.googlesource.com/1155966Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579475}

https://pdfium.googlesource.com/pdfium.git/+log/b53ef1e52d40..cede561c5ae6


git log b53ef1e52d40..cede561c5ae6 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 tsepez@chromium.org Remove CXFA_Corner downcasts from cxfa_rectangle.cpp


Created with:
  gclient setdep -r src/third_party/pdfium@cede561c5ae6

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic9b907abf3ace1d653ee280d0c42c4f3fc41448c
Reviewed-on: https://chromium-review.googlesource.com/1156906Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579474}

Early-out in OnSwapCompositorFrame if video_consumer_ exists. Don't do
this in OnSynchronousSwapCompositorFrame because video capture doesn't
work with Android WebView and we still have to call CopyFromSurface.

Bug: 865430
Change-Id: I4b59848b2c288fc06708187b8d48e86c1fd19237
Reviewed-on: https://chromium-review.googlesource.com/1156871Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579473}

Unlike normal layout cases, hit-testing, canvas, etc. may call
ShapeResult functions with 0-length text. In this case,
ShapeResult has no RunInfo.

It is also possible that there are no glyphs for the given
text, but in normal code path, HarfBuzzShaper should still
generate a run without glyphs.

Bug: 868893
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia86f4627c74122c915986858bc974fc2e18d3b3d
Reviewed-on: https://chromium-review.googlesource.com/1155275Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579472}

Command ids in CollectionViewTextItem are used in
GoogleServicesSettingsViewController. The command id lets the view
controller knows which command to send to the command handler when
the cell is tapped.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iafa070c38362d0295a0100f99033972da26d435e
Reviewed-on: https://chromium-review.googlesource.com/1156692Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579471}

New tabs opened from the grid were shown as white as they animated open,
because they were only showing the cell's snapshot, not the snapshot
taken from the BVC that will be displayed.

This was because the gird animation only shows the BVC snapshot if it
thinks there will be a difference between it and the cell snapshot --
specifically when there's been a device rotation.

This CL lets the grid view controller flag the active cell in the
animation as "appearing" so that the animation can always show the
BVC's snapshot in that case.

Bug: 865978
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iede4af004e89e5fda1395c4257c3d74fd2a682c7
Reviewed-on: https://chromium-review.googlesource.com/1156685
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579470}

When apps-grid-gap feature is enabled, dragging last item on a page to
another single-item page to create a folder will cause a crash. This is
caused because we delete the dragged item view in
AppListItemView::SetMouseDragging() before setting state, so swap the
two parts.

Bug: 869135
Change-Id: I99e466bc0ff3ddd6846fcd4f5cb9e14fd9522ac3
Reviewed-on: https://chromium-review.googlesource.com/1155723Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579469}

This unit test is supposed to test that deleting the SimpleURLLoader
in the OnRedirectCallback was safe. Taking a look at the code, it seems
that nothing is deleted in the callback so it might look like the test
is actually not testing anything. However there is a subtle reason why
the test is working, and that's because a unique_ptr is passed to the
callback which is actually deleted once out of scope.

Making the deletion explicit + checking the passed in attributes looks
like an improvement in this case.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5f10b660f19b5951b7ddb37c57228dca4cdf497c
Reviewed-on: https://chromium-review.googlesource.com/1156702
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579468}

These tests timeout on Linux and Mac, tagging as slow:

virtual/gpu/fast/canvas/canvas-shadow-source-in.html
virtual/gpu/fast/canvas/canvas-blending-color-over-pattern.html

NOTRY=true
TBR=fserb@chromium.org

Bug: 866850
Change-Id: I3cc17dbdf373e404bfd02e012fe13dd422edeb33
Reviewed-on: https://chromium-review.googlesource.com/1156855Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579467}

The synthetic WebTouchEvents are not constructed well, as their touch
pointer list are not contiguous. After releasing a touch pointer, the
touch pointer is not deleted from theWebTouchEvent, it is just reset to
initial value. When we loop the touch pointer list, there will be some
touch pointers at index after its real touch length.

We should reconstruct the WebTouchEvent's touch pointer list to
remove all the empty touch pointers.

Bug: 613672
Change-Id: I69c7d7c95a14efbe94b02e138f7b18dce328bf91
Reviewed-on: https://chromium-review.googlesource.com/1141133Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579466}

Using wpt-import in Chromium dbae05f3.
With Chromium commits locally applied on WPT:
7dad0f17 "Added new Sec-Metadata Web Platform Tests."
6fa8d815 "Add UserActivation member to MessageEvent"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22170

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
pwnall@chromium.org, jsbell@chromium.org:
  external/wpt/cookie-store

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I19a9d6919ecdf6d5a911deafe9a4e7dc4c72ffbc
Reviewed-on: https://chromium-review.googlesource.com/1156481
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579465}

Bug: 863089
Change-Id: I0e95f78799a2550aeb89b2b980b2d5cdb16142d2
Reviewed-on: https://chromium-review.googlesource.com/1156003Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579464}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/131b85f314db..aa1425d9d877


Created with:
  gclient setdep -r src-internal@aa1425d9d877

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ibc51dbd27acc16222b54021ccbd4d937f313c15a
Reviewed-on: https://chromium-review.googlesource.com/1156904Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579463}

"media/base/video_codecs.h" includes
"third_party/libaom/av1_buildflags.h" which is a generated header. This
should be a public_deps since it's included in another header file.

Change-Id: Ie9b340f5866174b0d33ea5289e9ca83aa26db3f8

Bug: 868764
Change-Id: Ie9b340f5866174b0d33ea5289e9ca83aa26db3f8
Reviewed-on: https://chromium-review.googlesource.com/1154528Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579462}

https://webrtc.googlesource.com/src.git/+log/304da796abc6..2a99c0bf6765


git log 304da796abc6..2a99c0bf6765 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 alessiob@webrtc.org Fix MovingMoments::CalculateMoments.
2018-07-31 ssilkin@webrtc.org Increase RtpFrameReferenceFinder's frame buffer length to 100 frames.
2018-07-31 buildbot@webrtc.org Roll chromium_revision fb3a9711..36ff521e (579262:579363)


Created with:
  gclient setdep -r src/third_party/webrtc@2a99c0bf6765

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:866925,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7829d349a5886e7cd5dfa9877f07e1848d09cf1f
Reviewed-on: https://chromium-review.googlesource.com/1156905Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579461}

(see the bug) From the traces the service/process creation gets posted to the
IO thread during startup.
It may be delaying startup for some other services needed for the first paint, or it may be
just eating up CPU when the load is already quite high. We'll experiment with delaying
the service launch.

Bug: 867461
Change-Id: I048e33d049e665d8e9489046c5813918d8077524
Reviewed-on: https://chromium-review.googlesource.com/1153248
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579460}

Listen to the WebContents muted state in MediaSession. If
the WebContents is muted then we should act as if the
player has no audio.

This stops muted tabs from getting audio focus.

BUG=863438

Change-Id: I8218f225cd79d8490a805d46ad4606829742dd5e
Reviewed-on: https://chromium-review.googlesource.com/1141144Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579459}

https://android.googlesource.com/platform/external/perfetto.git/+log/37a1543bfe3a..c2ace4e71f59


git log 37a1543bfe3a..c2ace4e71f59 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 michaschwab@google.com Fix All Tracks Import


Created with:
  gclient setdep -r src/third_party/perfetto@c2ace4e71f59

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I211953ded41cbd96f95649d0fd86342fe018c245
Reviewed-on: https://chromium-review.googlesource.com/1156489
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579458}

Bug: 842913
Change-Id: I834c962a21faeb53cb64acb4a4202cf7cfe0af9e
Reviewed-on: https://chromium-review.googlesource.com/1149185
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579457}

This reverts commit 77605f5e.

Reason for revert: The CL was reverted because two components
were depending on the os_crypt source_set, resulting in issues
with the component build.  I made os_crypt into a component
itself in https://chromium-review.googlesource.com/1155309,
which should fix the problem, and make the CL safe to re-land,
without modification.

Original change's description:
> Revert "NetworkContext: Always create the CookieStore and ChannelIDStore"
>
> This reverts commit 41e3c570.
>
> Reason for revert: https://crbug.com/868536 - DCHECK being hit because OSCrypt isn't set up.
>
> Original change's description:
> > NetworkContext: Always create the CookieStore and ChannelIDStore
> >
> > This CL makes NetworkContexts create CookieStores and ChannelIDStores in
> > the hybrid URLRequestContext creation path, where the embedder starts
> > configuring a URLRequestContextBuilder, and the NetworkContext finishes
> > configuring it.
> >
> > The reduces redundant code, lets us test the new path in production
> > before we ship the network service, and will allow Isolated App
> > URLRequestContexts to need less code when they're updated to use the
> > hybrid configuration path (Which I plan to do in a followup CL).
> >
> > The NetworkContext constructor that takes an already-initialized
> > URLRequestContext is not modified in this CL.
> >
> > Bug: 789644
> > Cq-Include-Trybots: luci.chromium.try:linux_mojo
> > Change-Id: Ibf40ae6497e7be06b0a666bc664ea943e145cae9
> > Reviewed-on: https://chromium-review.googlesource.com/1152083
> > Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> > Reviewed-by: Clark DuVall <cduvall@chromium.org>
> > Commit-Queue: Matt Menke <mmenke@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#578740}
>
> TBR=mmenke@chromium.org,morlovich@chromium.org,cduvall@chromium.org
>
> Change-Id: Ia9f914fac8b0fa624210363dd55333a0dfa20531
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 789644
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1153232
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578808}

TBR=mmenke@chromium.org,morlovich@chromium.org,cduvall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 789644
Change-Id: I958d52e4d3ef343b88f89f410bd009a166d00ef5
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1156664Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579456}

https://chromium.googlesource.com/catapult.git/+log/cf56f6f1be08..100f0ee2ceb7


git log cf56f6f1be08..100f0ee2ceb7 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 wangge@google.com Use `--ignore-certificate-error` if in Compatibility Mode
2018-07-31 sadrul@chromium.org tabs: Report tab-switching request delay.


Created with:
  gclient setdep -r src/third_party/catapult@100f0ee2ceb7

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866881,chromium:858944
TBR=sullivan@chromium.org

Change-Id: Icfdb76c18f63fc0451154b71e6df45b6a19a85cb
Reviewed-on: https://chromium-review.googlesource.com/1156488Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579455}

This is a reland of c31de326. The CHECK
that was triggering (crbug.com/868341) has been removed but the change
is otherwise the same. The CHECK will be readded once all of the bugs
that it reveals are fixed (crbug.com/869154)

Original change's description:
> Fix invalid handle errors found with App Verifier
>
> ChildProcessData was holding a raw ProcessHandle which meant that there
> was no guarantee that the handle would be valid when it was used. This
> change switches to a ScopedHandle on Windows, with the associated
> duplication of the handle, so that it is guaranteed to be valid. This
> fixes a frequently encountered use of an invalid handle that was
> detected by Application Verifier. This change also adds a CHECK to
> base::GetProcId to check for use of invalid handles even when not using
> Application Verifier.
>
> ChildProcessData::handle is now a private member so all references to
> it were updated to use accessors.
>
> When ChildProcessData::SetHandle is called the handle is duplicated.
> When a ChildProcessData object needs to be copied an explicit
> Duplicate function is called.
>
> An IsHandleValid helper function was added.
>
> An invalid test was removed because it was triggering the CHECK in
> base::GetProcId.
>
> Bug: 417532,821453,865805
> Change-Id: I7e38140335c0140536919341f011f144f150c88f
> Reviewed-on: https://chromium-review.googlesource.com/1145767
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578419}

Bug: 417532, 821453, 865805, 868341, 869154
Change-Id: I022982f447cce4649618f4413e960f5639ad750a
Reviewed-on: https://chromium-review.googlesource.com/1155498Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579454}

This ensures that deserialize -> serialize produces the same result as
deserialize -> serialize -> deserialize -> serialize for a particular
reproducer discovered by clusterfuzz. It was previously possible for
the first serialization to produce a different result than the second
one in the following way:

- the first deserialize would set the matrix type initially to unknown
  (in FixupMatrixPostSerialization) but then set it to the correct
  matrix type as a side effect of creating a transfer cache entry
  (see the following stack trace):

 #0  0x00000000006c9f70 in SkMatrix::getType() const () at ../../third_party/skia/include/core/SkMatrix.h:140
 #1  0x00000000006d3f3d in SkMatrix::isIdentity() const () at ../../third_party/skia/include/core/SkMatrix.h:155
 #2  0x00000000006d1031 in SkMatrix::invert(SkMatrix*) const () at ../../third_party/skia/include/core/SkMatrix.h:1152
 #3  0x0000000000a7e330 in SkGradientShader::MakeSweep(float, float, SkColor4f const*, sk_sp<SkColorSpace>, float const*, int, SkShader::TileMode, float, float, unsigned int, SkMatrix const*) () at ../../third_party/skia/src/shaders/gradients/SkGradientShader.cpp:886
 #4  0x0000000000a7e1c0 in SkGradientShader::MakeSweep(float, float, unsigned int const*, float const*, int, SkShader::TileMode, float, float, unsigned int, SkMatrix const*) () at ../../third_party/skia/src/shaders/gradients/SkGradientShader.cpp:863
 #5  0x0000000000dc2e0d in CreateSkShader() () at ../../cc/paint/paint_shader.cc:397
 #6  0x0000000000daf94d in Read() () at ../../cc/paint/paint_op_reader.cc:522

- the first serialize would write out the correct matrix type verbatim
  from the data structure

- the second deserialize would set the matrix type to unknown but would
  not end up setting it to the correct matrix type because a transfer
  cache entry exists so we follow this code path instead:

  https://cs.chromium.org/chromium/src/cc/paint/paint_op_reader.cc?l=519

- the second serialize would again write the matrix type verbatim from
  the data structure, but this time it would be unknown.

This change fixes the problem by always writing unknown.

Bug: 868966
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idfb1dcf82e652b696dde5427d9890b0ff6d9a268
Reviewed-on: https://chromium-review.googlesource.com/1156127Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579453}

OmniboxPopupContentsView squelched any queries for tooltips by returning
null from GetTooltipHandlerForPoint(). This change removes it. Doesn't
seem to make a difference, but tooltips now work for the tab switch
button and result view more generally.

Bug: 853929
Change-Id: I995af95362bca165495052444b1432ee875fc5e7
Reviewed-on: https://chromium-review.googlesource.com/1155744Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579452}

virtual/gpu/fast/canvas/canvas-blending-gradient-over-pattern.html times out on
Linux and Mac, so labeling as slow.

NOTRY=true
TBR=fserb@chromium.org

Bug: 866850,869276
Change-Id: I973034fa00e46504db0d528b72c726913a46c675
Reviewed-on: https://chromium-review.googlesource.com/1156999
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579451}

The header file is obsolete and will be deleted in webrtc cl
https://webrtc-review.googlesource.com/c/src/+/90410.

Bug: webrtc:6854
Change-Id: Ia3dff6686d8135ad54df8436f2c0125472c936bf
Reviewed-on: https://chromium-review.googlesource.com/1156388
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579450}