- 07 Jul, 2020 40 commits
-
-
Jonathan Backer authored
Work is on going to port this feature to other platforms, notably OSX and CrOS. Extending the expiry will help developers. Change-Id: Id24eb3e54e3db48bc4240268137ffd27761135b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284922Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#785768}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9eb2d25b67f1..1402ed576596 2020-07-07 rharrison@google.com Roll 6 dependencies and update expectations. (#1097) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ifddd5d9105f5dd3e4769017990b350d374e090d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785767}
-
Sébastien Séguin-Gagnon authored
In the passwords settings page, the savePasswordsItem variable can be unset when passwords are managed by policy. The setSavePasswordsSwitchItemEnabled needs to check for that before enabling/disabling it. Otherwise, it causes a nullptr crash when swiping existing passwords to delete them. Also fixes a bug introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2219569 where the switch value would be reset to on when swiping a password. Bug: 1101325 Change-Id: Icde314a7f1dccbee688f7fe882f44c7754c034b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281165Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#785766}
-
Philip Rogers authored
https://crrev.com/544756 ("Make <foreignObject> a stacking context") added svg-isolation-foreign-isolation.html which had an incorrect expectation. ForeignObject should create a stacking context [1] and everything that creates a stacking context is an 'isolated' group [2], so foreignObject should isolate. Our implementation is correct for html content in foreignObject but has a bug for svg content in foreignObject. This patch creates WPT tests for these two scenarios, and marks the svg variant as failing. [1] https://svgwg.org/svg2-draft/single-page.html#render-EstablishingStackingContex [2] https://drafts.fxtf.org/compositing-2/#csscompositingrules_CSS Bug: 1102803, 1101002 Change-Id: Ia5baceccab0be09eeec5e4682f16247a2881509b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284631 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#785765}
-
Bo Liu authored
There are reports that destroying Sequence can be expensive, and lock up other threads. So destroy it outside of the gpu::Scheduler lock. Bug: 916977 Change-Id: I774cf8188e81f5ebed5fd37edd45278b415df7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277110 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#785764}
-
Peter Kasting authored
Passing the current state is unnecessary; not all callers care, and those that do can simply ask for the state, which is cheap. Passing the Widget* in question is in some cases unnecessary as well. The primary motivation for this minor cleanup is to minimize a future CL's functional diff. Bug: none Change-Id: I7f526015c7c8ba238723f74e68bcadf8f5c9e944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283658 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#785763}
-
manuk authored
Titles should be set if the title UI param is enabled regardless of whether the suggestion is allowed to be default. Bug: 1062446 Change-Id: I58b49813f365341aed060ea603eb6eba9b36aa46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278629 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#785762}
-
sandromaggi authored
This adds new breaking conditions for navigations while in the RUNNING state. For non-renderer-initiated navigations the flow now breaks in RUNNING where previously only PROMPT was breaking. Full list of what is allowed and what isn't can be found in content/public/browser/navigation_handle.h (IsRendererInitiated) Bug: b/159309621 Change-Id: I6b6055fd213ca48e0130c48c4d1daa606bdc0fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283342 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#785761}
-
Maksim Moskvitin authored
The test was disabled on Windows a while ago due to flakiness. Since significant amount of time already passed there is a chance that flakiness already gone. Bug: 1045619 Change-Id: I0abd1d751127ec2174e39f15eae773becc105690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283592Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#785760}
-
Steven Bennetts authored
Bug: 1081786 Change-Id: I79065f3c4faabaed1f7b28b6db306ba736e0a797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278420Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#785759}
-
Gang Wu authored
This CL implement the animation for tab switch from Omnibox suggestions. Try to match the animation in IOS, if new tab's index is smaller than old one, new tab slide in from left. If new tab's index is larger than old one, new tab slide in from right. Also, the animation time is matching IOS at https://source.chromium.org/chromium/chromium/src/+/master:ios/chrome/browser/ui/tabs/switch_to_tab_animation_view.mm;l=15. Bug:1092268, 1101517 Change-Id: I5b6c6fa8c290130a3f7fdbc9818a2ac40179cfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276806 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#785758}
-
Livvie Lin authored
This CL: (1) Allows backward navigation on DontProceed if possible and there is no suggested URL. (2) Uses the button text 'Close page' instead of 'Back to safety' in cases where the tab will be closed (no suggested URL and can't go back). (3) Records metrics when the interstitial is closed. (4) Removes unused InterstitialParams reference, adds TODOs for handling reloads/redirects and the DontProceed navigation, and changes a function name for consistency. Bug: 1058898 Change-Id: I5b017072a3b650cbf0479ab9df17ac91d9260a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274250 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#785757}
-
Owen Min authored
When policy changing name, _CheckDeprecatedFutureField() function crash as there is no |new_policy| instance. Add a check in the first call to resolve the issue. Note that, for renamed or new added policy, it should be verified by the second call which always has the |new_policy| instance. Bug: 1076560 Tbr: pastarmovj@chromium.org Change-Id: I32d6e9b8b8b00cb9db4a1d34e0023aa8060fe6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284611 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785756}
-
Steven Bennetts authored
ShillServiceClient::ActivateCellularModem calls a deprecated Shill method that returns an error. This removes the functionality from Chrome and any classes that call into it. Bug: 1021688 Change-Id: Ideb04bbd3488e0bee1561fa25151a2ee8d5ac9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283308Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#785755}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0267238c608257e109275d45e7274370100815c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284046Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785754}
-
Antonio Gomes authored
... instead of WebMediaStreamSource. BUG=704136 R=guidou@chromium.org Change-Id: I1fa66c014c6b4be44d774dd7a5b81eb2da40a3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283390 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#785753}
-
Tomasz Wiszkowski authored
This change replicates an update in native SortAndCull method to skip past specialized suggestions when partially grouping suggestions by search vs url. The specialized suggestion types that are intentionally skipped are: - default match - query tiles - clipboard Corresponding native change: https://crrev.com/c/2266012 Bug: 1091098 Change-Id: If9446f60561f013948876a7ec38ff87e0cd8deed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268228Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL connects the PasswordCheckFragmentView with the controller code by introducing a ViewBinder to set properties. Additionally, a view test covers that model data is rendered as expected. Bug: 1101256,1092444 Change-Id: Id3afbb6a559bbaf6c0c8e267ecec322f7a4b75a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279117 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#785751}
-
Tim Volodine authored
Annotate SettingType constans with their availability regarding WebLayer version. In particular BASIC_SAFE_BROWSING_ENABLED is available since M84, other settings are available since M85. BUG=1102072 Change-Id: If37fd1d9d78c50eb7eef0f41a28eef8e03f3ce3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281341Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#785750}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0b6df3ba1a45..8bf8ca6dc7f2 2020-07-07 aerotwist@chromium.org Fix tsconfig generation paths 2020-07-07 tvanderlippe@chromium.org Migrate IdentityFormatter to TypeScript 2020-07-07 tvanderlippe@chromium.org Add OWNERS for test/conductor 2020-07-07 alexrudenko@chromium.org Fix stylelint-config-standard issues in sources/javaScriptBreakpointsSidebarPane.css 2020-07-07 tvanderlippe@chromium.org Extract copy to resources into separate template 2020-07-07 alexrudenko@chromium.org Fix snippet saving and search If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1066415,chromium:1083142,chromium:1098730 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2ed9710ec2ea19cb56e4a5a03066a9764b5bcde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284793Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f5ed7a69d5d6..ba17d8bcf0dc 2020-07-07 johnkslang@users.noreply.github.com Merge pull request #2324 from ben-clayton/gitignore If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: Iad350550445b947e608be6bb855e95366e948df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284798Reviewed-by:
-
Emily Stark authored
This method was a relic from an earlier version of this code, when the animation faded the path from a given starting color to a given ending color. In that version, HasStarted() was necessary to avoid duplicate animations, which would cause a flicker. For example, an initial user interaction would start to animate the path from opaque to transparent, and a subsequent user interaction while still animating could restart the same animation, causing the path to flicker from a midpoint color back to opaque to start the animation again. To avoid this flicker, I introduced HasStarted() to avoid running a given animation more than once. But the new ElideAnimation version of the code animates from whatever the current state is to the desired end state. This means that restarting a duplicate animation is a no-op and doesn't cause any flicker, so we can get rid of HasStarted(). I've also added unit tests for the cases where HasStarted() was used. Bug: 1099875 Change-Id: I53af1ae2437fbe24e6646c99d743f0af2a398ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278164 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#785747}
-
Roberto Moura authored
Change-Id: I20b611fde0d4787a7c189ad858f2a0b10b3bee07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284493 Auto-Submit: Roberto Moura <mouraroberto@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#785746}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I0ad00960726f92cdc2862efa1060422612d65a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247403Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#785745}
-
Marc Treib authored
Before this CL, BrowsingDataRemover did not expose the concept of "deletion failure", i.e. when a requested deletion could not be completed. (An example of such a deletion failure is a timeout, which BrowsingDataRemoverImpl sets to 30 seconds.) This CL adds the concept of "failed data types" to the API. They're represented as a bitmask of DataTypes - the same format that's used to request deletion in the various Remove*() methods. So far, the only data type that will actually report deletion errors is DATA_TYPE_PASSWORDS, but support for more types can easily be added. None of the clients/observers does anything with the new information yet; that's left for a future CL. Bug: 1086433 Change-Id: I24b62c4da7d5c2739f47f3b599918d4643758411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260636Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#785744}
-
Emanuel Krivoy authored
The callback should be DidWrite, not DidRead. It wasn't caught by any of our tests because both functions have the same behavior, except for the error message on failure. Bug: 1100389 Change-Id: Idb52738e52c15e7e41b087d3a3e55510ae884dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273282 Commit-Queue: Emanuel Krivoy <krivoy@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Emanuel Krivoy <krivoy@google.com> Cr-Commit-Position: refs/heads/master@{#785743}
-
Mugdha Lakhani authored
Move the tests that verify how clearing browsing history works with NoStatePrefetch. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I56e057d29e318cf33f6cfe4799dbfac3d3b208c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283344 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#785742}
-
Daniel Nicoara authored
These libraries are provided by the build and are installed with Chromium target. On ARM targets where the sandbox needs to be initialized early, EGL and GLES libraries need to be whitelisted such that the GPU process can load them post sandboxing. BUG=1097320 TEST=Manually on device to verify cast_shell starts. Change-Id: I38a5de8675501d9d0aa1aa246ff34d0366b2f3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282898Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#785741}
-
Julie Jeongeun Kim authored
This CL implements GetOffsetAtPoint which returns the offset of the character located at the position and adds the unittest for the API. AX-Relnotes: It supports atk_text_get_offset_at_point() on Linux. Bug: 1070742 Change-Id: Iff075f3e4f95cc746b67819b9426300c250ff485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280805 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#785740}
-
Ulan Degenbaev authored
The V8FlushEmbeddedBlobICache flag will be used in Finch experiment. Bug: chromium:889460 Change-Id: Iedec7b32e7272fd4df4d741b786c8a1391d89beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267158Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#785739}
-
Dylan Sleeper authored
In the current clipboard reader implementation, all of the encoding was done on the main thread. This CL moves all of the encoding from the image and text reader onto the background thread. The main benefit is avoiding main thread jank when the user pastes a large payload from the clipboard. Bug: 1091833 Change-Id: I640f5818cfd81312f3adb59f4643c8e4dd34dc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233982Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#785738}
-
Wenyu Fu authored
Bug: 1102474 Change-Id: I9ee0dea7befc9de17e83ca115b07e0e3b70028e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283650 Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chrome://internals/web-appAlan Cutter authored
This CL adds a chrome://internals/web-app page for inspecting the state of installed web apps. This is useful for answering basic questions like "what is the app's scope?" or "what is the start_url?". Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=455023&signed_aid=Q3oYomTbqmpTMmg83ou6bg==&inline=1 This CL refactors the chrome://internals WebUI to run on desktop Chrome and accept Mojo connections. Bug: 1098638 Change-Id: Ic52913e9681fa5579cb44262e0ee501534c8b2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262754 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#785736}
-
Thomas Tellier authored
Bug: 1015746 Change-Id: Iacb82292baccbbbc95c32cf1dd86a1859bd1336d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096957Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#785735}
-
Hiroki Nakagawa authored
Bug: 1007635 Change-Id: I1b85936fe0c96e3914b7b16b0c73df4e0dbf107f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282622 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#785734}
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1pP-ORyHcdbgILeijGR_s5S7-jkr1Sgii/view?usp=sharing Bug: 1063856 Change-Id: I8dc725b921ace9c3f59edfab6753adec1e6c2ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279885 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#785733}
-
Sreeja Kamishetty authored
- All/RenderFrameHostManagerTest.BeginNavigationIgnoredWhenNotActive/* - WebContentsImplTest.ActiveContentsCountChangeBrowsingInstance This CL also moves RenderFrameHostImplBrowserTest.CheckIsCurrentBeforeAndAfterUnload to content_browsertests.filter BUG=1102630 Change-Id: I0a2a0d5a0ad8303ff7ff73c41688b76c8a514f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284019Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#785732}
-
Mugdha Lakhani authored
This change gets rid of the EditText we were using in InstrumentationTestActivity for weblayer instrumentation tests and replaces it with a UrlBarView returned by UrlBarViewController. All relevant methods have been updated, and a small UrlBarControllerTest added to verify expected behavior. Bug: None Test: ./out/<build_dir>/bin/run_weblayer_instrumentation_test_apk Change-Id: I7b8a54cec34f4b53df2e410ebb9526c943f4edf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270442Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#785731}
-
David Bienvenu authored
When running ShellIntegrationWinMigrateShortcutTest.*, I got errors because the shortcut target path was all lower-case, but the passed-in target was mixed-case. I'm not sure why this was, but the file name comparisons should be case-insensitive anyway. Change-Id: I857b1c78030a8278507b19071c3ac765b20f1f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284086Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#785730}
-
Sreeja Kamishetty authored
-org.chromium.chrome.features.start_surface.StartSurfaceTest.* -org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest.* -org.chromium.chrome.browser.tasks.ReturnToChromeTest.* -org.chromium.chrome.features.start_surface.InstantStartTest.* -org.chromium.chrome.browser.datareduction.DataReductionSavingsMilestonePromoTest.* -org.chromium.chrome.browser.tasks.tab_management.TabSuggestionMessageCardTest.* -org.chromium.chrome.browser.feed.FeedContentStorageConformanceTest.* -org.chromium.chrome.browser.status_indicator.StatusIndicatorTest.* BUG=1102633 Change-Id: If64f3fc873214c498939d48ed847e558390c4acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284630Reviewed-by:
-
