- 10 Jul, 2019 40 commits
-
-
Friedrich Horschig authored
With this CL, we allow every UserInfo section to have an own title. This is useful for PSL labels of password credentials. Bug: 976761 Change-Id: Ia87ec1e8778217ecc3e44d9a1a3497535e78b4a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692409Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#675977}
-
Javier Ernesto Flores Robles authored
The setUp of these tests already adds an entry. Bug: 981922 Change-Id: I44856e336291c82be23bb2f35705aebe5a45acf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692418 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#675976}
-
Dominik Röttsches authored
Migrate watchlists information from [1] and a note about how it's not possible to add a watchlist for autoroller commits. [1] https://www.chromium.org/developers/contributing-code/watchlists Change-Id: I30649e5c50e846d708e63e03dd7e7b1ccd04794f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692983 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#675975}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, thumbnail fetching happens during tab restoration. This should be avoided since it's a waste of computation and memory, leading to slower start up and memory leak. Bug: 982491 Change-Id: I7bb0aa57fb01b688ab070e1f058281d18cf20aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694149 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#675974}
-
Ali Juma authored
The WebDriver protocol specifies that error responses must include a "stacktrace" field that contains an implementation-defined string. The Web Platform Test runner expects this field to be present in error responses (but doesn't depend on its contents, just on its presence). This CL adds a "stacktrace" field to error responses, and uses base::debug::StackTrace() as its contents, matching ChromeDriver on non-iOS platforms. Bug: 673423 Change-Id: I8c5249753b896162f9128022b91a2f8fc5e14e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687359 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#675973}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0fef8f7a8181a7b7dbe627df0782bf9868b323da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675972}
-
Staphany Park authored
This CL is largely a revert of https://crrev.com/c/1583343. Tbr: kinuko Bug: 971492 Change-Id: Ia78b9ada4a1e1151301e2cab14560ae249e9b687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693948 Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#675971}
-
Oleg Davydov authored
Every usage of ContentVerifyJob is like create it via ContentVerifier::CreateJobFor and immediately calling job->Start. That means that we can always start job in CreateJobFor. Change-Id: I517f185f08d5dff7dc3f2f193d97b96aec131ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687521 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#675970}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/snappy.git/+log/3f194acb57e0..156cd8939c5f $ git log 3f194acb5..156cd8939 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 cmumford Removed reference to deprecated autotools. 2019-05-25 costan Use GCC 9 on Travis CI 2019-05-16 cmumford The snappy landing page at http://google.github.io/snappy/ is served by [GitHub Pages](https://pages.github.com/) and lives in the gh-pages branch. This changes moves the page contents to a more easily accessed Markdown file. 2019-05-14 cmumford Minor typo fix in README. 2019-05-13 cmumford Sync TODO and comment processing with external repo. 2019-05-09 cmumford Changed CMake version from 3.4 to that in CMakeLists.txt in README. 2019-04-29 costan Update Travis CI configuration. 2019-04-22 cmumford Fixed formatted (bash/c++) sections of README.md. 2019-04-04 atdt Remove MSan exemption for _bzhi_u32, since LLVM now handles it correctly. 2019-04-25 5627721+abyss7 Fix compilation 2019-02-15 costan Remove MSBuild section from AppVeyor configuration. 2019-01-22 nafi Optimize snappy compression by about 2.2%. 2018-12-14 maikuolan Update README to use HTTPS instead of HTTP. Created with: roll-dep src/third_party/snappy/src Change-Id: I3cc138dfb47116892c8baf9718d47e1b7f4798e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694245Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#675969}
-
David Staessens authored
This CL adds logic to the video player test environment to dynamically detect whether import mode is supported. This fixes one of several issues making the new video decoder tests fail on devices that only support allocate mode. TEST=./video_decode_accelerator_tests on nyan_big BUG=957808 Change-Id: Ibf1e28ae3baab63f53b6483d5d60cc7928065424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688769 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#675968}
-
Victor Hugo Vianna Silva authored
Change-Id: Ic1289db5bdcfbc65b615206809ad2e72625aa326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692935Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#675967}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I4afba134597cf9ec4080ae18310570c4fd7173c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695122Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#675966}
-
Hitoshi Yoshida authored
Responsibility of the pickle files that are expected to consist of Collection objects should be in Collection. This CL makes it clearer. Bug: 839389 Change-Id: I1ee645af60b3befd3a0923790a0170c91a331243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694405Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#675965}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I964de858a26c64a1e3a89217e704acbf5fb908a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692112Reviewed-by:
-
Anders Hartvoll Ruud authored
Change-Id: I789406de0c9ec7f1f03df9b845ee777f5ae406c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692163 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#675963}
-
Joel Hockey authored
Change-Id: I9da153a15bec4771fd8f7d3f6f71f60007d2a8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695081 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#675962}
-
Noel Gordon authored
Closure markup says |entry| parameter is {!DirectoryEntry} so it makes no sense to if-test that and return if it is not a directory entry. It must be a directory entry: assert that. No-try: true Bug: 965370 Change-Id: Ia8ab054fb92ea801c365d1f34043379373769723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694941 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#675961}
-
Yuke Liao authored
Change-Id: I46ff0505f4b3f7cfa18f7848717498925ee97e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693703 Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#675960}
-
Noel Gordon authored
Resolving the directory size can fail and that stops the 3-dot loading animation. Whatever value is in the size field appears as a result and it could be ' '. Instead, format the size as undefined, to display the size formatter's undefined size '...' value. Also console.log the resolve error. Update the setDirectorySize method comments with reasons why this code is complicated and recursive. No-try: true Bug: 965370 Change-Id: I8bf11a2578bbf47b83ede445bf7cb7b7eb5f8b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691948Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#675959}
-
Xianzhu Wang authored
Bug: 979369 Change-Id: I18ae2915a4541832389ab6b0dd9eb8621f09ab31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684551 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#675958}
-
Michael Lippautz authored
Persistent was safe against constructing from a deleted value however there was logic missing to protect against assigning from a deleted value when internal storage was already created. Bug: 982313 Change-Id: I21a6f44b73239cf50a010d548af3f1653a19dd10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692178Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#675957}
-
Wanming Lin authored
The original CL has been reverted because the test external/wpt/shape-detection/detection-HTMLVideoElement-invalid-state.html is flaky. In the previous CL, the way to create a HTMLVideoElement with 'HAVE_METADATA' state is wrong, because simply loading a video file its readyState should be >= HAVE_METADATA during loadedmetadata event. Which is the reason of the flaky. This reland CL leverages MediaSource API to precisely trigger a transition to HAVE_METADATA state by invoking `appendBuffer()` with an initialization segment. See relevant spec: https://w3c.github.io/media-source/#sourcebuffer-init-segment-received Original change's description: > [shapedetection] Add some shapedetection tests > > Cover following two checkpoints: > - If the ImageBitmapSource is an HTMLVideoElement object whose readyState attribute > is either HAVE_NOTHING or HAVE_METADATA then reject the Promise with a new > DOMException whose name is InvalidStateError. > - If the ImageBitmapSource argument is an HTMLCanvasElement whose bitmap’s origin-clean > flag is false, then reject the Promise with a new DOMException whose name is SecurityError. > > spec: https://wicg.github.io/shape-detection-api/#image-sources-for-detection > Change-Id: I0522d0340d3cb0291df6be65dfc1ab99037b30f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666766 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > Cr-Commit-Position: refs/heads/master@{#671578} Bug: 979170 Change-Id: I963c3b6bce86791f5bedde7849c2e439b28c5481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688460Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#675956}
-
Yi Gu authored
TBR=wangxianzhu@chromium.org Bug:None Change-Id: Ic530a4c0a2077a59060c3cba4394bfdb79d444f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680114Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#675955}
-
Mitsuru Oshima authored
* Introduced AshTestHelper::InitParams * Changed ShellBrowserMainParts to use AshTestHelper, instead of its own. This is a preparation to add ash_ui_perftests Bug: 979440 Test: no functional change. All tests should pass. Change-Id: Iaa90e11e3ede27e88cb1aa31cb72b349e6288410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692216Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#675954}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b6fa8126927d..a9ca4d92eba0 git log b6fa8126927d..a9ca4d92eba0 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 groeck@chromium.org config: Remove old versioned generic builders 2019-07-10 linben@google.com Point symbol files to -userdebug variants for qt. 2019-07-10 vapier@chromium.org convert __nonzero__ to __bool__ Created with: gclient setdep -r src/third_party/chromite@a9ca4d92eba0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I89c76b30ccf7fd9167d29ca997a8566d9592d46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694609Reviewed-by:
-
Matt Mueller authored
Bug: 634470 Change-Id: I7e2130c00784447e8fd37807a8972ad1659cad65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693128 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#675952}
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the HTMLTrackElement IDL file which doesn't have the keyword yet. [1] https://github.com/heycam/webidl/issues/365 Spec URL: https://html.spec.whatwg.org/C/#the-track-element Bug: 963267 Change-Id: Ia9c5c1fd20e4f0ac1053f808e1cea17e063700e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694581 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#675951}
-
Matt Falkenhagen authored
This was needed in non-S13nServiceWorker, per the comment. The idea was to prevent a client from being claimed before its URL had settled. Before this CL, setting the controller registration was disallowed by ServiceWorkerControlleeRequestHandler while it was finding the controller service worker for a main resource request. The flag was checked in ClaimedByRegistration(). But that function is only called on clients for which is_execution_ready() is true, which means the response was already committed to the renderer so ServiceWorkerControlleeRequestHandler cannot be operating on the provider host. Bug: 926114, 824858 Change-Id: I78fc13696fe72f9027da4a20d55e1f73dd44901f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692235 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#675950}
-
Andres Calderon Jaramillo authored
This CL adds functionality to GpuImageDecodeCache to request hardware-accelerated image decodes when supported. The initial use case is for Chrome OS + JPEGs using the VA-API [1]. The typical flow of events for this path is expected to be as follows: 1) The "entry point" is GpuImageDecodeCache::CreateImageData(): here, we decide if an image will be hardware decoded. This involves checks such as whether the image is supported according to a list of profiles supplied through GPUInfo. 2) In GpuImageDecodeCache::GetImageDecodeTaskAndRef(), we don't generate a decode task for hardware accelerated decodes. Instead, we will wait until the upload task runs in order to request the decode. 3) In GpuImageDecodeCache::UploadImageIfNecessary(), we request the hardware decode. This ultimately involves sending a non-round-trip IPC message to the GPU process, but this is handled by RasterInterface::ScheduleImageDecode(). The decoded image never makes it back to the renderer. Instead, we get a sync token that we can use to "wait" on the decode to finish and we use the transfer cache entry ID to refer to the decoded image. Note that hardware accelerated decoding is currently supported only when using OOP-R. [1] https://tinyurl.com/accelerated-jpeg-decoding-v2 Bug: 868400 Change-Id: Ie57fe3a0cc30d039214a60a9da437b32f61a4ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565568 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#675949}
-
Kinuko Yasuda authored
We want to keep having these some more. Bug: 975308 Change-Id: Ic12e43efc2f3c11db8fa672ac373a5315ee4b890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688846 Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#675948}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Id3eba5ef7c7960310fa94900717b607f3cfd09a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694185Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#675947}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c26b60443768..b6fa8126927d git log c26b60443768..b6fa8126927d --date=short --no-merges --format='%ad %ae %s' 2019-07-09 cjmcdonald@chromium.org parallel_emerge: disable build retries in PCQ 2019-07-09 mmortensen@google.com Reland "Build API: Refactor service/lib and commands.py to use artifacts.BundleFirmware" Created with: gclient setdep -r src/third_party/chromite@b6fa8126927d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I8e2be72c8d3940f3c2469b45a472a472c643b4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694267Reviewed-by:
-
Katie D authored
When the Autoclick controller receives the scrollable bounds, it updates the autoclick scroll bubble's bounds. If the scrollable bounds are small, the scroll bubble is positioned outside of the scrollable area, otherwise the autoclick scroll bubble is positioned 100px to the right of the scroll point as before. Bug: 978163 Change-Id: I76d24c6583d2316ec4cec87b208fadfd55c3e0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688370Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#675945}
-
Allen Robinson authored
Change-Id: Iab9afe3a9be2fbc85d4ecb0214e23b05c8145582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692490 Auto-Submit: Allen Robinson <arobins@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If45b017df19da0ff03b4a82eec648c2dd694e31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694601Reviewed-by:
-
Jun Cai authored
This is a follow-up CL for the comment at: https://chromium-review.googlesource.com/c/chromium/src/+/1665909/7/chrome/android/java/src/org/chromium/chrome/browser/BluetoothScanningPermissionDialog.java#305 This CL uses @NativeMethods instead of native for BluetoothScanningPermissioniDialog and also updates the test code. Bug: 960960 Change-Id: Iafd054c5acfa46a2490aa0f4da9618f40cd46281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693779 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#675942}
-
Dan Beam authored
It's broken, unmaintained, and copies some <include> logic from Grit. R=kmilka@chromium.org BUG=949709 Change-Id: I21a8a84251d2f05407679fdcf35f9880754b0b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691865 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#675941}
-
Jianfeng Wang authored
Multiple requests are in-flight and contend the network resource with each other. The peak queueing delay reported by a request tells how the request was affected by the network congestion. Records the peak queueing delay when removing a request from the Chromium resource scheduler client's request queues. Change-Id: I100095c8c99305f88f0e7aa8cb0bb59b21dc4ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686607 Commit-Queue: Jianfeng Wang <jfwang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#675940}
-
Xiaocheng Hu authored
We should never construct a CSSNumericLiteralValue with kUnknown unit type. This patch ensures that with a DCHECK. Bug: 979895 Change-Id: I690259554857c826a4172b4a0c4c30a41ca67774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693943 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#675939}
-
Robert Sesek authored
Bug: 604282 Change-Id: I1a1aa3c86c1f7c28fde5b6f79210f1baf28810a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687794 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#675938}
-
