Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 06 Jan, 2017 12 commits
    • zqzhang's avatar
      [Blink>MediaSession] Use setActionCallback() instead of event listeners for media control actions · 3194c190
      zqzhang authored 
      As the MediaSession spec changed from using event-listener-based
to callback-based fashion for media controls, we need to keep the
implementation up to date.

Spec PR:
https://github.com/WICG/mediasession/pull/159

BUG=675963

Review-Url: https://codereview.chromium.org/2589893002
Cr-Commit-Position: refs/heads/master@{#441787}
      3194c190
    • mattcary's avatar
      Fix missed legacy_page_test module update. · ddded05f
      mattcary authored 
      This was missed by https://codereview.chromium.org/2539973004

BUG=678600

Review-Url: https://codereview.chromium.org/2615613005
Cr-Commit-Position: refs/heads/master@{#441786}
      ddded05f
    • nhiroki's avatar
      SharedWorker: Remove message forwarding mechanism · b46ff780
      nhiroki authored 
      SharedWorker service has a mechanism to forward a message sent from a document
to a worker. With this mechanism, a sender creates a nested IPC message and
sends it to the SharedWorker service in the browser process. The service
interprets the nested message and forwards it to an appropriate receiver.

This mechanism is available for any IPC messages but it has been used only for
worker connection message. If we use it only for one message type, we don't have
to manage such a complex mechanism. Therefore, this CL removes the mechanism and
uses a plain IPC message for connecting to a worker.

This simplification also makes it easier to mojofy SharedWorker.

BUG=612308

Review-Url: https://codereview.chromium.org/2601893002
Cr-Commit-Position: refs/heads/master@{#441785}
      b46ff780
    • tonikitoo's avatar
      Early return in ::SetTooltipText in case GetView returns null · b2127040
      tonikitoo authored 
      Driven by change: there is no point in doing the wrapping of
the tooltip text with RTL/LTR formatting, in case there is no view.
Simply bail out earlier.

BUG=

Review-Url: https://codereview.chromium.org/2611943003
Cr-Commit-Position: refs/heads/master@{#441784}
      b2127040
    • rune's avatar
      Revert of Don't post multiple task for executing blocked scripts. (patchset #2... · 482c1f85
      rune authored 
      Revert of Don't post multiple task for executing blocked scripts. (patchset #2 id:20001 of https://codereview.chromium.org/2609763002/ )

Reason for revert:
Regression in test for time to first meaningful paint: https://crbug.com/678584

Original issue's description:
> Don't post multiple task for executing blocked scripts.
>
> We may post a lot of tasks for executing blocked scripts in the case
> where we insert multiple shadow trees each containing a style element.
> When we start parsing a style element, we mark it as blocking and
> unblock script execution after finishing parsing. Check if the previous
> task is active before posting.
>
> Found while measuring performance for issue 603621.
>
> BUG=603621
>
> Committed: https://crrev.com/26cb3bdcd2a353402b78b716862567226317dff0
> Cr-Commit-Position: refs/heads/master@{#441110}

TBR=pmeenan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=603621

Review-Url: https://codereview.chromium.org/2617763002
Cr-Commit-Position: refs/heads/master@{#441783}
      482c1f85
    • xhwang's avatar
      media: Fix ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS check · 59123b61
      xhwang authored 
      Replace

 if (ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

with

 if defined(ENABLE_MOJO_MEDIA_IN_BROWSER_PROCESS)

The former was working because some compilers predefine FOO to be 1 when
-DFOO is specified. For example:
https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html

But I am not sure whether this is true for all compilers. Hence we
probably should not depend on it.

Long term, we should switch to use BUILDFLAG to avoid this.

TBR=mkwst@chromium.org
BUG=596252

Review-Url: https://codereview.chromium.org/2616703005
Cr-Commit-Position: refs/heads/master@{#441782}
      59123b61
    • nick's avatar
      Make window.open() IPCs be frame-based. · 5ae4d2d5
      nick authored 
       - Two IPCs, CreateNewWindow and ShowCreatedWindow, are made to be routed via
   the opener frame. Previously they were routed via the opener view.
 - CreateNewWindow (which is mojofied) stays put but its parameters change
 - ViewHostMsg_ShowView becomes FrameHostMsg_ShowCreatedWindow
 - The corresponding delegate methods move from RenderViewHostDelegate to
   RenderFrameHostDelegate, though the implementation stays in
   WebContentsImpl, which implements both interfaces.
 - Remove the RenderView opener_id parameter from the mojo CreateNewWindow
   params, it can be inferred from the RenderFrame id. This fixes a possible
   bad situation where an unrelated RV/RF route id pair could be supplied.
 - The pending WebContents list is made to be indexed by the main frame
   widget; this turns out to be cleaner than making it frame- based, since
   show() is an operation on the created RenderWidget.
 - The signature of ContentBrowserClient::CanCreateWindow changes to be
   frame-based, which necessitates retooling the android
   SingleTabModeTabHelper to be frame-based also.
 - The ViewMsg_Close message, which cleans up after UI-thread failure of the
   CreateNewWindow operation, is hoisted out to the outermost function where
   failure is possible, RenderWidgetHelper::OnCreateNewWindowOnUI. This
   addresses some possible RenderView leaks when e.g. window.open() races a
   navigation that destroys the opener. These races would have become more
   likely now that we're routing via the frame, since child frames can have a
   shorter lifetime than their RenderViewHosts.
 - The response to ShowCreatedWindow on the opener RenderFrame is a
   ViewMsg_Move_ACK on the openee RenderWidget. This IPC moves to
   WebContentsImpl::ShowCreatedWindow so that it can be sent via the openee
   RenderWidgetHost's IPC::Sender, rather than via the opener RenderFrame.

BUG=431769, 304341
TBR=alokp@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2506183002
Cr-Commit-Position: refs/heads/master@{#441781}
      5ae4d2d5
    • asanka's avatar
      [Downloads] Deprecate incorrect metrics. · d1d21f7f
      asanka authored 
      Download.ActualBandwidth:
Download.PotentialBandwidth:
Download.BandwidthUsed:

  These metrics were being recorded on each network read and were
  assuming that the size of the buffer and the duration between the
  prior read completion event and this one were reliable indicators of
  bandwidth.

  In practice, recording on each read is noisy and not all
  useful when aggregated across all users. Also size_of_buffer /
  elapsed_time is not an indicator of potential bandwidth, which makes
  both the PotentialBandwidth and BandwidthUsed incorrect.

Download.DiskBandwidthUsedPercentage:

  Neither useful nor correct.

SB2.DownloadDuration:

  Was measuring the lifetime of a DownloadRequestCore object, which
  doesn't correspond to the duration of a download.

Download.InterruptedOverrunBytes:
Download.InterruptedUnderrunBytes:

  When reporting UMA, the code was incorrectly picking the histogram
  name. Hence the meanings of the two histograms were switched. Rather
  than deprecating, I switched the descriptions around. The names are
  henceforth a bit odd, but the description should clarify what they are
  measuring.

Download.WriteSize:
Download.WriteLoopCount:

  WriteSize and WriteLoopCount metrics aren't actionable. WriteSize
  depends on the buffer sizes involved and the data is too noisy to be
  useful. Likewise WriteLoopCount counts the number of attempts it takes
  to fully write out a buffer. This isn't actionable.

BUG=none

Review-Url: https://codereview.chromium.org/2598773002
Cr-Commit-Position: refs/heads/master@{#441780}
      d1d21f7f
    • einbinder's avatar
      DevTools: Make sure a horizontal scrollbar doesn't appear in SuggestBox · f4b2e47a
      einbinder authored 
      BUG=none

Review-Url: https://codereview.chromium.org/2607103004
Cr-Commit-Position: refs/heads/master@{#441779}
      f4b2e47a
    • cco3's avatar
      Remove mContext field from UrlManager · cad9e849
      cco3 authored 
      This has been the the application context for some time now, so there
is no point in storing it when we can use ContextUtils as needed.

BUG=678787

Review-Url: https://codereview.chromium.org/2604953002
Cr-Commit-Position: refs/heads/master@{#441778}
      cad9e849
    • Rebaseline Bot's avatar
      Auto-rebaseline for r441775 · 71fa7ea8
      Rebaseline Bot authored 
      https://chromium.googlesource.com/chromium/src/+/495d8354acfb5

BUG=642454
TBR=robhogan@gmail.com

Review-Url: https://codereview.chromium.org/2613153004 .
Cr-Commit-Position: refs/heads/master@{#441777}
      71fa7ea8
    • sky's avatar
      Revert of Delete Mac & Cairo skia::BitmapPlatformDevice impls (patchset #3... · 0f9a1371
      sky authored 
      Revert of Delete Mac & Cairo skia::BitmapPlatformDevice impls (patchset #3 id:40001 of https://codereview.chromium.org/2611153002/ )

Reason for revert:
Revert in hopes of fix linux x64 bot: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/15545

Original issue's description:
> Delete Mac & Cairo skia::BitmapPlatformDevice impls
>
> We are no longer performing native drawing on these platforms, use the
> Skia placeholder instead.
>
> BUG=675977
> R=reed@google.com
> TBR=
>
> Review-Url: https://codereview.chromium.org/2611153002
> Cr-Commit-Position: refs/heads/master@{#441750}
> Committed: https://chromium.googlesource.com/chromium/src/+/ccdceaed36d07ad5ab6d5e504ece0459a4aeaddf

TBR=reed@google.com,robertphillips@chromium.org,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675977

Review-Url: https://codereview.chromium.org/2616003003
Cr-Commit-Position: refs/heads/master@{#441776}
      0f9a1371
  3. 05 Jan, 2017 28 commits